on master help sign in
command: Mark important TODOs for using git
commit92171aea5cd830e06001c0eeff13b46303f9eb31 authorElliot Cameron <eacameron@gmail.com> dateTue 24 Dec 2019, 17:37 (7 years ago) parent6ab3388
1 file changed+3−2
lib/command/src/Obelisk/Command/Utils.hs+3−2
lib/command/src/Obelisk/Command/Utils.hs+3−2
@@ -64,6 +64,7 @@ initGit repo = do
6464gitProcNoRepo :: [String] -> P.CreateProcess
6565gitProcNoRepo = P.proc "git"
6666
67+-- TODO: GIT_TERMINAL_PROMPT=0
6768gitProc :: FilePath -> [String] -> P.CreateProcess
6869gitProc repo = gitProcNoRepo . runGitInDir
6970 where
@@ -71,10 +72,10 @@ gitProc repo = gitProcNoRepo . runGitInDir
7172 args@("clone":_) -> args <> [repo]
7273 args -> ["-C", repo] <> args
7374
74−-- | Recursively copy a directory using `cp -a`
75+-- | Recursively copy a directory using `cp -a` -- TODO: Should use -rT instead of -a
7576copyDir :: FilePath -> FilePath -> P.CreateProcess
7677copyDir src dest =
77− (P.proc "cp" ["-a", ".", dest]) { P.cwd = Just src }
78+ (P.proc "cp" ["-a", ".", dest]) { P.cwd = Just src } -- TODO: This will break if dest is relative since we change cwd
7879
7980readGitProcess :: MonadObelisk m => FilePath -> [String] -> m Text
8081readGitProcess repo = readProcessAndLogOutput (Debug, Notice) . gitProc repo