on master help sign in
Make obelisk depend on reflex-dom-core instead of reflex-dom

All of the Obelisk libraries only need reflex-dom-core to work. reflex-dom reexports reflex-dom-core, so this worked fine before, but it had the side effect of pulling in jsaddle-webkit2gtk. For apps that are just using jsaddle-warp, this pulls in a lot of GTK dependencies that are never used. Switching everything to reflex-dom-core allows individual apps avoid these extra dependencies.

commitfe889f4f4230636aadc060f3f94029f42a49cb30 authorMatthew Bauer <mjbauer95@gmail.com> dateFri 3 Jan 2020, 11:22 (7 years ago) parentfa05960
6 files changed+11−5
ChangeLog.md+6 lib/backend/obelisk-backend.cabal+1−1 lib/backend/src/Obelisk/Backend.hs+1−1 lib/executable-config/lookup/obelisk-executable-config-lookup.cabal+1−1 lib/executable-config/lookup/src/Obelisk/Configs.hs+1−1 lib/run/obelisk-run.cabal+1−1
ChangeLog.md+6
@@ -2,6 +2,12 @@
22
33This project's release branch is `master`. This log is written from the perspective of the release branch: when changes hit `master`, they are considered released, and the date should reflect that release.
44
5+## Unreleased
6+
7+* Obelisk now depends directly on reflex-dom-core instead of
8+ reflex-dom. This avoids requiring a jsaddle-webkit2gtk dependency in
9+ apps that are only using jsaddle-warp.
10+
511## v0.3.0.0 - 2019-12-20
612
713* Generalised `pathSegmentEncoder`, added `pathFieldEncoder`.
lib/backend/obelisk-backend.cabal+1−1
@@ -21,7 +21,7 @@ library
2121 obelisk-frontend,
2222 obelisk-route,
2323 obelisk-snap-extras,
24− reflex-dom,
24+ reflex-dom-core,
2525 snap,
2626 snap-server,
2727 text,
lib/backend/src/Obelisk/Backend.hs+1−1
@@ -44,7 +44,7 @@ import qualified Obelisk.ExecutableConfig.Lookup as Lookup
4444import Obelisk.Frontend
4545import Obelisk.Route
4646import Obelisk.Snap.Extras (doNotCache, serveFileIfExistsAs)
47−import Reflex.Dom
47+import Reflex.Dom.Core
4848import Snap (MonadSnap, Snap, commandLineConfig, defaultConfig, getsRequest, httpServe, modifyResponse
4949 , rqPathInfo, rqQueryString, setContentType, writeBS, writeText
5050 , rqCookies, Cookie(..) , setHeader)
lib/executable-config/lookup/obelisk-executable-config-lookup.cabal+1−1
@@ -39,7 +39,7 @@ library
3939 primitive,
4040 monad-control,
4141 reflex,
42− reflex-dom,
42+ reflex-dom-core,
4343 jsaddle
4444
4545 ghc-options: -Wall
lib/executable-config/lookup/src/Obelisk/Configs.hs+1−1
@@ -35,7 +35,7 @@ import Data.Text (Text)
3535import qualified Data.Text.Encoding as T
3636import Reflex
3737import Reflex.Host.Class
38−import Reflex.Dom
38+import Reflex.Dom.Core
3939#ifndef ghcjs_HOST_OS
4040import Language.Javascript.JSaddle (MonadJSM)
4141#endif
lib/run/obelisk-run.cabal+1−1
@@ -33,7 +33,7 @@ library
3333 , process
3434 , ref-tf
3535 , reflex
36− , reflex-dom
36+ , reflex-dom-core
3737 , snap-core
3838 , streaming-commons
3939 , text