on ecbbd41 help sign in
61 files changed+682−1401
since splitsnapshots
unifiedsplit
.github/pull_request_template.md−2 CONTRIBUTING.md−52 ChangeLog.md+4−36 FAQ.md+67−62 README.md+167−68 acme.nix−430 all-builds.nix+1−1 default.nix+27−60 dep/.gitignore+5 dep/reflex-platform/default.nix+7−1 dep/reflex-platform/github.json+3−3 dep/reflex-platform/thunk.nix−9 docs/obelisk-logo-640.png guides/app-deploy/README.md+11−24 haskell-overlays/ghcide.nix+32−38 haskell-overlays/misc-deps.nix+2−8 haskell-overlays/obelisk.nix−5 lib/asset/README.md+19−16 lib/asset/assets.nix+5−28 lib/asset/manifest/obelisk-asset-manifest.cabal+2−4 lib/asset/manifest/src/Obelisk/Asset/Symlink.hs+1−1 lib/asset/serve-snap/obelisk-asset-serve-snap.cabal+2−4 lib/asset/serve-snap/src/Obelisk/Asset/Serve/Snap.hs+1−1 lib/backend/obelisk-backend.cabal+2−2 lib/backend/src/Obelisk/Backend.hs+1−1 lib/cliapp/obelisk-cliapp.cabal+1−3 lib/cliapp/src/Obelisk/CliApp.hs−3 lib/cliapp/src/Obelisk/CliApp/Logging.hs+2−2 lib/cliapp/src/Obelisk/CliApp/Process.hs+29−48 lib/command/obelisk-command.cabal+3−5 lib/command/src/Obelisk/Command.hs+8−12 lib/command/src/Obelisk/Command/Deploy.hs+16−16 lib/command/src/Obelisk/Command/Preprocessor.hs+47−52 lib/command/src/Obelisk/Command/Project.hs+15−26 lib/command/src/Obelisk/Command/Run.hs+61−72 lib/command/src/Obelisk/Command/Thunk.hs+3−3 lib/command/src/Obelisk/Command/Utils.hs+2−34 lib/command/src/Obelisk/Command/VmBuilder.hs+8−8 lib/executable-config/default.nix+2−13 lib/executable-config/inject/obelisk-executable-config-inject.cabal+1−1 lib/executable-config/lookup/obelisk-executable-config-lookup.cabal+7−10 lib/executable-config/lookup/src/Obelisk/Configs.hs+12−31 lib/frontend/obelisk-frontend.cabal+1−1 lib/frontend/src/Obelisk/Frontend.hs+1−1 lib/route/README.md−6 lib/route/obelisk-route.cabal+1−2 lib/route/src/Obelisk/Route.hs+48−92 lib/route/src/Obelisk/Route/Frontend.hs+28−41 lib/run/obelisk-run.cabal+2−2 lib/run/src/Obelisk/Run.hs+3−3 lib/selftest/src/Obelisk/SelfTest.hs−24 lib/snap-extras/obelisk-snap-extras.cabal+2−1 lib/snap-extras/src/Obelisk/Snap/Extras.hs+1−1 scripts/ghcid-this-lib+4 skeleton/.gitignore+6−12 skeleton/backend/backend.cabal+1−2 skeleton/cabal.project−1 skeleton/common/common.cabal−1 skeleton/default.nix+3−10 skeleton/frontend/frontend.cabal+4−6 skeleton/shell.nix+1
.github/pull_request_template.md−2
@@ -3,8 +3,6 @@
33I have:
44
55 - [ ] Based work on latest `develop` branch
6− - [ ] Followed the [contribution guide](https://github.com/obsidiansystems/obelisk/blob/develop/CONTRIBUTING.md#submitting-changes)
76 - [ ] Looked for lint in my changes with `hlint .` (lint found code you did not write can be left alone)
87 - [ ] Run the test suite: `$(nix-build -A selftest --no-out-link)`
9− - [ ] [Updated the changelog](https://github.com/obsidiansystems/obelisk/blob/develop/CONTRIBUTING.md#in-the-changelog)
108 - [ ] (Optional) Run CI tests locally: `nix-build release.nix -A build.x86_64-linux --no-out-link` (or `x86_64-darwin` on macOS)
CONTRIBUTING.md−52
@@ -8,7 +8,6 @@ Contributions and issue reports are encouraged and appreciated!
88 - [Guidelines for Pull Requests](#guidelines-for-pull-requests)
99 - [Code Quality](#code-quality)
1010 - [Documentation](#documentation)
11−- [Development Environment](#development-environment)
1211
1312## Opening Issues
1413
@@ -40,7 +39,6 @@ For breaking changes, new features, refactors, or other major changes, the body
4039
4140Wherever possible, pull requests should add a single feature or fix a single bug. Pull requests should not bundle several unrelated changes.
4241
43−
4442### Code Quality
4543
4644#### Warnings
@@ -79,53 +77,3 @@ Add an entry to the changelog when your PR:
7977#### In the [Readme](README.md)
8078The readme is the first place a lot of people look for information about the repository. Update any parts of the readme that are affected by your PR.
8179
82−
83−## Development Environment
84−
85−There are two ways to get live compiler feedback while developing Obelisk libraries. For libraries that are dependencies of the `skeleton` application, the easiest way to get feedback is to
86−
87−```bash
88−cd skeleton
89−ob run
90−```
91−
92−This `ob run` session only loads modules that are dependencies of the skeleton and `obelisk-run`. For example, `obelisk-asset` and `obelisk-route` are used by the skeleton.
93−
94−For other libraries like `obelisk-command` you can use `ghcid`. To launch `ghcid` for `lib/command` you can run
95−
96−```bash
97−nix-shell -A obeliskEnvs.obelisk-command --run "cd lib/command && ghcid"
98−```
99−
100−### Building `ob` for testing
101−
102−To re-install `ob` from source globally you can do
103−
104−```bash
105−nix-env -f /path/to/obelisk -iA command
106−```
107−
108−You can also open a shell with the local version of `ob` available on your `$PATH`:
109−
110−```bash
111−nix run -f /path/to/obelisk command
112−```
113−
114−### Hacking on Obelisk from within an Obelisk project
115−
116−`ob` will defer to the version found in your project's `.obelisk/impl` directory. To work on that version specifically:
117−
118−```bash
119−ob thunk unpack ./.obelisk/impl
120−cd ./.obelisk/impl
121−# apply your changes
122−```
123−
124−If you want to commit your changes, first push them to your fork of obelisk and then
125−
126−```bash
127−cd /your/project/root
128−ob thunk pack .obelisk/impl
129−git add .obelisk/impl
130−git commit -m "Bump obelisk"
131−```
ChangeLog.md+4−36
@@ -2,50 +2,18 @@
22
33This project's release branch is `master`. This log is written from the perspective of the release branch: when changes hit `master`, they are considered released.
44
5−## v0.9.1.0
5+## Unreleased
66
7−* [#801](https://github.com/obsidiansystems/obelisk/pull/801): Remove errors and warning for local packages without a library component
8−* [#812](https://github.com/obsidiansystems/obelisk/pull/812): Add support for `NoImplicitPrelude` and other extensions disabled via `No`
9−* Pinned version bumps:
10− * reflex-platform [0.7.0.0](https://github.com/reflex-frp/reflex-platform/releases/tag/v0.7.0.0)
11− * hnix 0.8.0
12−* [#787](https://github.com/obsidiansystems/obelisk/pull/787): Set `immutable` cache control directive when serving content-addressed static assets
13−* Use iOS SDK 13.2
14−
15−
16−## v0.9.0.1
17−
18−* ([#810](https://github.com/obsidiansystems/obelisk/pull/810)) Fix loading of `all.js` in fully compiled web apps.
19−
20−## v0.9.0.0
21−
22−* **(Breaking change)** Backport nixpkgs upgrades to ACME/Let's Encrypt handling so that HTTPS deployments continue to work flawlessly. If your deployment is having trouble renewing [Let's Encrypt](https://letsencrypt.org/) certificates, upgrade to this version.
23− * **IMPORTANT:** In order to use [Let's Encrypt](https://letsencrypt.org/) you must now accept their [terms of service](https://letsencrypt.org/repository/). To do that, add `terms.security.acme.acceptTerms = true;` to the `import ./.obelisk/impl {` section in your `default.nix`. The new skeleton application may serve as an [example](https://github.com/obsidiansystems/obelisk/blob/4759342ab3570888c027d4c58cb5694cb832d624/skeleton/default.nix#L13).
24−* Update reflex-platform dependency to v0.6.0.0
25−* ([#715](https://github.com/obsidiansystems/obelisk/pull/715)) In `Obelisk.Route` deprecate `isoEncoder` and `prismEncoder` in favor of more precisely named `viewEncoder` and `reviewEncoder` (respectively) and improve documentation regarding contravariance of `reviewEncoder`.
26−* ([#739](https://github.com/obsidiansystems/obelisk/pull/739)) Improve `ob shell` by allowing commands to be passed verbatim after a `--` argument. For example, `ob shell 'run command'` can now be written `ob shell -- run command`.
27−* ([#735](https://github.com/obsidiansystems/obelisk/pull/735)) Fix regression causing custom `Prelude`s to break `ob run`/`ob watch`/`ob repl`.
28−* ([#737](https://github.com/obsidiansystems/obelisk/pull/737)) Fix bug causing custom `Prelude`s to break `ob profile`.
29−* ([#752](https://github.com/obsidiansystems/obelisk/pull/752)) Fix the `ob` command-line tool to return non-zero exit code when underlying processes fail.
30−* ([#742](https://github.com/obsidiansystems/obelisk/pull/742), [#57](https://github.com/obsidiansystems/obelisk/pull/57), [#406](https://github.com/obsidiansystems/obelisk/pull/406)) Enable `-dedupe` and `-DGHCJS_BROWSER` in GHCJS builds to make JavaScript output considerably smaller leading to faster load/parse times and faster build times.
31− * **Migration:** New Obelisk projects will automatically benefit from this change, but existing projects need to apply a change similar to [this one](https://github.com/obsidiansystems/obelisk/blob/371cb3302085601c5ec73e9574d51c8b95e3e493/skeleton/frontend/frontend.cabal#L32-L34).
32−* ([#742](https://github.com/obsidiansystems/obelisk/pull/742)) Update `reflex-platform` which includes:
33− * A new version of GHCJS where `-dedupe` is fixed.
34−
35−## v0.8.0.0
36−
37−* ([#674](https://github.com/obsidiansystems/obelisk/pull/674), [#711](https://github.com/obsidiansystems/obelisk/pull/711)) Introduce a new thunk format to support accessing the thunk's source directly when packed. When packed, thunks have an additional file called `thunk.nix` and `default.nix` is now a thin wrapper around that.
7+* ([#674](https://github.com/obsidiansystems/obelisk/pull/674), [#711](https://github.com/obsidiansystems/obelisk/pull/711)) Introduce a new thunk format to support accessing the thunk's source directly when packed. When packed, thunks have an additional file called `thunk.nix` and `default.nix` is now a think wrapper around that.
388* ([#665](https://github.com/obsidiansystems/obelisk/pull/665)) Add `--interpret` and `--no-interpret` options to `ob run`/`ob watch`/`ob repl`/`ob shell`. These options allow you to pick which paths will be pre-compiled by `nix` when entering the shell/session and which won't. For example `ob run --no-interpret dep` will ensure that any dependencies found in `./dep` will be built by `nix` before loading the rest of the project into the `ghci` session. The same configuration for `ob shell` will ensure that those packages are built and available in the `ghc` package database inside the shell.
399
4010 **NOTE:** `ob shell`'s default behavior is now different. By default it now behaves like `ob run`/`ob watch`/`ob repl` in that it does *not* pre-build any packages whose `.cabal` or `package.yaml` files are found in the project. To regain the previous behavior, use `ob shell --no-interpret . --interpret backend --interpret common --interpret frontend` from the project root.
4111* ([#695](https://github.com/obsidiansystems/obelisk/pull/695)) `ob deploy init` now requires that your obelisk project be a clean `git` checkout with pushed changes. It has always required that your obelisk project be a `git` repository, but it did not require that your local changes be committed and pushed. This new requirement is added to ensure users don't accidentally create a deployment pointing to an old version of the project.
4212* ([#705](https://github.com/obsidiansystems/obelisk/pull/705)) Add `Obelisk.Route.packTextEncoder` and generalize `Obelisk.Route.unpackTextEncoder` over any `Data.Text.Lens.IsText`.
43−* ([#712](https://github.com/obsidiansystems/obelisk/pull/712)) Update [`reflex-platform`](https://github.com/reflex-frp/reflex-platform) to version 0.5.3.0.
44−* ([#700](https://github.com/obsidiansystems/obelisk/pull/700)) Ensure `ob init` uses the thunk format of the target obelisk rather than the one currently running the init command. If a user had installed a version of obelisk with a new thunk format, a newly initialized skeleton of an older version would not be able to unpack its own `.obelisk/impl`.
13+* ([#700](https://github.com/obsidiansystems/obelisk/pull/700)) Ensure `ob init` uses the thunk format of the target obelisk rather than the one currently running the init command. If a user had installed a version of obelisk with a new thunk format, a newly initialized skeleton of an older version would not be able to unpack it's own `.obelisk/impl`.
4514* ([#693](https://github.com/obsidiansystems/obelisk/pull/693)) Fix a bug where some packages in `.attr-cache` directories would be incorrectly picked up and used instead of the correct ones when using `ob run`/`ob watch`/`ob repl`.
4615* ([#709](https://github.com/obsidiansystems/obelisk/pull/709)) Fix a bug in obelisk's preprocessor causing it to incorrectly skip files in some circumstances.
4716* ([#663](https://github.com/obsidiansystems/obelisk/pull/663)) Add **experimental** support for [`ghcide`](https://github.com/digital-asset/ghcide). See the README for more information.
48−* ([#714](https://github.com/obsidiansystems/obelisk/pull/714)) Miscellaneous improvements to CLI help and logging.
4917
5018## v0.7.0.1
5119
@@ -92,7 +60,7 @@ This project's release branch is `master`. This log is written from the perspect
9260* Improve error messaging when a dependency doesn't have the expected `.cabal` or `package.yaml` file. ([#597](https://github.com/obsidiansystems/obelisk/pull/597))
9361* Improve the skeleton in small ways. ([#593](https://github.com/obsidiansystems/obelisk/pull/593), [#589](https://github.com/obsidiansystems/obelisk/pull/589))
9462* Fix `ob` commands to again support running from any subdirectory of an obelisk project ([#591](https://github.com/obsidiansystems/obelisk/pull/591))
95−* Add `reflex-platform-func` argument to Obelisk's `default.nix`. It defaults to its prior behavior of using the reflex-platform in in `dep`. ([#612](https://github.com/obsidiansystems/obelisk/pull/612))
63+* Add `reflex-platform-func` argument to Obelisk's `default.nix`. It defaults to it's prior behavior of using the reflex-platform in in `dep`. ([#612](https://github.com/obsidiansystems/obelisk/pull/612))
9664
9765## v0.3.0.0 - 2019-12-20
9866
FAQ.md+67−62
@@ -1,70 +1,14 @@
11# Frequently Asked Questions
22
3−1. [How do I declare a new Haskell dependency?](#how-do-i-declare-a-new-haskell-dependency)
4−1. [How do I add or override Haskell dependencies in the package set?](#how-do-i-add-or-override-haskell-dependencies-in-the-package-set)
5−1. [How do I extend my Obelisk application with more local packages?](#how-do-i-extend-my-obelisk-application-with-more-local-packages)
6−1. [How do I use `ob run` over HTTPS?](#how-do-i-use-ob-run-over-https)
7−1. [How do I fix invalid entitlements?](#how-do-i-fix-invalid-entitlements)
3+1. [How do I fix invalid entitlements? ](#how-do-i-fix-invalid-entitlements)
841. [`ob thunk update` or `ob deploy update` fails](#ob-thunk-update-or-ob-deploy-update-fails)
951. [How do I fix `Ambiguous module name` errors?](#how-do-i-fix-ambiguous-module-name-errors)
10−
11−### How do I declare a new Haskell dependency?
12−
13−Every component of your Obelisk application is a standard [cabal](https://www.haskell.org/cabal/) package. That means declaring new Haskell dependencies simply involves updating the `build-depends` field in the appropriate cabal file (`backend.cabal` for example). By default, Obelisk will use its curated package set to choose which version of each package you get. It's possible that the package you need is not already in the curated set or the curated version isn't the one you want. See [How do I add or override Haskell dependencies in the package set?](#how-do-i-add-or-override-haskell-dependencies-in-the-package-set) for a solution to this.
14−
15−### How do I add or override Haskell dependencies in the package set?
16−
17−To add a Haskell package that doesn't exist in Obelisk's package set or to override the version of a package, use the `overrides` attribute in your project's `default.nix`. For example, to use a specific version of the `aeson` package fetched from GitHub and a specific version of the `waargonaut` package fetched from Hackage, your `default.nix` will look like:
18−
19−```nix
20−# ...
21−project ./. ({ pkgs, ... }: {
22−# ...
23− overrides = self: super: let
24− aesonSrc = pkgs.fetchFromGitHub {
25− owner = "obsidiansystems";
26− repo = "aeson-gadt-th";
27− rev = "ed573c2cccf54d72aa6279026752a3fecf9c1383";
28− sha256 = "08q6rnz7w9pn76jkrafig6f50yd0f77z48rk2z5iyyl2jbhcbhx3";
29− };
30− in
31− {
32− aeson = self.callCabal2nix "aeson" aesonSrc {};
33− waargonaut = self.callHackageDirect {
34− pkg = "waargonaut";
35− ver = "0.8.0.1";
36− sha256 = "1zv28np3k3hg378vqm89v802xr0g8cwk7gy3mr77xrzy5jbgpa39";
37− } {};
38− };
39−# ...
40−```
41−
42−For further information see [the Haskell section](https://nixos.org/nixpkgs/manual/#users-guide-to-the-haskell-infrastructure) of nixpkgs "Contributors Guide".
43−
44−### How do I extend my Obelisk application with more local packages?
45−
46−If the standard packages (`frontend`, `backend`, and `common`) are not enough, you may add more local packages by defining them with the `packages` attribute in your `default.nix`. The sources of these packages will be automatically loaded by `ob run`/`ob repl`/etc.
47−
48−```nix
49−# ...
50−project ./. ({ pkgs, ... }: {
51−# ...
52− packages = {
53− another = ./dep/another;
54− };
55−# ...
56−```
57−
58−### How do I use `ob run` over HTTPS?
59−
60−To run your app locally over HTTPS, update the protocol in `config/common/route` to `https`, and then use `ob run` as normal.
61−
62−Obelisk generates a self-signed certificate for running HTTPS so the browser will issue a warning about using an invalid certificate. On Chrome, you can go to `chrome://flags/#allow-insecure-localhost` to enable invalid certificates for localhost.
63−
6+1. [What does `ob run` actually do?](#what-does-ob-run-actually-do)
647
658### How do I fix invalid entitlements?
669
67−You probably did not set `ios.bundleIdentifier` correctly in `default.nix`. When this happens you'll see an error something like this:
10+You probably did not set `ios.bundleIdentifier` correctly in `default.nix`.
11+When this happens you'll see an error something like this:
6812
6913```
70142018-11-25 09:34:22.438 ios-deploy[58106:8521046] [ !! ] Error 0xe8008016: The executable was signed with invalid entitlements. AMDeviceSecureInstallApplication(0, device, url, options, install_callback, 0)
@@ -75,7 +19,7 @@ Fixing the value of `ios.bundleIdentifier` should fix the error.
7519### `ob thunk update` or `ob deploy update` fails
7620Whenever an `ob` command fails, try re-running it with `-v`.
7721
78−If you're using a private repo, and you get a failure in `nix-prefetch-url`, you may need to unpack and repack the thunk. Here's some example output that shows this issue:
22+If you're using a private repo, and you get a failure in nix-prefetch-url, you may need to unpack and repack the thunk. Here's some example output that shows this issue:
7923
8024```
8125Starting Obelisk </nix/store/j8wls8a89xr6s1a47lg6g83gnbdrfd0l-obelisk-command-0.1/bin/.ob-wrapped> args=["deploy","update","-v"] logging-level=Debug
@@ -95,7 +39,7 @@ nix-prefetch-url: Failed to determine sha256 hash of URL https://github.com/obsi
9539
9640And here's how you can fix it:
9741
98−```bash
42+```
9943ob thunk unpack $SOME_THUNK
10044ob thunk pack $SOME_THUNK
10145```
@@ -115,3 +59,64 @@ error:
11559```
11660then specify the package you want in the import, e.g:
11761`import "cryptonite" Crypto.Hash`
62+
63+
64+### What does `ob run` actually do?
65+
66+
67+#### Short version:
68+
69+`ob run` starts a [`ghcid`](https://github.com/ndmitchell/ghcid) process which
70+tries to build your project within a carefully crafted `nix-shell` with all the
71+project's dependencies and,
72+
73+* either displays compilation errors/warnings,
74+* or starts the Obelisk server, which serves:
75+ * your backend's route handlers,
76+ * the static assets,
77+ * the [JSaddle](https://github.com/ghcjs/jsaddle) frontend code (while opening its websocket).
78+
79+#### Longer version:
80+
81+Assuming we are in a project created with `ob init`, `ob run` calls (see
82+`lib/command/src/Obelisk/Command.hs`):
83+
84+ nix-shell --pure -A shells.ghc --run 'ob --no-handoff internal run-static-io <real-run-function>'
85+
86+where
87+
88+* `shells.ghc` is defined in `./default.nix` by importing `./.obelisk/impl/default.nix` which
89+ is `default.nix` in the present (Obelisk) repository,
90+* `run-static-io` is a logging-enabled command wrapper
91+ (cf. `runObelisk` in `lib/command/src/Obelisk/App.hs`).
92+
93+In this case, it runs the function `Obelisk.Command.Command.run` (defined in
94+`lib/command/src/Obelisk/Command/Run.hs`).
95+
96+* It creates a GHCi config from a Nix expression which:
97+ * loads three packages: `backend`, `common`, `frontend`,
98+ * obtains a free port number.
99+* Then runs `ghcid`
100+ * with a command that reruns `Obelisk.Run.run` at each restart (option
101+ `--test`).
102+
103+It is defined in `lib/run/src/Obelisk/Run.hs`:
104+
105+* It creates a thread which starts the main backend.
106+ This runs `runSnapWithCommandLineArgs` and passes routes:
107+ * to the backend (result of the `_backend_run` field of your
108+ implementation of the `Backend fullRoute frontendRoute` record),
109+ * or to `serveDefaultObeliskApp` (`lib/backend/src/Obelisk/Backend.hs`) to
110+ serve static assets.
111+* Starts `runWidget`
112+ which itself runs
113+ [runSettingsSocket](https://hackage.haskell.org/package/warp-3.2.26/docs/Network-Wai-Handler-Warp.html#v:runSettingsSocket)
114+ (the *“TCP listen loop”*):
115+ * it binds to TCP socket, and
116+ * creates the HTTP connection manager
117+ ( [`newManager`](https://hackage.haskell.org/package/http-client-0.6.3/docs/Network-HTTP-Client.html#v:newManager))
118+ * calls `obeliskApp` which
119+ * has a route to serve the [JSaddle](https://github.com/ghcjs/jsaddle) frontend,
120+ * runs the frontend (*on* the server), to produce pre-rendered pages,
121+ * starts the JSaddle web-socket,
122+ * “falls back” to proxying the backend (`fallbackProxy`).
README.md+167−68
@@ -1,75 +1,96 @@
11# Obelisk
22
33[![Haskell Programming Language](https://img.shields.io/badge/language-Haskell-blue.svg)](http://www.haskell.org)
4−[![BSD3 License](http://img.shields.io/badge/license-BSD3-brightgreen.svg)](https://github.com/obsidiansystems/obelisk/blob/master/LICENSE)
4+[![BSD3 License](http://img.shields.io/badge/license-BSD3-brightgreen.svg)](https://tldrlegal.com/license/bsd-3-clause-license-%28revised%29)
55
6−<p align="center"><img src="docs/obelisk-logo-640.png" width="50%" alt="Obelisk Logo"></p>
76
8−Functional reactive web and mobile applications, with batteries included. Obelisk's goal is to represent a cohesive, highly-curated set of choices that [Obsidian Systems](https://obsidian.systems/) has made for building these types of applications in a way that is extremely fast but does not compromise on production readiness.
7+Obelisk provides an easy way to develop and deploy your [Reflex](https://github.com/reflex-frp/reflex) project as web apps and as mobile apps.
98
10−- [Overview](#overview)
11− - [Who should consider using it?](#who-should-consider-using-it)
129- [Installing Obelisk](#installing-obelisk)
1310- [Developing an Obelisk project](#developing-an-obelisk-project)
11+ - [Adding Packages](#adding-packages)
12+ - [Adding Package Overrides](#adding-package-overrides)
13+ - [Running over HTTPS](#running-over-https)
1414 - [IDE Support](#ide-support)
15+ - [Terminal-based feedback](#terminal-based-feedback)
16+ - [Experimental `ghcide` support](#experimental-ghcide-support)
1517- [Deploying](#deploying)
18+ - [Locally](#locally)
1619 - [Default EC2 Deployment](#default-ec2-deployment)
1720 - [Custom Non-EC2 Deployment](#custom-non-ec2-deployment)
1821 - [VirtualBox Deployment](#virtualbox-deployment)
19− - [Locally](#locally)
2022 - [From macOS](#from-macos)
2123 - [Deploying an updated version](#deploying-an-updated-version)
2224- [Mobile](#mobile)
2325 - [iOS](#ios)
2426 - [Android](#android)
25−- [Frequently Asked Questions (FAQ)](#frequently-asked-questions-faq)
26−- [Contributing](#contributing)
27−
28−## Overview
29−
30−Obelisk allows you to build high-quality web and mobile applications very quickly using [Reflex](https://reflex-frp.org/). In minutes you can go from an empty directory to an interactive application that works on web, iOS, and Android, all sharing the same Haskell codebase! Obelisk's development environment also enables extremely rapid development and feedback. You can take advantage of Haskell's type system across the frontend and backend boundary. This means changes to your backend that would break your frontend are immediately detected during development and vice versa. Obelisk uses Haskell's compiler to give you a complete "TODO list" of what needs to be updated.
31−
32−Obelisk is targeted primarily at Haskell developers who want to build high-quality web and/or mobile applications in Haskell, without the distractions of manually choosing and integrating technology for every piece of the system.
33−
34−### Who should consider using it?
35−
36−Obelisk assumes basic knowledge of [Haskell](https://www.haskell.org/) and [Reflex/Reflex-DOM](https://reflex-frp.org/), web technologies like [HTML](https://developer.mozilla.org/en-US/docs/Web/HTML) and [CSS](https://developer.mozilla.org/en-US/docs/Web/CSS), and a terminal shell like [Bash](https://en.wikipedia.org/wiki/Bash_(Unix_shell)). Knowledge of [Nix](https://nixos.org/) helps but is not strictly necessary.
37−
3827
3928## Installing Obelisk
40−
41291. [Install Nix](https://nixos.org/nix/).
4230 If you already have Nix installed, make sure you have version 2.0 or higher. To check your current version, run `nix-env --version`.
43311. Set up nix caches
4432 1. If you are running NixOS, add this to `/etc/nixos/configuration.nix`:
45− ```nix
33+ ```
4634 nix.binaryCaches = [ "https://nixcache.reflex-frp.org" ];
4735 nix.binaryCachePublicKeys = [ "ryantrinkle.com-1:JJiAKaRv9mWgpVAz8dwewnZe0AzzEAzPkagE9SP5NWI=" ];
4836 ```
4937 and rebuild your NixOS configuration (e.g. `sudo nixos-rebuild switch`).
50− 1. If you are using another operating system or Linux distribution, ensure that these lines are present in your Nix configuration file (`/etc/nix/nix.conf` on most systems; [see full list](https://nixos.org/nix/manual/#sec-conf-file)):
51− ```nix
52− binary-caches = https://cache.nixos.org https://nixcache.reflex-frp.org
53− binary-cache-public-keys = cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY= ryantrinkle.com-1:JJiAKaRv9mWgpVAz8dwewnZe0AzzEAzPkagE9SP5NWI=
54− binary-caches-parallel-connections = 40
38+ 1. If you are using another operating system or linux distribution, ensure that these lines are present in your Nix configuration file (`/etc/nix/nix.conf` on most systems; [see full list](https://nixos.org/nix/manual/#sec-conf-file)):
39+ ```
40+ binary-caches = https://cache.nixos.org https://nixcache.reflex-frp.org
41+ binary-cache-public-keys = cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY= ryantrinkle.com-1:JJiAKaRv9mWgpVAz8dwewnZe0AzzEAzPkagE9SP5NWI=
42+ binary-caches-parallel-connections = 40
5543 ```
56− * If you're on a Linux distribution other than NixOS, enable sandboxing (see these [issue 172](https://github.com/obsidiansystems/obelisk/issues/172#issuecomment-411507818) or [issue 6](https://github.com/obsidiansystems/obelisk/issues/6) if you run into build problems) by adding the following:
57− ```nix
44+ * other Linux: enable sandboxing (see these [issue172](https://github.com/obsidiansystems/obelisk/issues/172#issuecomment-411507818) or [issue6](https://github.com/obsidiansystems/obelisk/issues/6) if you run into build problems)
45+ ```
5846 sandbox = true
5947 ```
60− * If you're on MacOS, disable sandboxing (there are still some impure dependencies for now) by adding the following:
61− ```nix
48+ * MacOS: disable sandboxing (there are still some impure dependencies for now)
49+ ```
6250 sandbox = false
6351 ```
6452 then restart the nix daemon
65− ```bash
53+ ```
6654 sudo launchctl stop org.nixos.nix-daemon
6755 sudo launchctl start org.nixos.nix-daemon
6856 ```
69−1. Install obelisk:
70− ```bash
71− nix-env -f https://github.com/obsidiansystems/obelisk/archive/master.tar.gz -iA command
72− ```
57+1. Install obelisk: `nix-env -f https://github.com/obsidiansystems/obelisk/archive/master.tar.gz -iA command`
58+
59+### Contributing to Obelisk
60+
61+When developing on obelisk itself you may launch `ghcid` for the corresponding project as follows. For example to launch ghcid for `lib/backend` project:
62+
63+```bash
64+nix-shell -A obeliskEnvs.obelisk-backend --run "cd lib/backend && ghcid -c 'cabal new-repl'"
65+```
66+
67+Or to launch ghcid for `lib/command` project:
68+
69+```bash
70+nix-shell -A obeliskEnvs.obelisk-command --run "cd lib/command && ghcid -c 'cabal new-repl'"
71+```
72+
73+To re-install `ob` from source do
74+```bash
75+nix-env -f /path/to/obelisk -iA command
76+```
77+
78+Note that `ob` will defer to the version found in your project's `.obelisk/impl` directory. To update that version specifically:
79+
80+```bash
81+ob thunk unpack ./.obelisk/impl
82+cd ./.obelisk/impl
83+# apply your changes
84+```
85+
86+If you want to commit your changes, first push them to your fork of obelisk and then
87+
88+```bash
89+cd /your/project/root
90+ob thunk pack .obelisk/impl
91+git add .obelisk/impl
92+git commit -m "Bump obelisk"
93+```
7394
7495### Accessing private repositories
7596
@@ -99,12 +120,119 @@ Firefox will not be able to properly run the development website due to [issue 4
99120
100121Every time you change the Haskell source files in frontend, common or backend, `ob run` will automatically recompile the modified files and reload the server. Furthermore, it will display on screen compilation errors and warnings if any.
101122
123+### Adding packages
124+
125+In order to add package dependencies, declare them under the build-depends field in the appropriate cabal files (backend, common, and frontend each have their own). The corresponding Nix packages will automatically be selected when building.
126+
127+### Adding package overrides
128+
129+To add a version override to any Haskell package, or to add a Haskell package that doesn't exist in the nixpkgs used by Obelisk, use the `overrides` attribute in your project's `default.nix`. For example, to use a specific version of the `aeson` package fetched from GitHub and a specific version of the `waargonaut` package fetched from Hackage, your `default.nix` will look like:
130+
131+```nix
132+# ...
133+project ./. ({ pkgs, ... }: {
134+# ...
135+ overrides = self: super: let
136+ aesonSrc = pkgs.fetchFromGitHub {
137+ owner = "obsidiansystems";
138+ repo = "aeson-gadt-th";
139+ rev = "ed573c2cccf54d72aa6279026752a3fecf9c1383";
140+ sha256 = "08q6rnz7w9pn76jkrafig6f50yd0f77z48rk2z5iyyl2jbhcbhx3";
141+ };
142+ in
143+ {
144+ aeson = self.callCabal2nix "aeson" aesonSrc {};
145+ waargonaut = self.callHackageDirect {
146+ pkg = "waargonaut";
147+ ver = "0.8.0.1";
148+ sha256 = "1zv28np3k3hg378vqm89v802xr0g8cwk7gy3mr77xrzy5jbgpa39";
149+ } {};
150+ };
151+# ...
152+```
153+
154+For further information see [the Haskell section](https://nixos.org/nixpkgs/manual/#users-guide-to-the-haskell-infrastructure) of nixpkgs Contributors Guide.
155+
156+### Adding extra local packages
157+
158+If the standard packages (`frontend`, `backend`, and `common`) are not
159+enough, to add more local Haskell packages, define them with the
160+`packages` parameter. The sources of these packages will be
161+automatically reloaded by `ob run`.
162+
163+```nix
164+# ...
165+project ./. ({ pkgs, ... }: {
166+# ...
167+ packages = {
168+ another = ./another;
169+ };
170+# ...
171+```
172+
173+### Running over HTTPS
174+
175+To run your app locally over HTTPS, update the protocol in `config/common/route` to `https`, and then use `ob run` as normal.
176+
177+Since Obelisk generates a self-signed certificate for running HTTPS, the browser will issue a warning about using an invalid certificate. On Chrome, you can go to `chrome://flags/#allow-insecure-localhost` to enable invalid certificates for localhost.
178+
102179### IDE Support
103180
181+#### Terminal-based feedback
182+
104183Obelisk officially supports terminal-based feedback (akin to [`ghcid`](https://github.com/ndmitchell/ghcid)) in `ob run` and `ob watch`.
105184
185+#### **Experimental** `ghcide` support
186+
187+> **NOTE:** `ghcide` support is strictly **experimental** and **not officially supported**. There is no guarantee that it will work for you or that this support will be maintained over time.
188+
189+To try out the **experimental** [`ghcide`](https://github.com/digital-asset/ghcide) support:
190+
191+ * Install a `ghcide` plugin for your editor.
192+ * Add `__withGhcide = true;` to your Obelisk project's `default.nix` (inside the call to `project`). With this setting, `ob shell` will provide `ghcide` as well.
193+ * Add `hie-bios.sh` to the root of your project:
194+ ```shell
195+ cat > hie-bios.sh <<'EOF'
196+ #!/usr/bin/env bash
197+ source "$HOME/.bash_profile"; # NOTE: Some editors need help finding 'ob' and this assumes that `ob` is made available on your `$PATH` in `.bash_profile`
198+ ob internal export-ghci-configuration > "$HIE_BIOS_OUTPUT"
199+ EOF
200+ chmod +x hie-bios.sh
201+ ```
202+ * **Note:** In some projects you need to use `ob internal export-ghci-configuration --use-relative-paths` in this script instead. This is known to happen when your project contains symlinks to other packages.
203+ * Add `hie.yaml` to the root of your project:
204+ ```shell
205+ echo 'cradle: { bios: { program: hie-bios.sh } }' > hie.yaml
206+ ```
207+ * Test the configuration with `ob shell ghcide`. Assuming your project compiles and works with `ghcide` otherwise, this should succeed.
208+ * Start your editor in a way that it can access the appropriate `ghcide`:
209+ * This can sometimes be achieved with `ob shell 'start my editor'`.
210+ * If you can't easily start your editor in a way that it inherits your shell, you may need to customize how your `ghcide` plugin finds `ghcide` or create a custom `ghcide` replacement script that you install globally. For example, for Visual Studio Code on macOS adding a script called `ghcide` to your `PATH` like the one below will cause `ghcide` from each project's `ob shell` to be used:
211+ ```shell
212+ #!/usr/bin/env bash
213+ source "$HOME/.bash_profile" # NOTE: This assumes that `ob` is made available on your `$PATH` in `.bash_profile`
214+ ob shell "ghcide $@"
215+ ```
216+
106217## Deploying
107218
219+### Locally
220+
221+Build everything:
222+
223+```bash
224+nix-build -A exe --no-out-link
225+```
226+
227+Copy the result to a new directory, add configuration, and run!
228+
229+```bash
230+mkdir test-app
231+ln -s $(nix-build -A exe --no-out-link)/* test-app/
232+cp -r config test-app
233+(cd test-app && ./backend)
234+```
235+
108236### Default EC2 Deployment
109237
110238In this section we will demonstrate how to deploy your Obelisk app to an Amazon EC2 instance. Obelisk deployments are configured for EC2 by default (see [Custom Non-EC2 Deployment](#custom-non-ec2-deployment)).
@@ -114,14 +242,14 @@ First create a new EC2 instance:
1142421. Launch a NixOS 19.09 EC2 instance (we recommend [this AMI](https://console.aws.amazon.com/ec2/v2/home?region=us-east-1#LaunchInstanceWizard:ami=ami-00a8eeaf232a74f84))
1152431. In the instance configuration wizard ensure that your instance has at least 1GB RAM and 10GB disk space.
1162441. When prompted save your AWS private key (`~/myaws.pem`) somewhere safe. We'll need it later during deployment.
117−1. Go to "Security Groups", select your instance's security group and under "Inbound" tab add a new rule for HTTP port 80 and HTTPS port 443.
245+1. Go to "Security Groups", select your instance's security group and under "Inbound" tab add a new rule for HTTP port 80 and 443.
118246
119247At this stage your instance should be booting and become accessible shortly. Note down the hostname of your EC2 instance.
120248
121249Now go to your Obelisk project directory (`~/code/myapp`), and initialize a deployment config (`~/code/myapp-deploy`):
122250Your project directory must be "thunkable", i.e. something on which `ob thunk pack` can be called. Usually it will be a git repository whose current revision has been pushed upstream.
123251
124−```bash
252+```
125253cd ~/code/myapp
126254SERVER=ec2-35-183-22-197.ca-central-1.compute.amazonaws.com
127255ROUTE=https://myapp.com # Publicly accessible route to your app
@@ -140,7 +268,7 @@ This step will also require that you manually verify the authenticity of the hos
140268
141269Next, go to the deployment directory that you just initialized and deploy!
142270
143−```bash
271+```
144272cd ~/code/myapp-deploy
145273ob deploy push
146274```
@@ -169,25 +297,6 @@ Here's a `module.nix` that is configured for deployment to a VirtualBox VM (runn
169297
170298The `{...}:` and following is the [NixOS module](https://nixos.org/nixos/manual/index.html#sec-writing-modules) definition.
171299
172−### Locally
173−
174−If you want deploy your application locally or test a production-oriented build you can build and deploy the app as described below.
175−
176−Build the application:
177−
178−```bash
179−nix-build -A exe --no-out-link
180−```
181−
182−Copy the result to a new directory, add configuration, and run!
183−
184−```bash
185−mkdir test-app
186−ln -s $(nix-build -A exe --no-out-link)/* test-app/
187−cp -r config test-app
188−(cd test-app && ./backend)
189−```
190−
191300### From macOS
192301
193302Deploying from macOS requires some extra setup:
@@ -221,7 +330,7 @@ Your account must also belong to an Apple Developer Team, if you want to access
2213301. Click accept to authorize on both the computer and the iPhone.
222331
223332##### Xcode
224−Install Xcode 11.2 (contains iOS SDK 13.2) and open it so that it runs its post install tool setup.
333+Install Xcode 8.2 (contains iOS SDK 10.2) and open it so that it runs its post install tool setup.
225334
226335These versions will work out of the box but iOS SDKs prior to 11.3 should also work. You can choose another installed version in `default.nix`
227336
@@ -314,13 +423,3 @@ This should copy over and install the application on your device (if you see a
314423##### Build a release version
315424
316425After having configured signing for your app, you may proceed to build a release version of the app. This is no different to how you build the non-release version, so consult the section [Android](#android) further above for exact instructions on building and deploying to your device.
317−
318−
319−## Frequently Asked Questions (FAQ)
320−
321−Refer to [FAQ](FAQ.md).
322−
323−
324−## Contributing
325−
326−Contributions and issue reports are encouraged and appreciated! Refer to the [Contributing](CONTRIBUTING.md) guide for information about getting started.
acme.nixdeleted−430
@@ -1,430 +0,0 @@
1−# Copied from https://github.com/NixOS/nixpkgs-channels/blob/70717a337f7ae4e486ba71a500367cad697e5f09/nixos/modules/security/acme.nix # MODIFIED
2−# Lines marked '# MODIFIED' have been added or modified from the original. # MODIFIED
3−{ config, lib, pkgs, ... }:
4−with lib;
5−let
6−
7− cfg = config.security.acme;
8−
9− certOpts = { name, ... }: {
10− options = {
11− webroot = mkOption {
12− type = types.nullOr types.str;
13− default = null;
14− example = "/var/lib/acme/acme-challenges";
15− description = ''
16− Where the webroot of the HTTP vhost is located.
17− <filename>.well-known/acme-challenge/</filename> directory
18− will be created below the webroot if it doesn't exist.
19− <literal>http://example.org/.well-known/acme-challenge/</literal> must also
20− be available (notice unencrypted HTTP).
21− '';
22− };
23−
24− server = mkOption {
25− type = types.nullOr types.str;
26− default = null;
27− description = ''
28− ACME Directory Resource URI. Defaults to let's encrypt
29− production endpoint,
30− https://acme-v02.api.letsencrypt.org/directory, if unset.
31− '';
32− };
33−
34− domain = mkOption {
35− type = types.str;
36− default = name;
37− description = "Domain to fetch certificate for (defaults to the entry name)";
38− };
39−
40− email = mkOption {
41− type = types.nullOr types.str;
42− default = cfg.email;
43− description = "Contact email address for the CA to be able to reach you.";
44− };
45−
46− user = mkOption {
47− type = types.str;
48− default = "root";
49− description = "User running the ACME client.";
50− };
51−
52− group = mkOption {
53− type = types.str;
54− default = "root";
55− description = "Group running the ACME client.";
56− };
57−
58− allowKeysForGroup = mkOption {
59− type = types.bool;
60− default = false;
61− description = ''
62− Give read permissions to the specified group
63− (<option>security.acme.cert.&lt;name&gt;.group</option>) to read SSL private certificates.
64− '';
65− };
66−
67− postRun = mkOption {
68− type = types.lines;
69− default = "";
70− example = "systemctl reload nginx.service";
71− description = ''
72− Commands to run after new certificates go live. Typically
73− the web server and other servers using certificates need to
74− be reloaded.
75− Executed in the same directory with the new certificate.
76− '';
77− };
78−
79− directory = mkOption {
80− type = types.str;
81− readOnly = true;
82− default = "/var/lib/acme/${name}";
83− description = "Directory where certificate and other state is stored.";
84− };
85−
86− extraDomains = mkOption {
87− type = types.attrsOf (types.nullOr types.str);
88− default = {};
89− example = literalExample ''
90− {
91− "example.org" = null;
92− "mydomain.org" = null;
93− }
94− '';
95− description = ''
96− A list of extra domain names, which are included in the one certificate to be issued.
97− Setting a distinct server root is deprecated and not functional in 20.03+
98− '';
99− };
100−
101− keyType = mkOption {
102− type = types.str;
103− default = "ec256";
104− description = ''
105− Key type to use for private keys.
106− For an up to date list of supported values check the --key-type option
107− at https://go-acme.github.io/lego/usage/cli/#usage.
108− '';
109− };
110−
111− dnsProvider = mkOption {
112− type = types.nullOr types.str;
113− default = null;
114− example = "route53";
115− description = ''
116− DNS Challenge provider. For a list of supported providers, see the "code"
117− field of the DNS providers listed at https://go-acme.github.io/lego/dns/.
118− '';
119− };
120−
121− credentialsFile = mkOption {
122− type = types.path;
123− description = ''
124− Path to an EnvironmentFile for the cert's service containing any required and
125− optional environment variables for your selected dnsProvider.
126− To find out what values you need to set, consult the documentation at
127− https://go-acme.github.io/lego/dns/ for the corresponding dnsProvider.
128− '';
129− example = "/var/src/secrets/example.org-route53-api-token";
130− };
131−
132− dnsPropagationCheck = mkOption {
133− type = types.bool;
134− default = true;
135− description = ''
136− Toggles lego DNS propagation check, which is used alongside DNS-01
137− challenge to ensure the DNS entries required are available.
138− '';
139− };
140− };
141− };
142−
143−in
144−
145−{
146−
147− ###### interface
148− imports = [
149− (mkRemovedOptionModule [ "security" "acme" "production" ] ''
150− Use security.acme.server to define your staging ACME server URL instead.
151− To use the let's encrypt staging server, use security.acme.server =
152− "https://acme-staging-v02.api.letsencrypt.org/directory".
153− ''
154− )
155− # (mkRemovedOptionModule [ "security" "acme" "directory"] "ACME Directory is now hardcoded to /var/lib/acme and its permisisons are managed by systemd. See https://github.com/NixOS/nixpkgs/issues/53852 for more info.") # MODIFIED
156− # (mkRemovedOptionModule [ "security" "acme" "preDelay"] "This option has been removed. If you want to make sure that something executes before certificates are provisioned, add a RequiredBy=acme-\${cert}.service to the service you want to execute before the cert renewal") # MODIFIED
157− # (mkRemovedOptionModule [ "security" "acme" "activationDelay"] "This option has been removed. If you want to make sure that something executes before certificates are provisioned, add a RequiredBy=acme-\${cert}.service to the service you want to execute before the cert renewal") # MODIFIED
158− (mkChangedOptionModule [ "security" "acme" "validMin"] [ "security" "acme" "validMinDays"] (config: config.security.acme.validMin / (24 * 3600)))
159− ];
160− options = {
161− security.acme = {
162−
163− validMinDays = mkOption {
164− type = types.int;
165− default = 30;
166− description = "Minimum remaining validity before renewal in days.";
167− };
168−
169− email = mkOption {
170− type = types.nullOr types.str;
171− default = null;
172− description = "Contact email address for the CA to be able to reach you.";
173− };
174−
175− renewInterval = mkOption {
176− type = types.str;
177− default = "daily";
178− description = ''
179− Systemd calendar expression when to check for renewal. See
180− <citerefentry><refentrytitle>systemd.time</refentrytitle>
181− <manvolnum>7</manvolnum></citerefentry>.
182− '';
183− };
184−
185− server = mkOption {
186− type = types.nullOr types.str;
187− default = null;
188− description = ''
189− ACME Directory Resource URI. Defaults to let's encrypt
190− production endpoint,
191− <literal>https://acme-v02.api.letsencrypt.org/directory</literal>, if unset.
192− '';
193− };
194−
195− preliminarySelfsigned = mkOption {
196− type = types.bool;
197− default = true;
198− description = ''
199− Whether a preliminary self-signed certificate should be generated before
200− doing ACME requests. This can be useful when certificates are required in
201− a webserver, but ACME needs the webserver to make its requests.
202− With preliminary self-signed certificate the webserver can be started and
203− can later reload the correct ACME certificates.
204− '';
205− };
206−
207− acceptTerms = mkOption {
208− type = types.bool;
209− default = false;
210− description = ''
211− Accept the CA's terms of service. The default provier is Let's Encrypt,
212− you can find their ToS at https://letsencrypt.org/repository/
213− '';
214− };
215−
216− certs = mkOption {
217− default = { };
218− type = with types; attrsOf (submodule certOpts);
219− description = ''
220− Attribute set of certificates to get signed and renewed. Creates
221− <literal>acme-''${cert}.{service,timer}</literal> systemd units for
222− each certificate defined here. Other services can add dependencies
223− to those units if they rely on the certificates being present,
224− or trigger restarts of the service if certificates get renewed.
225− '';
226− example = literalExample ''
227− {
228− "example.com" = {
229− webroot = "/var/www/challenges/";
230− email = "foo@example.com";
231− extraDomains = { "www.example.com" = null; "foo.example.com" = null; };
232− };
233− "bar.example.com" = {
234− webroot = "/var/www/challenges/";
235− email = "bar@example.com";
236− };
237− }
238− '';
239− };
240− };
241− };
242−
243− ###### implementation
244− config = mkMerge [
245− (mkIf (cfg.certs != { }) {
246−
247− assertions = let
248− certs = (mapAttrsToList (k: v: v) cfg.certs);
249− in [
250− {
251− assertion = all (certOpts: certOpts.dnsProvider == null || certOpts.webroot == null) certs;
252− message = ''
253− Options `security.acme.certs.<name>.dnsProvider` and
254− `security.acme.certs.<name>.webroot` are mutually exclusive.
255− '';
256− }
257− {
258− assertion = cfg.email != null || all (certOpts: certOpts.email != null) certs;
259− message = ''
260− You must define `security.acme.certs.<name>.email` or
261− `security.acme.email` to register with the CA.
262− '';
263− }
264− {
265− assertion = cfg.acceptTerms;
266− message = ''
267− You must accept the CA's terms of service before using
268− the ACME module by setting `security.acme.acceptTerms`
269− to `true`. For Let's Encrypt's ToS see https://letsencrypt.org/repository/
270− '';
271− }
272− ];
273−
274− systemd.services = let
275− services = concatLists servicesLists;
276− servicesLists = mapAttrsToList certToServices cfg.certs;
277− certToServices = cert: data:
278− let
279− # StateDirectory must be relative, and will be created under /var/lib by systemd
280− lpath = "acme/${cert}";
281− apath = "/var/lib/${lpath}";
282− spath = "/var/lib/acme/.lego/${cert}";
283− fileMode = if data.allowKeysForGroup then "640" else "600";
284− globalOpts = [ "-d" data.domain "--email" data.email "--path" "." "--key-type" data.keyType ]
285− ++ optionals (cfg.acceptTerms) [ "--accept-tos" ]
286− ++ optionals (data.dnsProvider != null && !data.dnsPropagationCheck) [ "--dns.disable-cp" ]
287− ++ concatLists (mapAttrsToList (name: root: [ "-d" name ]) data.extraDomains)
288− ++ (if data.dnsProvider != null then [ "--dns" data.dnsProvider ] else [ "--http" "--http.webroot" data.webroot ])
289− ++ optionals (cfg.server != null || data.server != null) ["--server" (if data.server == null then cfg.server else data.server)];
290− runOpts = escapeShellArgs (globalOpts ++ [ "run" ]);
291− renewOpts = escapeShellArgs (globalOpts ++ [ "renew" "--days" (toString cfg.validMinDays) ]);
292− acmeService = {
293− description = "Renew ACME Certificate for ${cert}";
294− after = [ "network.target" "network-online.target" ];
295− wants = [ "network-online.target" ];
296− wantedBy = mkIf (!config.boot.isContainer) [ "multi-user.target" ];
297− serviceConfig = {
298− Type = "oneshot";
299− User = data.user;
300− Group = data.group;
301− PrivateTmp = true;
302− StateDirectory = "acme/.lego/${cert} acme/.lego/accounts ${lpath}";
303− StateDirectoryMode = if data.allowKeysForGroup then "750" else "700";
304− WorkingDirectory = spath;
305− # Only try loading the credentialsFile if the dns challenge is enabled
306− EnvironmentFile = if data.dnsProvider != null then data.credentialsFile else null;
307− ExecStart = pkgs.writeScript "acme-start" ''
308− #!${pkgs.runtimeShell} -e
309− test -L ${spath}/accounts -o -d ${spath}/accounts || ln -s ../accounts ${spath}/accounts
310− ${pkgs.lego}/bin/lego ${renewOpts} || ${pkgs.lego}/bin/lego ${runOpts}
311− '';
312− ExecStartPost =
313− let
314− keyName = builtins.replaceStrings ["*"] ["_"] data.domain;
315− script = pkgs.writeScript "acme-post-start" ''
316− #!${pkgs.runtimeShell} -e
317− cd ${apath}
318− # Test that existing cert is older than new cert
319− KEY=${spath}/certificates/${keyName}.key
320− KEY_CHANGED=no
321− if [ -e $KEY -a $KEY -nt key.pem ]; then
322− KEY_CHANGED=yes
323− cp -p ${spath}/certificates/${keyName}.key key.pem
324− cp -p ${spath}/certificates/${keyName}.crt fullchain.pem
325− cp -p ${spath}/certificates/${keyName}.issuer.crt chain.pem
326− ln -sf fullchain.pem cert.pem
327− cat key.pem fullchain.pem > full.pem
328− fi
329− chmod ${fileMode} *.pem
330− chown '${data.user}:${data.group}' *.pem
331− if [ "$KEY_CHANGED" = "yes" ]; then
332− : # noop in case postRun is empty
333− ${data.postRun}
334− fi
335− '';
336− in
337− "+${script}";
338− };
339−
340− };
341− selfsignedService = {
342− description = "Create preliminary self-signed certificate for ${cert}";
343− path = [ pkgs.openssl ];
344− script =
345− ''
346− workdir="$(mktemp -d)"
347− # Create CA
348− openssl genrsa -des3 -passout pass:xxxx -out $workdir/ca.pass.key 2048
349− openssl rsa -passin pass:xxxx -in $workdir/ca.pass.key -out $workdir/ca.key
350− openssl req -new -key $workdir/ca.key -out $workdir/ca.csr \
351− -subj "/C=UK/ST=Warwickshire/L=Leamington/O=OrgName/OU=Security Department/CN=example.com"
352− openssl x509 -req -days 1 -in $workdir/ca.csr -signkey $workdir/ca.key -out $workdir/ca.crt
353− # Create key
354− openssl genrsa -des3 -passout pass:xxxx -out $workdir/server.pass.key 2048
355− openssl rsa -passin pass:xxxx -in $workdir/server.pass.key -out $workdir/server.key
356− openssl req -new -key $workdir/server.key -out $workdir/server.csr \
357− -subj "/C=UK/ST=Warwickshire/L=Leamington/O=OrgName/OU=IT Department/CN=example.com"
358− openssl x509 -req -days 1 -in $workdir/server.csr -CA $workdir/ca.crt \
359− -CAkey $workdir/ca.key -CAserial $workdir/ca.srl -CAcreateserial \
360− -out $workdir/server.crt
361− # Copy key to destination
362− cp $workdir/server.key ${apath}/key.pem
363− # Create fullchain.pem (same format as "simp_le ... -f fullchain.pem" creates)
364− cat $workdir/{server.crt,ca.crt} > "${apath}/fullchain.pem"
365− # Create full.pem for e.g. lighttpd
366− cat $workdir/{server.key,server.crt,ca.crt} > "${apath}/full.pem"
367− # Give key acme permissions
368− chown '${data.user}:${data.group}' "${apath}/"{key,fullchain,full}.pem
369− chmod ${fileMode} "${apath}/"{key,fullchain,full}.pem
370− '';
371− serviceConfig = {
372− Type = "oneshot";
373− PrivateTmp = true;
374− StateDirectory = lpath;
375− User = data.user;
376− Group = data.group;
377− };
378− unitConfig = {
379− # Do not create self-signed key when key already exists
380− ConditionPathExists = "!${apath}/key.pem";
381− };
382− };
383− in (
384− [ { name = "acme-${cert}"; value = acmeService; } ]
385− ++ optional cfg.preliminarySelfsigned { name = "acme-selfsigned-${cert}"; value = selfsignedService; }
386− );
387− servicesAttr = listToAttrs services;
388− in
389− servicesAttr;
390−
391− systemd.tmpfiles.rules =
392− map (data: "d ${data.webroot}/.well-known/acme-challenge - ${data.user} ${data.group}") (filter (data: data.webroot != null) (attrValues cfg.certs));
393−
394− systemd.timers = let
395− # Allow systemd to pick a convenient time within the day
396− # to run the check.
397− # This allows the coalescing of multiple timer jobs.
398− # We divide by the number of certificates so that if you
399− # have many certificates, the renewals are distributed over
400− # the course of the day to avoid rate limits.
401− numCerts = length (attrNames cfg.certs);
402− _24hSecs = 60 * 60 * 24;
403− AccuracySec = "${toString (_24hSecs / numCerts)}s";
404− in flip mapAttrs' cfg.certs (cert: data: nameValuePair
405− ("acme-${cert}")
406− ({
407− description = "Renew ACME Certificate for ${cert}";
408− wantedBy = [ "timers.target" ];
409− timerConfig = {
410− OnCalendar = cfg.renewInterval;
411− Unit = "acme-${cert}.service";
412− Persistent = "yes";
413− inherit AccuracySec;
414− # Skew randomly within the day, per https://letsencrypt.org/docs/integration-guide/.
415− RandomizedDelaySec = "24h";
416− };
417− })
418− );
419−
420− systemd.targets.acme-selfsigned-certificates = mkIf cfg.preliminarySelfsigned {};
421− systemd.targets.acme-certificates = {};
422− })
423−
424− ];
425−
426− meta = {
427− maintainers = with lib.maintainers; [ abbradar fpletz globin m1cr0man ];
428− # doc = ./acme.xml; # MODIFIED
429− };
430−}
all-builds.nix+1−1
@@ -1,6 +1,6 @@
11{ self-args ? {
22 config.android_sdk.accept_license = true;
3− iosSdkVersion = "13.2";
3+ iosSdkVersion = "10.2";
44 }
55, local-self ? import ./. self-args
66, supportedSystems ? [ builtins.currentSystem ]
default.nix+27−60
@@ -1,10 +1,7 @@
11{ system ? builtins.currentSystem
22, profiling ? false
3−, iosSdkVersion ? "13.2"
3+, iosSdkVersion ? "10.2"
44, config ? {}
5−, terms ? { # Accepted terms, conditions, and licenses
6− security.acme.acceptTerms = false;
7− }
85, reflex-platform-func ? import ./dep/reflex-platform
96}:
107let
@@ -46,7 +43,7 @@ in rec {
4643 pathGit = ./.; # Used in CI by the migration graph hash algorithm to correctly ignore files.
4744 path = reflex-platform.filterGit ./.;
4845 obelisk = ghcObelisk;
49− obeliskEnvs = pkgs.lib.filterAttrs (k: _: k == "tabulation" || pkgs.lib.strings.hasPrefix "obelisk-" k) ghcObeliskEnvs; #TODO: use thunkSet https://github.com/reflex-frp/reflex-platform/pull/671
46+ obeliskEnvs = pkgs.lib.filterAttrs (k: _: pkgs.lib.strings.hasPrefix "obelisk-" k) ghcObeliskEnvs;
5047 command = ghcObelisk.obelisk-command;
5148 shell = pinBuildInputs "obelisk-shell" ([command] ++ command.commandRuntimeDeps);
5249
@@ -77,20 +74,16 @@ in rec {
7774 '';
7875
7976 compressedJs = frontend: optimizationLevel: pkgs.runCommand "compressedJs" {} ''
80− set -euo pipefail
81− cd '${haskellLib.justStaticExecutables frontend}'
82− shopt -s globstar
83− for f in **/all.js; do
84− dir="$out/$(basename "$(dirname "$f")")"
85− mkdir -p "$dir"
86− ln -s "$(realpath "$f")" "$dir/all.unminified.js"
87− ${if optimizationLevel == null then ''
88− ln -s "$dir/all.unminified.js" "$dir/all.js"
89− '' else ''
90− '${pkgs.closurecompiler}/bin/closure-compiler' --externs '${reflex-platform.ghcjsExternsJs}' -O '${optimizationLevel}' --jscomp_warning=checkVars --create_source_map="$dir/all.js.map" --source_map_format=V3 --js_output_file="$dir/all.js" "$dir/all.unminified.js"
91− echo '//# sourceMappingURL=all.js.map' >> "$dir/all.js"
92− ''}
93− done
77+ mkdir $out
78+ cd $out
79+ # TODO profiling + static shouldn't break and need an ad-hoc workaround like that
80+ ln -s "${haskellLib.justStaticExecutables frontend}/bin/frontend.jsexe/all.js" all.unminified.js
81+ ${if optimizationLevel == null then ''
82+ ln -s all.unminified.js all.js
83+ '' else ''
84+ ${pkgs.closurecompiler}/bin/closure-compiler --externs "${reflex-platform.ghcjsExternsJs}" -O ${optimizationLevel} --jscomp_warning=checkVars --create_source_map="all.js.map" --source_map_format=V3 --js_output_file="all.js" all.unminified.js
85+ echo "//# sourceMappingURL=all.js.map" >> all.js
86+ ''}
9487 '';
9588
9689 serverModules = {
@@ -116,8 +109,6 @@ in rec {
116109 security.acme.certs = if enableHttps then {
117110 "${routeHost}".email = adminEmail;
118111 } else {};
119−
120− security.acme.${if enableHttps && (terms.security.acme.acceptTerms or false) then "acceptTerms" else null} = true;
121112 };
122113
123114 mkObeliskApp =
@@ -134,16 +125,12 @@ in rec {
134125 }: {...}: {
135126 services.nginx = {
136127 enable = true;
137− recommendedProxySettings = true;
138128 virtualHosts."${routeHost}" = {
139129 enableACME = enableHttps;
140130 forceSSL = enableHttps;
141131 locations.${baseUrl} = {
142132 proxyPass = "http://127.0.0.1:" + toString internalPort;
143133 proxyWebsockets = true;
144− extraConfig = ''
145− access_log off;
146− '';
147134 };
148135 };
149136 };
@@ -184,11 +171,9 @@ in rec {
184171 pkgs.runCommand "serverExe" {} ''
185172 mkdir $out
186173 set -eux
187− ln -s '${if profiling then backend else haskellLib.justStaticExecutables backend}'/bin/* $out/
188− ln -s '${mkAssets assets}' $out/static.assets
189− for d in '${mkAssets (compressedJs frontend optimizationLevel)}'/*/; do
190− ln -s "$d" "$out"/"$(basename "$d").assets"
191− done
174+ ln -s "${if profiling then backend else haskellLib.justStaticExecutables backend}"/bin/* $out/
175+ ln -s "${mkAssets assets}" $out/static.assets
176+ ln -s ${mkAssets (compressedJs frontend optimizationLevel)} $out/frontend.jsexe.assets
192177 echo ${version} > $out/version
193178 '';
194179
@@ -202,20 +187,6 @@ in rec {
202187 (module { inherit exe hostName adminEmail routeHost enableHttps version; nixosPkgs = pkgs; })
203188 (serverModules.mkDefaultNetworking args)
204189 (serverModules.mkObeliskApp args)
205− ./acme.nix # Backport of ACME upgrades from 20.03
206− ];
207−
208− # Backport of ACME upgrades from 20.03
209− disabledModules = [
210− (pkgs.path + /nixos/modules/security/acme.nix)
211− ];
212− nixpkgs.overlays = [
213− (self: super: {
214− lego = (import (builtins.fetchTarball {
215− url = https://github.com/NixOS/nixpkgs-channels/archive/70717a337f7ae4e486ba71a500367cad697e5f09.tar.gz;
216− sha256 = "1sbmqn7yc5iilqnvy9nvhsa9bx6spfq1kndvvis9031723iyymd1";
217− }) {}).lego;
218− })
219190 ];
220191 };
221192 };
@@ -350,33 +321,29 @@ in rec {
350321 __unstable__.profiledObRun = let
351322 profiled = projectOut { inherit system; enableLibraryProfiling = true; };
352323 exeSource = builtins.toFile "ob-run.hs" ''
353− {-# LANGUAGE NoImplicitPrelude #-}
354− {-# LANGUAGE PackageImports #-}
355324 module Main where
356325
357− -- Explicitly import Prelude from base lest there be multiple modules called Prelude
358− import "base" Prelude (IO, (++), read)
359−
360− import "base" Control.Exception (finally)
361− import "reflex" Reflex.Profiled (writeProfilingData)
362− import "base" System.Environment (getArgs)
326+ import Control.Exception
327+ import Reflex.Profiled
328+ import System.Environment
363329
364− import qualified "obelisk-run" Obelisk.Run
330+ import qualified Obelisk.Run
365331 import qualified Frontend
366332 import qualified Backend
367333
368334 main :: IO ()
369335 main = do
370− [portStr, assets, profFileName] <- getArgs
371− Obelisk.Run.run (read portStr) (Obelisk.Run.runServeAsset assets) Backend.backend Frontend.frontend
372− `finally` writeProfilingData (profFileName ++ ".rprof")
336+ args <- getArgs
337+ let port = read $ args !! 0
338+ assets = args !! 1
339+ profileFile = (args !! 2) <> ".rprof"
340+ Obelisk.Run.run port (Obelisk.Run.runServeAsset assets) Backend.backend Frontend.frontend `finally` writeProfilingData profileFile
373341 '';
374342 in nixpkgs.runCommand "ob-run" {
375− buildInputs = [ (profiled.ghc.ghcWithPackages (p: [p.backend p.frontend])) ];
343+ buildInputs = [ (profiled.ghc.ghcWithPackages (p: [ p.backend p.frontend])) ];
376344 } ''
377− cp ${exeSource} ob-run.hs
378− mkdir -p $out/bin
379− ghc -x hs -prof -fno-prof-auto -threaded ob-run.hs -o $out/bin/ob-run
345+ mkdir -p $out/bin/
346+ ghc -x hs -prof -fno-prof-auto -threaded ${exeSource} -o $out/bin/ob-run
380347 '';
381348
382349 linuxExeConfigurable = linuxExe;
dep/.gitignorenew file+5
@@ -0,0 +1,5 @@
1+*
2+!*/
3+!.gitignore
4+!*/*.json
5+!*/default.nix
dep/reflex-platform/default.nix+7−1
@@ -1,2 +1,8 @@
11# DO NOT HAND-EDIT THIS FILE
2−import (import ./thunk.nix)
2+let fetch = { private ? false, fetchSubmodules ? false, owner, repo, rev, sha256, ... }:
3+ if !fetchSubmodules && !private then builtins.fetchTarball {
4+ url = "https://github.com/${owner}/${repo}/archive/${rev}.tar.gz"; inherit sha256;
5+ } else (import <nixpkgs> {}).fetchFromGitHub {
6+ inherit owner repo rev sha256 fetchSubmodules private;
7+ };
8+in import (fetch (builtins.fromJSON (builtins.readFile ./github.json)))
dep/reflex-platform/github.json+3−3
@@ -1,8 +1,8 @@
11{
22 "owner": "reflex-frp",
33 "repo": "reflex-platform",
4− "branch": "release/0.7.0.0",
4+ "branch": "release/0.5.3.0",
55 "private": false,
6− "rev": "27a7851a780ff21472d85f9a02fb84635ef9027a",
7− "sha256": "1m4zlw91dpjlbdchjyxhvhv3k7lilm0qa17dhhww868xxc27sann"
6+ "rev": "9779ea3b4c87fdc971057c561262696d5e9b1847",
7+ "sha256": "0v87ilal9355xwz8y9m0zh14pm9c0f7pqch0854kkj92ybc5l62q"
88}
dep/reflex-platform/thunk.nixdeleted−9
@@ -1,9 +0,0 @@
1−# DO NOT HAND-EDIT THIS FILE
2−let fetch = { private ? false, fetchSubmodules ? false, owner, repo, rev, sha256, ... }:
3− if !fetchSubmodules && !private then builtins.fetchTarball {
4− url = "https://github.com/${owner}/${repo}/archive/${rev}.tar.gz"; inherit sha256;
5− } else (import <nixpkgs> {}).fetchFromGitHub {
6− inherit owner repo rev sha256 fetchSubmodules private;
7− };
8− json = builtins.fromJSON (builtins.readFile ./github.json);
9−in fetch json
docs/obelisk-logo-640.pngdeleted

Binary file not shown.

guides/app-deploy/README.md+11−24
@@ -1,14 +1,13 @@
11# Obelisk Application Deployment Guide
2−
32This document serves two purposes, the first one is to guide new users that want to deploy Obelisk/Reflex apps and the second one to provide a walk-through for test driving Obelisk releases.
43
5−> **Note:** This guide can be completed on a Linux host with Nix installed or a macOS host with Nix installed. Each section is labeled regarding which operating system hosts it supports. When going through the guide, start at the beginning and go through all sections that are supported on your host and merely skip sections that are not supported. The sections for iOS deployments require an iPhone or iPad device and the sections for Android deployments require an Android device. This guide assumes that you have Nix correctly set up and that your system is configured to fetch from binary caches instead of building everything on your machine. If you notice any of the commands below takes more than 5 minutes, then caches are not likely enabled.
4+> **Note:** To complete this *entire* guide you need access to a macOS machine running the latest OSX release, a Linux machine (can be a VM on that mac) with Nix installed, an iPhone or iPad, and a recent Android device. It also assumes that you have Nix correctly set up and that your system is set up to fetch from binary caches instead of building everything on your machine. If you notice any of the commands below takes more than 5 minutes, then caches are not likely enabled.
65>
76> Refer to the [Obelisk Installation Documentation](https://github.com/obsidiansystems/obelisk#installing-obelisk) for instructions on configuring the binary caches for any Nix-compatible setup.
87
9−## a) Get Obelisk (Linux, Mac)
8+## a) Get Obelisk
109
11−There are several ways to install Obelisk, but the one we are going to use here allows us to test a single version of Obelisk in different ways. The approach is to clone Obelisk from its GitHub repository and start a project that uses that local check out.
10+There are several ways to install Obelisk, but the one we are going to use here allows us to test a single version of Obelisk in different ways. The approach is to clone Obelisk from it's GitHub repository and start a project that uses that local check out.
1211
1312Open a terminal and run the following:
1413
@@ -40,7 +39,7 @@ ob init --branch "$OBELISK_BRANCH"
4039
4140> **Note:** If the `--branch` parameter is not used, then Obelisk sets your project up to look at the `master` branch from GitHub. This is quite handy for real life projects but distracting for our test drive since we want to make sure any changes we do to the Obelisk codebase (like testing a pull request) are immediately picked up.
4241
43−## b) Run the Obelisk app on localhost (Linux, Mac)
42+## b) Run the Obelisk app on localhost
4443
4544Let's test that we can run a server on localhost. This is quite easy:
4645
@@ -53,10 +52,9 @@ Now open a browser and point it to http://localhost:8000 (or just click on this
5352
5453![](assets/app-deploy.png)
5554
56−## c) Prepare a VirtualBox deploy target (Linux, Mac)
55+## c) Deploy the web app on a remote machine
5756
5857### Import the NixOS VirtualBox appliance
59−
6058Install [VirtualBox](https://www.virtualbox.org/) on your machine.
6159
6260On NixOS, do this by adding the following line to your `/etc/nixos/configuration.nix` before the last line containing `}`:
@@ -81,7 +79,7 @@ You should now see a NixOS machine in the dashboard:
8179
8280![](assets/virtualbox-dashboard-nixos.png)
8381
84−If you are on a network with DHCP on your wireless or network card then right-click on the "NixOS" image and click "Settings". Go to the "Network" section and make "Attached to:" set to "Bridged Adapter".
82+If you are on a network with DHCP on your wireless or network card then select right-click on the "NixOS" image and click "Settings". Go to the "Network" section and make "Attached to:" set to "Bridged Adapter".
8583
8684![](assets/virtualbox-image-settings-network.png)
8785
@@ -203,7 +201,7 @@ git remote add origin "$WORKDIR/myapp-git-remote"
203201git push -u origin master
204202```
205203
206−### Initialize deployment directory
204+### Deploy
207205
208206With that, we can come back to the Obelisk app and initialize the deployment:
209207
@@ -218,11 +216,7 @@ Then configure the deployment for VirtualBox:
218216echo '{nixosPkgs, ...}: {...}: { imports = [ (nixosPkgs.path + /nixos/modules/virtualisation/virtualbox-image.nix) ]; }' > "$WORKDIR/myappdeploy/module.nix"
219217```
220218
221−## d) Deploy to VirtualBox target (Linux only)
222−
223−> Deploying requires a Linux host in order to build the Linux binaries.
224−
225−Now we can deploy to the VirtualBox VM.
219+And deploy:
226220
227221```bash
228222cd "$WORKDIR/myappdeploy"
@@ -249,7 +243,7 @@ It should look like this:
249243
250244Congratulations! You have deployed an Obelisk application to a remote server via SSH.
251245
252−## e) Deploy an Android app (Linux only)
246+## d) Deploy an Android app (Linux host only)
253247
254248> **Note:** This section requires that you be running a Linux *host*.
255249
@@ -273,14 +267,7 @@ ob deploy update
273267ob deploy test android -v
274268```
275269
276−This deployment will ask you to create a password (at least 6 characters long) and then ask you a series of questions. You can pick arbitrary answers. When you are presented with prompt like:
277−
278−```
279−Is CN=a, OU=b, O=c, L=d, ST=e, C=f correct?
280− [no]:
281−```
282−
283−You can enter `yes` to continue. If the deployment fails, try using different USB ports on your computer and running `ob deploy test android -v` again. The USB cable you use can also make a difference.
270+This deployment will ask you to create a password (at least 6 characters long) and then ask you a series of questions. You can pick arbitrary answers. If the deployment fails, try using different USB ports on your computer and running `ob deploy test android -v` again. The USB cable you use can also make a difference.
284271
285272When connecting your Android device you may be asked to "Allow USB debugging". You need to allow it.
286273![](assets/android-confirm-usb-debugging.jpg)
@@ -292,7 +279,7 @@ When the deployment is complete opening the app should look something like
292279
293280Congratulations! You have deployed an Obelisk Android app via USB.
294281
295−## f) Deploy an iOS app (Mac only)
282+## e) Deploy an iOS app (macOS host only)
296283
297284> **Note:** This section requires that you be running a macOS *host*.
298285
haskell-overlays/ghcide.nix+32−38
@@ -1,40 +1,34 @@
11self: super:
2−let
3− pkgs = self.callPackage ({ pkgs }: pkgs) { };
4− inherit (pkgs.haskell.lib) dontCheck justStaticExecutables;
5− inherit (pkgs.haskellPackages) callHackageDirect callHackage;
6−
7−in {
8− ghcide = justStaticExecutables (dontCheck (callHackageDirect {
9− pkg = "ghcide";
10− ver = "0.2.0";
11− sha256 = "199l4qzrghhz6wbfkgqdl4gll4wvgpr190kinzhv88idnn9pxm96";
12− } rec {
13− ghc-check = callHackageDirect {
14− pkg = "ghc-check";
15− ver = "0.3.0.1";
16− sha256 = "1dj909m09m24315x51vxvcl28936ahsw4mavbc53danif3wy09ns";
17− } { };
18− lsp-test = dontCheck (callHackage "lsp-test" "0.6.1.0" { });
19− haddock-library = dontCheck (callHackage "haddock-library" "1.8.0" { });
20− haskell-lsp = dontCheck (callHackageDirect {
21− pkg = "haskell-lsp";
22− ver = "0.22.0.0";
23− sha256 = "1q3w46qcvzraxgmw75s7bl0qvb2fvff242r5vfx95sqska566b4m";
24− } { inherit haskell-lsp-types; });
25− haskell-lsp-types = dontCheck (callHackageDirect {
26− pkg = "haskell-lsp-types";
27− ver = "0.22.0.0";
28− sha256 = "1apjclphi2v6ggrdnbc0azxbb1gkfj3x1vkwpc8qd6lsrbyaf0n8";
29− } { });
30− regex-tdfa = dontCheck (callHackage "regex-tdfa" "1.3.1.0" {
31− regex-base = dontCheck (callHackage "regex-base" "0.94.0.0" { });
32− });
33− shake = dontCheck (callHackage "shake" "0.18.4" { });
34− hie-bios = dontCheck (callHackageDirect {
35− pkg = "hie-bios";
36− ver = "0.5.0";
37− sha256 = "116nmpva5jmlgc2dgy8cm5wv6cinhzmga1l0432p305074w720r2";
38− } { });
39− }));
2+ let
3+ pkgs = self.callPackage ({ pkgs }: pkgs) {};
4+ inherit (pkgs.haskell.lib) dontCheck;
5+ in {
6+ ghcide = pkgs.haskell.lib.justStaticExecutables (dontCheck ((self.override {
7+ overrides = self: super: {
8+ ghc-check = self.callHackageDirect {
9+ pkg = "ghc-check";
10+ ver = "0.1.0.3";
11+ sha256 = "038llbvryk5y27jbdpbshp0zw5lw1j6m7qk7vx1n96ykqdzkh649";
12+ } {};
13+ lsp-test = dontCheck (self.callHackage "lsp-test" "0.6.1.0" {});
14+ haddock-library = dontCheck (self.callHackage "haddock-library" "1.8.0" {});
15+ haskell-lsp = dontCheck (self.callHackage "haskell-lsp" "0.19.0.0" {});
16+ haskell-lsp-types = dontCheck (self.callHackage "haskell-lsp-types" "0.19.0.0" {});
17+ regex-posix = dontCheck (self.callHackage "regex-posix" "0.96.0.0" {});
18+ test-framework = dontCheck (self.callHackage "test-framework" "0.8.2.0" {});
19+ regex-base = dontCheck (self.callHackage "regex-base" "0.94.0.0" {});
20+ regex-tdfa = dontCheck (self.callHackage "regex-tdfa" "1.3.1.0" {});
21+ shake = dontCheck (self.callHackage "shake" "0.18.4" {});
22+ hie-bios = dontCheck (self.callHackageDirect {
23+ pkg = "hie-bios";
24+ ver = "0.4.0";
25+ sha256 = "19lpg9ymd9656cy17vna8wr1hvzfal94gpm2d3xpnw1d5qr37z7x";
26+ } {});
27+ };
28+ }).callCabal2nix "ghcide" (pkgs.fetchFromGitHub {
29+ owner = "digital-asset";
30+ repo = "ghcide";
31+ rev = "v0.1.0";
32+ sha256 = "1kf71iix46hvyxviimrcv7kvsj67hcnnqlpdsmazmlmybf7wbqbb";
33+ }) {}));
4034}
haskell-overlays/misc-deps.nix+2−8
@@ -9,14 +9,8 @@ let
99in
1010
1111{
12− regex-base = self.callHackage "regex-base" "0.94.0.0" {};
13− regex-posix = self.callHackage "regex-posix" "0.96.0.0" {};
14− regex-tdfa = self.callHackage "regex-tdfa" "1.3.1.0" {};
15− test-framework = haskellLib.dontCheck (self.callHackage "test-framework" "0.8.2.0" {});
16− hnix = haskellLib.dontCheck (self.callHackage "hnix" "0.8.0" {});
17− hnix-store-core = self.callHackage "hnix-store-core" "0.2.0.0" {};
18−
19− aeson-gadt-th = self.callHackage "aeson-gadt-th" "0.2.4" {};
12+ hnix = haskellLib.dontCheck (haskellLib.doJailbreak (self.callCabal2nix "hnix" (hackGet ../dep/hnix) {}));
13+ hnix-store-core = self.callHackage "hnix-store-core" "0.1.0.0" {};
2014
2115 ghcid = self.callCabal2nix "ghcid" (hackGet ../dep/ghcid) {};
2216 # Exports more internals
haskell-overlays/obelisk.nix−5
@@ -19,12 +19,7 @@ in
1919 obelisk-command = haskellLib.overrideCabal (self.callCabal2nix "obelisk-command" (obeliskCleanSource ../lib/command) {}) {
2020 librarySystemDepends = [
2121 pkgs.jre
22− pkgs.git
2322 pkgs.nix
24− pkgs.nix-prefetch-git
25− pkgs.openssh
26− pkgs.rsync
27− pkgs.which
2823 (haskellLib.justStaticExecutables self.ghcid)
2924 ];
3025 };
lib/asset/README.md+19−16
@@ -1,26 +1,29 @@
1−# obelisk-asset
1+## obelisk-asset
22
3−[![Haskell Programming Language](https://img.shields.io/badge/language-Haskell-blue.svg)](http://www.haskell.org)
4−[![BSD3 License](http://img.shields.io/badge/license-BSD3-brightgreen.svg)](https://github.com/obsidiansystems/obelisk/blob/master/LICENSE)
5−
6−**Efficiently served, aggressively cached static web resources.**
7−
8−The `assets.nix` file contains nix expressions that are a mutually recursive set of attributes used to create static asset directories with hashable file encodings. This file should be incorporated within your project's `default.nix` file. (See `example/default.nix`, line 2)
9−
10−```nix
11−{ assets ? import ./../assets.nix { inherit nixpkgs; } }:
3+The 'assets.nix' file contains nix expressions that are a mutually
4+recursive set of attributes used to create static asset directories
5+with hashable file encodings. This file should be incorporated within
6+your project's 'default.nix' file. (See ./example/default.nix , line 2)
7+```
8+{assets ? import ./../assets.nix { inherit nixpkgs; }
9+}:
1210```
1311
14−The `mkAssets` and `mkAssetsWith` functions within `assets.nix` only need to be passed an `encoding("zopfliEncodings", "gzipEncodings", "noEncodings")` and a static directory of your choice as arguments.
15−
16−In this example, `mkAssets` is used on a directory that has a `.png` file inside of it. (See `example/default.nix`, line 11)
12+The 'mkAssets' and 'mkAssetsWith' functions within 'assets.nix' only
13+need to be passed an encoding('zopfliEncodings', 'gzipEncodings',
14+'noEncodings') and a static directory of your choice as arguments.
1715
18−```nix
16+In this example, 'mkAssets' is used on a directory that has a .png
17+file inside of it. (See ./example/default.nix, line 11)
18+```
1919myAssets = assets.mkAssets ./static;
2020```
2121
22−Once you have successfully incorporated `assets.nix` into your project's nix file(s), use `nix-build` to generate a symlink of your `mkAssets` expression. The following command from `example/run-example` (line 3) will generate an immutable symlink that holds hashed static assets.
23−
22+Once you have successfully incorporated 'assets.nix' into your
23+project's nix file(s), use nix-build to generate a symlink of
24+your 'mkAssets' expression. The following command from
25+example/run-example (line 3) will generate an immutable symlink
26+that holds hashed static assets.
2427```bash
2528nix-build -o static.assets -A myAssets
2629```
lib/asset/assets.nix+5−28
@@ -20,7 +20,7 @@ zopfliEncodings = file:
2020 nixpkgs.stdenv.mkDerivation {
2121 name = "encodings";
2222
23− input = mkPath file;
23+ input = file;
2424
2525 builder = builtins.toFile "builder.sh" ''
2626 source "$stdenv/setup"
@@ -46,7 +46,7 @@ gzipEncodings = file:
4646 nixpkgs.stdenv.mkDerivation {
4747 name = "encodings";
4848
49− input = mkPath file;
49+ input = file;
5050
5151 builder = builtins.toFile "builder.sh" ''
5252 source "$stdenv/setup"
@@ -70,7 +70,7 @@ noEncodings = file:
7070 nixpkgs.stdenv.mkDerivation {
7171 name = "encodings";
7272
73− input = mkPath file;
73+ input = file;
7474
7575 builder = builtins.toFile "builder.sh" ''
7676 source "$stdenv/setup"
@@ -203,7 +203,7 @@ hashFile = path:
203203 nixpkgs.nix
204204 ];
205205 preferLocalBuild = true;
206− path = mkPath path;
206+ inherit path;
207207 } ''
208208 nix-hash --flat --base32 --type sha256 "$path" | tr -d '\n' >"$out"
209209 '');
@@ -224,30 +224,7 @@ symlink = path: {
224224 inherit path;
225225};
226226
227−# Tests if a given character (string of length 1) is valid for a derivation path name.
228−# Passing a string of length other than 1 is undefined.
229−# :: Char -> Bool
230−isValidDrvNameChar = c: "a" <= c && c <= "z" || "A" <= c && c <= "Z" || "0" <= c && c <= "9" || c == "+" || c == "-" || c == "_" || c == "?" || c == "=" || c == ".";
231−
232−# Convert a string into a string that could be used in a derivation name.
233−# replacement lets you choose how to replace invalid characters. It may be any length.
234−# If it contains invalid characters then the result will also be invalid.
235−# :: { str :: String, replacement :: String } -> String
236−mkValidDrvName = { str, replacement ? "?" }:
237− let
238− newName = stringAsChars (c: if isValidDrvNameChar c then c else replacement) str;
239− in if builtins.substring 0 1 newName == "." then "_" + newName else newName;
240−
241−# Like builtins.path but always ensures the name is valid.
242−mkPath = path:
243− if builtins.typeOf path == "path" # Don't mess with non-paths
244− then builtins.path {
245− inherit path;
246− name = mkValidDrvName { str = builtins.baseNameOf path; };
247− }
248− else path;
249−
250−# Given an encoding generation function and a file entry resulting from readDirRecursive in the form { name :: String, value: { path :: String } },
227+# Given a encoding generation function and a file entry resulting from readDirRecursive in the form { name :: String, value: { path :: String } },
251228# build a DirEntry for dirToPath with the various encodings of the asset for dirToPath to build into a final directory tree.
252229mkAsset = encodings: {name, value}:
253230 let nameWithHash = "${hashFile value.path}-${name}";
lib/asset/manifest/obelisk-asset-manifest.cabal+2−4
@@ -24,7 +24,7 @@ library
2424 , template-haskell
2525 , text
2626 , transformers
27− , unix-compat
27+ , unix
2828 , vector
2929 exposed-modules:
3030 Obelisk.Asset.Gather
@@ -33,9 +33,7 @@ library
3333 Obelisk.Asset.TH
3434
3535 other-extensions: TemplateHaskell
36− ghc-options:
37− -Wall -Werror -Wredundant-constraints -Wincomplete-uni-patterns -Wincomplete-record-updates -O2
38− -fno-warn-unused-do-bind -funbox-strict-fields -fprof-auto-calls
36+ ghc-options: -Wall -Werror -fno-warn-unused-do-bind -fwarn-tabs -funbox-strict-fields -O2 -fprof-auto-calls
3937
4038executable obelisk-asset-manifest-generate
4139 hs-source-dirs: src-bin
lib/asset/manifest/src/Obelisk/Asset/Symlink.hs+1−1
@@ -7,7 +7,7 @@ import Data.Map (Map)
77import qualified Data.Map as Map
88import System.Directory
99import System.FilePath.Posix
10−import System.PosixCompat.Files
10+import System.Posix.Files
1111
1212-- | Copy the given hashed files from one location to hashed paths in another
1313-- location, and symlink the unhashed paths to the hashed ones
lib/asset/serve-snap/obelisk-asset-serve-snap.cabal+2−4
@@ -23,12 +23,10 @@ library
2323 , obelisk-snap-extras
2424 , text
2525 , transformers
26− , unix-compat
26+ , unix
2727 exposed-modules:
2828 Obelisk.Asset.Accept
2929 Obelisk.Asset.Serve.Snap
3030
3131 other-extensions: TemplateHaskell
32− ghc-options:
33− -Wall -Werror -Wredundant-constraints -Wincomplete-uni-patterns -Wincomplete-record-updates -O2
34− -fno-warn-unused-do-bind -funbox-strict-fields -fprof-auto-calls
32+ ghc-options: -Wall -Werror -fno-warn-unused-do-bind -fwarn-tabs -funbox-strict-fields -O2 -fprof-auto-calls
lib/asset/serve-snap/src/Obelisk/Asset/Serve/Snap.hs+1−1
@@ -31,7 +31,7 @@ import Data.Text.Encoding (decodeUtf8, encodeUtf8)
3131import System.Directory (getDirectoryContents)
3232import System.FilePath ((</>), splitFileName, takeDirectory)
3333import System.IO.Error (isDoesNotExistError)
34−import System.PosixCompat.Files (getFileStatus, fileSize)
34+import System.Posix (getFileStatus, fileSize)
3535
3636-- | Serve static assets from an asset directory generated via @assets.nix@ or, failing that, from a regular directory.
3737--
lib/backend/obelisk-backend.cabal+2−2
@@ -21,10 +21,10 @@ library
2121 obelisk-frontend,
2222 obelisk-route,
2323 obelisk-snap-extras,
24− reflex-dom-core,
24+ reflex-dom,
2525 snap,
2626 snap-server,
2727 text,
2828 universe
2929 exposed-modules: Obelisk.Backend
30− ghc-options: -Wall -Werror -Wredundant-constraints -Wincomplete-uni-patterns -Wincomplete-record-updates -O
30+ ghc-options: -Wall
lib/backend/src/Obelisk/Backend.hs+1−1
@@ -58,7 +58,7 @@ import qualified Obelisk.ExecutableConfig.Lookup as Lookup
5858import Obelisk.Frontend
5959import Obelisk.Route
6060import Obelisk.Snap.Extras (doNotCache, serveFileIfExistsAs)
61−import Reflex.Dom.Core
61+import Reflex.Dom
6262import Snap (MonadSnap, Snap, commandLineConfig, defaultConfig, getsRequest, httpServe, modifyResponse
6363 , rqPathInfo, rqQueryString, setContentType, writeBS, writeText
6464 , rqCookies, Cookie(..) , setHeader)
lib/cliapp/obelisk-cliapp.cabal+1−3
@@ -19,12 +19,10 @@ library
1919 , monad-loops
2020 , mtl
2121 , process
22− , shell-escape
2322 , terminal-size
2423 , text
2524 , time
2625 , transformers
27− , utf8-string
2826 exposed-modules:
2927 Obelisk.CliApp
3028 other-modules:
@@ -34,4 +32,4 @@ library
3432 Obelisk.CliApp.TerminalString
3533 Obelisk.CliApp.Theme
3634 Obelisk.CliApp.Types
37− ghc-options: -Wall -Werror -Wredundant-constraints -Wincomplete-uni-patterns -Wincomplete-record-updates -O
35+ ghc-options: -Wall -fobject-code
lib/cliapp/src/Obelisk/CliApp.hs−3
@@ -39,9 +39,7 @@ module Obelisk.CliApp
3939 , callCommand
4040 , callProcess
4141 , callProcessAndLogOutput
42− , createProcess
4342 , createProcess_
44− , exitCodeToException
4543 , overCreateProcess
4644 , proc
4745 , readCreateProcessWithExitCode
@@ -49,7 +47,6 @@ module Obelisk.CliApp
4947 , readProcessAndLogStderr
5048 , readProcessJSONAndLogStderr
5149 , reconstructCommand
52− , runProcess_
5350 , setCwd
5451 , setDelegateCtlc
5552 , setEnvOverride
lib/cliapp/src/Obelisk/CliApp/Logging.hs+2−2
@@ -160,7 +160,7 @@ failWith :: (CliThrow e m, AsUnstructuredError e) => Text -> m a
160160failWith = throwError . review asUnstructuredError
161161
162162errorToWarning
163− :: (HasCliConfig e m, CliLog m)
163+ :: (HasCliConfig e m, CliThrow e m, CliLog m)
164164 => e -> m ()
165165errorToWarning e = do
166166 c <- getCliConfig
@@ -177,7 +177,7 @@ withExitFailMessage msg f = f `catch` \(e :: ExitCode) -> do
177177 throwM e
178178
179179-- | Write log to stdout, with colors (unless `noColor`)
180−writeLog :: (MonadIO m) => Bool -> Bool -> WithSeverity Text -> m ()
180+writeLog :: (MonadIO m, MonadMask m) => Bool -> Bool -> WithSeverity Text -> m ()
181181writeLog withNewLine noColor (WithSeverity severity s) = if T.null s then pure () else write
182182 where
183183 write
lib/cliapp/src/Obelisk/CliApp/Process.hs+29−48
@@ -1,6 +1,7 @@
11{-# LANGUAGE FlexibleContexts #-}
22{-# LANGUAGE LambdaCase #-}
33{-# LANGUAGE MultiParamTypeClasses #-}
4+{-# LANGUAGE MultiWayIf #-}
45{-# LANGUAGE OverloadedStrings #-}
56{-# LANGUAGE ScopedTypeVariables #-}
67{-# LANGUAGE TupleSections #-}
@@ -16,7 +17,6 @@ module Obelisk.CliApp.Process
1617 , callProcessAndLogOutput
1718 , createProcess
1819 , createProcess_
19− , exitCodeToException
2020 , overCreateProcess
2121 , proc
2222 , readCreateProcessWithExitCode
@@ -24,7 +24,6 @@ module Obelisk.CliApp.Process
2424 , readProcessAndLogStderr
2525 , readProcessJSONAndLogStderr
2626 , reconstructCommand
27− , runProcess_
2827 , setCwd
2928 , setDelegateCtlc
3029 , setEnvOverride
@@ -33,14 +32,12 @@ module Obelisk.CliApp.Process
3332 ) where
3433
3534import Control.Monad ((<=<), join, void)
36−import Control.Monad.Catch (MonadMask, bracketOnError)
3735import Control.Monad.Except (throwError)
3836import Control.Monad.Fail
3937import Control.Monad.IO.Class (MonadIO, liftIO)
4038import Control.Lens (Prism', review)
4139import qualified Data.ByteString as BS
4240import qualified Data.ByteString.Char8 as BSC
43−import qualified Data.ByteString.UTF8 as BSU
4441import Data.Function (fix)
4542import Data.Map (Map)
4643import qualified Data.Map as Map
@@ -57,7 +54,6 @@ import qualified System.IO.Streams as Streams
5754import System.IO.Streams.Concurrent (concurrentMerge)
5855import System.Process (CreateProcess, ProcessHandle, StdStream (CreatePipe), std_err, std_out)
5956import qualified System.Process as Process
60−import Text.ShellEscape (bash, bytes)
6157import qualified Data.Aeson as Aeson
6258
6359import Control.Monad.Log (Severity (..))
@@ -101,7 +97,7 @@ instance AsProcessFailure ProcessFailure where
10197 asProcessFailure = id
10298
10399readProcessAndLogStderr
104− :: (MonadIO m, CliLog m, CliThrow e m, AsProcessFailure e, MonadMask m)
100+ :: (MonadIO m, CliLog m, CliThrow e m, AsProcessFailure e, MonadFail m)
105101 => Severity -> ProcessSpec -> m Text
106102readProcessAndLogStderr sev process = do
107103 (out, _err) <- withProcess process $ \_out err -> do
@@ -109,7 +105,7 @@ readProcessAndLogStderr sev process = do
109105 liftIO $ T.decodeUtf8With lenientDecode <$> BS.hGetContents out
110106
111107readProcessJSONAndLogStderr
112− :: (Aeson.FromJSON a, MonadIO m, CliLog m, CliThrow e m, AsProcessFailure e, MonadMask m)
108+ :: (Aeson.FromJSON a, MonadIO m, CliLog m, CliThrow e m, AsProcessFailure e, MonadFail m)
113109 => Severity -> ProcessSpec -> m a
114110readProcessJSONAndLogStderr sev process = do
115111 (out, _err) <- withProcess process $ \_out err -> do
@@ -122,7 +118,7 @@ readProcessJSONAndLogStderr sev process = do
122118 throwError $ review asProcessFailure $ ProcessFailure (Process.cmdspec $ _processSpec_createProcess process) 0
123119
124120readCreateProcessWithExitCode
125− :: (MonadIO m, CliLog m)
121+ :: (MonadIO m, CliLog m, CliThrow e m, AsProcessFailure e)
126122 => ProcessSpec -> m (ExitCode, String, String)
127123readCreateProcessWithExitCode procSpec = do
128124 process <- mkCreateProcess procSpec
@@ -132,10 +128,10 @@ readCreateProcessWithExitCode procSpec = do
132128-- | Like `System.Process.readProcess` but logs the combined output (stdout and stderr)
133129-- with the corresponding severity.
134130--
135−-- Usually this function is called as `readProcessAndLogOutput (Debug, Error)`. However
131+-- Usually this function is called as `callProcessAndLogOutput (Debug, Error)`. However
136132-- some processes are known to spit out diagnostic or informative messages in stderr, in
137133-- which case it is advisable to call it with a non-Error severity for stderr, like
138−-- `readProcessAndLogOutput (Debug, Debug)`.
134+-- `callProcessAndLogOutput (Debug, Debug)`.
139135readProcessAndLogOutput
140136 :: (MonadIO m, CliLog m, CliThrow e m, AsProcessFailure e, MonadFail m)
141137 => (Severity, Severity) -> ProcessSpec -> m Text
@@ -148,7 +144,9 @@ readProcessAndLogOutput (sev_out, sev_err) process = do
148144 outText <- liftIO $ T.decodeUtf8With lenientDecode <$> BS.hGetContents out
149145 putLogRaw sev_out outText
150146
151− outText <$ (exitCodeToException process =<< waitForProcess p)
147+ waitForProcess p >>= \case
148+ ExitSuccess -> pure outText
149+ ExitFailure code -> throwError $ review asProcessFailure $ ProcessFailure (Process.cmdspec $ _processSpec_createProcess process) code
152150
153151-- | Like 'System.Process.callProcess' but logs the combined output (stdout and stderr)
154152-- with the corresponding severity.
@@ -158,7 +156,7 @@ readProcessAndLogOutput (sev_out, sev_err) process = do
158156-- which case it is advisable to call it with a non-Error severity for stderr, like
159157-- `callProcessAndLogOutput (Debug, Debug)`.
160158callProcessAndLogOutput
161− :: (MonadIO m, CliLog m, CliThrow e m, AsProcessFailure e, MonadMask m)
159+ :: (MonadIO m, CliLog m, CliThrow e m, AsProcessFailure e, MonadFail m)
162160 => (Severity, Severity) -> ProcessSpec -> m ()
163161callProcessAndLogOutput (sev_out, sev_err) process =
164162 void $ withProcess process $ \out err -> do
@@ -188,11 +186,12 @@ createProcess_ name procSpec = do
188186 liftIO $ Process.createProcess_ name p
189187
190188mkCreateProcess :: MonadIO m => ProcessSpec -> m Process.CreateProcess
191−mkCreateProcess (ProcessSpec p override') = case override' of
192− Nothing -> pure p
193− Just override -> do
194− procEnv <- Map.fromList <$> maybe (liftIO getEnvironment) pure (Process.env p)
195− pure $ p { Process.env = Just $ Map.toAscList (override procEnv) }
189+mkCreateProcess (ProcessSpec p override') = do
190+ case override' of
191+ Nothing -> pure p
192+ Just override -> do
193+ procEnv <- Map.fromList <$> maybe (liftIO getEnvironment) pure (Process.env p)
194+ pure $ p { Process.env = Just $ Map.toAscList (override procEnv) }
196195
197196-- | Like `System.Process.callProcess` but also logs (debug) the process being run
198197callProcess
@@ -211,30 +210,18 @@ callCommand cmd = do
211210 liftIO $ Process.callCommand cmd
212211
213212withProcess
214− :: (MonadIO m, CliLog m, CliThrow e m, AsProcessFailure e, MonadMask m)
213+ :: (MonadIO m, CliLog m, CliThrow e m, AsProcessFailure e, MonadFail m)
215214 => ProcessSpec -> (Handle -> Handle -> m ()) -> m (Handle, Handle)
216−withProcess process f =
217− bracketOnError
218− (createProcess $ overCreateProcess
219− (\x -> x { std_out = CreatePipe , std_err = CreatePipe }) process
220− )
221− (liftIO . Process.cleanupProcess)
222− (\case
223− (_, Just out, Just err, p) -> do
224− f out err
225− (out, err) <$ (exitCodeToException process =<< waitForProcess p)
226− _ -> error "withProcess: createProcess did not provide handles for CreatePipe as expected"
227− )
228−
229−-- | Runs a process to completion failing if it does not exit cleanly.
230−runProcess_
231− :: (MonadIO m, CliLog m, CliThrow e m, MonadMask m, AsProcessFailure e)
232− => ProcessSpec -> m ()
233−runProcess_ process =
234− bracketOnError
235− (createProcess process)
236− (liftIO . Process.cleanupProcess)
237− (\(_, _, _, ph) -> exitCodeToException process =<< waitForProcess ph)
215+withProcess process f = do -- TODO: Use bracket.
216+ -- FIXME: Using `withCreateProcess` here leads to something operating illegally on closed handles.
217+ (_, Just out, Just err, p) <- createProcess $ overCreateProcess
218+ (\x -> x { std_out = CreatePipe , std_err = CreatePipe }) process
219+
220+ f out err -- Pass the handles to the passed function
221+
222+ waitForProcess p >>= \case
223+ ExitSuccess -> return (out, err)
224+ ExitFailure code -> throwError $ review asProcessFailure $ ProcessFailure (Process.cmdspec $ _processSpec_createProcess process) code
238225
239226-- Create an input stream from the file handle, associating each item with the given severity.
240227streamHandle :: Severity -> Handle -> IO (InputStream (Severity, BSC.ByteString))
@@ -253,20 +240,14 @@ streamToLog stream = fix $ \loop -> do
253240waitForProcess :: MonadIO m => ProcessHandle -> m ExitCode
254241waitForProcess = liftIO . Process.waitForProcess
255242
256−-- | Converts an 'ExitCode' to an exception when it's non-zero.
257−exitCodeToException :: (CliThrow e m, AsProcessFailure e) => ProcessSpec -> ExitCode -> m ()
258−exitCodeToException spec = \case
259− ExitSuccess -> pure ()
260− ExitFailure code -> throwError $ review asProcessFailure $ ProcessFailure (Process.cmdspec $ _processSpec_createProcess spec) code
261−
262243-- | Pretty print a 'CmdSpec'
263244reconstructCommand :: Process.CmdSpec -> Text
264245reconstructCommand p = case p of
265246 Process.ShellCommand str -> T.pack str
266247 Process.RawCommand c as -> processToShellString c as
267248 where
268− processToShellString cmd args = T.pack $ unwords $
269− map (BSU.toString . bytes . bash . BSU.fromString) (cmd : args)
249+ processToShellString cmd args = T.unwords $ map quoteAndEscape (cmd : args)
250+ quoteAndEscape x = "'" <> T.replace "'" "'\''" (T.pack x) <> "'"
270251
271252reconstructProcSpec :: ProcessSpec -> Text
272253reconstructProcSpec = reconstructCommand . Process.cmdspec . _processSpec_createProcess
lib/command/obelisk-command.cabal+3−5
@@ -1,5 +1,5 @@
11name: obelisk-command
2−version: 0.9.0.1
2+version: 0.7.0.1
33cabal-version: >= 1.8
44build-type: Simple
55
@@ -39,15 +39,13 @@ library
3939 , optparse-applicative
4040 , placeholders
4141 , process
42− , shell-escape
4342 , temporary
4443 , terminal-size
4544 , text
4645 , time
4746 , transformers
48− , unix-compat
47+ , unix
4948 , unordered-containers
50− , utf8-string
5149 , which
5250 , yaml
5351 exposed-modules:
@@ -66,4 +64,4 @@ library
6664executable ob
6765 main-is: src-bin/ob.hs
6866 build-depends: base, obelisk-command
69− ghc-options: -Wall -Werror -Wredundant-constraints -Wincomplete-uni-patterns -Wincomplete-record-updates -O -threaded
67+ ghc-options: -Wall -O2 -threaded
lib/command/src/Obelisk/Command.hs+8−12
@@ -22,7 +22,7 @@ import System.Environment
2222import System.FilePath
2323import qualified System.Info
2424import System.IO (hIsTerminalDevice, stdout)
25−import System.Process (rawSystem)
25+import System.Posix.Process (executeFile)
2626
2727import Obelisk.App
2828import Obelisk.CliApp
@@ -114,7 +114,7 @@ obCommand cfg = hsubparser
114114 , command "thunk" $ info (ObCommand_Thunk <$> thunkOption) $ progDesc "Manipulate thunk directories"
115115 , command "repl" $ info (ObCommand_Repl <$> interpretOpts) $ progDesc "Open an interactive interpreter"
116116 , command "watch" $ info (ObCommand_Watch <$> interpretOpts) $ progDesc "Watch current project for errors and warnings"
117− , command "shell" $ info (ObCommand_Shell <$> shellOpts) $ progDesc "Enter a shell with project dependencies or run a command in such a shell. E.g. ob shell -- ghc-pkg list"
117+ , command "shell" $ info (ObCommand_Shell <$> shellOpts) $ progDesc "Enter a shell with project dependencies"
118118 , command "doc" $ info (ObCommand_Doc <$> shellFlags <*> packageNames) $
119119 progDesc "List paths to haddock documentation for specified packages"
120120 <> footerDoc (Just $
@@ -285,10 +285,7 @@ shellOpts :: Parser ShellOpts
285285shellOpts = ShellOpts
286286 <$> shellFlags
287287 <*> interpretOpts
288− -- This funny construction is used to support optparse-applicative's @--@ parsing.
289− -- All arguments after @--@ are left unparsed and instead provided to the last positional parser
290− -- which must therefore be 'many' in order to consume the rest of the input.
291− <*> ((\xs -> if null xs then Nothing else Just $ unwords xs) <$> many (strArgument (metavar "COMMAND")))
288+ <*> optional (strArgument (metavar "COMMAND"))
292289
293290portOpt :: Int -> Parser Int
294291portOpt dfault = option auto (long "port" <> short 'p' <> help "Port number for server" <> showDefault <> value dfault <> metavar "INT")
@@ -366,8 +363,7 @@ main' argsCfg = do
366363 Just impl -> do
367364 -- Invoke the real implementation, using --no-handoff to prevent infinite recursion
368365 putLog Debug $ "Handing off to " <> T.pack impl
369− _ <- liftIO $ rawSystem impl ("--no-handoff" : myArgs)
370− return ()
366+ liftIO $ executeFile impl False ("--no-handoff" : myArgs) Nothing
371367 case myArgs of
372368 "--no-handoff" : as -> go as -- If we've been told not to hand off, don't hand off
373369 origPath:inPath:outPath:preprocessorName:packagePaths
@@ -402,11 +398,11 @@ ob = \case
402398 ObCommand_Repl interpretPathsList -> withInterpretPaths interpretPathsList runRepl
403399 ObCommand_Watch interpretPathsList -> withInterpretPaths interpretPathsList runWatch
404400 ObCommand_Shell (ShellOpts shellAttr interpretPathsList cmd) -> withInterpretPaths interpretPathsList $ \root interpretPaths ->
405− nixShellForInterpretPaths False shellAttr root interpretPaths cmd -- N.B. We do NOT bash escape here; we want to run the command as-is
406− ObCommand_Doc shellAttr pkgs -> withInterpretPaths [] $ \root interpretPaths ->
407− nixShellForInterpretPaths True shellAttr root interpretPaths $ Just $ haddockCommand pkgs
401+ nixShellForInterpretPaths False shellAttr root interpretPaths cmd
402+ ObCommand_Doc shellAttr pkgs -> withProjectRoot "." $ \root ->
403+ nixShellForInterpretPaths True shellAttr root emptyPathTree $ Just $ haddockCommand pkgs
408404 ObCommand_Hoogle shell' port -> withProjectRoot "." $ \root -> do
409− nixShellWithHoogle root True shell' $ Just $ "hoogle server -p" <> show port <> " --local"
405+ nixShellWithHoogle root True shell' $ Just $ "hoogle server -p " <> show port <> " --local"
410406 ObCommand_Internal icmd -> case icmd of
411407 ObInternal_ApplyPackages origPath inPath outPath packagePaths -> do
412408 liftIO $ Preprocessor.applyPackages origPath inPath outPath packagePaths
lib/command/src/Obelisk/Command/Deploy.hs+16−16
@@ -25,7 +25,7 @@ import GHC.Generics
2525import System.Directory
2626import System.FilePath
2727import System.IO
28−import System.PosixCompat.Files
28+import System.Posix.Files
2929import Text.URI (URI)
3030import qualified Text.URI as URI
3131import Text.URI.Lens
@@ -85,12 +85,13 @@ deployInit' thunkPtr (DeployInitOpts deployDir sshKeyPath hostnames route adminE
8585 --accidentally create a production deployment that uses development
8686 --credentials to connect to some resources. This could result in, e.g.,
8787 --production data backed up to a dev environment.
88− withSpinner "Creating project configuration directories" $ liftIO $ do
89− mapM_ (createDirectoryIfMissing True)
90− [ deployDir </> "config" </> "backend"
91− , deployDir </> "config" </> "common"
92− , deployDir </> "config" </> "frontend"
93− ]
88+ withSpinner "Creating project configuration directories" $ do
89+ callProcessAndLogOutput (Notice, Error) $
90+ proc "mkdir" [ "-p"
91+ , deployDir </> "config" </> "backend"
92+ , deployDir </> "config" </> "common"
93+ , deployDir </> "config" </> "frontend"
94+ ]
9495
9596 let srcDir = deployDir </> "src"
9697 withSpinner ("Creating source thunk (" <> T.pack (makeRelative deployDir srcDir) <> ")") $ do
@@ -161,8 +162,8 @@ deployPush deployPath getNixBuilders = do
161162 "nix-copy-closure" ["-v", "--to", "--use-substitutes", "root@" <> host, "--gzip", outputPath]
162163 withSpinner "Uploading config" $ ifor_ buildOutputByHost $ \host _ -> do
163164 callProcessAndLogOutput (Notice, Warning) $
164− proc rsyncPath
165− [ "-e " <> sshPath <> " " <> unwords sshOpts
165+ proc "rsync"
166+ [ "-e ssh " <> unwords sshOpts
166167 , "-qarvz"
167168 , deployPath </> "config"
168169 , "root@" <> host <> ":/var/lib/backend"
@@ -170,10 +171,9 @@ deployPush deployPath getNixBuilders = do
170171 --TODO: Create GC root so we're sure our closure won't go away during this time period
171172 withSpinner "Switching to new configuration" $ ifor_ buildOutputByHost $ \host outputPath -> do
172173 callProcessAndLogOutput (Notice, Warning) $
173− proc sshPath $ sshOpts <>
174+ proc "ssh" $ sshOpts <>
174175 [ "root@" <> host
175176 , unwords
176− -- Note that we don't want to $(staticWhich "nix-env") here, because this is executing on a remote machine
177177 [ "nix-env -p /nix/var/nix/profiles/system --set " <> outputPath
178178 , "&&"
179179 , "/nix/var/nix/profiles/system/bin/switch-to-configuration switch"
@@ -182,10 +182,10 @@ deployPush deployPath getNixBuilders = do
182182 isClean <- checkGitCleanStatus deployPath True
183183 when (not isClean) $ do
184184 withSpinner "Committing changes to Git" $ do
185− callProcessAndLogOutput (Debug, Error) $
186− gitProc deployPath ["add", "."]
187− callProcessAndLogOutput (Debug, Error) $
188− gitProc deployPath ["commit", "-m", "New deployment"]
185+ callProcessAndLogOutput (Debug, Error) $ proc "git"
186+ ["-C", deployPath, "add", "."]
187+ callProcessAndLogOutput (Debug, Error) $ proc "git"
188+ ["-C", deployPath, "commit", "-m", "New deployment"]
189189 putLog Notice $ "Deployed => " <> T.pack route
190190 where
191191 callProcess' envMap cmd args = do
@@ -315,7 +315,7 @@ readDeployConfig deployDir fname = liftIO $ do
315315
316316verifyHostKey :: MonadObelisk m => FilePath -> FilePath -> String -> m ()
317317verifyHostKey knownHostsPath keyPath hostName =
318− callProcessAndLogOutput (Notice, Warning) $ proc sshPath $
318+ callProcessAndLogOutput (Notice, Warning) $ proc "ssh" $
319319 sshArgs knownHostsPath keyPath True <>
320320 [ "root@" <> hostName
321321 , "-o", "NumberOfPasswordPrompts=0"
lib/command/src/Obelisk/Command/Preprocessor.hs+47−52
@@ -5,7 +5,6 @@ module Obelisk.Command.Preprocessor where
55
66import qualified Data.ByteString.Lazy as BL
77import qualified Data.ByteString.Lazy.Builder as BU
8−import Data.Foldable (for_)
98import Data.List (intersperse, isPrefixOf, sortOn)
109import Data.Maybe (fromMaybe)
1110import qualified Data.Text.Lazy.Builder as TL
@@ -18,83 +17,79 @@ import System.FilePath (hasTrailingPathSeparator, joinPath, splitPath)
1817
1918import Obelisk.Command.Run (CabalPackageInfo (..), parseCabalPackage')
2019
21−-- | This code is intended to be executed via ghci's -pgmF preprocessor option.
22−-- The command line arguments are passed in via ghc, which dictates the first three options and meanings
23−-- In order for this code to execute, origPath must contain either a '.' character or a '/' character.
24−-- (This is to avoid the possibility of the command line syntax conflicting with another ob command)
25−-- We do have control over the remaining arguments, but they must be the same for all files.
26−-- Thus, the fourth command line argument must be "apply-packages", which has already been handled.
27−-- We assume all the remaining arguments passed in are paths to cabal or hpack package specifications.
28−-- Thus we must select among the packagePaths for the file we are going to parse.
2920applyPackages :: FilePath -> FilePath -> FilePath -> [FilePath] -> IO ()
30−applyPackages origPath inPath outPath packagePaths' = do
21+applyPackages origPath inPath outPath packagePaths' = withFile outPath WriteMode $ \outFile -> do
22+ -- This code is intended to be executed via ghci's -pgmF preprocessor option
23+ -- The command line arguments are passed in via ghc, which dictates the first three options and meanings
24+ -- In order for this code to execute, origPath must contain either a '.' character or a '/' character.
25+ -- (This is to avoid the possibility of the command line syntax conflicting with another ob command)
26+ -- We do have control over the remaining arguments, but they must be the same for all files.
27+ -- Thus, the fourth command line argument must be "apply-packages", which has already been handled.
28+ -- We assume all the remaining arguments passed in are paths to cabal or hpack package specifications.
29+ -- Thus we must select among the packagePaths for the file we are going to parse.
30+
3131 origPathCanonical <- canonicalizePath origPath
3232 packagePaths <- traverse canonicalizePath packagePaths'
3333
34− let
35− takeDirs = takeWhile hasTrailingPathSeparator
36− packageDirs = sortOn (negate . length . takeDirs) $ map splitPath packagePaths
37− origDir = splitPath origPathCanonical
38− matches = [ joinPath d | d <- packageDirs, takeDirs d `isPrefixOf` origDir ]
34+ let takeDirs = takeWhile hasTrailingPathSeparator
35+ packageDirs = sortOn (negate . length . takeDirs) $ map splitPath packagePaths
36+ origDir = splitPath origPathCanonical
37+ matches = [ joinPath d | d <- packageDirs, takeDirs d `isPrefixOf` origDir ]
3938
40− -- The first element of matches is going to be the deepest path to a package spec that contains
39+ -- So the first element of matches is going to be the deepest path to a package spec that contains
4140 -- our file as a subdirectory.
42− packageInfo' <- case matches of
43− [] -> do
41+
42+ case matches of
43+ [] ->
4444 hPutStrLn stderr $ "Error: Unable to find cabal information for " <> origPath <> "; Skipping preprocessor."
45− pure Nothing
46− packagePath:_ -> parseCabalPackage' packagePath >>= \case
47− Left err -> do
48− hPutStrLn stderr $ "Error: Unable to parse cabal package " <> packagePath <> "; Skipping preprocessor on " <> origPath <> ". Error: " <> show err
49− pure Nothing
50− Right (Just (_, packageInfo)) -> pure $ Just packageInfo
51− Right Nothing -> pure Nothing
45+ packagePath:_ -> do
46+ parseCabalPackage' packagePath >>= \case
47+ Left err ->
48+ hPutStrLn stderr $ "Error: Unable to parse cabal package " <> packagePath <> "; Skipping preprocessor on " <> origPath <> ". Error: " <> show err
49+ Right (_warnings, packageInfo) ->
50+ hPutTextBuilder outFile (generateHeader origPath packageInfo)
5251
53− writeOutput packageInfo' inPath outPath
52+ BL.readFile inPath >>= BL.hPut outFile
5453
55−writeOutput :: Maybe CabalPackageInfo -> FilePath -> FilePath -> IO ()
56−writeOutput packageInfo' origPath outPath = withFile outPath WriteMode $ \hOut -> do
57− for_ packageInfo' $ \packageInfo -> hPutTextBuilder hOut (generateHeader origPath packageInfo)
58− BL.readFile origPath >>= BL.hPut hOut
5954 where
6055 hPutTextBuilder h = BU.hPutBuilder h . TL.encodeUtf8Builder . TL.toLazyText
6156
57+
58+ -- I'm pretty sure there's a certain amount of oversimplification in CabalPackageInfo, so I doubt this is fully robust.
59+
6260generateHeader :: FilePath -> CabalPackageInfo -> TL.Builder
6361generateHeader origPath packageInfo =
6462 hsExtensions <> ghcOptions <> lineNumberPragma origPath
6563 where
6664 hsExtensions =
67− if null extList
68− then mempty
69− else pragma $ TL.fromText "LANGUAGE " <> mconcat (intersperse (TL.fromText ", ") extList)
65+ if not (null extList)
66+ then TL.fromText "{-# LANGUAGE "
67+ <> mconcat (intersperse (TL.fromText ", ") extList)
68+ <> TL.fromText " #-}\n"
69+ else mempty
7070 extList = addDefaultLanguage $ concatMap showExt $ _cabalPackageInfo_defaultExtensions packageInfo
7171 addDefaultLanguage =
7272 case _cabalPackageInfo_defaultLanguage packageInfo of
7373 Nothing -> id
7474 Just x -> case x of
75− UnknownLanguage ext -> (TL.fromString ext :)
76− ext -> (TL.fromString (show ext) :)
75+ UnknownLanguage ext -> ( TL.fromString ext :)
76+ ext -> ( TL.fromString (show ext) :)
7777 showExt = \case
7878 EnableExtension ext -> [TL.fromString (show ext)]
79− DisableExtension ext -> ["No" <> TL.fromString (show ext)]
79+ DisableExtension _ -> []
8080 UnknownExtension ext -> [TL.fromString ext]
8181
8282 ghcOptions =
83− if null optList
84− then mempty
85− else pragma $
86− TL.fromText "OPTIONS_GHC " <> mconcat (intersperse (TL.fromText " ") (map TL.fromString optList))
87− ghcOptList
88− = filter (not . isPrefixOf "-O")
89− $ fromMaybe []
90− $ lookup GHC (_cabalPackageInfo_compilerOptions packageInfo)
91− optList = _cabalPackageInfo_cppOptions packageInfo <> ghcOptList
83+ if not (null optList)
84+ then TL.fromText "{-# OPTIONS_GHC "
85+ <> mconcat (intersperse (TL.fromText " ") optList)
86+ <> TL.fromText " #-}\n"
87+ else mempty
88+ optList = map TL.fromString
89+ $ filter (not . isPrefixOf "-O")
90+ $ fromMaybe []
91+ $ lookup GHC (_cabalPackageInfo_compilerOptions packageInfo)
9292
9393lineNumberPragma :: FilePath -> TL.Builder
94−lineNumberPragma origPath = pragma $ TL.fromText "LINE 1 " <> quoted '"' (TL.fromString origPath)
95−
96−pragma :: TL.Builder -> TL.Builder
97−pragma x = TL.fromText "{-# " <> x <> TL.fromText " #-}\n"
98−
99−quoted :: Char -> TL.Builder -> TL.Builder
100−quoted char x = TL.singleton char <> x <> TL.singleton char
94+lineNumberPragma origPath =
95+ TL.fromText "{-# LINE 1 \"" <> TL.fromString origPath <> TL.fromText "\" #-}\n"
lib/command/src/Obelisk/Command/Project.hs+15−26
@@ -15,7 +15,6 @@ module Obelisk.Command.Project
1515 , toImplDir
1616 , toObeliskDir
1717 , withProjectRoot
18− , bashEscape
1918 ) where
2019
2120import Control.Concurrent.MVar (MVar, newMVar, withMVarMasked)
@@ -24,7 +23,6 @@ import Control.Monad
2423import Control.Monad.IO.Class (liftIO)
2524import Control.Monad.State
2625import qualified Data.Aeson as Json
27−import qualified Data.ByteString.UTF8 as BSU
2826import Data.Bits
2927import qualified Data.ByteString.Lazy as BSL
3028import Data.Default (def)
@@ -32,17 +30,15 @@ import Data.Function ((&), on)
3230import Data.Map (Map)
3331import Data.Text (Text)
3432import qualified Data.Text as T
35−import Data.Text.Encoding (decodeUtf8, encodeUtf8)
33+import Data.Text.Encoding (decodeUtf8)
3634import Data.Traversable (for)
3735import System.Directory
3836import System.Environment (lookupEnv)
3937import System.FilePath
4038import System.IO.Temp
4139import System.IO.Unsafe (unsafePerformIO)
42−import System.PosixCompat.Files
43−import System.PosixCompat.Types
44−import System.PosixCompat.User
45−import Text.ShellEscape (bash, bytes)
40+import System.Posix (FileStatus, FileMode, CMode (..), UserID, deviceID, fileID, fileMode, fileOwner, getFileStatus, getRealUserID)
41+import System.Posix.Files
4642
4743import GitHub.Data.GitData (Branch)
4844import GitHub.Data.Name (Name)
@@ -51,7 +47,7 @@ import Obelisk.App (MonadObelisk)
5147import Obelisk.CliApp
5248import Obelisk.Command.Nix
5349import Obelisk.Command.Thunk
54−import Obelisk.Command.Utils (nixBuildExePath, nixExePath, toNixPath, cp, nixShellPath)
50+import Obelisk.Command.Utils (nixBuildExePath, nixExePath, toNixPath)
5551
5652--TODO: Make this module resilient to random exceptions
5753
@@ -116,7 +112,7 @@ initProject source force = withSystemTempDirectory "ob-init" $ \tmpDir -> do
116112 skel <- nixBuildAttrWithCache implDir "skeleton" --TODO: I don't think there's actually any reason to cache this
117113
118114 callProcessAndLogOutput (Notice, Error) $
119− proc cp
115+ proc "cp"
120116 [ "-r"
121117 , "--preserve=links"
122118 , obDir
@@ -126,7 +122,7 @@ initProject source force = withSystemTempDirectory "ob-init" $ \tmpDir -> do
126122
127123 withSpinner "Copying project skeleton" $ do
128124 callProcessAndLogOutput (Notice, Error) $
129− proc cp
125+ proc "cp"
130126 [ "-r"
131127 , "--no-preserve=mode"
132128 , "-T"
@@ -137,12 +133,6 @@ initProject source force = withSystemTempDirectory "ob-init" $ \tmpDir -> do
137133 let configDir = "config"
138134 createDirectoryIfMissing False configDir
139135 mapM_ (createDirectoryIfMissing False . (configDir </>)) ["backend", "common", "frontend"]
140− putLog Notice $ T.intercalate "\n"
141− [ "An obelisk project has been successfully initialized. Next steps:"
142− , " 'ob run': Start a development server"
143− , " 'ob watch': Watch for changes without starting a server"
144− , " 'ob repl': Load your project into GHCi"
145− ]
146136
147137callHandoffOb
148138 :: MonadObelisk m
@@ -288,17 +278,14 @@ nixShellRunConfig root isPure command = do
288278 pure $ def
289279 & nixShellConfig_pure .~ isPure
290280 & nixShellConfig_common . nixCmdConfig_target .~ (def & target_path .~ Nothing)
291− & nixShellConfig_run .~ (command <&> \cs -> unwords $ concat
292− [ ["export", BSU.toString . bytes . bash $ "NIX_PATH=nixpkgs=" <> encodeUtf8 nixpkgsPath, ";"]
293− , maybe [] (\v -> ["export", BSU.toString . bytes . bash $ "NIX_REMOTE=" <> encodeUtf8 (T.pack v), ";"]) nixRemote
294− , [cs]
281+ & nixShellConfig_run .~ (command <&> \c -> mconcat
282+ [ "export NIX_PATH=nixpkgs=", T.unpack nixpkgsPath, "; "
283+ , maybe "" (\v -> "export NIX_REMOTE=" <> v <> "; ") nixRemote
284+ , c
295285 ])
296286
297−bashEscape :: String -> String
298−bashEscape = BSU.toString . bytes . bash . BSU.fromString
299−
300287nixShellRunProc :: NixShellConfig -> ProcessSpec
301−nixShellRunProc cfg = setDelegateCtlc True $ proc nixShellPath $ runNixShellConfig cfg
288+nixShellRunProc cfg = setDelegateCtlc True $ proc "nix-shell" $ runNixShellConfig cfg
302289
303290nixShellWithoutPkgs
304291 :: MonadObelisk m
@@ -313,7 +300,7 @@ nixShellWithoutPkgs root isPure chdirToRoot packageNamesAndPaths shellAttr comma
313300 packageNamesAndAbsPaths <- liftIO $ for packageNamesAndPaths makeAbsolute
314301 defShellConfig <- nixShellRunConfig root isPure command
315302 let setCwd_ = if chdirToRoot then setCwd (Just root) else id
316− runProcess_ $ setCwd_ $ nixShellRunProc $ defShellConfig
303+ (_, _, _, ph) <- createProcess_ "nixShellWithoutPkgs" $ setCwd_ $ nixShellRunProc $ defShellConfig
317304 & nixShellConfig_common . nixCmdConfig_target . target_expr ?~
318305 "{root, pkgs, shell}: ((import root {}).passthru.__unstable__.self.extend (_: _: {\
319306 \shellPackages = builtins.fromJSON pkgs;\
@@ -323,16 +310,18 @@ nixShellWithoutPkgs root isPure chdirToRoot packageNamesAndPaths shellAttr comma
323310 , strArg "pkgs" (T.unpack $ decodeUtf8 $ BSL.toStrict $ Json.encode packageNamesAndAbsPaths)
324311 , strArg "shell" shellAttr
325312 ]
313+ void $ waitForProcess ph
326314
327315nixShellWithHoogle :: MonadObelisk m => FilePath -> Bool -> String -> Maybe String -> m ()
328316nixShellWithHoogle root isPure shell' command = do
329317 defShellConfig <- nixShellRunConfig root isPure command
330− runProcess_ $ setCwd (Just root) $ nixShellRunProc $ defShellConfig
318+ (_, _, _, ph) <- createProcess_ "nixShellWithHoogle" $ setCwd (Just root) $ nixShellRunProc $ defShellConfig
331319 & nixShellConfig_common . nixCmdConfig_target . target_expr ?~
332320 "{shell}: ((import ./. {}).passthru.__unstable__.self.extend (_: super: {\
333321 \userSettings = super.userSettings // { withHoogle = true; };\
334322 \})).project.shells.${shell}"
335323 & nixShellConfig_common . nixCmdConfig_args .~ [ strArg "shell" shell' ]
324+ void $ waitForProcess ph
336325
337326findProjectAssets :: MonadObelisk m => FilePath -> m Text
338327findProjectAssets root = do
lib/command/src/Obelisk/Command/Run.hs+61−72
@@ -14,7 +14,7 @@ module Obelisk.Command.Run where
1414import Control.Arrow ((&&&))
1515import Control.Exception (Exception, bracket)
1616import Control.Lens (ifor, (.~), (&))
17−import Control.Monad (filterM)
17+import Control.Monad (filterM, unless, void)
1818import Control.Monad.Except (runExceptT, throwError)
1919import Control.Monad.IO.Class (liftIO)
2020import Control.Monad.Reader (MonadIO)
@@ -25,14 +25,12 @@ import Data.Default (def)
2525import Data.Either (partitionEithers)
2626import Data.Foldable (fold, for_, toList)
2727import Data.Functor.Identity (runIdentity)
28−import Data.List (intercalate)
2928import Data.List.NonEmpty (NonEmpty)
3029import qualified Data.List.NonEmpty as NE
3130import Data.Map (Map)
3231import qualified Data.Map as Map
3332import qualified Data.Map.Monoidal as MMap
34−import Data.Maybe (catMaybes, fromMaybe, mapMaybe)
35−import Data.Ord (comparing)
33+import Data.Maybe
3634import Data.Set (Set)
3735import qualified Data.Set as Set
3836import Data.String.Here.Interpolated (i)
@@ -46,17 +44,17 @@ import Distribution.Compiler (CompilerFlavor(..))
4644import Distribution.PackageDescription.Parsec (parseGenericPackageDescription)
4745import Distribution.Parsec.ParseResult (runParseResult)
4846import qualified Distribution.System as Dist
49−import Distribution.Types.BuildInfo (buildable, cppOptions, defaultExtensions, defaultLanguage, hsSourceDirs, options)
50−import Distribution.Types.CondTree (simplifyCondTree)
51−import Distribution.Types.GenericPackageDescription (ConfVar (Arch, Impl, OS), condLibrary)
52−import Distribution.Types.Library (libBuildInfo)
53−import Distribution.Utils.Generic (toUTF8BS, readUTF8File)
47+import Distribution.Types.BuildInfo
48+import Distribution.Types.CondTree
49+import Distribution.Types.GenericPackageDescription
50+import Distribution.Types.Library
51+import Distribution.Utils.Generic
5452import qualified Distribution.Parsec.Common as Dist
5553import qualified Hpack.Config as Hpack
5654import qualified Hpack.Render as Hpack
5755import qualified Hpack.Yaml as Hpack
58−import Language.Haskell.Extension (Extension, Language)
59−import qualified Network.Socket as Socket
56+import Language.Haskell.Extension
57+import Network.Socket hiding (Debug)
6058import System.Directory
6159import System.Environment (getExecutablePath)
6260import System.FilePath
@@ -66,18 +64,19 @@ import System.IO.Temp (withSystemTempDirectory)
6664import Obelisk.App (MonadObelisk)
6765import Obelisk.CliApp (
6866 Severity (..),
67+ createProcess_,
6968 failWith,
7069 proc,
7170 putLog,
7271 readCreateProcessWithExitCode,
7372 readProcessAndLogStderr,
74− runProcess_,
7573 setCwd,
7674 setDelegateCtlc,
75+ waitForProcess,
7776 withSpinner,
7877 )
7978import Obelisk.Command.Nix
80−import Obelisk.Command.Project (nixShellWithoutPkgs, withProjectRoot, findProjectAssets, bashEscape)
79+import Obelisk.Command.Project (nixShellWithoutPkgs, withProjectRoot, findProjectAssets)
8180import Obelisk.Command.Thunk (attrCacheFileName)
8281import Obelisk.Command.Utils (findExePath, ghcidExePath)
8382
@@ -94,11 +93,9 @@ data CabalPackageInfo = CabalPackageInfo
9493 -- ^ List of globally set languages of the library component
9594 , _cabalPackageInfo_compilerOptions :: [(CompilerFlavor, [String])]
9695 -- ^ List of compiler-specific options (e.g., the "ghc-options" field of the cabal file)
97− , _cabalPackageInfo_cppOptions :: [String]
98− -- ^ List of CPP (C Preprocessor) options (e.g. the "cpp-options" field of the cabal file)
9996 }
10097
101−-- | 'Bool' with a better name for its purpose.
98+-- | 'Bool' with a better name for it's purpose.
10299data Interpret = Interpret_Interpret | Interpret_NoInterpret deriving (Eq, Ord, Show)
103100
104101textInterpret :: Interpret -> Text
@@ -112,6 +109,9 @@ data PathTree a = PathTree_Node
112109 (Map FilePath (PathTree a)) -- Branches to deeper leaves
113110 deriving (Eq, Ord, Show, Functor, Foldable, Traversable)
114111
112+emptyPathTree :: PathTree a
113+emptyPathTree = PathTree_Node Nothing mempty
114+
115115-- | 2D ASCII drawing of a 'PathTree'. Adapted from Data.Tree.draw.
116116drawPathTree :: (a -> Text) -> PathTree a -> Text
117117drawPathTree showA (PathTree_Node _ ts0) = T.intercalate "\n" $ goForest (Map.toList ts0)
@@ -151,7 +151,7 @@ profile profileBasePattern rtsFlags = withProjectRoot "." $ \root -> do
151151 liftIO $ createDirectoryIfMissing True $ takeDirectory $ root </> profileBaseName
152152 putLog Debug $ "Storing profiled data under base name of " <> T.pack (root </> profileBaseName)
153153 freePort <- getFreePort
154− runProcess_ $ setCwd (Just root) $ setDelegateCtlc True $ proc (outPath </> "bin" </> "ob-run") $
154+ (_, _, _, ph) <- createProcess_ "runProfExe" $ setCwd (Just root) $ setDelegateCtlc True $ proc (outPath </> "bin" </> "ob-run") $
155155 [ show freePort
156156 , T.unpack assets
157157 , profileBaseName
@@ -159,16 +159,17 @@ profile profileBasePattern rtsFlags = withProjectRoot "." $ \root -> do
159159 , "-po" <> profileBaseName
160160 ] <> rtsFlags
161161 <> [ "-RTS" ]
162+ void $ waitForProcess ph
162163
163164run :: MonadObelisk m => FilePath -> PathTree Interpret -> m ()
164165run root interpretPaths = do
165166 pkgs <- getParsedLocalPkgs root interpretPaths
166− assets <- findProjectAssets root
167− putLog Debug $ "Assets impurely loaded from: " <> assets
168− ghciArgs <- getGhciSessionSettings pkgs root True
169− freePort <- getFreePort
170− withGhciScriptArgs pkgs $ \dotGhciArgs -> do
171− runGhcid root True (ghciArgs <> dotGhciArgs) pkgs $ Just $ unwords
167+ withGhciScript pkgs $ \dotGhciPath -> do
168+ assets <- findProjectAssets root
169+ putLog Debug $ "Assets impurely loaded from: " <> assets
170+ ghciArgs <- getGhciSessionSettings pkgs root True
171+ freePort <- getFreePort
172+ runGhcid root True (ghciArgs <> mkGhciScriptArg dotGhciPath) pkgs $ Just $ unwords
172173 [ "Obelisk.Run.run"
173174 , show freePort
174175 , "(Obelisk.Run.runServeAsset " ++ show assets ++ ")"
@@ -180,15 +181,15 @@ runRepl :: MonadObelisk m => FilePath -> PathTree Interpret -> m ()
180181runRepl root interpretPaths = do
181182 pkgs <- getParsedLocalPkgs root interpretPaths
182183 ghciArgs <- getGhciSessionSettings pkgs "." True
183− withGhciScriptArgs pkgs $ \dotGhciArgs ->
184− runGhciRepl root pkgs (ghciArgs <> dotGhciArgs)
184+ withGhciScript pkgs $ \dotGhciPath ->
185+ runGhciRepl root pkgs (ghciArgs <> mkGhciScriptArg dotGhciPath)
185186
186187runWatch :: MonadObelisk m => FilePath -> PathTree Interpret -> m ()
187188runWatch root interpretPaths = do
188189 pkgs <- getParsedLocalPkgs root interpretPaths
189190 ghciArgs <- getGhciSessionSettings pkgs root True
190− withGhciScriptArgs pkgs $ \dotGhciArgs ->
191− runGhcid root True (ghciArgs <> dotGhciArgs) pkgs Nothing
191+ withGhciScript pkgs $ \dotGhciPath ->
192+ runGhcid root True (ghciArgs <> mkGhciScriptArg dotGhciPath) pkgs Nothing
192193
193194exportGhciConfig :: MonadObelisk m => Bool -> FilePath -> PathTree Interpret -> m [String]
194195exportGhciConfig useRelativePaths root interpretPaths = do
@@ -304,16 +305,15 @@ parseCabalPackage
304305 -> m (Maybe CabalPackageInfo)
305306parseCabalPackage dir = parseCabalPackage' dir >>= \case
306307 Left err -> Nothing <$ putLog Error err
307− Right (Just (warnings, pkgInfo)) -> do
308+ Right (warnings, pkgInfo) -> do
308309 for_ warnings $ putLog Warning . T.pack . show
309310 pure $ Just pkgInfo
310− Right Nothing -> pure Nothing
311311
312312-- | Like 'parseCabalPackage' but returns errors and warnings directly so as to avoid 'MonadObelisk'.
313313parseCabalPackage'
314314 :: (MonadIO m)
315315 => FilePath -- ^ Package directory
316− -> m (Either T.Text (Maybe ([Dist.PWarning], CabalPackageInfo)))
316+ -> m (Either T.Text ([Dist.PWarning], CabalPackageInfo))
317317parseCabalPackage' pkg = runExceptT $ do
318318 (cabalContents, packageFile, packageName) <- guessCabalPackageFile pkg >>= \case
319319 Left GuessPackageFileError_NotFound -> throwError $ "No .cabal or package.yaml file found in " <> T.pack pkg
@@ -341,7 +341,7 @@ parseCabalPackage' pkg = runExceptT $ do
341341 case condLibrary <$> result of
342342 Right (Just condLib) -> do
343343 let (_, lib) = simplifyCondTree evalConfVar condLib
344− pure $ Just $ (warnings,) $ CabalPackageInfo
344+ pure $ (warnings,) $ CabalPackageInfo
345345 { _cabalPackageInfo_packageName = T.pack packageName
346346 , _cabalPackageInfo_packageFile = packageFile
347347 , _cabalPackageInfo_packageRoot = takeDirectory packageFile
@@ -353,19 +353,18 @@ parseCabalPackage' pkg = runExceptT $ do
353353 , _cabalPackageInfo_defaultLanguage =
354354 defaultLanguage $ libBuildInfo lib
355355 , _cabalPackageInfo_compilerOptions = options $ libBuildInfo lib
356− , _cabalPackageInfo_cppOptions = cppOptions $ libBuildInfo lib
357356 }
358− Right Nothing -> pure Nothing
357+ Right Nothing -> throwError "Haskell package has no library component"
359358 Left (_, errors) ->
360359 throwError $ T.pack $ "Failed to parse " <> packageFile <> ":\n" <> unlines (map show errors)
361360
362361parsePackagesOrFail :: (MonadObelisk m, Foldable f) => f FilePath -> m (NE.NonEmpty CabalPackageInfo)
363362parsePackagesOrFail dirs' = do
364− packageInfos' <- fmap catMaybes $ for dirs $ \dir -> do
363+ (pkgDirErrs, packageInfos') <- fmap partitionEithers $ for dirs $ \dir -> do
365364 flip fmap (parseCabalPackage dir) $ \case
366365 Just packageInfo
367− | _cabalPackageInfo_buildable packageInfo -> Just packageInfo
368− _ -> Nothing
366+ | _cabalPackageInfo_buildable packageInfo -> Right packageInfo
367+ _ -> Left dir
369368
370369 -- Sort duplicate packages such that we prefer shorter paths, but fall back to alphabetical ordering.
371370 let packagesByName = Map.map (NE.sortBy $ comparing $ \p -> let n = _cabalPackageInfo_packageFile p in (length n, n))
@@ -387,6 +386,9 @@ parsePackagesOrFail dirs' = do
387386 "No valid, buildable packages found" <> (if null dirs then "" else " in " <> intercalate ", " dirs)
388387 Just xs -> pure xs
389388
389+ unless (null pkgDirErrs) $
390+ putLog Warning $ T.pack $ "Failed to find buildable packages in " <> intercalate ", " pkgDirErrs
391+
390392 pure packageInfos
391393 where
392394 dirs = toList dirs'
@@ -394,29 +396,13 @@ parsePackagesOrFail dirs' = do
394396packageInfoToNamePathMap :: Foldable f => f CabalPackageInfo -> Map Text FilePath
395397packageInfoToNamePathMap = Map.fromList . map (_cabalPackageInfo_packageName &&& _cabalPackageInfo_packageRoot) . toList
396398
397−-- Like 'withGhciScript' but provides the precise ghci arguments to add to a ghci session
398−withGhciScriptArgs
399− :: (MonadObelisk m, Foldable f)
400− => f CabalPackageInfo -- ^ List of packages to load into ghci
401− -> ([String] -> m ()) -- ^ Action to run with the extra ghci arguments
402− -> m ()
403−withGhciScriptArgs packageInfos f = withGhciScript loadPreludeManually packageInfos $ \fp -> f ["-XNoImplicitPrelude", "-ghci-script", fp]
404− where
405− -- These lines must be first and allow the session to support a custom Prelude when @-XNoImplicitPrelude@
406− -- is passed to the ghci session.
407− loadPreludeManually =
408− [ ":add Prelude" -- @:add@ is used because it's less noisy when there is no custom Prelude
409− , ":set -XImplicitPrelude" -- Turn the default setting on
410− ]
411−
412399-- | Create ghci configuration to load the given packages
413400withGhciScript
414401 :: (MonadObelisk m, Foldable f)
415− => [String] -- ^ Commands to prefix to file
416− -> f CabalPackageInfo -- ^ List of packages to load into ghci
402+ => f CabalPackageInfo -- ^ List of packages to load into ghci
417403 -> (FilePath -> m ()) -- ^ Action to run with the path to generated temporary .ghci
418404 -> m ()
419−withGhciScript preCommands (toList -> packageInfos) f =
405+withGhciScript (toList -> packageInfos) f =
420406 withSystemTempDirectory "ob-ghci" $ \fp -> do
421407 let dotGhciPath = fp </> ".ghci"
422408 liftIO $ writeFile dotGhciPath dotGhci
@@ -428,8 +414,7 @@ withGhciScript preCommands (toList -> packageInfos) f =
428414 , [ "Backend" | "backend" `Set.member` packageNames ]
429415 , [ "Frontend" | "frontend" `Set.member` packageNames ]
430416 ]
431− dotGhci = unlines $
432− preCommands <>
417+ dotGhci = unlines
433418 [ if null modulesToLoad then "" else ":load " <> unwords modulesToLoad
434419 , "import qualified Obelisk.Run"
435420 , "import qualified Frontend"
@@ -482,7 +467,7 @@ runGhciRepl root (toList -> packages) ghciArgs =
482467 -- NOTE: We do *not* want to use $(staticWhich "ghci") here because we need the
483468 -- ghc that is provided by the shell in the user's project.
484469 nixShellWithoutPkgs root True False (packageInfoToNamePathMap packages) "ghc" $
485− Just $ unwords $ fmap bashEscape $ "ghci" : ghciArgs
470+ Just $ unwords $ "ghci" : ghciArgs -- TODO: Shell escape
486471
487472-- | Run ghcid
488473runGhcid
@@ -495,28 +480,32 @@ runGhcid
495480 -> m ()
496481runGhcid root chdirToRoot ghciArgs (toList -> packages) mcmd =
497482 nixShellWithoutPkgs root True chdirToRoot (packageInfoToNamePathMap packages) "ghc" $
498− Just $ unwords $ fmap bashEscape $ ghcidExePath : opts
483+ Just $ unwords $ ghcidExePath : opts -- TODO: Shell escape
499484 where
500− opts = concat
501− [ ["-W"]
502− , ["--outputfile=ghcid-output.txt"]
503− , map (\x -> "--reload=" <> x) reloadFiles
504− , map (\x -> "--restart=" <> x) restartFiles
505− , maybe [] (\cmd -> ["--test=" <> cmd]) mcmd
506− , ["--command=" <> unwords ("ghci" : ghciArgs)]
507− ]
485+ opts =
486+ [ "-W"
487+ , "--outputfile=ghcid-output.txt"
488+ ] <> map (\x -> "--reload='" <> x <> "'") reloadFiles
489+ <> map (\x -> "--restart='" <> x <> "'") restartFiles
490+ <> testCmd
491+ <> ["--command='" <> unwords ("ghci" : ghciArgs) <> "'"] -- TODO: Shell escape
492+ testCmd = maybeToList (flip fmap mcmd $ \cmd -> "--test='" <> cmd <> "'") -- TODO: Shell escape
493+
508494 adjustRoot x = if chdirToRoot then makeRelative root x else x
509495 reloadFiles = map adjustRoot [root </> "config"]
510496 restartFiles = map (adjustRoot . _cabalPackageInfo_packageFile) packages
511497
512−getFreePort :: MonadIO m => m Socket.PortNumber
513−getFreePort = liftIO $ Socket.withSocketsDo $ do
514− addr:_ <- Socket.getAddrInfo (Just Socket.defaultHints) (Just "127.0.0.1") (Just "0")
515− bracket (open addr) Socket.close Socket.socketPort
498+mkGhciScriptArg :: FilePath -> [String]
499+mkGhciScriptArg dotGhci = ["-ghci-script", dotGhci]
500+
501+getFreePort :: MonadIO m => m PortNumber
502+getFreePort = liftIO $ withSocketsDo $ do
503+ addr:_ <- getAddrInfo (Just defaultHints) (Just "127.0.0.1") (Just "0")
504+ bracket (open addr) close socketPort
516505 where
517506 open addr = do
518− sock <- Socket.socket (Socket.addrFamily addr) (Socket.addrSocketType addr) (Socket.addrProtocol addr)
519− Socket.bind sock (Socket.addrAddress addr)
507+ sock <- socket (addrFamily addr) (addrSocketType addr) (addrProtocol addr)
508+ bind sock (addrAddress addr)
520509 return sock
521510
522511
lib/command/src/Obelisk/Command/Thunk.hs+3−3
@@ -56,7 +56,7 @@ import System.Exit
5656import System.FilePath
5757import System.IO.Error
5858import System.IO.Temp
59−import System.PosixCompat.Files (getSymbolicLinkStatus, modificationTime)
59+import System.Posix (getSymbolicLinkStatus, modificationTime)
6060import qualified Text.URI as URI
6161
6262import Obelisk.App (MonadObelisk)
@@ -178,14 +178,14 @@ getNixSha256ForUriUnpacked
178178getNixSha256ForUriUnpacked uri =
179179 withExitFailMessage ("nix-prefetch-url: Failed to determine sha256 hash of URL " <> gitUriToText uri) $ do
180180 [hash] <- fmap T.lines $ readProcessAndLogOutput (Debug, Debug) $
181− proc nixPrefetchUrlPath ["--unpack", "--type", "sha256", T.unpack $ gitUriToText uri]
181+ proc "nix-prefetch-url" ["--unpack", "--type", "sha256", T.unpack $ gitUriToText uri]
182182 pure hash
183183
184184nixPrefetchGit :: MonadObelisk m => GitUri -> Text -> Bool -> m NixSha256
185185nixPrefetchGit uri rev fetchSubmodules =
186186 withExitFailMessage ("nix-prefetch-git: Failed to determine sha256 hash of Git repo " <> gitUriToText uri <> " at " <> rev) $ do
187187 out <- readProcessAndLogStderr Debug $
188− proc nixPrefetchGitPath $ filter (/="")
188+ proc "nix-prefetch-git" $ filter (/="")
189189 [ "--url", T.unpack $ gitUriToText uri
190190 , "--rev", T.unpack rev
191191 , if fetchSubmodules then "--fetch-submodules" else ""
lib/command/src/Obelisk/Command/Utils.hs+2−34
@@ -54,38 +54,6 @@ nixBuildExePath = $(staticWhich "nix-build")
5454jreKeyToolPath :: FilePath
5555jreKeyToolPath = $(staticWhich "keytool")
5656
57−nixPrefetchGitPath :: FilePath
58−nixPrefetchGitPath = $(staticWhich "nix-prefetch-git")
59−
60−nixPrefetchUrlPath :: FilePath
61−nixPrefetchUrlPath = $(staticWhich "nix-prefetch-url")
62−
63−nixShellPath :: FilePath
64−nixShellPath = $(staticWhich "nix-shell")
65−
66−rsyncPath :: FilePath
67−rsyncPath = $(staticWhich "rsync")
68−
69−sshPath :: FilePath
70−sshPath = $(staticWhich "ssh")
71−
72−gitPath :: FilePath
73−gitPath = $(staticWhich "git")
74−
75−whichPath :: FilePath
76−whichPath = $(staticWhich "which")
77−
78−sshKeygenPath :: FilePath
79−sshKeygenPath = $(staticWhich "ssh-keygen")
80−
81−-- $(staticWhich "docker") was intentionally omitted, at least for now
82−-- One concern is that I don't know how particular docker is about having the
83−-- CLI exe match the version of the docker daemon, which is largely outside of
84−-- the control of obelisk-command.
85−-- TODO: Investigate the tradeoffs associated with this choice
86−dockerPath :: FilePath
87−dockerPath = "docker"
88−
8957-- | Nix syntax requires relative paths to be prefixed by @./@ or
9058-- @../@. This will make a 'FilePath' that can be embedded in a Nix
9159-- expression.
@@ -123,7 +91,7 @@ initGit repo = do
12391 git ["commit", "-m", "Initial commit."]
12492
12593gitProcNoRepo :: [String] -> ProcessSpec
126−gitProcNoRepo args = setEnvOverride (M.singleton "GIT_TERMINAL_PROMPT" "0" <>) $ proc gitPath args
94+gitProcNoRepo args = setEnvOverride (M.singleton "GIT_TERMINAL_PROMPT" "0" <>) $ proc "git" args
12795
12896gitProc :: FilePath -> [String] -> ProcessSpec
12997gitProc repo = gitProcNoRepo . runGitInDir
@@ -140,7 +108,7 @@ isolateGitProc = setEnvOverride (overrides <>)
140108 , ("GIT_CONFIG_NOSYSTEM", "1")
141109 , ("GIT_TERMINAL_PROMPT", "0") -- git 2.3+
142110 , ("GIT_ASKPASS", "echo") -- pre git 2.3 to just use empty password
143− , ("GIT_SSH_COMMAND", "ssh -o PreferredAuthentications=password -o PubkeyAuthentication=no -o GSSAPIAuthentication=no")
111+ , ("GIT_SSH_COMMAND", "ssh -o PreferredAuthentications password -o PubkeyAuthentication no -o GSSAPIAuthentication no")
144112 ]
145113
146114-- | Recursively copy a directory using `cp -a` -- TODO: Should use -rT instead of -a
lib/command/src/Obelisk/Command/VmBuilder.hs+8−8
@@ -21,7 +21,7 @@ import qualified System.Info
2121
2222import Obelisk.App (MonadObelisk, getObeliskUserStateDir)
2323import Obelisk.CliApp
24−import Obelisk.Command.Utils (rmPath, whichPath, sshKeygenPath, nixBuildExePath, dockerPath)
24+import Obelisk.Command.Utils (rmPath)
2525
2626-- | Generate the `--builders` argument string to enable the VM builder after ensuring it is available.
2727getNixBuildersArg :: MonadObelisk m => m String
@@ -35,7 +35,7 @@ getNixBuildersArg = do
3535
3636checkForNixDarwin :: MonadObelisk m => String -> m ()
3737checkForNixDarwin sshIdFile = do
38− (exitCode, _, _) <- readCreateProcessWithExitCode $ proc whichPath ["darwin-rebuild"]
38+ (exitCode, _, _) <- readCreateProcessWithExitCode $ proc "which" ["darwin-rebuild"]
3939 unless (exitCode == ExitSuccess) $ failWith $ T.intercalate "\n"
4040 [ "Deployments from macOS require nix-darwin to be installed."
4141 , "Follow the installation instructions here: https://github.com/LnL7/nix-darwin"
@@ -67,7 +67,7 @@ containerExists :: MonadObelisk m => FilePath -> m Bool
6767containerExists stateDir = handle (\(_ :: IOError) -> failWith needDockerMsg) $ do
6868 containerNames <- fmap (map T.strip . T.lines) $
6969 readProcessAndLogStderr Error $
70− proc dockerPath ["container", "list", "--all", "--format", "{{.Names}}"]
70+ proc "docker" ["container", "list", "--all", "--format", "{{.Names}}"]
7171 let exists = containerName `elem` containerNames
7272 when exists $ testLinuxBuild stateDir
7373 pure exists
@@ -85,7 +85,7 @@ containerSshPort = 2222
8585startContainer :: MonadObelisk m => m ()
8686startContainer = withSpinner "Starting VM builder" $
8787 callProcessAndLogOutput (Debug, Debug) $
88− proc dockerPath ["start", containerName]
88+ proc "docker" ["start", containerName]
8989
9090-- | Creates the Docker container; assumes it does not exist.
9191setupNixDocker :: MonadObelisk m => FilePath -> m ()
@@ -98,12 +98,12 @@ setupNixDocker stateDir = withSpinner ("Creating Docker container named " <> con
9898 callProcessAndLogOutput (Debug, Error) $
9999 proc rmPath ["-f", stateDir </> sshKeyFileName, stateDir </> sshKeyFileName <.> "pub"]
100100 callProcessAndLogOutput (Debug, Error) $
101− proc sshKeygenPath ["-t", "ed25519", "-f", stateDir </> sshKeyFileName, "-P", ""]
101+ proc "ssh-keygen" ["-t", "ed25519", "-f", stateDir </> sshKeyFileName, "-P", ""]
102102
103103 -- Build the docker container (which uses the SSH keys in the 'ssh' folder)
104104 containerId <- fmap T.strip $ readProcessAndLogStderr Error $
105− proc dockerPath ["build", stateDir, "--quiet"]
106− callProcessAndLogOutput (Debug, Error) $ proc dockerPath
105+ proc "docker" ["build", stateDir, "--quiet"]
106+ callProcessAndLogOutput (Debug, Error) $ proc "docker"
107107 [ "run"
108108 , "--restart", "always"
109109 , "--detach"
@@ -155,7 +155,7 @@ testLinuxBuild :: MonadObelisk m => FilePath -> m ()
155155testLinuxBuild stateDir
156156 | System.Info.os == "linux" = failWith "Using the docker builder is not necessary on linux."
157157 | otherwise = do
158− (exitCode, _stdout, stderr) <- readCreateProcessWithExitCode $ proc nixBuildExePath
158+ (exitCode, _stdout, stderr) <- readCreateProcessWithExitCode $ proc "nix-build"
159159 [ "--no-out-link"
160160 , "-E", "(import <nixpkgs> { system = \"x86_64-linux\"; }).writeText \"test\" builtins.currentTime"
161161 , "--builders", nixBuildersArgString stateDir
lib/executable-config/default.nix+2−13
@@ -25,19 +25,8 @@ let
2525in
2626
2727{
28− haskellOverlay = self: super:
29− let
30− pkgs = self.callPackage ({pkgs}: pkgs) {};
31− in {
32− obelisk-executable-config-lookup = pkgs.haskell.lib.overrideCabal
33− (self.callCabal2nix "obelisk-executable-config-lookup" (obeliskCleanSource ./lookup) {})
34− (drv: {
35− # Hack until https://github.com/NixOS/cabal2nix/pull/432 lands
36− libraryHaskellDepends = (drv.libraryHaskellDepends or [])
37− ++ pkgs.stdenv.lib.optionals (with pkgs.stdenv.hostPlatform; isAndroid && is32bit) [
38− self.android-activity
39− ];
40− });
28+ haskellOverlay = self: super: {
29+ obelisk-executable-config-lookup = self.callCabal2nix "obelisk-executable-config-lookup" (obeliskCleanSource ./lookup) {};
4130 };
4231
4332 platforms = {
lib/executable-config/inject/obelisk-executable-config-inject.cabal+1−1
@@ -15,4 +15,4 @@ library
1515 text
1616
1717 exposed-modules: Obelisk.ExecutableConfig.Inject
18− ghc-options: -Wall -Werror -Wredundant-constraints -Wincomplete-uni-patterns -Wincomplete-record-updates -O
18+ ghc-options: -Wall
lib/executable-config/lookup/obelisk-executable-config-lookup.cabal+7−10
@@ -31,18 +31,15 @@ library
3131 base64-bytestring,
3232 bytestring,
3333 containers,
34− exceptions,
3534 filepath,
36− jsaddle,
37− mmorph,
38− monad-control,
39− mtl,
40− primitive,
41− ref-tf,
42− reflex-dom-core,
43− reflex,
4435 text,
36+ transformers,
4537 transformers-base,
46− transformers
38+ ref-tf,
39+ primitive,
40+ monad-control,
41+ reflex,
42+ reflex-dom,
43+ jsaddle
4744
4845 ghc-options: -Wall
lib/executable-config/lookup/src/Obelisk/Configs.hs+12−31
@@ -18,38 +18,24 @@ module Obelisk.Configs
1818 , getTextConfig
1919 ) where
2020
21−import Control.Applicative (Alternative)
22−import Control.Monad (MonadPlus)
23−import Control.Monad.Base (MonadBase)
24−import Control.Monad.Catch (MonadThrow)
25−import Control.Monad.Fail (MonadFail)
26−import Control.Monad.Fix (MonadFix)
27−import Control.Monad.IO.Class (MonadIO)
28−import Control.Monad.Morph (MFunctor)
29−import Control.Monad.Primitive (PrimMonad, PrimState, primitive)
30−import Control.Monad.Ref (MonadRef)
31−import Control.Monad.Trans (MonadTrans, lift)
32−import Control.Monad.Trans.Control (MonadBaseControl)
33−import Control.Monad.Trans.Reader (ReaderT (..), ask, mapReaderT)
34−import Control.Monad.Trans.State (StateT)
35−import qualified Control.Monad.Trans.State.Strict as Strict
21+import Control.Applicative
22+import Control.Monad
23+import Control.Monad.Base
24+import Control.Monad.Fix
25+import Control.Monad.Primitive
26+import Control.Monad.Ref
27+import Control.Monad.IO.Class
28+import Control.Monad.Trans.Class
29+import Control.Monad.Trans.Control
30+import Control.Monad.Trans.Reader
3631import Data.ByteString (ByteString)
3732import Data.Map (Map)
3833import qualified Data.Map as Map
3934import Data.Text (Text)
4035import qualified Data.Text.Encoding as T
4136import Reflex
42−import Reflex.Host.Class (MonadReflexCreateTrigger)
43−import Reflex.Dom.Core
44− ( DomBuilder
45− , DomRenderHook
46− , HasDocument
47− , HasJS
48− , HasJSContext
49− , Prerender (Client)
50− , StaticDomBuilderT
51− , prerender
52− )
37+import Reflex.Host.Class
38+import Reflex.Dom
5339#ifndef ghcjs_HOST_OS
5440import Language.Javascript.JSaddle (MonadJSM)
5541#endif
@@ -76,8 +62,6 @@ instance HasConfigs m => HasConfigs (PostBuildT t m)
7662instance HasConfigs m => HasConfigs (QueryT t q m)
7763instance HasConfigs m => HasConfigs (ReaderT r m)
7864instance HasConfigs m => HasConfigs (RequesterT t request response m)
79−instance HasConfigs m => HasConfigs (StateT w m)
80−instance HasConfigs m => HasConfigs (Strict.StateT w m)
8165instance HasConfigs m => HasConfigs (StaticDomBuilderT t m)
8266instance HasConfigs m => HasConfigs (TriggerEventT t m)
8367
@@ -88,15 +72,12 @@ newtype ConfigsT m a = ConfigsT { unConfigsT :: ReaderT (Map Text ByteString) m
8872 , Monad
8973 , MonadPlus
9074 , Alternative
91− , MonadFail
9275 , MonadFix
93− , MonadThrow
9476 , MonadIO
9577 , MonadBase m'
9678 , MonadBaseControl m'
9779 , MonadRef
9880 , MonadTrans
99− , MFunctor
10081 , DomBuilder t
10182 , MonadHold t
10283 , MonadReflexCreateTrigger t
lib/frontend/obelisk-frontend.cabal+1−1
@@ -26,4 +26,4 @@ library
2626 exposed-modules:
2727 Obelisk.Frontend
2828 Obelisk.Frontend.Cookie
29− ghc-options: -Wall -Werror -Wredundant-constraints -Wincomplete-uni-patterns -Wincomplete-record-updates -O
29+ ghc-options: -Wall
lib/frontend/src/Obelisk/Frontend.hs+1−1
@@ -182,7 +182,7 @@ runFrontendWithConfigsAndCurrentRoute
182182 -> Frontend (R frontendRoute)
183183 -> JSM ()
184184runFrontendWithConfigsAndCurrentRoute mode configs validFullEncoder frontend = do
185− let ve = validFullEncoder . hoistParse errorLeft (reviewEncoder (rPrism $ _FullRoute_Frontend . _ObeliskRoute_App))
185+ let ve = validFullEncoder . hoistParse errorLeft (prismEncoder (rPrism $ _FullRoute_Frontend . _ObeliskRoute_App))
186186 errorLeft = \case
187187 Left _ -> error "runFrontend: Unexpected non-app ObeliskRoute reached the frontend. This shouldn't happen."
188188 Right x -> Identity x
lib/route/README.mddeleted−6
@@ -1,6 +0,0 @@
1−# obelisk-route
2−
3−[![Haskell Programming Language](https://img.shields.io/badge/language-Haskell-blue.svg)](http://www.haskell.org)
4−[![BSD3 License](http://img.shields.io/badge/license-BSD3-brightgreen.svg)](https://github.com/obsidiansystems/obelisk/blob/master/LICENSE)
5−
6−Robust URL management for single-page apps.
lib/route/obelisk-route.cabal+1−2
@@ -20,7 +20,6 @@ library
2020 http-types,
2121 jsaddle,
2222 lens,
23− mmorph,
2423 monad-control,
2524 mtl,
2625 network-uri,
@@ -39,4 +38,4 @@ library
3938 exposed-modules: Obelisk.Route
4039 Obelisk.Route.TH
4140 Obelisk.Route.Frontend
42− ghc-options: -Wall -Werror -Wredundant-constraints -Wincomplete-uni-patterns -Wincomplete-record-updates -O
41+ ghc-options: -Wall -fwarn-redundant-constraints
lib/route/src/Obelisk/Route.hs+48−92
@@ -1,4 +1,3 @@
1−{-# LANGUAGE CPP #-}
21{-# LANGUAGE ApplicativeDo #-}
32{-# LANGUAGE ConstraintKinds #-}
43{-# LANGUAGE EmptyCase #-}
@@ -6,6 +5,7 @@
65{-# LANGUAGE FlexibleContexts #-}
76{-# LANGUAGE FlexibleInstances #-}
87{-# LANGUAGE GADTs #-}
8+{-# LANGUAGE KindSignatures #-}
99{-# LANGUAGE LambdaCase #-}
1010{-# LANGUAGE MultiParamTypeClasses #-}
1111{-# LANGUAGE OverloadedStrings #-}
@@ -61,7 +61,6 @@ module Obelisk.Route
6161 , justEncoder
6262 , nothingEncoder
6363 , isoEncoder
64− , viewEncoder
6564 , wrappedEncoder
6665 , unwrappedEncoder
6766 , listToNonEmptyEncoder
@@ -70,7 +69,6 @@ module Obelisk.Route
7069 , toListMapEncoder
7170 , shadowEncoder
7271 , prismEncoder
73− , reviewEncoder
7472 , rPrism
7573 , _R
7674 , obeliskRouteEncoder
@@ -135,24 +133,20 @@ import Control.Lens
135133 , Prism'
136134 , prism'
137135 , re
138− , review
139136 , view
140137 , Wrapped (..)
141138 )
142139import Control.Monad.Except
140+import Control.Monad.Writer (execWriter, tell)
143141import qualified Control.Monad.State.Strict as State
144142import Control.Monad.Trans (lift)
145−import Control.Monad.Writer (execWriter, tell)
146−import Data.Aeson (FromJSON, ToJSON)
147−import qualified Data.Aeson as Aeson
148143import qualified Data.ByteString as BS
149144import qualified Data.ByteString.Lazy as BSL
145+import Data.Dependent.Sum (DSum (..))
150146import Data.Dependent.Map (DMap)
151147import qualified Data.Dependent.Map as DMap
152−import Data.Dependent.Sum (DSum (..))
153148import Data.Either.Validation (Validation (..))
154149import Data.Foldable
155−import Data.Functor (($>))
156150import Data.Functor.Sum
157151import Data.GADT.Compare
158152import Data.GADT.Compare.TH
@@ -165,18 +159,19 @@ import Data.Monoid ((<>))
165159import Data.Set (Set)
166160import qualified Data.Set as Set
167161import Data.Some (Some(Some))
168−import Data.Tabulation
169162import Data.Text (Text)
163+import Data.Text.Lens (IsText, packed, unpacked)
170164import qualified Data.Text as T
171165import qualified Data.Text.Encoding as T
172−import Data.Text.Lens (IsText, packed, unpacked)
173−import Data.Type.Equality
174166import Data.Universe
175167import Data.Universe.Some
176168import Network.HTTP.Types.URI
177169import qualified Numeric.Lens
178170import Obelisk.Route.TH
179171import Text.Read (readMaybe)
172+import Data.Tabulation
173+import qualified Data.Aeson as Aeson
174+import Data.Aeson (FromJSON, ToJSON)
180175
181176-- Design goals:
182177-- No start-up time on the frontend (not yet met)
@@ -226,19 +221,7 @@ hoistR f (x :=> Identity y) = f x :/ y
226221infixr 5 :.
227222type (:.) = (,)
228223
229−#ifdef __GLASGOW_HASKELL__
230−#if __GLASGOW_HASKELL__ >= 810
231224{-# COMPLETE (:.) #-}
232−#else
233−{-# WARNING (:.)
234− [ "Use of this pattern in GHC < 8.10 will result in spurious non-exhaustive warnings at every use site."
235− , "We cannot provide a COMPLETE pragma to silence these due to a GHC bug: https://gitlab.haskell.org/ghc/ghc/issues/17729."
236− , "The bug hides incompleteness warnings for all two tuples when the COMPLETE pattern is in scope."
237− , "Instead, you should use (,) directly until you can switch to GHC >= 8.10, where the COMPLETE pragma is reinstated."
238− ]
239− #-}
240−#endif
241−#endif
242225pattern (:.) :: a -> b -> a :. b
243226pattern a :. b = (a, b)
244227
@@ -304,13 +287,13 @@ decode e x = runIdentity (tryDecode e x)
304287-- | Once an 'Encoder' has been checked, so that its check monad has become 'Identity', even if the same is not true of the
305288-- parse monad, we may still attempt to decode with it in its parse monad.
306289tryDecode :: Encoder Identity parse decoded encoded -> encoded -> parse decoded
307−tryDecode (Encoder (Identity impl)) = _encoderImpl_decode impl
290+tryDecode (Encoder (Identity impl)) x = _encoderImpl_decode impl x
308291
309292-- | Similar to 'decode', once an encoder has been checked so that its check monad is Identity, it
310293-- can be used to actually encode by using this. Note that while there's no constraint on the parse monad here,
311294-- one should usually be applying decode and encode to the same 'Encoder'
312295encode :: Encoder Identity parse decoded encoded -> decoded -> encoded
313−encode (Encoder (Identity impl)) = _encoderImpl_encode impl
296+encode (Encoder (Identity impl)) x = _encoderImpl_encode impl x
314297
315298-- | This is a primitive used to build encoders which can't fail to check. It should not be used unless one is
316299-- reasonably certain that the law given for 'EncoderImpl' above holds.
@@ -357,7 +340,7 @@ instance Monad parse => Bifunctor (,) (EncoderImpl parse) (EncoderImpl parse) (E
357340 }
358341
359342instance (Monad parse, Applicative check) => Braided (Encoder check parse) (,) where
360− braid = viewEncoder (iso swap swap)
343+ braid = isoEncoder (iso swap swap)
361344
362345
363346instance (Applicative check, Monad parse) => PFunctor (,) (Encoder check parse) (Encoder check parse) where
@@ -393,11 +376,11 @@ instance (Monad parse, Applicative check) => Bifunctor Either (Encoder check par
393376 bimap f g = Encoder $ liftA2 bimap (unEncoder f) (unEncoder g)
394377
395378instance (Applicative check, Monad parse) => Associative (Encoder check parse) Either where
396− associate = viewEncoder (iso (associate @(->) @Either) disassociate)
397− disassociate = viewEncoder (iso disassociate associate)
379+ associate = isoEncoder (iso (associate @(->) @Either) disassociate)
380+ disassociate = isoEncoder (iso disassociate associate)
398381
399382instance (Monad parse, Applicative check) => Braided (Encoder check parse) Either where
400− braid = viewEncoder (iso swap swap)
383+ braid = isoEncoder (iso swap swap)
401384
402385
403386
@@ -451,17 +434,17 @@ instance (Applicative check, Monad parse) => Monoidal (Encoder check parse) (,)
451434--------------------------------------------------------------------------------
452435
453436-- | Given a valid 'Iso' from lens, construct an 'Encoder'
454−viewEncoder :: (Applicative check, Applicative parse) => Iso' a b -> Encoder check parse a b
455−viewEncoder f = unsafeMkEncoder $ EncoderImpl
437+isoEncoder :: (Applicative check, Applicative parse) => Iso' a b -> Encoder check parse a b
438+isoEncoder f = unsafeMkEncoder $ EncoderImpl
456439 { _encoderImpl_encode = view f
457440 , _encoderImpl_decode = pure . view (from f)
458441 }
459442
460443wrappedEncoder :: (Wrapped a, Applicative check, Applicative parse) => Encoder check parse (Unwrapped a) a
461−wrappedEncoder = viewEncoder $ from _Wrapped'
444+wrappedEncoder = isoEncoder $ from _Wrapped'
462445
463446unwrappedEncoder :: (Wrapped a, Applicative check, Applicative parse) => Encoder check parse a (Unwrapped a)
464−unwrappedEncoder = viewEncoder $ _Wrapped'
447+unwrappedEncoder = isoEncoder _Wrapped'
465448
466449maybeToEitherEncoder :: (Applicative check, Applicative parse) => Encoder check parse (Maybe a) (Either () a)
467450maybeToEitherEncoder = unsafeMkEncoder $ EncoderImpl
@@ -486,11 +469,11 @@ maybeEncoder f g = shadowEncoder f g . maybeToEitherEncoder
486469
487470-- | Encode a value by simply applying 'Just'
488471justEncoder :: (Applicative check, MonadError Text parse) => Encoder check parse a (Maybe a)
489−justEncoder = reviewEncoder _Just
472+justEncoder = prismEncoder _Just
490473
491474-- | Encode () to 'Nothing'.
492475nothingEncoder :: (Applicative check, MonadError Text parse) => Encoder check parse () (Maybe a)
493−nothingEncoder = reviewEncoder _Nothing
476+nothingEncoder = prismEncoder _Nothing
494477
495478someConstEncoder :: (Applicative check, Applicative parse) => Encoder check parse (Some (Const a)) a
496479someConstEncoder = unsafeMkEncoder $ EncoderImpl
@@ -555,11 +538,11 @@ pathComponentEncoder f = Encoder $ do
555538 unEncoder (pathComponentEncoderImpl (enum1Encoder (extractPathSegment . f)) f')
556539
557540pathComponentEncoderImpl :: forall check parse p. (Monad check, Monad parse)
558− => Encoder check parse (Some p) (Maybe Text)
541+ => (Encoder check parse (Some p) (Maybe Text))
559542 -> (forall a. p a -> Encoder Identity parse a PageName)
560543 -> Encoder check parse (R p) PageName
561−pathComponentEncoderImpl =
562− chainEncoder (lensEncoder (\(_, b) a -> (a, b)) Prelude.fst consEncoder)
544+pathComponentEncoderImpl this rest =
545+ chainEncoder (lensEncoder (\(_, b) a -> (a, b)) Prelude.fst consEncoder) this rest
563546
564547--NOTE: Naming convention in this module is to always talk about things in the *encoding* direction, never in the *decoding* direction
565548
@@ -815,7 +798,7 @@ rPrism
815798 :: forall f f'
816799 . (forall a. Prism' (f a) (f' a))
817800 -> Prism' (R f) (R f')
818−rPrism = dSumPrism
801+rPrism p = dSumPrism p
819802
820803dSumPrism'
821804 :: forall f g a
@@ -827,7 +810,7 @@ dSumGEqPrism
827810 :: GEq f
828811 => f a
829812 -> Prism' (DSum f g) (g a)
830−dSumGEqPrism variant = dSumPrism' $ prism' (\Refl -> variant) (geq variant)
813+dSumGEqPrism variant = dSumPrism' $ prism' (\Refl -> variant) (\x -> geq variant x)
831814
832815-- | Given a 'tag :: f a', make a prism for 'R f'. This generalizes the usual
833816-- prisms for a sum type (the ones that 'mkPrisms' would make), just as 'R'
@@ -844,19 +827,12 @@ _R variant = dSumGEqPrism variant . iso runIdentity Identity
844827
845828-- | An encoder that only works on the items available via the prism. An error will be thrown in the parse monad
846829-- if the prism doesn't match.
847−--
848−-- Note that a 'Prism' from @a@ to @b@ will produce an 'Encoder' from @b@ to @a@
849−-- (i.e. 'reviewEncoder' is a contravariant functor from the category of prisms to the category of encoders),
850−-- just like 'review' produces a function @b -> a@. This is because 'Prism's extract values, in a way that might
851−-- fail, in their forward direction and inject values, in a way that cannot fail, in their reverse direction;
852−-- whereas 'Encoder's encode, which cannot fail, in their forward direction, and decode, which can fail, in their
853−-- reverse direction. In short @reviewEncoder (f . g) = reviewEncoder g . reviewEncoder f@.
854−reviewEncoder :: (Applicative check, MonadError Text parse) => Prism' b a -> Encoder check parse a b
855−reviewEncoder p = unsafeMkEncoder $ EncoderImpl
856− { _encoderImpl_encode = review p
830+prismEncoder :: (Applicative check, MonadError Text parse) => Prism' b a -> Encoder check parse a b
831+prismEncoder p = unsafeMkEncoder $ EncoderImpl
832+ { _encoderImpl_encode = (^. re p)
857833 , _encoderImpl_decode = \r -> case r ^? p of
858834 Just a -> pure a
859− Nothing -> throwError "reviewEncoder: value is not present in the prism"
835+ Nothing -> throwError "prismEncoder: value is not present in the prism"
860836 }
861837
862838-- | A URL path and query string, in which trailing slashes don't matter in the path
@@ -994,9 +970,9 @@ obeliskRouteSegment r appRouteSegment = case r of
994970-- be combined with other such segment encoders before 'pathComponentEncoder' turns it into a proper 'Encoder'.
995971resourceRouteSegment :: (MonadError Text check, MonadError Text parse) => ResourceRoute a -> SegmentResult check parse a
996972resourceRouteSegment = \case
997− ResourceRoute_Static -> PathSegment "static" pathOnlyEncoderIgnoringQuery
998− ResourceRoute_Ghcjs -> PathSegment "ghcjs" pathOnlyEncoder
999− ResourceRoute_JSaddleWarp -> PathSegment "jsaddle" jsaddleWarpRouteEncoder
973+ ResourceRoute_Static -> PathSegment "static" $ pathOnlyEncoderIgnoringQuery
974+ ResourceRoute_Ghcjs -> PathSegment "ghcjs" $ pathOnlyEncoder
975+ ResourceRoute_JSaddleWarp -> PathSegment "jsaddle" $ jsaddleWarpRouteEncoder
1000976 ResourceRoute_Version -> PathSegment "version" $ unitEncoder mempty
1001977
1002978data JSaddleWarpRoute :: * -> * where
@@ -1008,7 +984,7 @@ jsaddleWarpRouteEncoder :: (MonadError Text check, MonadError Text parse) => Enc
1008984jsaddleWarpRouteEncoder = pathComponentEncoder $ \case
1009985 JSaddleWarpRoute_JavaScript -> PathSegment "jsaddle.js" $ unitEncoder mempty
1010986 JSaddleWarpRoute_WebSocket -> PathEnd $ unitEncoder mempty
1011− JSaddleWarpRoute_Sync -> PathSegment "sync" pathOnlyEncoder
987+ JSaddleWarpRoute_Sync -> PathSegment "sync" $ pathOnlyEncoder
1012988
1013989instance GShow appRoute => GShow (ObeliskRoute appRoute) where
1014990 gshowsPrec prec = \case
@@ -1039,8 +1015,8 @@ someSumEncoder = Encoder $ pure $ EncoderImpl
10391015
10401016data Void1 :: * -> * where {}
10411017
1042−instance UniverseSome Void1 where
1043− universeSome = []
1018+instance Universe (Some Void1) where
1019+ universe = []
10441020
10451021void1Encoder :: (Applicative check, MonadError Text parse) => Encoder check parse (Some Void1) a
10461022void1Encoder = Encoder $ pure $ EncoderImpl
@@ -1052,6 +1028,17 @@ void1Encoder = Encoder $ pure $ EncoderImpl
10521028instance GShow Void1 where
10531029 gshowsPrec _ = \case {}
10541030
1031+concat <$> mapM deriveRouteComponent
1032+ [ ''ResourceRoute
1033+ , ''JSaddleWarpRoute
1034+ , ''IndexOnlyRoute
1035+ ]
1036+
1037+makePrisms ''ObeliskRoute
1038+makePrisms ''FullRoute
1039+deriveGEq ''Void1
1040+deriveGCompare ''Void1
1041+
10551042-- | Given a backend route and a checked route encoder, render the route (path
10561043-- and query string). See 'checkEncoder' for how to produce a checked encoder.
10571044renderBackendRoute
@@ -1084,11 +1071,11 @@ readShowEncoder :: (MonadError Text parse, Read a, Show a, Applicative check) =>
10841071readShowEncoder = singlePathSegmentEncoder . unsafeTshowEncoder
10851072
10861073integralEncoder :: (MonadError Text parse, Applicative check, Integral a) => Encoder check parse a Integer
1087−integralEncoder = reviewEncoder Numeric.Lens.integral
1074+integralEncoder = prismEncoder (Numeric.Lens.integral)
10881075
10891076pathSegmentEncoder :: (MonadError Text parse, Applicative check, Cons as as a a) =>
10901077 Encoder check parse (a, (as, b)) (as, b)
1091−pathSegmentEncoder = first (reviewEncoder _Cons) . disassociate
1078+pathSegmentEncoder = first (prismEncoder _Cons) . disassociate
10921079
10931080newtype Decoder check parse b a = Decoder { toEncoder :: Encoder check parse a b }
10941081
@@ -1159,7 +1146,7 @@ pathFieldEncoder fieldEncoder = unsafeEncoder $ do
11591146 fieldEncoderPure f = toEncoder (DMap.findWithDefault (error "bad") f fieldEncoderPureMap)
11601147 pure $ EncoderImpl
11611148 { _encoderImpl_encode = \(x, rest) -> execWriter $ do
1162− _ <- traverseWithField (\f x_i -> tell (pure $ encode (fieldEncoderPure f) x_i) $> x_i) x
1149+ _ <- traverseWithField (\f x_i -> tell (pure $ encode (fieldEncoderPure f) x_i) *> pure x_i) x
11631150 tell rest
11641151 , _encoderImpl_decode = State.runStateT $ tabulateFieldsA $ \f -> State.get >>= \case
11651152 [] -> throwError $ T.pack "not enough path components"
@@ -1195,34 +1182,3 @@ byteStringsToPageName p q =
11951182 in decode pageNameEncoder' (T.unpack (T.decodeUtf8 p), T.unpack (T.decodeUtf8 q))
11961183
11971184--TODO: decodeURIComponent as appropriate
1198−
1199−
1200−{-# DEPRECATED isoEncoder "Instead of 'isoEncoder f', use 'viewEncoder f'" #-}
1201−-- | Given a valid 'Iso' from lens, construct an 'Encoder'
1202−isoEncoder :: (Applicative check, Applicative parse) => Iso' a b -> Encoder check parse a b
1203−isoEncoder = viewEncoder
1204−
1205−{-# DEPRECATED prismEncoder "Instead of 'prismEncoder f', use 'reviewEncoder f'" #-}
1206−-- | An encoder that only works on the items available via the prism. An error will be thrown in the parse monad
1207−-- if the prism doesn't match.
1208−--
1209−-- Note that a 'Prism' from @a@ to @b@ will produce an 'Encoder' from @b@ to @a@
1210−-- (i.e. 'prismEncoder' is a contravariant functor from the category of prisms to the category of encoders),
1211−-- just like 'review' produces a function @b -> a@. This is because 'Prism's extract values, in a way that might
1212−-- fail, in their forward direction and inject values, in a way that cannot fail, in their reverse direction;
1213−-- whereas 'Encoder's encode, which cannot fail, in their forward direction, and decode, which can fail, in their
1214−-- reverse direction. In short @prismEncoder (f . g) = prismEncoder g . prismEncoder f@.
1215−prismEncoder :: (Applicative check, MonadError Text parse) => Prism' b a -> Encoder check parse a b
1216−prismEncoder = reviewEncoder
1217−
1218−
1219−concat <$> mapM deriveRouteComponent
1220− [ ''ResourceRoute
1221− , ''JSaddleWarpRoute
1222− , ''IndexOnlyRoute
1223− ]
1224−
1225−makePrisms ''ObeliskRoute
1226−makePrisms ''FullRoute
1227−deriveGEq ''Void1
1228−deriveGCompare ''Void1
lib/route/src/Obelisk/Route/Frontend.hs+28−41
@@ -1,24 +1,24 @@
1−{-# LANGUAGE CPP #-}
21{-# LANGUAGE ApplicativeDo #-}
2+{-# LANGUAGE CPP #-}
3+{-# LANGUAGE RecursiveDo #-}
4+{-# LANGUAGE StandaloneDeriving #-}
35{-# LANGUAGE ConstraintKinds #-}
4−{-# LANGUAGE DataKinds #-}
56{-# LANGUAGE DefaultSignatures #-}
67{-# LANGUAGE FlexibleContexts #-}
78{-# LANGUAGE FlexibleInstances #-}
8−{-# LANGUAGE FunctionalDependencies #-}
99{-# LANGUAGE GADTs #-}
10−{-# LANGUAGE GeneralizedNewtypeDeriving #-}
1110{-# LANGUAGE LambdaCase #-}
1211{-# LANGUAGE OverloadedStrings #-}
1312{-# LANGUAGE PatternSynonyms #-}
1413{-# LANGUAGE RankNTypes #-}
15−{-# LANGUAGE RecursiveDo #-}
1614{-# LANGUAGE ScopedTypeVariables #-}
17−{-# LANGUAGE StandaloneDeriving #-}
1815{-# LANGUAGE TypeFamilies #-}
1916{-# LANGUAGE TypeOperators #-}
20−{-# LANGUAGE UndecidableInstances #-}
2117{-# LANGUAGE ViewPatterns #-}
18+{-# LANGUAGE GeneralizedNewtypeDeriving #-}
19+{-# LANGUAGE UndecidableInstances #-}
20+{-# LANGUAGE DataKinds #-}
21+{-# LANGUAGE FunctionalDependencies #-}
2222
2323module Obelisk.Route.Frontend
2424 ( module Obelisk.Route
@@ -57,42 +57,49 @@ module Obelisk.Route.Frontend
5757
5858import Prelude hiding ((.), id)
5959
60+import Obelisk.Route
61+
6062import Control.Category (Category (..), (.))
6163import Control.Category.Cartesian ((&&&))
6264import Control.Lens hiding (Bifunctor, bimap, universe, element)
6365import Control.Monad ((<=<))
6466import Control.Monad.Fix
65−import Control.Monad.Morph
6667import Control.Monad.Primitive
6768import Control.Monad.Reader
6869import Control.Monad.Ref
6970import Control.Monad.Trans.Control
7071import Data.Coerce
7172import Data.Dependent.Sum (DSum (..))
72−import Data.Functor.Compose
73−import Data.Functor.Misc
7473import Data.GADT.Compare
75−import qualified Data.List as L
7674import Data.Map (Map)
77−import Data.Maybe (fromMaybe)
7875import Data.Monoid
7976import Data.Proxy
8077import Data.Text (Text)
8178import qualified Data.Text as T
79+import Data.Functor.Compose
80+import Data.Functor.Misc
81+import Reflex.Class
82+import Reflex.Host.Class
83+import Reflex.PostBuild.Class
84+import Reflex.TriggerEvent.Class
85+import Reflex.PerformEvent.Class
86+import Reflex.EventWriter.Class
87+import Reflex.EventWriter.Base
88+import Reflex.Dynamic
89+import Reflex.Dom.Builder.Class
8290import Data.Type.Coercion
91+import Language.Javascript.JSaddle --TODO: Get rid of this - other platforms can also be routed
92+import Reflex.Dom.Core
8393import qualified GHCJS.DOM as DOM
8494import qualified GHCJS.DOM.Types as DOM
8595import qualified GHCJS.DOM.Window as Window
86−import Language.Javascript.JSaddle (MonadJSM, jsNull, liftJSM) --TODO: Get rid of this - other platforms can also be routed
8796import Network.URI
88−import Reflex.Class
89−import Reflex.Dom.Builder.Class
90−import Reflex.Dom.Core
91−import Reflex.Host.Class
97+import Data.Maybe (fromMaybe)
98+import qualified Data.List as L
99+
92100import Unsafe.Coerce
93101
94102import Obelisk.Configs
95−import Obelisk.Route
96103
97104infixr 5 :~
98105pattern (:~) :: Reflex t => f a -> Dynamic t a -> DSum f (Compose (Dynamic t) Identity)
@@ -109,23 +116,7 @@ instance Monad m => Routed t r (RoutedT t r m) where
109116instance (Monad m, Routed t r m) => Routed t r (ReaderT r' m)
110117
111118newtype RoutedT t r m a = RoutedT { unRoutedT :: ReaderT (Dynamic t r) m a }
112− deriving
113− ( Functor
114− , Applicative
115− , Monad
116− , MonadFix
117− , MonadTrans
118− , MFunctor
119− , NotReady t
120− , MonadHold t
121− , MonadSample t
122− , PostBuild t
123− , TriggerEvent t
124− , MonadIO
125− , MonadReflexCreateTrigger t
126− , HasDocument
127− , DomRenderHook t
128− )
119+ deriving (Functor, Applicative, Monad, MonadFix, MonadTrans, NotReady t, MonadHold t, MonadSample t, PostBuild t, TriggerEvent t, MonadIO, MonadReflexCreateTrigger t, HasDocument, DomRenderHook t)
129120
130121instance MonadReader r' m => MonadReader r' (RoutedT t r m) where
131122 ask = lift ask
@@ -201,10 +192,6 @@ instance (Monad m, RouteToUrl r m) => RouteToUrl r (EventWriterT t w m)
201192
202193instance (Monad m, SetRoute t r m) => SetRoute t r (EventWriterT t w m)
203194
204−instance (Monad m, RouteToUrl r m) => RouteToUrl r (DynamicWriterT t w m)
205−
206−instance (Monad m, SetRoute t r m) => SetRoute t r (DynamicWriterT t w m)
207−
208195runRoutedT :: RoutedT t r m a -> Dynamic t r -> m a
209196runRoutedT = runReaderT . unRoutedT
210197
@@ -269,7 +256,7 @@ dynamicIdentityCoercion = unsafeCoerce (Coercion :: Coercion (Identity ()) ()) -
269256factorRouted :: (Reflex t, MonadFix m, MonadHold t m, GEq f) => RoutedT t (DSum f (Dynamic t)) m a -> RoutedT t (DSum f Identity) m a
270257factorRouted r = RoutedT $ ReaderT $ \d -> do
271258 d' <- factorDyn d
272− runRoutedT r $ coerceWith (dynamicCoercion $ dsumValueCoercion dynamicIdentityCoercion) d'
259+ runRoutedT r $ (coerceWith (dynamicCoercion $ dsumValueCoercion dynamicIdentityCoercion) d')
273260
274261maybeRouted :: (Reflex t, MonadFix m, MonadHold t m) => RoutedT t (Maybe (Dynamic t a)) m b -> RoutedT t (Maybe a) m b
275262maybeRouted r = RoutedT $ ReaderT $ \d -> do
@@ -477,7 +464,7 @@ runRouteViewT
477464 , MonadJSM (Performable m)
478465 , MonadFix m
479466 )
480− => Encoder Identity Identity r PageName
467+ => (Encoder Identity Identity r PageName)
481468 --TODO: Get rid of the switchover and useHash arguments
482469 -- useHash can probably be baked into the encoder
483470 -> Event t () -- ^ Switchover event, nothing is done until this event fires. Used to prevent incorrect DOM expectations at hydration switchover time
lib/run/obelisk-run.cabal+2−2
@@ -33,7 +33,7 @@ library
3333 , process
3434 , ref-tf
3535 , reflex
36− , reflex-dom-core
36+ , reflex-dom
3737 , snap-core
3838 , streaming-commons
3939 , text
@@ -47,7 +47,7 @@ library
4747 , websockets
4848 exposed-modules:
4949 Obelisk.Run
50− ghc-options: -Wall -Werror -Wredundant-constraints -Wincomplete-uni-patterns -Wincomplete-record-updates -O
50+ ghc-options: -Wall -fwarn-redundant-constraints
5151 if os(linux)
5252 cpp-options: -DIPROUTE_SUPPORTED
5353 build-depends: which
lib/run/src/Obelisk/Run.hs+3−3
@@ -144,9 +144,9 @@ runWidget conf configs frontend validFullEncoder = do
144144
145145 cert <- X509.newX509 >>= X509Request.makeX509FromReq certRequest
146146 _ <- X509.setPublicKey cert privateKey
147− timenow <- getCurrentTime
148− _ <- X509.setNotBefore cert $ addUTCTime (-1) timenow
149− _ <- X509.setNotAfter cert $ addUTCTime (365 * 24 * 60 * 60) timenow
147+ now <- getCurrentTime
148+ _ <- X509.setNotBefore cert $ addUTCTime (-1) now
149+ _ <- X509.setNotAfter cert $ addUTCTime (365 * 24 * 60 * 60) now
150150 _ <- X509.signX509 cert privateKey Nothing
151151
152152 certByteString <- BSUTF8.fromString <$> PEM.writeX509 cert
lib/selftest/src/Obelisk/SelfTest.hs−24
@@ -19,7 +19,6 @@ import Data.Bool (bool)
1919import qualified Data.ByteString.Lazy as LBS
2020import Data.Foldable (for_)
2121import Data.Function (fix)
22−import Data.List (isInfixOf)
2322import qualified Data.Map as Map
2423import Data.Semigroup ((<>))
2524import qualified Data.Set as Set
@@ -206,22 +205,6 @@ main' isVerbose httpManager obeliskRepoReadOnly = withInitCache $ \initCache ->
206205 it "works in root directory" $ inTmpObInit $ \_ -> testObRunInDir' Nothing httpManager
207206 it "works in sub directory" $ inTmpObInit $ \_ -> testObRunInDir' (Just "frontend") httpManager
208207
209− describe "ob repl" $ do
210− it "accepts stdin commands" $ inTmpObInit $ \_ -> do
211− setStdin "print 3\n:q"
212− output <- runOb ["repl"]
213− liftIO $ assertBool "" $
214− [ "*Obelisk.Run Obelisk.Run Frontend Backend> 3"
215− , "*Obelisk.Run Obelisk.Run Frontend Backend> Leaving GHCi."
216− ] `isInfixOf` T.lines (T.strip output)
217− it "works with custom Prelude" $ inTmpObInit $ \_ -> do
218− writefile "common/src/Prelude.hs"
219− "{-# LANGUAGE PackageImports #-} module Prelude (module X) where import \"base\" Prelude as X"
220− setStdin ":q"
221− output <- runOb ["repl"]
222− liftIO $ assertBool "" $
223− "*Obelisk.Run Obelisk.Run Frontend Backend> Leaving GHCi." `T.isInfixOf` output
224−
225208 describe "obelisk project" $ parallel $ do
226209 it "can build obelisk command" $ inTmpObInit $ \_ -> nixBuild ["-A", "command" , toTextIgnore obeliskRepoReadOnly]
227210 it "can build obelisk skeleton" $ inTmpObInit $ \_ -> nixBuild ["-A", "skeleton", toTextIgnore obeliskRepoReadOnly]
@@ -260,8 +243,6 @@ main' isVerbose httpManager obeliskRepoReadOnly = withInitCache $ \initCache ->
260243 uu <- update
261244 assertRevEQ u uu
262245
263− it "can run 'ob doc'" $ inTmpObInit $ \_ -> runOb_ ["doc", "reflex"]
264−
265246 describe "ob thunk pack/unpack" $ parallel $ do
266247 it "has thunk pack and unpack inverses" $ inTmpObInitWithImplCopy $ \_ -> do
267248
@@ -323,11 +304,6 @@ main' isVerbose httpManager obeliskRepoReadOnly = withInitCache $ \initCache ->
323304 void $ errExit False $ runOb ["thunk", "update", toTextIgnore dir, "--branch", "dumble-palooza"]
324305 checkDir dir >>= liftIO . assertEqual "" startingContents
325306
326− describe "ob shell" $ parallel $ do
327− it "works with --" $ inTmpObInit $ \_ -> do
328− output <- runOb ["shell", "--", "ghc-pkg", "list"]
329− liftIO $ assertBool "Unexpected output from ob shell" $ ("Cabal-" `T.isInfixOf` output) && ("ghc-" `T.isInfixOf` output)
330−
331307 describe "ob hoogle" $ {- NOT parallel -} do
332308 it "starts a hoogle server on the given port" $ inTmpObInit $ \_ -> do
333309 [p0] <- liftIO $ getFreePorts 1
lib/snap-extras/obelisk-snap-extras.cabal+2−1
@@ -12,9 +12,10 @@ library
1212 , base
1313 , bytestring
1414 , snap-core
15+ , unix
1516 , directory
1617 , filepath
1718 , text
1819 exposed-modules:
1920 Obelisk.Snap.Extras
20− ghc-options: -Wall -Werror -Wredundant-constraints -Wincomplete-uni-patterns -Wincomplete-record-updates -O
21+ ghc-options: -Wall
lib/snap-extras/src/Obelisk/Snap/Extras.hs+1−1
@@ -17,7 +17,7 @@ import System.Directory
1717-- | Set response header for "permanent" caching
1818cachePermanently :: MonadSnap m => m ()
1919cachePermanently = do
20− modifyResponse $ setHeader "Cache-Control" "public, max-age=315360000, immutable"
20+ modifyResponse $ setHeader "Cache-Control" "public, max-age=315360000"
2121 modifyResponse $ setHeader "Expires" "Tue, 01 Feb 2050 00:00:00 GMT" --TODO: This should be set to "approximately one year from the time the response is sent"
2222
2323-- | Set response header to not cache
scripts/ghcid-this-libnew file+4
@@ -0,0 +1,4 @@
1+#!/usr/bin/env bash
2+set -euo pipefail
3+
4+nix-shell -E "with (import ../.. {}); reflex-platform.workOn haskellPackageSets.ghc haskellPackageSets.ghc.obelisk-$(basename $PWD)" --run "ghcid -c 'cabal new-repl'"
skeleton/.gitignore+6−12
@@ -1,15 +1,9 @@
1+dist-newstyle
2+result
3+result-*
4+result-android
5+result-ios
6+result-exe
17.attr-cache
2−.cabal-sandbox
3−*.hi
4−*.o
5−cabal.project.local
6−cabal.sandbox.config
7−ctags
8−dist-newstyle/
9−dist/
108ghcid-output.txt
119profile/
12−result
13−result-*
14−tags
15−TAGS
skeleton/backend/backend.cabal+1−2
@@ -14,12 +14,11 @@ library
1414 , obelisk-route
1515 exposed-modules:
1616 Backend
17− ghc-options: -Wall -Wredundant-constraints -Wincomplete-uni-patterns -Wincomplete-record-updates -O -fno-show-valid-hole-fits
17+ ghc-options: -Wall
1818
1919executable backend
2020 main-is: main.hs
2121 hs-source-dirs: src-bin
22− ghc-options: -Wall -Wredundant-constraints -Wincomplete-uni-patterns -Wincomplete-record-updates -O -threaded -fno-show-valid-hole-fits
2322 if impl(ghcjs)
2423 buildable: False
2524 build-depends: base
skeleton/cabal.project−1
@@ -1,3 +1,2 @@
11optional-packages:
22 *
3−write-ghc-environment-files: never
skeleton/common/common.cabal−1
@@ -12,4 +12,3 @@ library
1212 exposed-modules:
1313 Common.Api
1414 Common.Route
15− ghc-options: -Wall -Wredundant-constraints -Wincomplete-uni-patterns -Wincomplete-record-updates -O -fno-show-valid-hole-fits
skeleton/default.nix+3−10
@@ -1,17 +1,10 @@
1−{ system ? builtins.currentSystem
2−, obelisk ? import ./.obelisk/impl {
3− inherit system;
4− iosSdkVersion = "13.2";
5−
1+{ obelisk ? import ./.obelisk/impl {
2+ system = builtins.currentSystem;
3+ iosSdkVersion = "10.2";
64 # You must accept the Android Software Development Kit License Agreement at
75 # https://developer.android.com/studio/terms in order to build Android apps.
86 # Uncomment and set this to `true` to indicate your acceptance:
97 # config.android_sdk.accept_license = false;
10−
11− # In order to use Let's Encrypt for HTTPS deployments you must accept
12− # their terms of service at https://letsencrypt.org/repository/.
13− # Uncomment and set this to `true` to indicate your acceptance:
14− # terms.security.acme.acceptTerms = false;
158 }
169}:
1710with obelisk;
skeleton/frontend/frontend.cabal+4−6
@@ -16,7 +16,7 @@ library
1616 , text
1717 exposed-modules:
1818 Frontend
19− ghc-options: -Wall -Wredundant-constraints -Wincomplete-uni-patterns -Wincomplete-record-updates -O -fno-show-valid-hole-fits
19+ ghc-options: -Wall
2020
2121executable frontend
2222 main-is: main.hs
@@ -28,9 +28,7 @@ executable frontend
2828 , reflex-dom
2929 , obelisk-generated-static
3030 , frontend
31− ghc-options: -threaded -O -Wall -Wredundant-constraints -Wincomplete-uni-patterns -Wincomplete-record-updates -fno-show-valid-hole-fits
32− if impl(ghcjs)
33− ghc-options: -dedupe
34− cpp-options: -DGHCJS_BROWSER
31+ --TODO: Make these ghc-options optional
32+ ghc-options: -threaded
3533 if os(darwin)
36− ghc-options: -dynamic
34+ ghc-options: -dynamic
skeleton/shell.nixnew file+1
@@ -0,0 +1 @@
1+(import ./. {}).shells.ghc