on master help sign in
Follow hlint suggestion: eta reduce.
commit089f585662240adcae5c8a23741cf8cb6dff67e9 authorPhil de Joux <philderbeast@gmail.com> dateSun 16 Oct 2022, 16:27 (4 years ago) parent50cb786
5 files changed+8−9
.hlint.yaml−1 src/OddJobs/ConfigBuilder.hs+2−2 src/OddJobs/Job.hs+4−4 src/OddJobs/Web.hs+1−1 test/Test.hs+1−1
.hlint.yaml−1
@@ -1,3 +1,2 @@
11# Warnings currently triggered by your code
2−- ignore: {name: "Eta reduce"} # 6 hints
32- ignore: {name: "Use newtype instead of data"} # 1 hint
src/OddJobs/ConfigBuilder.hs+2−2
@@ -337,7 +337,7 @@ defaultJsonLogEvent logEvent =
337337 , "contents" Aeson..= t ]
338338
339339defaultJsonJob :: Job -> Aeson.Value
340−defaultJsonJob job = genericToJSON Aeson.defaultOptions job
340+defaultJsonJob = genericToJSON Aeson.defaultOptions
341341
342342defaultJsonFailureMode :: FailureMode -> Aeson.Value
343−defaultJsonFailureMode fm = genericToJSON Aeson.defaultOptions fm
343+defaultJsonFailureMode = genericToJSON Aeson.defaultOptions
src/OddJobs/Job.hs+4−4
@@ -668,14 +668,14 @@ scheduleJob conn tname payload runAt = do
668668eitherParsePayload :: (FromJSON a)
669669 => Job
670670 -> Either String a
671−eitherParsePayload job =
672− eitherParsePayloadWith parseJSON job
671+eitherParsePayload =
672+ eitherParsePayloadWith parseJSON
673673
674674throwParsePayload :: (FromJSON a)
675675 => Job
676676 -> IO a
677−throwParsePayload job =
678− throwParsePayloadWith parseJSON job
677+throwParsePayload =
678+ throwParsePayloadWith parseJSON
679679
680680eitherParsePayloadWith :: (Aeson.Value -> Aeson.Parser a)
681681 -> Job
src/OddJobs/Web.hs+1−1
@@ -503,5 +503,5 @@ resultsPanel routes@Routes{..} t filter@Filter{filterPage} js runningCount = do
503503 a_ [ class_ "page-link", href_ lnk ] "Next"
504504
505505ariaExpanded_ :: Text -> Attribute
506−ariaExpanded_ v = makeAttribute "aria-expanded" v
506+ariaExpanded_ = makeAttribute "aria-expanded"
507507
test/Test.hs+1−1
@@ -505,7 +505,7 @@ data JobEvent = JobStart
505505
506506
507507payloadDelay :: Seconds -> JobPayload -> Seconds
508−payloadDelay jobPollingInterval pload = payloadDelay_ (Seconds 0) pload
508+payloadDelay jobPollingInterval = payloadDelay_ (Seconds 0)
509509 where
510510 payloadDelay_ total p =
511511 let defaultDelay x = total + x + jobPollingInterval