git.iko.soy/odd-jobs
on master help sign in
Follow hlint suggestion: use lambda-case.
commit37c13354cd9b8a1dfe3e64eb884bc63786a7ba6b authorPhil de Joux <philderbeast@gmail.com> dateSun 16 Oct 2022, 15:27 (4 years ago) parenta08dc15
2 files changed+22−21
compare with master
unifiedsplit
.hlint.yaml−1 test/Test.hs+22−20
.hlint.yaml−1
@@ -7,7 +7,6 @@
77- ignore: {name: "Redundant lambda"} # 1 hint
88- ignore: {name: "Replace case with fromMaybe"} # 2 hints
99- ignore: {name: "Use asks"} # 13 hints
10−- ignore: {name: "Use lambda-case"} # 5 hints
1110- ignore: {name: "Use newtype instead of data"} # 1 hint
1211- ignore: {name: "Use null"} # 3 hints
1312- ignore: {name: "Use optional"} # 1 hint
test/Test.hs+22−20
@@ -190,36 +190,38 @@ assertJobIdStatus conn tname logRef msg st jid = do
190190 case st of
191191 Job.Success ->
192192 assertBool (msg <> ": Success event not found in job-logs for JobId=" <> show jid) $
193− (flip DL.any) logs $ \logEvent -> case logEvent of
194− Job.LogJobSuccess j _ -> jid == Job.jobId j
195− _ -> False
193+ (flip DL.any) logs $ \case
194+ Job.LogJobSuccess j _ -> jid == Job.jobId j
195+ _ -> False
196+
196197 Job.Queued ->
197198 assertBool (msg <> ": Not expecting to find a queued job in the the job-logs JobId=" <> show jid) $
198− not $ (flip DL.any) logs $ \logEvent -> case logEvent of
199− Job.LogJobStart j -> jid == Job.jobId j
200− Job.LogJobSuccess j _ -> jid == Job.jobId j
201− Job.LogJobFailed j _ _ _ -> jid == Job.jobId j
202− Job.LogJobTimeout j -> jid == Job.jobId j
203− Job.LogWebUIRequest -> False
204− Job.LogText _ -> False
205− Job.LogPoll -> False
199+ not $ (flip DL.any) logs $ \case
200+ Job.LogJobStart j -> jid == Job.jobId j
201+ Job.LogJobSuccess j _ -> jid == Job.jobId j
202+ Job.LogJobFailed j _ _ _ -> jid == Job.jobId j
203+ Job.LogJobTimeout j -> jid == Job.jobId j
204+ Job.LogWebUIRequest -> False
205+ Job.LogText _ -> False
206+ Job.LogPoll -> False
207+
206208 Job.Failed ->
207209 assertBool (msg <> ": Failed event not found in job-logs for JobId=" <> show jid) $
208− (flip DL.any) logs $ \logEvent -> case logEvent of
209− Job.LogJobFailed j _ _ _ -> jid == Job.jobId j
210− _ -> False
210+ (flip DL.any) logs $ \case
211+ Job.LogJobFailed j _ _ _ -> jid == Job.jobId j
212+ _ -> False
211213
212214 Job.Retry ->
213215 assertBool (msg <> ": Failed event not found in job-logs for JobId=" <> show jid) $
214− (flip DL.any) logs $ \logEvent -> case logEvent of
215− Job.LogJobFailed j _ _ _ -> jid == Job.jobId j
216− _ -> False
216+ (flip DL.any) logs $ \case
217+ Job.LogJobFailed j _ _ _ -> jid == Job.jobId j
218+ _ -> False
217219
218220 Job.Locked ->
219221 assertBool (msg <> ": Start event should be present in the log for a locked job JobId=" <> show jid) $
220− (flip DL.any) logs $ \logEvent -> case logEvent of
221− Job.LogJobStart j -> jid == Job.jobId j
222− _ -> False
222+ (flip DL.any) logs $ \case
223+ Job.LogJobStart j -> jid == Job.jobId j
224+ _ -> False
223225
224226 when (st /= Job.Success) $ do
225227 Job.findJobByIdIO conn tname jid >>= \case