on master help sign in
Follow hlint suggestion: use null.
commit41a0f265dc91825af443d29ff90366812d7a5ff7 authorPhil de Joux <philderbeast@gmail.com> dateSun 16 Oct 2022, 16:21 (4 years ago) parente0f7be9
2 files changed+4−5
.hlint.yaml+1−2 src/OddJobs/Web.hs+3−3
.hlint.yaml+1−2
@@ -1,5 +1,4 @@
11# Warnings currently triggered by your code
22- ignore: {name: "Eta reduce"} # 6 hints
33- ignore: {name: "Redundant if"} # 1 hint
4−- ignore: {name: "Use newtype instead of data"} # 1 hint
5−- ignore: {name: "Use null"} # 3 hints
4+- ignore: {name: "Use newtype instead of data"} # 1 hint
src/OddJobs/Web.hs+3−3
@@ -274,7 +274,7 @@ sideNav Routes{..} jobTypes jobRunnerNames _t filter@Filter{..} = do
274274 h6_ "Filter by job status"
275275 div_ [ class_ "card" ] $ do
276276 ul_ [ class_ "list-group list-group-flush" ] $ do
277− li_ [ class_ ("list-group-item " <> if filterStatuses == [] then "active-nav" else "") ] $ do
277+ li_ [ class_ ("list-group-item " <> if null filterStatuses then "active-nav" else "") ] $ do
278278 let lnk = rFilterResults $ Just filter{filterStatuses = [], filterPage = OddJobs.Web.filterPage blankFilter}
279279 a_ [ href_ lnk ] $ do
280280 "all"
@@ -295,7 +295,7 @@ sideNav Routes{..} jobTypes jobRunnerNames _t filter@Filter{..} = do
295295
296296 div_ [ class_ "card" ] $ do
297297 ul_ [ class_ "list-group list-group-flush" ] $ do
298− li_ [ class_ ("list-group-item " <> if filterJobRunner == [] then "active-nav" else "") ] $ do
298+ li_ [ class_ ("list-group-item " <> if null filterJobRunner then "active-nav" else "") ] $ do
299299 let lnk = rFilterResults $ Just filter{filterJobRunner = [], filterPage = OddJobs.Web.filterPage blankFilter}
300300 a_ [ href_ lnk ] "all"
301301 forM_ jobRunnerNames $ \jr -> do
@@ -311,7 +311,7 @@ sideNav Routes{..} jobTypes jobRunnerNames _t filter@Filter{..} = do
311311
312312 div_ [ class_ "card" ] $ do
313313 ul_ [ class_ "list-group list-group-flush" ] $ do
314− li_ [ class_ ("list-group-item " <> if filterJobTypes == [] then "active-nav" else "") ] $ do
314+ li_ [ class_ ("list-group-item " <> if null filterJobTypes then "active-nav" else "") ] $ do
315315 let lnk = rFilterResults $ Just filter{filterJobTypes = [], filterPage = OddJobs.Web.filterPage blankFilter}
316316 a_ [ href_ lnk ] "all"
317317 forM_ jobTypes $ \jt -> do