d34c997 · odd-jobs · git.iko.soy

git.iko.soy/odd-jobs

Follow hlint suggestion: use void.

commitd34c997f3b0f485e3f61b9cc299f4a563cb78a3c authorPhil de Joux <philderbeast@gmail.com> dateSun 16 Oct 2022, 15:01 (4 years ago) parentbb76a13

2 files changed+3−3

unifiedsplit

.hlint.yaml+1−2

@@ -17,5 +17,4 @@

1717- ignore: {name: "Use list literal pattern"} # 2 hints

1818- ignore: {name: "Use newtype instead of data"} # 1 hint

1919- ignore: {name: "Use null"} # 3 hints

20−- ignore: {name: "Use optional"} # 1 hint

21−- ignore: {name: "Use void"} # 1 hint

20+- ignore: {name: "Use optional"} # 1 hint

test/Test.hs+2−1

@@ -12,6 +12,7 @@ import Data.Pool as Pool

1212import Test.Tasty.HUnit

1313import Debug.Trace

1414-- import Control.Exception.Lifted (finally, catch, bracket)

15+import Control.Monad (void)

1516import Control.Monad.Logger

1617import Control.Monad.Reader

1718import Data.Aeson as Aeson

@@ -143,7 +144,7 @@ jobRunner Job{jobPayload, jobAttempts} = case (fromJSON jobPayload) of

143144 Success (j :: JobPayload) ->

144145 let recur pload idx = case pload of

145146 PayloadAlwaysFail delay -> (delaySeconds delay) >> (error $ "Forced error after " <> show delay <> " seconds")

146− PayloadSucceed delay -> (delaySeconds delay) >> pure ()

147+ PayloadSucceed delay -> void $ delaySeconds delay

147148 PayloadFail delay innerpload -> if idx<jobAttempts

148149 then recur innerpload (idx + 1)

149150 else (delaySeconds delay) >> (error $ "Forced error after " <> show delay <> " seconds. step=" <> show idx)