on master help sign in
Follow hlint suggestion: use asks.
commitd6bc6f18649aef0fbb6ca2e9d76b8e4289f1814b authorPhil de Joux <philderbeast@gmail.com> dateSun 16 Oct 2022, 15:36 (4 years ago) parent766e9d7
2 files changed+13−14
.hlint.yaml−1 src/OddJobs/Job.hs+13−13
.hlint.yaml−1
@@ -4,7 +4,6 @@
44- ignore: {name: "Redundant $"} # 21 hints
55- ignore: {name: "Redundant bracket"} # 118 hints
66- ignore: {name: "Redundant if"} # 1 hint
7−- ignore: {name: "Use asks"} # 13 hints
87- ignore: {name: "Use newtype instead of data"} # 1 hint
98- ignore: {name: "Use null"} # 3 hints
109- ignore: {name: "Use optional"} # 1 hint
src/OddJobs/Job.hs+13−13
@@ -167,34 +167,34 @@ logCallbackErrors :: (HasJobRunner m) => JobId -> Text -> m () -> m ()
167167logCallbackErrors jid msg action = catchAny action $ \e -> log LevelError $ LogText $ msg <> " Job ID=" <> toS (show jid) <> ": " <> toS (show e)
168168
169169instance HasJobRunner RunnerM where
170− getPollingInterval = cfgPollingInterval . envConfig <$> ask
171− onJobFailed = cfgOnJobFailed . envConfig <$> ask
170+ getPollingInterval = asks (cfgPollingInterval . envConfig)
171+ onJobFailed = asks (cfgOnJobFailed . envConfig)
172172 onJobSuccess job = do
173− fn <- cfgOnJobSuccess . envConfig <$> ask
173+ fn <- asks (cfgOnJobSuccess . envConfig)
174174 logCallbackErrors (jobId job) "onJobSuccess" $ liftIO $ fn job
175− deleteSuccessfulJobs = cfgDeleteSuccessfulJobs . envConfig <$> ask
175+ deleteSuccessfulJobs = asks (cfgDeleteSuccessfulJobs . envConfig)
176176
177− getJobRunner = cfgJobRunner . envConfig <$> ask
178− getDbPool = cfgDbPool . envConfig <$> ask
179− getTableName = cfgTableName . envConfig <$> ask
177+ getJobRunner = asks (cfgJobRunner . envConfig)
178+ getDbPool = asks (cfgDbPool . envConfig)
179+ getTableName = asks (cfgTableName . envConfig)
180180 onJobStart job = do
181− fn <- cfgOnJobStart . envConfig <$> ask
181+ fn <- asks (cfgOnJobStart . envConfig)
182182 logCallbackErrors (jobId job) "onJobStart" $ liftIO $ fn job
183183
184− getDefaultMaxAttempts = cfgDefaultMaxAttempts . envConfig <$> ask
184+ getDefaultMaxAttempts = asks (cfgDefaultMaxAttempts . envConfig)
185185
186186 getRunnerEnv = ask
187187
188− getConcurrencyControl = (cfgConcurrencyControl . envConfig <$> ask)
188+ getConcurrencyControl = asks (cfgConcurrencyControl . envConfig)
189189
190190 log logLevel logEvent = do
191− loggerFn <- cfgLogger . envConfig <$> ask
191+ loggerFn <- asks (cfgLogger . envConfig)
192192 liftIO $ loggerFn logLevel logEvent
193193
194− getDefaultJobTimeout = cfgDefaultJobTimeout . envConfig <$> ask
194+ getDefaultJobTimeout = asks (cfgDefaultJobTimeout . envConfig)
195195
196196 getDefaultRetryBackoff attempts = do
197− retryFn <- cfgDefaultRetryBackoff . envConfig <$> ask
197+ retryFn <- asks (cfgDefaultRetryBackoff . envConfig)
198198 liftIO $ retryFn attempts
199199
200200-- | Start the job-runner in the /current/ thread, i.e. you'll need to use