osm-search/Nominatim
1
1
Fork 0
mirror of https://github.com/osm-search/Nominatim.git synced 2024-12-04 15:16:19 +03:00
Code Issues Packages Projects Releases Wiki Activity
336258ecf8
Nominatim/test/bdd/db/import/linking.feature

252 lines
9.4 KiB
Gherkin
Raw Normal View History

tests for linking
2016-11-27 01:04:31 +03:00
@DB
Feature: Linking of places
Tests for correctly determining linked places
Scenario: Only address-describing places can be linked
Given the scene way-area-with-center
And the places
| osm | class | type | name | geometry |
| R13 | landuse | forest | Garbo | :area |
| N256 | natural | peak | Garbo | :inner-C |
When importing
Then placex contains
| object | linked_place_id |
| R13 | - |
| N256 | - |
disallow linking for postcode areas
2020-11-17 12:53:26 +03:00
Scenario: Postcode areas cannot be linked
Given the grid
| 1 | | 2 |
| | 9 | |
| 4 | | 3 |
And the named places
| osm | class | type | addr+postcode | extra+wikidata | geometry |
| R13 | boundary | postal_code | 123 | Q87493 | (1,2,3,4,1) |
| N25 | place | suburb | 123 | Q87493 | 9 |
When importing
Then placex contains
| object | linked_place_id |
| R13 | - |
| N25 | - |
Scenario: Waterways are linked when in waterway relations
tests for linking
2016-11-27 01:04:31 +03:00
Given the scene split-road
And the places
| osm | class | type | name | geometry |
| W1 | waterway | river | Rhein | :w-2 |
| W2 | waterway | river | Rhein | :w-3 |
| R13 | waterway | river | Rhein | :w-1 + :w-2 + :w-3 |
| R23 | waterway | river | Limmat| :w-4a |
And the relations
| id | members | tags+type |
| 13 | R23:tributary,W1,W2:main_stream | waterway |
When importing
Then placex contains
| object | linked_place_id |
| W1 | R13 |
| W2 | R13 |
| R13 | - |
| R23 | - |
switch BDD tests to always use search API
2021-06-06 16:27:52 +03:00
When sending search query "rhein"
tests for linking
2016-11-27 01:04:31 +03:00
Then results contain
| osm_type |
| R |
Scenario: Relations are not linked when in waterway relations
Given the scene split-road
And the places
when linking waterway ways and relations allow all river-like types Fixes #848
2017-12-16 18:59:48 +03:00
| osm | class | type | name | geometry |
| W1 | waterway | stream | Rhein | :w-2 |
| W2 | waterway | river | Rhein | :w-3 |
| R1 | waterway | river | Rhein | :w-1 + :w-2 + :w-3 |
| R2 | waterway | river | Limmat| :w-4a |
tests for linking
2016-11-27 01:04:31 +03:00
And the relations
| id | members | tags+type |
| 1 | R2 | waterway |
When importing
Then placex contains
| object | linked_place_id |
| W1 | - |
| W2 | - |
| R1 | - |
| R2 | - |
Scenario: Empty waterway relations are handled correctly
Given the scene split-road
And the places
| osm | class | type | name | geometry |
| R1 | waterway | river | Rhein | :w-1 + :w-2 + :w-3 |
And the relations
| id | members | tags+type |
| 1 | | waterway |
When importing
Then placex contains
| object | linked_place_id |
| R1 | - |
when linking waterway ways and relations allow all river-like types Fixes #848
2017-12-16 18:59:48 +03:00
Scenario: Waterways are not linked when the way type is not a river feature
tests for linking
2016-11-27 01:04:31 +03:00
Given the scene split-road
And the places
| osm | class | type | name | geometry |
when linking waterway ways and relations allow all river-like types Fixes #848
2017-12-16 18:59:48 +03:00
| W1 | waterway | lock | Rhein | :w-2 |
tests for linking
2016-11-27 01:04:31 +03:00
| R1 | waterway | river | Rhein | :w-1 + :w-2 + :w-3 |
And the relations
| id | members | tags+type |
| 1 | N23,N34,W1,R45 | multipolygon |
When importing
Then placex contains
| object | linked_place_id |
| W1 | - |
| R1 | - |
switch BDD tests to always use search API
2021-06-06 16:27:52 +03:00
When sending search query "rhein"
tests for linking
2016-11-27 01:04:31 +03:00
Then results contain
| ID | osm_type |
| 0 | R |
| 1 | W |
Scenario: Side streams are linked only when they have the same name
Given the scene split-road
And the places
| osm | class | type | name | geometry |
| W1 | waterway | river | Rhein2 | :w-2 |
| W2 | waterway | river | Rhein | :w-3 |
| R1 | waterway | river | Rhein | :w-1 + :w-2 + :w-3 |
And the relations
| id | members | tags+type |
| 1 | W1:side_stream,W2:side_stream | waterway |
When importing
Then placex contains
| object | linked_place_id |
| W1 | - |
| W2 | R1 |
switch BDD tests to always use search API
2021-06-06 16:27:52 +03:00
When sending search query "rhein2"
tests for linking
2016-11-27 01:04:31 +03:00
Then results contain
| osm_type |
| W |
restrict linked places to place nodes Avoids getting the wrong entry when the linked place has double tagging. Fixes #573.
2017-06-07 22:32:02 +03:00
# github #573
Scenario: Boundaries should only be linked to places
Given the named places
| osm | class | type | extra+wikidata | admin | geometry |
| R1 | boundary | administrative | 34 | 8 | poly-area:0.1 |
And the named places
| osm | class | type | geometry |
| N3 | natural | island | 0.00001 0 |
| N3 | place | city | 0.00001 0 |
And the relations
| id | members |
| 1 | N3:label |
When importing
Then placex contains
| object | linked_place_id |
| N3:natural | - |
| N3:place | R1 |
move linked place type into linked_place extratags Using linked_place means that we don't overwrite any place tags on the boundary. This is important when we wanto to use the information for linking.
2020-02-10 00:26:53 +03:00
Scenario: Nodes with 'role' label are always linked
Given the places
| osm | class | type | admin | name | geometry |
| R13 | boundary | administrative | 6 | Garbo | poly-area:0.1 |
| N2 | place | hamlet | 15 | Vario | 0.006 0.00001 |
And the relations
| id | members | tags+type |
| 13 | N2:label | boundary |
When importing
Then placex contains
| object | linked_place_id |
| N2 | R13 |
And placex contains
| object | centroid | name+name | extratags+linked_place |
| R13 | 0.006 0.00001 | Garbo | hamlet |
link against place nodes by place type If a boundary relation has no label member preferably link against a place node with the same place type. Also inherit the rank_address from the place node (only has an effect when linking via lable member or place type).
2020-02-19 11:50:19 +03:00
Scenario: Boundaries with place tags are linked against places with same type
Given the places
| osm | class | type | admin | name | extra+place | geometry |
add testing for rank adaption while linking
2020-02-21 18:35:59 +03:00
| R13 | boundary | administrative | 4 | Berlin | city |poly-area:0.1 |
link against place nodes by place type If a boundary relation has no label member preferably link against a place node with the same place type. Also inherit the rank_address from the place node (only has an effect when linking via lable member or place type).
2020-02-19 11:50:19 +03:00
And the places
| osm | class | type | name | geometry |
| N2 | place | city | Berlin | 0.006 0.00001 |
When importing
Then placex contains
| object | linked_place_id |
| N2 | R13 |
And placex contains
| object | rank_address |
| R13 | 16 |
switch BDD tests to always use search API
2021-06-06 16:27:52 +03:00
When sending search query ""
add testing for rank adaption while linking
2020-02-21 18:35:59 +03:00
| city |
| Berlin |
Then results contain
| ID | osm_type | osm_id |
| 0 | R | 13 |
switch BDD tests to always use search API
2021-06-06 16:27:52 +03:00
When sending search query ""
add testing for rank adaption while linking
2020-02-21 18:35:59 +03:00
| state |
| Berlin |
Then results contain
| ID | osm_type | osm_id |
| 0 | R | 13 |
link against place nodes by place type If a boundary relation has no label member preferably link against a place node with the same place type. Also inherit the rank_address from the place node (only has an effect when linking via lable member or place type).
2020-02-19 11:50:19 +03:00
Scenario: Boundaries without place tags only link against same admin level
Given the places
| osm | class | type | admin | name | geometry |
add testing for rank adaption while linking
2020-02-21 18:35:59 +03:00
| R13 | boundary | administrative | 4 | Berlin |poly-area:0.1 |
link against place nodes by place type If a boundary relation has no label member preferably link against a place node with the same place type. Also inherit the rank_address from the place node (only has an effect when linking via lable member or place type).
2020-02-19 11:50:19 +03:00
And the places
| osm | class | type | name | geometry |
| N2 | place | city | Berlin | 0.006 0.00001 |
When importing
Then placex contains
| object | linked_place_id |
| N2 | - |
And placex contains
| object | rank_address |
add testing for rank adaption while linking
2020-02-21 18:35:59 +03:00
| R13 | 8 |
switch BDD tests to always use search API
2021-06-06 16:27:52 +03:00
When sending search query ""
add testing for rank adaption while linking
2020-02-21 18:35:59 +03:00
| state |
| Berlin |
Then results contain
| ID | osm_type | osm_id |
| 0 | R | 13 |
switch BDD tests to always use search API
2021-06-06 16:27:52 +03:00
When sending search query ""
add testing for rank adaption while linking
2020-02-21 18:35:59 +03:00
| city |
| Berlin |
Then results contain
| ID | osm_type | osm_id |
| 0 | N | 2 |
link against place nodes by place type If a boundary relation has no label member preferably link against a place node with the same place type. Also inherit the rank_address from the place node (only has an effect when linking via lable member or place type).
2020-02-19 11:50:19 +03:00
linked centroids must always be within geometry When using a linked place as centroid for a boundary, check first that it is really within the area. If it is outside, just keep the computed centroid because a centroid outside the area just causes havok. Fixes #1352.
2020-03-04 11:59:57 +03:00
# github #1352
Scenario: Do not use linked centroid when it is outside the area
Given the named places
| osm | class | type | admin | geometry |
| R13 | boundary | administrative | 4 | poly-area:0.01 |
And the named places
| osm | class | type | geometry |
| N2 | place | city | 0.1 0.1 |
And the relations
| id | members | tags+type |
| 13 | N2:label | boundary |
When importing
Then placex contains
| object | linked_place_id |
| N2 | R13 |
And placex contains
| object | centroid |
| R13 | in geometry |
place nodes can only be linked once against boundaries If a place node is already linked against a boundary, it should not be used for linking again. It is usually a sign of a mapping error, when there are multiple boundary candidates. This change just avoids inconsistent data in the database, it does not guarantee that the linking is against the more correct boundary.
2020-12-02 17:31:02 +03:00
Scenario: Place nodes can only be linked once
Given the named places
| osm | class | type | extra+wikidata | geometry |
| N2 | place | city | Q1234 | 0 0 |
And the named places
| osm | class | type | extra+wikidata | admin | geometry |
| R1 | boundary | administrative | Q1234 | 8 | poly-area:0.1 |
| R2 | boundary | administrative | Q1234 | 9 | poly-area:0.01 |
When importing
Then placex contains
| object | linked_place_id |
| N2 | R1 |
And placex contains
| object | extratags |
| R1 | 'linked_place' : 'city', 'wikidata': 'Q1234' |
| R2 | 'wikidata': 'Q1234' |
Reference in New Issue Copy Permalink