osm-search/Nominatim
1
1
Fork 0
mirror of https://github.com/osm-search/Nominatim.git synced 2024-11-25 19:35:02 +03:00
Code Issues Packages Projects Releases Wiki Activity

remove comma as name separator

Browse Source 
Commas are most of the time used as a part of a name, not to
separate multiple names.

See also #2950.
This commit is contained in:
Sarah Hoffmann 2023-01-22 21:10:12 +01:00
parent 56f0d678e3
commit 929a13d4cd
2 changed files with 13 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
settings/icu_tokenizer.yaml
View File

@ -38,6 +38,7 @@ sanitizers:
default-pattern: "[A-Z0-9- ]{3,12}" default-pattern: "[A-Z0-9- ]{3,12}"
- step: clean-tiger-tags - step: clean-tiger-tags
- step: split-name-list - step: split-name-list
delimiters: ;
- step: strip-brace-terms - step: strip-brace-terms
- step: tag-analyzer-by-language - step: tag-analyzer-by-language
filter-kind: [".*name.*"] filter-kind: [".*name.*"]

19
test/bdd/db/import/search_name.feature
View File

@ -2,21 +2,26 @@
Feature: Creation of search terms Feature: Creation of search terms
Tests that search_name table is filled correctly Tests that search_name table is filled correctly
Scenario Outline: Comma- and semicolon separated names appear as full names Scenario: Semicolon-separated names appear as separate full names
Given the places Given the places
| osm | class | type | name+alt_name | | osm | class | type | name+alt_name |
| N1 | place | city | New York<sep>Big Apple | | N1 | place | city | New York; Big Apple |
When importing When importing
Then search_name contains Then search_name contains
| object | name_vector | | object | name_vector |
| N1 | #New York, #Big Apple | | N1 | #New York, #Big Apple |
Examples: @fail-legacy
| sep | Scenario: Comma-separated names appear as a single full name
| , | Given the places
| ; | | osm | class | type | name+alt_name |
| N1 | place | city | New York, Big Apple |
When importing
Then search_name contains
| object | name_vector |
| N1 | #New York Big Apple |
Scenario Outline: Name parts before brackets appear as full names Scenario: Name parts before brackets appear as full names
Given the places Given the places
| osm | class | type | name+name | | osm | class | type | name+name |
| N1 | place | city | Halle (Saale) | | N1 | place | city | Halle (Saale) |