From a0e85cc17c9d43c8472aba937a0134dd719456f1 Mon Sep 17 00:00:00 2001 From: Sarah Hoffmann Date: Tue, 25 May 2021 19:16:22 +0200 Subject: [PATCH] only initialise tokenizer for refresh functions where needed Fixes #2347. --- nominatim/cli.py | 2 +- nominatim/clicmd/refresh.py | 21 ++++++++++++++++----- 2 files changed, 17 insertions(+), 6 deletions(-) diff --git a/nominatim/cli.py b/nominatim/cli.py index c66e78d3..533a920e 100644 --- a/nominatim/cli.py +++ b/nominatim/cli.py @@ -263,7 +263,7 @@ def get_set_parser(**kwargs): parser.add_subcommand('add-data', UpdateAddData) parser.add_subcommand('index', clicmd.UpdateIndex) - parser.add_subcommand('refresh', clicmd.UpdateRefresh) + parser.add_subcommand('refresh', clicmd.UpdateRefresh()) parser.add_subcommand('admin', clicmd.AdminFuncs) diff --git a/nominatim/clicmd/refresh.py b/nominatim/clicmd/refresh.py index e696e7b6..386516d6 100644 --- a/nominatim/clicmd/refresh.py +++ b/nominatim/clicmd/refresh.py @@ -19,6 +19,8 @@ class UpdateRefresh: These functions must not be run in parallel with other update commands. """ + def __init__(self): + self.tokenizer = None @staticmethod def add_args(parser): @@ -43,16 +45,15 @@ class UpdateRefresh: group.add_argument('--enable-debug-statements', action='store_true', help='Enable debug warning statements in functions') - @staticmethod - def run(args): + + def run(self, args): from ..tools import refresh, postcodes - from ..tokenizer import factory as tokenizer_factory from ..indexer.indexer import Indexer - tokenizer = tokenizer_factory.get_tokenizer_for_db(args.config) if args.postcodes: LOG.warning("Update postcodes centroid") + tokenizer = self._get_tokenizer(args.config) postcodes.update_postcodes(args.config.get_libpq_dsn(), args.project_dir, tokenizer) indexer = Indexer(args.config.get_libpq_dsn(), tokenizer, @@ -74,7 +75,7 @@ class UpdateRefresh: with connect(args.config.get_libpq_dsn()) as conn: refresh.create_functions(conn, args.config, args.diffs, args.enable_debug_statements) - tokenizer.update_sql_functions(args.config) + self._get_tokenizer(args.config).update_sql_functions(args.config) if args.wiki_data: data_path = Path(args.config.WIKIPEDIA_DATA_PATH @@ -96,4 +97,14 @@ class UpdateRefresh: LOG.warning('Setting up website directory at %s', webdir) with connect(args.config.get_libpq_dsn()) as conn: refresh.setup_website(webdir, args.config, conn) + return 0 + + + def _get_tokenizer(self, config): + if self.tokenizer is None: + from ..tokenizer import factory as tokenizer_factory + + self.tokenizer = tokenizer_factory.get_tokenizer_for_db(config) + + return self.tokenizer