This commit is contained in:
gemo1011 2018-05-22 12:22:15 +02:00
parent 6b8c99a275
commit ab5bcd6d2f
2 changed files with 38 additions and 36 deletions

View File

@ -164,19 +164,21 @@ class PlaceLookup
$aResults = $this->lookup(array($iPlaceID => new Result($iPlaceID))); $aResults = $this->lookup(array($iPlaceID => new Result($iPlaceID)));
return sizeof($aResults) ? reset($aResults) : null; return empty($aResults) ? null : reset($aResults);
} }
public function lookup($aResults, $iMinRank = 0, $iMaxRank = 30) public function lookup($aResults, $iMinRank = 0, $iMaxRank = 30)
{ {
if (!sizeof($aResults)) { Debug::newFunction('Place lookup');
if (empty($aResults)) {
return array(); return array();
} }
$aSubSelects = array(); $aSubSelects = array();
$sPlaceIDs = Result::joinIdsByTable($aResults, Result::TABLE_PLACEX); $sPlaceIDs = Result::joinIdsByTable($aResults, Result::TABLE_PLACEX);
if (CONST_Debug) var_dump('PLACEX', $sPlaceIDs);
if ($sPlaceIDs) { if ($sPlaceIDs) {
Debug::printVar('Ids from placex', $sPlaceIDs);
$sSQL = 'SELECT '; $sSQL = 'SELECT ';
$sSQL .= ' osm_type,'; $sSQL .= ' osm_type,';
$sSQL .= ' osm_id,'; $sSQL .= ' osm_id,';
@ -246,6 +248,7 @@ class PlaceLookup
// postcode table // postcode table
$sPlaceIDs = Result::joinIdsByTable($aResults, Result::TABLE_POSTCODE); $sPlaceIDs = Result::joinIdsByTable($aResults, Result::TABLE_POSTCODE);
if ($sPlaceIDs) { if ($sPlaceIDs) {
Debug::printVar('Ids from location_postcode', $sPlaceIDs);
$sSQL = 'SELECT'; $sSQL = 'SELECT';
$sSQL .= " 'P' as osm_type,"; $sSQL .= " 'P' as osm_type,";
$sSQL .= ' (SELECT osm_id from placex p WHERE p.place_id = lp.parent_place_id) as osm_id,'; $sSQL .= ' (SELECT osm_id from placex p WHERE p.place_id = lp.parent_place_id) as osm_id,';
@ -276,6 +279,7 @@ class PlaceLookup
if (CONST_Use_US_Tiger_Data) { if (CONST_Use_US_Tiger_Data) {
$sPlaceIDs = Result::joinIdsByTable($aResults, Result::TABLE_TIGER); $sPlaceIDs = Result::joinIdsByTable($aResults, Result::TABLE_TIGER);
if ($sPlaceIDs) { if ($sPlaceIDs) {
Debug::printVar('Ids from Tiger table', $sPlaceIDs);
$sHousenumbers = Result::sqlHouseNumberTable($aResults, Result::TABLE_TIGER); $sHousenumbers = Result::sqlHouseNumberTable($aResults, Result::TABLE_TIGER);
// Tiger search only if a housenumber was searched and if it was found // Tiger search only if a housenumber was searched and if it was found
// (realized through a join) // (realized through a join)
@ -321,6 +325,7 @@ class PlaceLookup
// osmline - interpolated housenumbers // osmline - interpolated housenumbers
$sPlaceIDs = Result::joinIdsByTable($aResults, Result::TABLE_OSMLINE); $sPlaceIDs = Result::joinIdsByTable($aResults, Result::TABLE_OSMLINE);
if ($sPlaceIDs) { if ($sPlaceIDs) {
Debug::printVar('Ids from interpolation', $sPlaceIDs);
$sHousenumbers = Result::sqlHouseNumberTable($aResults, Result::TABLE_OSMLINE); $sHousenumbers = Result::sqlHouseNumberTable($aResults, Result::TABLE_OSMLINE);
// interpolation line search only if a housenumber was searched // interpolation line search only if a housenumber was searched
// (realized through a join) // (realized through a join)
@ -406,16 +411,13 @@ class PlaceLookup
} }
} }
if (CONST_Debug) var_dump($aSubSelects); if (empty($aSubSelects)) {
if (!sizeof($aSubSelects)) {
return array(); return array();
} }
$aPlaces = chksql( $sSQL = join(' UNION ', $aSubSelects);
$this->oDB->getAll(join(' UNION ', $aSubSelects)), Debug::printSQL($sSQL);
'Could not lookup place' $aPlaces = chksql($this->oDB->getAll($sSQL), 'Could not lookup place');
);
$aClassType = getClassTypes(); $aClassType = getClassTypes();
foreach ($aPlaces as &$aPlace) { foreach ($aPlaces as &$aPlace) {
@ -457,12 +459,12 @@ class PlaceLookup
$aPlace['addresstype'] = $sAddressType; $aPlace['addresstype'] = $sAddressType;
} }
if (CONST_Debug) var_dump($aPlaces); Debug::printVar('Places', $aPlaces);
return $aPlaces; return $aPlaces;
} }
private function getAddressDetails($iPlaceID, $bAll, $sHousenumber) public function getAddressDetails($iPlaceID, $bAll = false, $sHousenumber = -1)
{ {
$sSQL = 'SELECT *,'; $sSQL = 'SELECT *,';
$sSQL .= ' get_name_by_language(name,'.$this->aLangPrefOrderSql.') as localname'; $sSQL .= ' get_name_by_language(name,'.$this->aLangPrefOrderSql.') as localname';

View File

@ -41,7 +41,7 @@ if ($sOsmType && $iOsmId > 0) {
if ($oLookup) { if ($oLookup) {
$aPlaces = $oPlaceLookup->lookup(array($oLookup->iId => $oLookup)); $aPlaces = $oPlaceLookup->lookup(array($oLookup->iId => $oLookup));
if (sizeof($aPlaces)) { if (!empty($aPlaces)) {
$aPlace = reset($aPlaces); $aPlace = reset($aPlaces);
} }
} }
@ -55,16 +55,14 @@ if (isset($aPlace)) {
$aPlace['place_id'], $aPlace['place_id'],
$aPlace['lon'], $aPlace['lon'],
$aPlace['lat'], $aPlace['lat'],
$fRadius, $fRadius
$fLat,
$fLon
); );
if ($aOutlineResult) { if ($aOutlineResult) {
$aPlace = array_merge($aPlace, $aOutlineResult); $aPlace = array_merge($aPlace, $aOutlineResult);
} }
} else { } else {
$aPlace = []; $aPlace = array();
} }
@ -74,8 +72,10 @@ if (CONST_Debug) {
} }
if ($sOutputFormat == 'html') { if ($sOutputFormat == 'html') {
$sDataDate = chksql($oDB->getOne("select TO_CHAR(lastimportdate - '2 minutes'::interval,'YYYY/MM/DD HH24:MI')||' GMT' from import_status limit 1")); $sDataDate = chksql($oDB->getOne("select TO_CHAR(lastimportdate,'YYYY/MM/DD HH24:MI')||' GMT' from import_status limit 1"));
$sTileURL = CONST_Map_Tile_URL; $sTileURL = CONST_Map_Tile_URL;
$sTileAttribution = CONST_Map_Tile_Attribution; $sTileAttribution = CONST_Map_Tile_Attribution;
} }
include(CONST_BasePath.'/lib/template/address-'.$sOutputFormat.'.php');
$sOutputTemplate = ($sOutputFormat=='jsonv2' ? 'json' : $sOutputFormat);
include(CONST_BasePath.'/lib/template/address-'.$sOutputTemplate.'.php');