mirror of
https://github.com/osm-search/Nominatim.git
synced 2024-08-16 22:50:24 +03:00
PHP linter looks for phpcs.xml by default. Also removed a couple of exceptions that didnt cause warnings
This commit is contained in:
parent
4a321487f3
commit
cfed4bc204
63
phpcs.xml
63
phpcs.xml
@ -20,17 +20,20 @@
|
||||
</rule>
|
||||
|
||||
|
||||
<!-- "A file should declare new symbols (classes, functions, constants, etc.) and cause no
|
||||
other side effects, or it should execute logic with side effects, but should not do both."
|
||||
... we have too many script and includes to be able to enforce that.
|
||||
-->
|
||||
<rule ref="PSR1.Files.SideEffects.FoundWithSymbols">
|
||||
<severity>0</severity>
|
||||
</rule>
|
||||
|
||||
|
||||
|
||||
<!-- **************************************************************
|
||||
DOCUMENTATION
|
||||
************************************************************** -->
|
||||
|
||||
<rule ref="PEAR.Commenting.FileComment.Missing">
|
||||
<severity>0</severity>
|
||||
</rule>
|
||||
<rule ref="PEAR.Commenting.ClassComment.Missing">
|
||||
<severity>0</severity>
|
||||
</rule>
|
||||
<rule ref="PEAR.Commenting.FunctionComment.Missing">
|
||||
<severity>0</severity>
|
||||
</rule>
|
||||
@ -42,6 +45,12 @@
|
||||
COMMENTS
|
||||
************************************************************** -->
|
||||
|
||||
<!-- any comments in the lines before function() are better than forcing
|
||||
a PHPdoc style right now -->
|
||||
<rule ref="PEAR.Commenting.FunctionComment.WrongStyle">
|
||||
<severity>0</severity>
|
||||
</rule>
|
||||
|
||||
<!-- We allow comments after statements -->
|
||||
<rule ref="Squiz.Commenting.PostStatementComment.Found">
|
||||
<severity>0</severity>
|
||||
@ -50,6 +59,10 @@
|
||||
<rule ref="Squiz.Commenting.InlineComment.NoSpaceBefore">
|
||||
<severity>0</severity>
|
||||
</rule>
|
||||
<!-- blank lines after inline comments are fine -->
|
||||
<rule ref="Squiz.Commenting.InlineComment.SpacingAfter">
|
||||
<severity>0</severity>
|
||||
</rule>
|
||||
|
||||
<!-- Comments don't have to start uppercase -->
|
||||
<rule ref="Squiz.Commenting.InlineComment.NotCapital">
|
||||
@ -59,16 +72,10 @@
|
||||
<rule ref="Squiz.Commenting.InlineComment.InvalidEndChar">
|
||||
<severity>0</severity>
|
||||
</rule>
|
||||
|
||||
<!-- we don't need '} // functionname()' at end of large blocks -->
|
||||
<rule ref="Squiz.Commenting.ClosingDeclarationComment.Missing">
|
||||
<!-- Empty comments are fine -->
|
||||
<rule ref="Squiz.Commenting.InlineComment.Empty">
|
||||
<severity>0</severity>
|
||||
</rule>
|
||||
<!-- .. same for conditions -->
|
||||
<rule ref="Squiz.Commenting.LongConditionClosingComment.Missing">
|
||||
<severity>0</severity>
|
||||
</rule>
|
||||
|
||||
|
||||
|
||||
|
||||
@ -86,6 +93,9 @@
|
||||
<rule ref="Generic.Formatting.MultipleStatementAlignment.NotSame">
|
||||
<severity>0</severity>
|
||||
</rule>
|
||||
<rule ref="Generic.Formatting.MultipleStatementAlignment.NotSameWarning">
|
||||
<severity>0</severity>
|
||||
</rule>
|
||||
|
||||
<!-- Aligned looks nicer, but causes too many warnings currently -->
|
||||
<rule ref="Squiz.Arrays.ArrayDeclaration.DoubleArrowNotAligned">
|
||||
@ -131,12 +141,6 @@
|
||||
<rule ref="Generic.ControlStructures.InlineControlStructure.NotAllowed">
|
||||
<severity>0</severity>
|
||||
</rule>
|
||||
<rule ref="Generic.ControlStructures.InlineControlStructure.Discouraged">
|
||||
<severity>0</severity>
|
||||
</rule>
|
||||
<rule ref="Squiz.PHP.DisallowInlineIf.Found">
|
||||
<severity>0</severity>
|
||||
</rule>
|
||||
|
||||
<!-- We allow "if (a)". No need for "if (a === TRUE)" -->
|
||||
<rule ref="Squiz.Operators.ComparisonOperatorUsage.ImplicitTrue">
|
||||
@ -147,25 +151,6 @@
|
||||
<severity>0</severity>
|
||||
</rule>
|
||||
|
||||
<!-- We allow
|
||||
if (a)
|
||||
{
|
||||
-->
|
||||
<rule ref="PEAR.ControlStructures.MultiLineCondition.NewlineBeforeOpenBrace">
|
||||
<severity>0</severity>
|
||||
</rule>
|
||||
<!-- ... same -->
|
||||
<rule ref="Squiz.WhiteSpace.ControlStructureSpacing.NoLineAfterClose">
|
||||
<severity>0</severity>
|
||||
</rule>
|
||||
<!-- ... same for foreach/while etc -->
|
||||
<rule ref="PEAR.ControlStructures.ControlSignature">
|
||||
<severity>0</severity>
|
||||
</rule>
|
||||
<!-- ... same -->
|
||||
<rule ref="Squiz.WhiteSpace.FunctionClosingBraceSpace.SpacingBeforeClose">
|
||||
<severity>0</severity>
|
||||
</rule>
|
||||
|
||||
|
||||
</ruleset>
|
||||
|
Loading…
Reference in New Issue
Block a user