Sarah Hoffmann
6e4b7eb966
do not block deletion of large highway areas
...
Deletion of areas should only e blocked for addressable features.
Streets and POIs do not have a large impact on updates.
2020-08-28 09:49:21 +02:00
Sarah Hoffmann
be6ecc388c
add support for place=square
...
Squares are now addressable (on address level 25) and thus can
be attached to a house number via addr:place. Needed to increase
the rank range for matching up addr:place to 25.
2020-08-26 12:12:52 +02:00
Sarah Hoffmann
d730e179bf
tests: use larger grid to avoid rouding errors
2020-08-22 16:04:24 +02:00
Sarah Hoffmann
d6ff7475f1
make sure that addr:* tags can always be searched for
...
Always add contents of addr:* tags into address part of the search
table, even when there is no corresponding other name. This keeps
search tolerant to the kind of tagging where parts show up in the
address that have no corresponding object in the database or where
it is only an unaddressable object.
2020-08-19 11:44:10 +02:00
Sarah Hoffmann
e21a707166
remove linked_place from extratags when updating
...
Before updating an admin boundary we need to make sure that any
artificially generated 'linked_place' entry is removed from the
extratags column. This ensures that the place designation does
not linger when a linked place disappears and that it is updated
when the linking changes.
2020-08-13 16:59:11 +02:00
Sarah Hoffmann
06aa0f0b76
use address rank for address forming when available
2020-08-12 22:22:24 +02:00
Sarah Hoffmann
fb8bb30144
boundary address ranks must not go above 25
...
Fixes #1914 .
2020-08-12 22:22:24 +02:00
Sarah Hoffmann
7429a33818
add simple tests for address rank computation
2020-08-12 22:22:24 +02:00
Sarah Hoffmann
f29dc7d7ac
Merge pull request #1865 from mtmail/how-to-import-test-db
...
test/README.md - more instructions how to import test db
2020-08-04 14:31:19 +02:00
Sarah Hoffmann
1347abb1e7
be more strict what areas make up an address
...
Exclude boundaries that touch a line in only one point and
that touch areas only along the boundary.
Fixes #1900 .
2020-08-04 12:08:50 +02:00
Sarah Hoffmann
2cb85e48b4
adapt test results to new ranking
2020-08-03 16:57:22 +02:00
marc tobias
01b009ff24
test/README.md - more instructions how to import test db
2020-07-31 16:50:27 +02:00
Sarah Hoffmann
9a204f6284
test: make road really cross the boundary
2020-07-26 15:57:07 +02:00
Sarah Hoffmann
6e4ee160ee
adapt tests to new search ranks
2020-06-17 10:53:11 +02:00
Sarah Hoffmann
8218da27b3
adapt tests to new ranks
2020-05-23 19:40:41 +02:00
Sarah Hoffmann
aa4bd00631
Adapt boundary labels for Sweden and Norway
...
This also gives us the correct labels for address output in
json and xml.
2020-05-23 16:19:27 +02:00
Sarah Hoffmann
cadbdaff18
fix style
2020-05-18 22:20:36 +02:00
Sarah Hoffmann
57510f517a
adapt tests to modified address types
2020-05-17 16:53:33 +02:00
Sarah Hoffmann
528fe6553f
adapt php tests
...
Also fixes some errors found by the tests.
2020-05-17 16:46:45 +02:00
Simon Will
14dba39157
Use assertEqualsWithDelta for float comparisons
...
PHPUnit 7.3 introduced the functions assertEqualsWithDelta for comparing
floats with a delta. The old four-argument version of assertEquals is
deprecated in PHPUnit 8 and removed in PHPUnit 9.
This commit means that the tests will fail with PHPUnit < 7.3 because
assertEqualsWithDelta is not defined there.
2020-05-05 23:43:09 +02:00
Simon Will
43fd2a7423
Declare return type of testcase setUp method
...
PHPUnit 7 changed the signature of the TestCase methods to include the
return type.
2020-05-05 23:40:18 +02:00
Sarah Hoffmann
65ee7a8002
Merge pull request #1754 from mtmail/nominatim-db-tests-against-postgres
...
Nominatim::DB tests against separate postgresql database
2020-04-26 10:20:30 +02:00
marc tobias
a5d0657d9b
lonvia PR feedback
2020-04-26 03:33:15 +02:00
Sarah Hoffmann
0b0349f746
Merge pull request #1752 from mtmail/new-oo-shell-class
...
new PHP Nominatim\Shell class to wrap shell escaping
2020-04-25 16:48:04 +02:00
Sarah Hoffmann
207efe700f
highway:construction should appear as 'road' in the address list
...
Fixes #1763 .
2020-04-22 09:08:33 +02:00
marc tobias
38c21de0ee
Nominatim::DB tests against separate postgresql database
2020-04-13 18:01:37 +02:00
marc tobias
fc40939775
new PHP Nominatim\Shell class to wrap shell escaping
2020-04-12 03:50:40 +02:00
Sarah Hoffmann
ef47515420
make admin levels 3 and 7 distinct ones in addresses
...
There really is no need to conflate these two levels as they
are in use in various countries.
Also adds province as a distinct place.
Fixes #1736 .
2020-04-10 22:58:11 +02:00
Sarah Hoffmann
98be5bf637
adapt tests to geocodejson format adaptions
2020-04-08 11:19:43 +02:00
Rahul
eb2d816f2a
Added test cases for whitespaces in LatLon
2020-04-04 00:53:40 +05:30
Sarah Hoffmann
0d189ac5df
Merge pull request #1733 from krahulreddy/whitespaces-considered-as-single-space
...
Support whitespace characters(x09-x0d) as single space
2020-04-03 18:01:47 +02:00
K Rahul Reddy
7aa2df5389
Support whitespace characters(x09-x0d) as single space
2020-04-02 05:04:40 +05:30
Sarah Hoffmann
975ef0b305
re-add district to geocodejson
2020-04-01 21:24:42 +02:00
Sarah Hoffmann
8150c3602b
add tests for geocodejson address fields
2020-04-01 11:14:48 +02:00
Sarah Hoffmann
19948c378a
adapt tests to new borough ranking
2020-03-30 23:04:20 +02:00
marc tobias
7a94872413
remove polygon=1 (polypoints) feature
2020-03-29 21:58:11 +02:00
Sarah Hoffmann
d56c69dd01
adapt API tests to place linkage changes
...
The missing district is due to a data error for wikidata tags.
2020-03-25 11:38:31 +01:00
Sarah Hoffmann
78526a33b4
Remove linkees from search_name
...
Fixes #722
2020-03-04 11:36:39 +01:00
Sarah Hoffmann
6d431aebb7
linked centroids must always be within geometry
...
When using a linked place as centroid for a boundary, check
first that it is really within the area. If it is outside,
just keep the computed centroid because a centroid outside the
area just causes havok.
Fixes #1352 .
2020-03-04 09:59:57 +01:00
Sarah Hoffmann
acd8ca2ebd
add testing for rank adaption while linking
2020-02-28 15:22:48 +01:00
Sarah Hoffmann
06fdfad89e
link against place nodes by place type
...
If a boundary relation has no label member preferably
link against a place node with the same place type.
Also inherit the rank_address from the place node (only
has an effect when linking via lable member or place type).
2020-02-28 15:22:48 +01:00
Sarah Hoffmann
00ca493f33
move linked place type into linked_place extratags
...
Using linked_place means that we don't overwrite any
place tags on the boundary. This is important when we
wanto to use the information for linking.
2020-02-28 15:22:48 +01:00
Sarah Hoffmann
5220a92be4
adapt API tests
2020-02-22 16:46:03 +01:00
marc tobias
7fd9d0eeef
unit tests for ParameterParser::hasSetAny
2020-02-19 16:55:17 +01:00
Sarah Hoffmann
6073d948e6
fix duplicate keys in tests
...
The tests suddenly failed because the unique key constraint
is more strict and does no longer include the type.
2020-02-12 11:29:33 +01:00
marc tobias
932ac23f18
document how to extract subset of TIGER data needed for API tests
2020-02-11 18:50:27 +01:00
Sarah Hoffmann
3a3f9b3496
fix formatting
2020-02-09 16:57:55 +01:00
Sarah Hoffmann
c36fd72f99
use detailsPermaLink function on main website as well
2020-02-09 16:05:22 +01:00
Sarah Hoffmann
57ae3d03a1
return place_id link to details when not an OSM object
...
Stop-gap solution to find the right object for Tiger and
interpolation objects.
2020-02-09 15:45:38 +01:00
Sarah Hoffmann
4856f56d61
adapt test to change in hamlet classification
2020-01-23 22:26:47 +01:00