ossf/scorecard
1
1
Fork 0
mirror of https://github.com/ossf/scorecard.git synced 2024-09-19 04:57:14 +03:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

fix (#1331)

Browse Source
This commit is contained in:
laurentsimon 2021-12-01 06:43:25 -08:00 committed by GitHub
parent fb3d483c7d
commit 2d6bf97dd8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
checks/branch_protection.go
View File

@ -80,8 +80,9 @@ type scoresInfo struct {
// Maximum score depending on whether admin token is used.
type levelScore struct {
scores scoresInfo // Score result for a branch.
maxes scoresInfo // Maximum possible score for a branch.
scores scoresInfo // Score result for a branch.
maxes scoresInfo // Maximum possible score for a branch.
protected bool // Protection enabled on the branch.
}
//nolint:gochecknoinits
@ -152,6 +153,10 @@ func getMaxScores(scores []levelScore) (scoresInfo, error) {
score := scores[0]
for _, s := range scores[1:] {
// Only validate the maximum scores if both entries have the same protection status.
if s.protected != score.protected {
continue
}
if err := validateMaxScore(score.maxes.basic, s.maxes.basic); err != nil {
return scoresInfo{}, err
}
@ -397,6 +402,7 @@ func checkReleaseAndDevBranchProtection(
}
// The branch is protected. Check the protection.
score.protected = true
score.scores.basic, score.maxes.basic = basicNonAdminProtection(&branch.BranchProtectionRule, b, dl)
score.scores.adminBasic, score.maxes.adminBasic = basicAdminProtection(&branch.BranchProtectionRule, b, dl)
score.scores.review, score.maxes.review = nonAdminReviewProtection(&branch.BranchProtectionRule)