ossf/scorecard
1
1
Fork 0
mirror of https://github.com/ossf/scorecard.git synced 2024-08-15 19:30:40 +03:00
Code Issues Actions 7 Packages Projects Releases Wiki Activity

Fix lint issues: goerr113 linter (#491)

Browse Source 
Co-authored-by: Azeem Shaikh <azeemshaikh38@gmail.com>
This commit is contained in:
Chris McGehee 2021-05-22 12:36:47 -07:00 committed by GitHub
parent 0c636b0f5f
commit 2e7a71fbf2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 21 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.golangci.yml
View File

@ -23,7 +23,7 @@ linters:
- gocyclo
- godot
- godox
# - goerr113
- goerr113
- gofmt
- gofumpt
- goheader

4
checker/check_result.go
View File

@ -18,6 +18,8 @@ import "errors"
const MaxResultConfidence = 10
var ErrorDemoninatorZero = errors.New("internal error: denominator is 0")
type CheckResult struct {
Error error `json:"-"`
Name string
@ -65,7 +67,7 @@ func MakeRetryResult(name string, err error) CheckResult {
func MakeProportionalResult(name string, numerator int, denominator int,
threshold float32) CheckResult {
if denominator == 0 {
return MakeInconclusiveResult(name, errors.New("internal error: denominator is 0"))
return MakeInconclusiveResult(name, ErrorDemoninatorZero)
}
if numerator == 0 {
return CheckResult{

6
checks/code_review.go
View File

@ -24,6 +24,8 @@ import (
const codeReviewStr = "Code-Review"
var ErrorNoReviews = errors.New("no reviews found")
//nolint:gochecknoinits
func init() {
registerCheck(codeReviewStr, DoesCodeReview)
@ -147,7 +149,7 @@ func ProwCodeReview(c *checker.CheckRequest) checker.CheckResult {
}
if totalReviewed == 0 {
return checker.MakeInconclusiveResult(codeReviewStr, errors.New("no reviews found"))
return checker.MakeInconclusiveResult(codeReviewStr, ErrorNoReviews)
}
c.Logf("prow code reviews found")
return checker.MakeProportionalResult(codeReviewStr, totalReviewed, totalMerged, .75)
@ -187,7 +189,7 @@ func CommitMessageHints(c *checker.CheckRequest) checker.CheckResult {
}
if totalReviewed == 0 {
return checker.MakeInconclusiveResult(codeReviewStr, errors.New("no reviews found"))
return checker.MakeInconclusiveResult(codeReviewStr, ErrorNoReviews)
}
c.Logf("code reviews found")
return checker.MakeProportionalResult(codeReviewStr, totalReviewed, total, .75)

10
checks/sast.go
View File

@ -23,7 +23,11 @@ import (
const sastStr = "SAST"
var sastTools map[string]bool = map[string]bool{"github-code-scanning": true, "sonarcloud": true}
var (
sastTools map[string]bool = map[string]bool{"github-code-scanning": true, "sonarcloud": true}
ErrorNoChecks = errors.New("no check runs found")
ErrorNoMerges = errors.New("no merges found")
)
//nolint:gochecknoinits
func init() {
@ -58,7 +62,7 @@ func SASTToolInCheckRuns(c *checker.CheckRequest) checker.CheckResult {
return checker.MakeRetryResult(sastStr, err)
}
if crs == nil {
return checker.MakeInconclusiveResult(sastStr, errors.New("no check runs found"))
return checker.MakeInconclusiveResult(sastStr, ErrorNoChecks)
}
for _, cr := range crs.CheckRuns {
if cr.GetStatus() != "completed" {
@ -75,7 +79,7 @@ func SASTToolInCheckRuns(c *checker.CheckRequest) checker.CheckResult {
}
}
if totalTested == 0 {
return checker.MakeInconclusiveResult(sastStr, errors.New("no merges found"))
return checker.MakeInconclusiveResult(sastStr, ErrorNoMerges)
}
return checker.MakeProportionalResult(sastStr, totalTested, totalMerged, .75)
}

4
checks/signed_releases.go
View File

@ -27,6 +27,8 @@ const (
releaseLookBackDays = 5
)
var ErrorNoReleases = errors.New("no releases found")
//nolint:gochecknoinits
func init() {
registerCheck(signedReleasesStr, SignedReleases)
@ -76,7 +78,7 @@ func SignedReleases(c *checker.CheckRequest) checker.CheckResult {
if totalReleases == 0 {
c.Logf("no releases found")
return checker.MakeInconclusiveResult(signedReleasesStr, errors.New("no releases found"))
return checker.MakeInconclusiveResult(signedReleasesStr, ErrorNoReleases)
}
c.Logf("found signed artifacts for %d out of %d releases", totalSigned, totalReleases)

4
checks/signed_tags.go
View File

@ -26,6 +26,8 @@ const (
tagLookBack = 5
)
var ErrorNoTags = errors.New("no signed tags found")
//nolint:gochecknoinits
func init() {
registerCheck(signedTagsStr, SignedTags)
@ -75,7 +77,7 @@ func SignedTags(c *checker.CheckRequest) checker.CheckResult {
if totalTags == 0 {
c.Logf("no tags found")
return checker.MakeInconclusiveResult(signedTagsStr, errors.New("no signed tags found"))
return checker.MakeInconclusiveResult(signedTagsStr, ErrorNoTags)
}
c.Logf("found %d out of %d verified tags", totalSigned, totalTags)