🌱Fix lint issues: gochecknoinits linter (#485)

* Fix lint issues: gochecknoinits linter

* Fix lint issues: gochecknoinits linter

.golangci.yml

@@ -16,7 +16,7 @@ linters:
     - errcheck
     - exhaustive
     - exportloopref
-    # - gochecknoinits
+    - gochecknoinits
     - gocognit
     - goconst
     - gocritic

CONTRIBUTING.md

@@ -149,10 +149,12 @@ type CheckFn func(*c.Checker) CheckResult
 Checks are registered in an init function:
 
 ```golang
-    AllChecks = append(AllChecks, NamedCheck{
-        Name: "Code-Review",
-        Fn:   DoesCodeReview,
-    })
+const codeReviewStr = "Code-Review"
+
+//nolint:gochecknoinits
+func init() {
+	registerCheck(codeReviewStr, DoesCodeReview)
+}
 ```
 
 ### Updating Docs

checks/active.go

@@ -26,6 +26,7 @@ const (
 	lookbackDays = 90
 )
 
+//nolint:gochecknoinits
 func init() {
 	registerCheck(activeStr, IsActive)
 }

checks/branch_protected.go

@@ -24,6 +24,7 @@ const (
 	minReviews          = 1
 )
 
+//nolint:gochecknoinits
 func init() {
 	registerCheck(branchProtectionStr, BranchProtection)
 }

checks/ci_tests.go

@@ -36,6 +36,7 @@ const (
 	githubCheckRuns
 )
 
+//nolint:gochecknoinits
 func init() {
 	registerCheck(ciTestsStr, CITests)
 }

checks/cii_best_practices.go

@@ -25,6 +25,7 @@ import (
 
 const ciiBestPracticesStr = "CII-Best-Practices"
 
+//nolint:gochecknoinits
 func init() {
 	registerCheck(ciiBestPracticesStr, CIIBestPractices)
 }

checks/code_review.go

@@ -24,6 +24,7 @@ import (
 
 const codeReviewStr = "Code-Review"
 
+//nolint:gochecknoinits
 func init() {
 	registerCheck(codeReviewStr, DoesCodeReview)
 }

checks/contributors.go

@@ -27,6 +27,7 @@ const (
 	contributorsStr         = "Contributors"
 )
 
+//nolint:gochecknoinits
 func init() {
 	registerCheck(contributorsStr, Contributors)
 }

checks/frozen_deps.go

@@ -33,6 +33,7 @@ var ErrInvalidDockerfile = errors.New("invalid docker file")
 // ErrEmptyFile : Invalid docker file.
 var ErrEmptyFile = errors.New("file has no content")
 
+//nolint:gochecknoinits
 func init() {
 	registerCheck(frozenDepsStr, FrozenDeps)
 }

checks/fuzzing.go

@@ -23,6 +23,7 @@ import (
 
 const fuzzingStr = "Fuzzing"
 
+//nolint:gochecknoinits
 func init() {
 	registerCheck(fuzzingStr, Fuzzing)
 }

checks/packaging.go

@@ -25,6 +25,7 @@ import (
 
 const packagingStr = "Packaging"
 
+//nolint:gochecknoinits
 func init() {
 	registerCheck(packagingStr, Packaging)
 }

checks/pull_requests.go

@@ -23,6 +23,7 @@ import (
 
 const pullRequestsStr = "Pull-Requests"
 
+//nolint:gochecknoinits
 func init() {
 	registerCheck(pullRequestsStr, PullRequests)
 }

checks/sast.go

@@ -25,6 +25,7 @@ const sastStr = "SAST"
 
 var sastTools map[string]bool = map[string]bool{"github-code-scanning": true, "sonarcloud": true}
 
+//nolint:gochecknoinits
 func init() {
 	registerCheck(sastStr, SAST)
 }

checks/security_policy.go

@@ -22,6 +22,7 @@ import (
 
 const securityPolicyStr = "Security-Policy"
 
+//nolint:gochecknoinits
 func init() {
 	registerCheck(securityPolicyStr, SecurityPolicy)
 }

checks/signed_releases.go

@@ -27,6 +27,7 @@ const (
 	releaseLookBackDays = 5
 )
 
+//nolint:gochecknoinits
 func init() {
 	registerCheck(signedReleasesStr, SignedReleases)
 }

checks/signed_tags.go

@@ -26,6 +26,7 @@ const (
 	tagLookBack   = 5
 )
 
+//nolint:gochecknoinits
 func init() {
 	registerCheck(signedTagsStr, SignedTags)
 }

cmd/root.go

@@ -267,6 +267,7 @@ func fetchGitRepositoryFromRubyGems(packageName string) (string, error) {
 	return v.SourceCodeURI, nil
 }
 
+//nolint:gochecknoinits
 func init() {
 	// Add the zap flag manually
 	rootCmd.PersistentFlags().AddGoFlagSet(goflag.CommandLine)

cmd/serve.go

@@ -32,6 +32,7 @@ import (
 	"go.uber.org/zap"
 )
 
+//nolint:gochecknoinits
 func init() {
 	rootCmd.AddCommand(serveCmd)
 }