mirror of
https://github.com/ossf/scorecard.git
synced 2024-10-26 10:28:10 +03:00
Add new linter: errorlint
This commit is contained in:
parent
934c741b8d
commit
524a187b31
@ -16,6 +16,7 @@ linters:
|
||||
- dogsled
|
||||
- dupl
|
||||
- errcheck
|
||||
- errorlint
|
||||
- exhaustive
|
||||
- exportloopref
|
||||
- gci
|
||||
|
@ -17,6 +17,7 @@ package checks
|
||||
import (
|
||||
"archive/tar"
|
||||
"compress/gzip"
|
||||
"errors"
|
||||
"io"
|
||||
"net/http"
|
||||
"strings"
|
||||
@ -55,7 +56,7 @@ func CheckIfFileExists(checkName string, c *checker.CheckRequest, onFile func(na
|
||||
|
||||
for {
|
||||
hdr, err := tr.Next()
|
||||
if err == io.EOF {
|
||||
if errors.Is(err, io.EOF) {
|
||||
break
|
||||
} else if err != nil {
|
||||
return checker.MakeRetryResult(checkName, err)
|
||||
|
12
cmd/root.go
12
cmd/root.go
@ -203,14 +203,14 @@ func fetchGitRepositoryFromNPM(packageName string) (string, error) {
|
||||
}
|
||||
resp, err := client.Get(fmt.Sprintf(npmSearchURL, packageName))
|
||||
if err != nil {
|
||||
return "", fmt.Errorf("failed to get npm package json: %v", err)
|
||||
return "", fmt.Errorf("failed to get npm package json: %w", err)
|
||||
}
|
||||
|
||||
defer resp.Body.Close()
|
||||
v := &npmSearchResults{}
|
||||
err = json.NewDecoder(resp.Body).Decode(v)
|
||||
if err != nil {
|
||||
return "", fmt.Errorf("failed to parse npm package json: %v", err)
|
||||
return "", fmt.Errorf("failed to parse npm package json: %w", err)
|
||||
}
|
||||
if len(v.Objects) == 0 {
|
||||
return "", fmt.Errorf("could not find source repo for npm package: %s", packageName)
|
||||
@ -228,14 +228,14 @@ func fetchGitRepositoryFromPYPI(packageName string) (string, error) {
|
||||
}
|
||||
resp, err := client.Get(fmt.Sprintf(pypiSearchURL, packageName))
|
||||
if err != nil {
|
||||
return "", fmt.Errorf("failed to get pypi package json: %v", err)
|
||||
return "", fmt.Errorf("failed to get pypi package json: %w", err)
|
||||
}
|
||||
|
||||
defer resp.Body.Close()
|
||||
v := &pypiSearchResults{}
|
||||
err = json.NewDecoder(resp.Body).Decode(v)
|
||||
if err != nil {
|
||||
return "", fmt.Errorf("failed to parse pypi package json: %v", err)
|
||||
return "", fmt.Errorf("failed to parse pypi package json: %w", err)
|
||||
}
|
||||
if v.Info.ProjectUrls.Source == "" {
|
||||
return "", fmt.Errorf("could not find source repo for pypi package: %s", packageName)
|
||||
@ -253,14 +253,14 @@ func fetchGitRepositoryFromRubyGems(packageName string) (string, error) {
|
||||
}
|
||||
resp, err := client.Get(fmt.Sprintf(rubyGemsSearchURL, packageName))
|
||||
if err != nil {
|
||||
return "", fmt.Errorf("failed to get ruby gem json: %v", err)
|
||||
return "", fmt.Errorf("failed to get ruby gem json: %w", err)
|
||||
}
|
||||
|
||||
defer resp.Body.Close()
|
||||
v := &rubyGemsSearchResults{}
|
||||
err = json.NewDecoder(resp.Body).Decode(v)
|
||||
if err != nil {
|
||||
return "", fmt.Errorf("failed to parse ruby gem json: %v", err)
|
||||
return "", fmt.Errorf("failed to parse ruby gem json: %w", err)
|
||||
}
|
||||
if v.SourceCodeURI == "" {
|
||||
return "", fmt.Errorf("could not find source repo for ruby gem: %s", packageName)
|
||||
|
@ -63,7 +63,7 @@ type csvIterator struct {
|
||||
|
||||
func (reader *csvIterator) HasNext() bool {
|
||||
reader.err = reader.decoder.Decode(&reader.next)
|
||||
return reader.err != io.EOF
|
||||
return !errors.Is(reader.err, io.EOF)
|
||||
}
|
||||
|
||||
func (reader *csvIterator) Next() (repos.RepoURL, error) {
|
||||
|
Loading…
Reference in New Issue
Block a user