🐛 Remove Options that belong to the Action (#1898)

* updates

* tests
This commit is contained in:
laurentsimon 2022-05-09 12:40:15 -07:00 committed by GitHub
parent 7ff4b7e050
commit 62e3de5f48
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 10 deletions

View File

@ -28,22 +28,20 @@ import (
// Options define common options for configuring scorecard. // Options define common options for configuring scorecard.
type Options struct { type Options struct {
Repo string `env:"GITHUB_REPOSITORY"` Repo string
Local string Local string
Commit string `env:"GITHUB_REF"` Commit string
LogLevel string LogLevel string
Format string `env:"SCORECARD_RESULTS_FORMAT"` Format string
NPM string NPM string
PyPI string PyPI string
RubyGems string RubyGems string
PolicyFile string `env:"SCORECARD_POLICY_FILE"` PolicyFile string
// TODO(action): Add logic for writing results to file // TODO(action): Add logic for writing results to file
ResultsFile string `env:"SCORECARD_RESULTS_FILE"` ResultsFile string
ChecksToRun []string `env:"SCORECARD_ENABLED_CHECKS"` ChecksToRun []string
Metadata []string Metadata []string
ShowDetails bool ShowDetails bool
// TODO(action): Add logic for determining if results should be published.
PublishResults bool `env:"SCORECARD_PUBLISH_RESULTS"`
// Feature flags. // Feature flags.
EnableSarif bool `env:"ENABLE_SARIF"` EnableSarif bool `env:"ENABLE_SARIF"`

View File

@ -37,7 +37,6 @@ func TestOptions_Validate(t *testing.T) {
ChecksToRun []string ChecksToRun []string
Metadata []string Metadata []string
ShowDetails bool ShowDetails bool
PublishResults bool
EnableSarif bool EnableSarif bool
EnableScorecardV5 bool EnableScorecardV5 bool
EnableScorecardV6 bool EnableScorecardV6 bool
@ -106,7 +105,6 @@ func TestOptions_Validate(t *testing.T) {
ChecksToRun: tt.fields.ChecksToRun, ChecksToRun: tt.fields.ChecksToRun,
Metadata: tt.fields.Metadata, Metadata: tt.fields.Metadata,
ShowDetails: tt.fields.ShowDetails, ShowDetails: tt.fields.ShowDetails,
PublishResults: tt.fields.PublishResults,
EnableSarif: tt.fields.EnableSarif, EnableSarif: tt.fields.EnableSarif,
EnableScorecardV5: tt.fields.EnableScorecardV5, EnableScorecardV5: tt.fields.EnableScorecardV5,
EnableScorecardV6: tt.fields.EnableScorecardV6, EnableScorecardV6: tt.fields.EnableScorecardV6,