🐛 Remove inconclusive result from SAST (#1447)

* remove inconclusive

* fix comment
This commit is contained in:
laurentsimon 2022-01-07 15:22:49 -08:00 committed by GitHub
parent 192ae4d18f
commit 87a2d09822
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -124,12 +124,8 @@ func sastToolInCheckRuns(c *checker.CheckRequest) (int, error) {
return checker.InconclusiveResultScore,
sce.WithMessage(sce.ErrScorecardInternal, fmt.Sprintf("Client.Checks.ListCheckRunsForRef: %v", err))
}
if crs == nil {
c.Dlogger.Warn3(&checker.LogMessage{
Text: "no pull requests merged into dev branch",
})
return checker.InconclusiveResultScore, nil
}
// Note: crs may be `nil`: in this case
// the loop below will be skipped.
for _, cr := range crs {
if cr.Status != "completed" {
continue