From 91b3641196ebf134be8e6914797dcadbd1b3513a Mon Sep 17 00:00:00 2001 From: Chris McGehee Date: Wed, 19 May 2021 23:21:01 -0700 Subject: [PATCH] Fix lint issues: gocritic linter (#477) --- .golangci.yml | 2 +- checker/check_runner.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.golangci.yml b/.golangci.yml index 10873cfe..622642a5 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -19,7 +19,7 @@ linters: # - gochecknoinits - gocognit - goconst - # - gocritic + - gocritic - gocyclo - godot - godox diff --git a/checker/check_runner.go b/checker/check_runner.go index 70623e5c..597b719e 100644 --- a/checker/check_runner.go +++ b/checker/check_runner.go @@ -94,7 +94,7 @@ func MultiCheckAnd(fns ...CheckFn) CheckFn { for _, fn := range fns { result := fn(c) - if len(minResult.Name) == 0 { + if minResult.Name == "" { minResult.Name = result.Name } if Bool2int(result.Pass) < Bool2int(minResult.Pass) ||