diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 71c99e8c..ca8ab5c0 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -102,7 +102,11 @@ Following the targets that can be used to test your changes locally. | Command | Description | Is called in the CI? | | -------- | -------------------------------------------------- | -------------------- | | make all | Runs go test,golangci lint checks, fmt, go mod tidy| yes | -| make e2e | Runs e2e tests | yes | +| make e2e-pat | Runs e2e tests | yes | + +Make sure to signoff your commits before submitting a pull request. + +https://docs.pi-hole.net/guides/github/how-to-signoff/ ## Permission for GitHub personal access tokens diff --git a/Makefile b/Makefile index a36aa11b..2cc9968b 100644 --- a/Makefile +++ b/Makefile @@ -84,7 +84,7 @@ install: $(GOLANGCI_LINT) \ ##@ Build ################################## make all ################################### all: ## Runs build, test and verify -all-targets = build check-linter validate-docs add-projects validate-projects +all-targets = build unit-test unit-test-attestor check-linter validate-docs add-projects validate-projects .PHONY: all all-targets-update-dependencies $(all-targets) update-dependencies tree-status all-targets-update-dependencies: $(all-targets) | update-dependencies all: update-dependencies all-targets-update-dependencies tree-status