Commit Graph

5 Commits

Author SHA1 Message Date
Spencer Schrock
0b9dfb656f
⚠️ Replace v4 module references with v5 (#4027)
Signed-off-by: Spencer Schrock <sschrock@google.com>
2024-04-12 14:51:50 -07:00
Spencer Schrock
b577d79c96
⚠️ Replace Positive and Negative outcomes with True and False (#4017)
* rename positive to true

Signed-off-by: Spencer Schrock <sschrock@google.com>

* rename negative to false

Signed-off-by: Spencer Schrock <sschrock@google.com>

---------

Signed-off-by: Spencer Schrock <sschrock@google.com>
2024-04-08 15:36:11 -07:00
Spencer Schrock
c59e93b9b2
🌱 Switch probe tests to helper func (#3782)
* simplify test helper to verify finding outcomes

Signed-off-by: Spencer Schrock <sschrock@google.com>

* switch existing callers to helper func

Signed-off-by: Spencer Schrock <sschrock@google.com>

* remove TODO comments

Signed-off-by: Spencer Schrock <sschrock@google.com>

* fixup doc string

Signed-off-by: Spencer Schrock <sschrock@google.com>

---------

Signed-off-by: Spencer Schrock <sschrock@google.com>
2024-01-10 10:00:04 -08:00
Spencer Schrock
92470deac3
🌱 enable nolintlint linter and fix violations (#3650)
* enable nolintlint

Signed-off-by: Spencer Schrock <sschrock@google.com>

* first chunk of fixing nolintlint

Signed-off-by: Spencer Schrock <sschrock@google.com>

* second chunk of fixing nolintlint

Signed-off-by: Spencer Schrock <sschrock@google.com>

* third chunk of fixing nolintlint

Signed-off-by: Spencer Schrock <sschrock@google.com>

* fourth chunk of fixing nolintlint

Signed-off-by: Spencer Schrock <sschrock@google.com>

* include reason for the specific linter config

Signed-off-by: Spencer Schrock <sschrock@google.com>

* fifth chunk of fixing nolintlint

Signed-off-by: Spencer Schrock <sschrock@google.com>

* fix linter errors that are somehow still triggering

Signed-off-by: Spencer Schrock <sschrock@google.com>

---------

Signed-off-by: Spencer Schrock <sschrock@google.com>
2023-11-15 11:44:28 -08:00
AdamKorcz
ae75bbb70e
🌱 Add probe support for contributors metrics (#3460)
* 🌱 Add probe support for contributors metrics

Signed-off-by: AdamKorcz <adam@adalogics.com>

* fix lint issues

Signed-off-by: AdamKorcz <adam@adalogics.com>

* change 'contributorsWith' to 'contributorsFrom'

Signed-off-by: AdamKorcz <adam@adalogics.com>

* change remediation difficulty

Signed-off-by: AdamKorcz <adam@adalogics.com>

* fix nits

Signed-off-by: AdamKorcz <adam@adalogics.com>

* Updates to checks and checks/evaluation

Signed-off-by: AdamKorcz <adam@adalogics.com>

* fix tests like in #3409

Signed-off-by: AdamKorcz <adam@adalogics.com>

* fix raw test

Signed-off-by: AdamKorcz <adam@adalogics.com>

* Update description in def.yml

Signed-off-by: AdamKorcz <adam@adalogics.com>

* move logic out of utils

Signed-off-by: AdamKorcz <adam@adalogics.com>

* add comment to consolidate unit test validation

Signed-off-by: AdamKorcz <adam@adalogics.com>

* change a couple of t.Fatal to t.Error

Signed-off-by: AdamKorcz <adam@adalogics.com>

* un-remove comment

Signed-off-by: AdamKorcz <adam@adalogics.com>

* remove map

Signed-off-by: AdamKorcz <adam@adalogics.com>

* fix typo

Signed-off-by: AdamKorcz <adam@adalogics.com>

* remove lint comment

Signed-off-by: AdamKorcz <adam@adalogics.com>

* fix incorrect -1/0 scoring

Signed-off-by: AdamKorcz <adam@adalogics.com>

* Do not specify 'Github' in def.yml

Signed-off-by: AdamKorcz <adam@adalogics.com>

* do not mention 'which companies' in def.yml

Signed-off-by: AdamKorcz <adam@adalogics.com>

* Rename tests

Signed-off-by: AdamKorcz <adam@adalogics.com>

* Use getRawResults and uncomment logging statement

Signed-off-by: AdamKorcz <adam@adalogics.com>

* Define return values of probe better

Signed-off-by: AdamKorcz <adam@adalogics.com>

* Use proportional score instead of min score

Signed-off-by: AdamKorcz <adam@adalogics.com>

* revert changed scoring

Signed-off-by: AdamKorcz <adam@adalogics.com>

* fix incorrect function name

Signed-off-by: AdamKorcz <adam@adalogics.com>

* remove utility function that finds non-positive outcomes

Signed-off-by: AdamKorcz <adam@adalogics.com>

* rebase with latest upstream main and fix linter issues

Signed-off-by: AdamKorcz <adam@adalogics.com>

* Log findings in one statements except a logging statements per finding

Signed-off-by: AdamKorcz <adam@adalogics.com>

* redefine conditional logic

Signed-off-by: AdamKorcz <adam@adalogics.com>

* rebase

Signed-off-by: AdamKorcz <adam@adalogics.com>

* remove unused function

Signed-off-by: AdamKorcz <adam@adalogics.com>

---------

Signed-off-by: AdamKorcz <adam@adalogics.com>
2023-10-24 14:02:18 -07:00