scorecard/finding/probe.go
Spencer Schrock 6629b09746
Some checks are pending
CodeQL / Analyze (go) (push) Waiting to run
CodeQL / Analyze (javascript) (push) Waiting to run
gitlab-tests / gitlab-integration-trusted (push) Waiting to run
golangci-lint / check-linter (push) Waiting to run
build / unit-test (push) Waiting to run
build / generate-mocks (push) Waiting to run
build / generate-docs (push) Waiting to run
build / build-proto (push) Waiting to run
build / ${{ matrix.target }} (build-add-script) (push) Blocked by required conditions
build / ${{ matrix.target }} (build-bq-transfer) (push) Blocked by required conditions
build / ${{ matrix.target }} (build-cii-worker) (push) Blocked by required conditions
build / ${{ matrix.target }} (build-controller) (push) Blocked by required conditions
build / ${{ matrix.target }} (build-github-server) (push) Blocked by required conditions
build / ${{ matrix.target }} (build-scorecard) (push) Blocked by required conditions
build / ${{ matrix.target }} (build-shuffler) (push) Blocked by required conditions
build / ${{ matrix.target }} (build-validate-script) (push) Blocked by required conditions
build / ${{ matrix.target }} (build-webhook) (push) Blocked by required conditions
build / ${{ matrix.target }} (build-worker) (push) Blocked by required conditions
build / validate-docs (push) Waiting to run
build / add-projects (push) Waiting to run
build / validate-projects (push) Waiting to run
build / license boilerplate check (push) Waiting to run
Scorecard analysis workflow / Scorecard analysis (push) Waiting to run
🌱 Add lifecycle field to probes (#4147)
* add lifecycle field to probe yaml definitions

Signed-off-by: Spencer Schrock <sschrock@google.com>

* classify existing probes

Some are listed as stable if they're not expected to change,
others are listed as experimental if there are still expected changes.

Signed-off-by: Spencer Schrock <sschrock@google.com>

* add lifecycle to probe readme

Signed-off-by: Spencer Schrock <sschrock@google.com>

* fix linter

Signed-off-by: Spencer Schrock <sschrock@google.com>

* add lifecycle for new probe

Signed-off-by: Spencer Schrock <sschrock@google.com>

* add probe lifecycle to documentation

Signed-off-by: Spencer Schrock <sschrock@google.com>

---------

Signed-off-by: Spencer Schrock <sschrock@google.com>
2024-07-02 17:11:19 +00:00

252 lines
6.4 KiB
Go

// Copyright 2023 OpenSSF Scorecard Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package finding
import (
"embed"
"fmt"
"strings"
"gopkg.in/yaml.v3"
"github.com/ossf/scorecard/v5/clients"
pyaml "github.com/ossf/scorecard/v5/internal/probes/yaml"
)
// RemediationEffort indicates the estimated effort necessary to remediate a finding.
type RemediationEffort int
// lifecycle indicates the probe's stability.
type lifecycle string
const (
// RemediationEffortNone indicates a no remediation effort.
RemediationEffortNone RemediationEffort = iota
// RemediationEffortLow indicates a low remediation effort.
RemediationEffortLow
// RemediationEffortMedium indicates a medium remediation effort.
RemediationEffortMedium
// RemediationEffortHigh indicates a high remediation effort.
RemediationEffortHigh
lifecycleExperimental lifecycle = "experimental"
lifecycleStable lifecycle = "stable"
lifecycleDeprecated lifecycle = "deprecated"
)
// Remediation represents the remediation for a finding.
type Remediation struct {
// Patch for machines.
Patch *string `json:"patch,omitempty"`
// Text for humans.
Text string `json:"text"`
// Text in markdown format for humans.
Markdown string `json:"markdown"`
// Effort to remediate.
Effort RemediationEffort `json:"effort"`
}
var supportedClients = map[string]bool{
"github": true,
"gitlab": true,
"localdir": true,
}
type probe struct {
ID string
Short string
Motivation string
Implementation string
Remediation *Remediation
RemediateOnOutcome Outcome
}
func probeFromBytes(content []byte, probeID string) (*probe, error) {
r, err := parseFromYAML(content)
if err != nil {
return nil, err
}
if err := validate(r, probeID); err != nil {
return nil, err
}
return &probe{
ID: r.ID,
Short: r.Short,
Motivation: r.Motivation,
Implementation: r.Implementation,
Remediation: &Remediation{
Text: strings.Join(r.Remediation.Text, "\n"),
Markdown: strings.Join(r.Remediation.Markdown, "\n"),
Effort: toRemediationEffort(r.Remediation.Effort),
},
RemediateOnOutcome: Outcome(r.Remediation.OnOutcome),
}, nil
}
// New create a new probe.
func newProbe(loc embed.FS, probeID string) (*probe, error) {
content, err := loc.ReadFile("def.yml")
if err != nil {
return nil, fmt.Errorf("%w", err)
}
return probeFromBytes(content, probeID)
}
func validate(r *pyaml.Probe, probeID string) error {
if err := validateID(r.ID, probeID); err != nil {
return err
}
if err := validateRemediation(&r.Remediation); err != nil {
return err
}
if err := validateEcosystem(r.Ecosystem); err != nil {
return err
}
if err := validateLifecycle(lifecycle(r.Lifecycle)); err != nil {
return err
}
return nil
}
func validateID(actual, expected string) error {
if actual != expected {
return fmt.Errorf("%w: ID: read '%v', expected '%v'", errInvalid,
actual, expected)
}
return nil
}
func validateRemediation(r *pyaml.Remediation) error {
if err := validateRemediationOutcomeTrigger(Outcome(r.OnOutcome)); err != nil {
return fmt.Errorf("remediation: %w", err)
}
switch toRemediationEffort(r.Effort) {
case RemediationEffortHigh, RemediationEffortMedium, RemediationEffortLow:
return nil
default:
return fmt.Errorf("%w: %v", errInvalid, fmt.Sprintf("remediation '%v'", r))
}
}
func validateEcosystem(r pyaml.Ecosystem) error {
if err := validateSupportedLanguages(r); err != nil {
return err
}
if err := validateSupportedClients(r); err != nil {
return err
}
return nil
}
func validateRemediationOutcomeTrigger(o Outcome) error {
switch o {
case OutcomeTrue, OutcomeFalse, OutcomeNotApplicable, OutcomeNotAvailable, OutcomeNotSupported, OutcomeError:
return nil
default:
return fmt.Errorf("%w: unknown outcome: %v", errInvalid, o)
}
}
func validateSupportedLanguages(r pyaml.Ecosystem) error {
for _, lang := range r.Languages {
switch clients.LanguageName(lang) {
case clients.Go, clients.Python, clients.JavaScript,
clients.Cpp, clients.C, clients.TypeScript,
clients.Java, clients.CSharp, clients.Ruby,
clients.PHP, clients.StarLark, clients.Scala,
clients.Kotlin, clients.Swift, clients.Rust,
clients.Haskell, clients.All, clients.Dockerfile,
clients.ObjectiveC:
continue
default:
return fmt.Errorf("%w: %v", errInvalid, fmt.Sprintf("language '%v'", r))
}
}
return nil
}
func validateSupportedClients(r pyaml.Ecosystem) error {
for _, lang := range r.Clients {
if _, ok := supportedClients[lang]; !ok {
return fmt.Errorf("%w: %v", errInvalid, fmt.Sprintf("client '%v'", r))
}
}
return nil
}
func validateLifecycle(l lifecycle) error {
switch l {
case lifecycleExperimental, lifecycleStable, lifecycleDeprecated:
return nil
default:
return fmt.Errorf("%w: %v", errInvalid, fmt.Sprintf("lifecycle '%v'", l))
}
}
func parseFromYAML(content []byte) (*pyaml.Probe, error) {
r := pyaml.Probe{}
err := yaml.Unmarshal(content, &r)
if err != nil {
return nil, fmt.Errorf("unable to parse yaml: %w", err)
}
return &r, nil
}
// UnmarshalYAML is a custom unmarshalling function
// to transform the string into an enum.
func (r *RemediationEffort) UnmarshalYAML(n *yaml.Node) error {
var str string
if err := n.Decode(&str); err != nil {
return fmt.Errorf("%w: %w", errInvalid, err)
}
*r = toRemediationEffort(n.Value)
if *r == RemediationEffortNone {
return fmt.Errorf("%w: effort:%q", errInvalid, str)
}
return nil
}
// String stringifies the enum.
func (r *RemediationEffort) String() string {
switch *r {
case RemediationEffortLow:
return "Low"
case RemediationEffortMedium:
return "Medium"
case RemediationEffortHigh:
return "High"
default:
return ""
}
}
func toRemediationEffort(s string) RemediationEffort {
switch s {
case "Low":
return RemediationEffortLow
case "Medium":
return RemediationEffortMedium
case "High":
return RemediationEffortHigh
default:
return RemediationEffortNone
}
}