scorecard/checks/branch_protected.go
Azeem Shaikh be8aa3d713
Export registered check names (#518)
Co-authored-by: Azeem Shaikh <azeems@google.com>
2021-05-27 14:54:34 -07:00

152 lines
4.9 KiB
Go

// Copyright 2020 Security Scorecard Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package checks
import (
"github.com/google/go-github/v32/github"
"github.com/ossf/scorecard/checker"
)
const (
// CheckBranchProtection is the registered name for BranchProtection.
CheckBranchProtection = "Branch-Protection"
minReviews = 1
)
//nolint:gochecknoinits
func init() {
registerCheck(CheckBranchProtection, BranchProtection)
}
func BranchProtection(c *checker.CheckRequest) checker.CheckResult {
repo, _, err := c.Client.Repositories.Get(c.Ctx, c.Owner, c.Repo)
if err != nil {
return checker.MakeRetryResult(CheckBranchProtection, err)
}
protection, resp, err := c.Client.Repositories.
GetBranchProtection(c.Ctx, c.Owner, c.Repo, *repo.DefaultBranch)
const fileNotFound = 404
if resp.StatusCode == fileNotFound {
return checker.MakeRetryResult(CheckBranchProtection, err)
}
if err != nil {
c.Logf("!! branch protection not enabled")
const confidence = 10
return checker.CheckResult{
Name: CheckBranchProtection,
Pass: false,
Confidence: confidence,
}
}
return IsBranchProtected(protection, c)
}
func IsBranchProtected(protection *github.Protection, c *checker.CheckRequest) checker.CheckResult {
totalChecks := 6
totalSuccess := 0
// This is disabled by default (good).
if protection.GetAllowForcePushes() != nil &&
protection.AllowForcePushes.Enabled {
c.Logf("!! branch protection - AllowForcePushes should be disabled")
} else {
totalSuccess++
}
// This is disabled by default (good).
if protection.GetAllowDeletions() != nil &&
protection.AllowDeletions.Enabled {
c.Logf("!! branch protection - AllowDeletions should be disabled")
} else {
totalSuccess++
}
// This is disabled by default (bad).
if protection.GetEnforceAdmins() != nil &&
protection.EnforceAdmins.Enabled {
totalSuccess++
} else {
c.Logf("!! branch protection - EnforceAdmins should be enabled")
}
// This is disabled by default (bad).
if protection.GetRequireLinearHistory() != nil &&
protection.RequireLinearHistory.Enabled {
totalSuccess++
} else {
c.Logf("!! branch protection - Linear history should be enabled")
}
if requiresStatusChecks(protection, c) {
totalSuccess++
}
if requiresThoroughReviews(protection, c) {
totalSuccess++
}
return checker.MakeProportionalResult(CheckBranchProtection, totalSuccess, totalChecks, 1.0)
}
// Returns true if several PR status checks requirements are enabled. Otherwise returns false and logs why it failed.
func requiresStatusChecks(protection *github.Protection, c *checker.CheckRequest) bool {
// This is disabled by default (bad).
if protection.GetRequiredStatusChecks() != nil &&
protection.RequiredStatusChecks.Strict &&
len(protection.RequiredStatusChecks.Contexts) > 0 {
return true
}
switch {
case protection.RequiredStatusChecks == nil ||
!protection.RequiredStatusChecks.Strict:
c.Logf("!! branch protection - Status checks for merging should be enabled")
case len(protection.RequiredStatusChecks.Contexts) == 0:
c.Logf("!! branch protection - Status checks for merging should have specific status to check for")
default:
panic("!! branch protection - Unhandled status checks error")
}
return false
}
// Returns true if several PR review requirements are enabled. Otherwise returns false and logs why it failed.
func requiresThoroughReviews(protection *github.Protection, c *checker.CheckRequest) bool {
// This is disabled by default (bad).
if protection.GetRequiredPullRequestReviews() != nil &&
protection.RequiredPullRequestReviews.RequiredApprovingReviewCount >= minReviews &&
protection.RequiredPullRequestReviews.DismissStaleReviews &&
protection.RequiredPullRequestReviews.RequireCodeOwnerReviews {
return true
}
switch {
case protection.RequiredPullRequestReviews == nil:
c.Logf("!! branch protection - Pullrequest reviews should be enabled")
fallthrough
case protection.RequiredPullRequestReviews.RequiredApprovingReviewCount < minReviews:
c.Logf("!! branch protection - %v pullrequest reviews should be enabled", minReviews)
fallthrough
case !protection.RequiredPullRequestReviews.DismissStaleReviews:
c.Logf("!! branch protection - Stale review dismissal should be enabled")
fallthrough
case !protection.RequiredPullRequestReviews.RequireCodeOwnerReviews:
c.Logf("!! branch protection - Owner review should be enabled")
default:
panic("!! branch protection - Unhandled pull request error")
}
return false
}