mirror of
https://github.com/ossf/scorecard.git
synced 2024-10-26 10:28:10 +03:00
0e3a5233ae
* 🌱 Add license probe
Signed-off-by: AdamKorcz <adam@adalogics.com>
* [WIP] add two remaining license checks as probes
Signed-off-by: AdamKorcz <adam@adalogics.com>
* fix nits
Signed-off-by: AdamKorcz <adam@adalogics.com>
* Use Errorf in test
Signed-off-by: AdamKorcz <adam@adalogics.com>
* use zrunner
Signed-off-by: AdamKorcz <adam@adalogics.com>
* fix wrong return value
Signed-off-by: AdamKorcz <adam@adalogics.com>
* fix linting issues and remove empty default
Signed-off-by: AdamKorcz <adam@adalogics.com>
* fix double if statement
Signed-off-by: AdamKorcz <adam@adalogics.com>
* Remove struct field from test
Signed-off-by: AdamKorcz <adam@adalogics.com>
* Add test for nil-case of license files slice
Signed-off-by: AdamKorcz <adam@adalogics.com>
* rewrite multiple def.ymls
Signed-off-by: AdamKorcz <adam@adalogics.com>
* fix nits
Signed-off-by: AdamKorcz <adam@adalogics.com>
* Add unit test with multiple unapproved license files
Signed-off-by: AdamKorcz <adam@adalogics.com>
* Add link to approved license formats
Signed-off-by: AdamKorcz <adam@adalogics.com>
* fix linting
Signed-off-by: AdamKorcz <adam@adalogics.com>
* remove comment
Signed-off-by: AdamKorcz <adam@adalogics.com>
* preserve logging from original check
Signed-off-by: AdamKorcz <adam@adalogics.com>
* fix typo
Signed-off-by: AdamKorcz <adam@adalogics.com>
* remove redundant map manipulation
Signed-off-by: AdamKorcz <adam@adalogics.com>
* rename hasApproveLicense probe
Signed-off-by: AdamKorcz <adam@adalogics.com>
* Return OutcomeNotApplicable if hasFSFOrOSIApprovedLicense probe does not find a license
Signed-off-by: AdamKorcz <adam@adalogics.com>
* Include license file locations in log
Signed-off-by: AdamKorcz <adam@adalogics.com>
* fix linting issues
Signed-off-by: AdamKorcz <adam@adalogics.com>
* replace strings filtering with OutcomeNotApplicable in hasLicenseFileAtTopDir probe
Signed-off-by: AdamKorcz <adam@adalogics.com>
* Fix linter issue
Signed-off-by: AdamKorcz <adam@adalogics.com>
* Include location of found license files
Signed-off-by: AdamKorcz <adam@adalogics.com>
---------
Signed-off-by: AdamKorcz <adam@adalogics.com>
103 lines
2.5 KiB
Go
103 lines
2.5 KiB
Go
// Copyright 2020 OpenSSF Scorecard Authors
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package checks
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"testing"
|
|
|
|
"github.com/golang/mock/gomock"
|
|
|
|
"github.com/ossf/scorecard/v4/checker"
|
|
"github.com/ossf/scorecard/v4/clients"
|
|
"github.com/ossf/scorecard/v4/clients/localdir"
|
|
"github.com/ossf/scorecard/v4/log"
|
|
scut "github.com/ossf/scorecard/v4/utests"
|
|
)
|
|
|
|
func TestLicenseFileSubdirectory(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
tests := []struct {
|
|
name string
|
|
inputFolder string
|
|
err error
|
|
expected scut.TestReturn
|
|
}{
|
|
{
|
|
name: "With LICENSE",
|
|
inputFolder: "testdata/licensedir/withlicense",
|
|
expected: scut.TestReturn{
|
|
Error: nil,
|
|
Score: 9, // Does not have approved format
|
|
NumberOfInfo: 1,
|
|
NumberOfWarn: 1,
|
|
},
|
|
err: nil,
|
|
},
|
|
{
|
|
name: "Without LICENSE",
|
|
inputFolder: "testdata/licensedir/withoutlicense",
|
|
expected: scut.TestReturn{
|
|
Error: nil,
|
|
Score: checker.MinResultScore,
|
|
NumberOfWarn: 0,
|
|
NumberOfInfo: 2,
|
|
},
|
|
err: nil,
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
tt := tt // Re-initializing variable so it is not changed while executing the closure below
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
logger := log.NewLogger(log.DebugLevel)
|
|
|
|
// TODO: Use gMock instead of Localdir here.
|
|
ctrl := gomock.NewController(t)
|
|
repo, err := localdir.MakeLocalDirRepo(tt.inputFolder)
|
|
|
|
if !errors.Is(err, tt.err) {
|
|
t.Errorf("MakeLocalDirRepo: %v, expected %v", err, tt.err)
|
|
}
|
|
|
|
ctx := context.Background()
|
|
|
|
client := localdir.CreateLocalDirClient(ctx, logger)
|
|
if err := client.InitRepo(repo, clients.HeadSHA, 0); err != nil {
|
|
t.Errorf("InitRepo: %v", err)
|
|
}
|
|
|
|
dl := scut.TestDetailLogger{}
|
|
|
|
req := checker.CheckRequest{
|
|
Ctx: ctx,
|
|
RepoClient: client,
|
|
Dlogger: &dl,
|
|
}
|
|
|
|
res := License(&req)
|
|
|
|
if !scut.ValidateTestReturn(t, tt.name, &tt.expected, &res, &dl) {
|
|
t.Fail()
|
|
}
|
|
|
|
ctrl.Finish()
|
|
})
|
|
}
|
|
}
|