scorecard/clients
Spencer Schrock d03c8cbb43
🐛 revert making RequiredPullRequestReviews a pointer (#3728)
* revert the change which made RequiredPullRequestReviews a pointer

While the current approach works with the tiered scoring,
it wont work for probes or if we remove tiers. Making the struct nil to
signal that PRs aren't required hides some of the data we do have.

This is especially problematic for repo rules, where we can infer all
settings by what we see or dont see.

Signed-off-by: Spencer Schrock <sschrock@google.com>

* add helper to deref pointers

Signed-off-by: Spencer Schrock <sschrock@google.com>

* clarify comments and keep code consistent

Signed-off-by: Spencer Schrock <sschrock@google.com>

---------

Signed-off-by: Spencer Schrock <sschrock@google.com>
2023-12-13 00:26:35 +00:00
..
git 🌱 re-enable paralleltest linter (#3705) 2023-12-04 02:25:03 +00:00
githubrepo 🐛 revert making RequiredPullRequestReviews a pointer (#3728) 2023-12-13 00:26:35 +00:00
gitlabrepo 🐛 revert making RequiredPullRequestReviews a pointer (#3728) 2023-12-13 00:26:35 +00:00
localdir GitLab: Security Policy check (#2754) 2023-03-16 19:18:32 +00:00
mockclients 🐛 Gitlab: Commit/Commitor Exceptions (#3026) 2023-05-19 01:31:07 +00:00
ossfuzz 🌱 re-enable paralleltest linter (#3705) 2023-12-04 02:25:03 +00:00
branch.go 🐛 revert making RequiredPullRequestReviews a pointer (#3728) 2023-12-13 00:26:35 +00:00
checkruns.go Use new project name in Copyright notices (#2505) 2022-12-01 15:08:48 -08:00
cii_blob_client.go Use new project name in Copyright notices (#2505) 2022-12-01 15:08:48 -08:00
cii_client.go 📖 Update bestpractices links (#3448) 2023-09-12 22:47:53 +00:00
cii_http_client.go 🌱 enable nolintlint linter and fix violations (#3650) 2023-11-15 11:44:28 -08:00
cii_response_test.go 🌱 Enable golangci-lint test presets (#3594) 2023-10-27 15:05:40 -07:00
cii_response.go Use new project name in Copyright notices (#2505) 2022-12-01 15:08:48 -08:00
commit.go Use new project name in Copyright notices (#2505) 2022-12-01 15:08:48 -08:00
issue.go Use new project name in Copyright notices (#2505) 2022-12-01 15:08:48 -08:00
languages.go Detect fuzzing in Haskell by the presence of property tests. (#2843) 2023-04-12 17:29:29 +00:00
licenses.go Use new project name in Copyright notices (#2505) 2022-12-01 15:08:48 -08:00
osv_test.go ⚠️ OSV scanner integration (#2509) 2022-12-12 16:46:43 -08:00
osv.go 🐛 Give inconclusive Vulnerabilities score when osv-scanner panics (#2896) 2023-04-24 17:26:20 +00:00
pull_request.go Use new project name in Copyright notices (#2505) 2022-12-01 15:08:48 -08:00
release.go Use new project name in Copyright notices (#2505) 2022-12-01 15:08:48 -08:00
repo_client.go GitLab: Security Policy check (#2754) 2023-03-16 19:18:32 +00:00
repo.go GitLab: Security Policy check (#2754) 2023-03-16 19:18:32 +00:00
search.go Use new project name in Copyright notices (#2505) 2022-12-01 15:08:48 -08:00
statuses.go Use new project name in Copyright notices (#2505) 2022-12-01 15:08:48 -08:00
user.go 🐛 Use leveled scoring for Code Review check (#2542) 2023-01-10 20:46:11 -08:00
vulnerabilities.go ⚠️ OSV scanner integration (#2509) 2022-12-12 16:46:43 -08:00
webhook.go Use new project name in Copyright notices (#2505) 2022-12-01 15:08:48 -08:00
workflows.go Use new project name in Copyright notices (#2505) 2022-12-01 15:08:48 -08:00