mirror of
https://github.com/ossf/scorecard.git
synced 2024-09-19 21:18:09 +03:00
cc312f2d1d
* branch protection without admin permission Signed-off-by: Asra Ali <asraa@google.com> * handle other errors Signed-off-by: Asra Ali <asraa@google.com> * fix lint Signed-off-by: Asra Ali <asraa@google.com> Co-authored-by: Naveen <172697+naveensrinivasan@users.noreply.github.com>
88 lines
2.7 KiB
Go
88 lines
2.7 KiB
Go
// Copyright 2021 Security Scorecard Authors
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package e2e
|
|
|
|
import (
|
|
"context"
|
|
|
|
. "github.com/onsi/ginkgo"
|
|
. "github.com/onsi/gomega"
|
|
|
|
"github.com/ossf/scorecard/v2/checker"
|
|
"github.com/ossf/scorecard/v2/checks"
|
|
scut "github.com/ossf/scorecard/v2/utests"
|
|
)
|
|
|
|
var _ = Describe("E2E TEST:"+checks.CheckBranchProtection, func() {
|
|
Context("E2E TEST:Validating branch protection", func() {
|
|
It("Should fail to return branch protection on other repositories", func() {
|
|
dl := scut.TestDetailLogger{}
|
|
req := checker.CheckRequest{
|
|
Ctx: context.Background(),
|
|
Client: ghClient,
|
|
HTTPClient: httpClient,
|
|
RepoClient: nil,
|
|
Owner: "apache",
|
|
Repo: "airflow",
|
|
GraphClient: graphClient,
|
|
Dlogger: &dl,
|
|
}
|
|
expected := scut.TestReturn{
|
|
Errors: nil,
|
|
Score: 1,
|
|
NumberOfWarn: 3,
|
|
NumberOfInfo: 0,
|
|
NumberOfDebug: 0,
|
|
}
|
|
result := checks.BranchProtection(&req)
|
|
// UPGRADEv2: to remove.
|
|
// Old version.
|
|
Expect(result.Error).ShouldNot(BeNil())
|
|
Expect(result.Pass).Should(BeFalse())
|
|
// New version.
|
|
Expect(scut.ValidateTestReturn(nil, "branch protection not accessible", &expected, &result, &dl)).Should(BeTrue())
|
|
})
|
|
Context("E2E TEST:Validating branch protection", func() {
|
|
It("Should fail to return branch protection on other repositories", func() {
|
|
dl := scut.TestDetailLogger{}
|
|
req := checker.CheckRequest{
|
|
Ctx: context.Background(),
|
|
Client: ghClient,
|
|
HTTPClient: httpClient,
|
|
RepoClient: nil,
|
|
Owner: "ossf-tests",
|
|
Repo: "scorecard-check-branch-protection-e2e",
|
|
GraphClient: graphClient,
|
|
Dlogger: &dl,
|
|
}
|
|
expected := scut.TestReturn{
|
|
Errors: nil,
|
|
Score: 9,
|
|
NumberOfWarn: 1,
|
|
NumberOfInfo: 8,
|
|
NumberOfDebug: 0,
|
|
}
|
|
result := checks.BranchProtection(&req)
|
|
// UPGRADEv2: to remove.
|
|
// Old version.
|
|
Expect(result.Error).Should(BeNil())
|
|
Expect(result.Pass).Should(BeTrue())
|
|
// New version.
|
|
Expect(scut.ValidateTestReturn(nil, "branch protection accessible", &expected, &result, &dl)).Should(BeTrue())
|
|
})
|
|
})
|
|
})
|
|
})
|