git.iko.soy/parseable-macos
on master help sign in
Fix connection lifecycle and credential checks

- /api/v1/liveness is unauthenticated, so Test Connection and Connect accepted any password. Probe an authenticated endpoint and fail on 401. - Removing a connection while it is still connecting (Cancel in the sheet, delete in Settings) now cancels that connect instead of letting it install a client for a deleted connection. - A failed connect's alert no longer pops up after a successful retry. - Test Connection ignores a result for fields edited since it started. - URL schemes are matched case-insensitively (HTTP://host became https://HTTP://host) and non-HTTP schemes are rejected. - The offline gate no longer blocks localhost servers. - Stream/filter refreshes compare the client, not only the connection id, and a connect drops a selected stream the new server lacks. - Deleting a stream re-checks that the server hasn't changed since the stream was picked. - Remove File > New Window and window tabs: all windows share one AppState, so sheets and alerts appeared twice. - Allow plain-HTTP servers (App Transport Security), which the app accepts but URLSession refused for DNS hostnames. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015p9SN94YqDtQkEisiPQ3xJ

commit1c8b1dadb5fb07ffb795086edc9109fdf2c17ad3 authorClaude <noreply@anthropic.com> dateWed 30 Sep 2026, 10:49 (1 week ago) parentf4c4ced
7 files changed+174−16
ParseableViewer/App/AppState.swift+81−5 ParseableViewer/App/ParseableViewerApp.swift+13−1 ParseableViewer/Info.plist+5 ParseableViewer/Models/ServerConnection.swift+19−2 ParseableViewer/Views/ConnectionSheet.swift+27−7 ParseableViewer/Views/SidebarView.swift+19−1 ParseableViewerTests/ServerConnectionTests.swift+10
ParseableViewer/App/AppState.swift+81−5
@@ -15,6 +15,10 @@ final class AppState {
1515 private let networkMonitor = NWPathMonitor()
1616 private let networkMonitorQueue = DispatchQueue(label: "com.parseableviewer.network-monitor")
1717 private var connectTask: Task<Bool, Never>?
18+ /// The connection `connectTask` is connecting to. `activeConnection` only
19+ /// switches once the new server answers, so this is what identifies an
20+ /// in-flight connect whose target the user deletes (see `removeConnection`).
21+ private var connectingConnectionID: UUID?
1822
1923 // MARK: - Stream State
2024 var streams: [LogStream] = []
@@ -96,6 +100,7 @@ final class AppState {
96100
97101 if let activeID = ConnectionStore.loadActiveConnectionID(),
98102 let connection = connections.first(where: { $0.id == activeID }) {
103+ connectingConnectionID = connection.id
99104 connectTask = Task { @MainActor [weak self] in
100105 await self?.performConnect(to: connection) ?? false
101106 }
@@ -115,6 +120,7 @@ final class AppState {
115120 existing.cancel()
116121 _ = await existing.value
117122 }
123+ connectingConnectionID = connection.id
118124 let task = Task { @MainActor [weak self] in
119125 await self?.performConnect(to: connection) ?? false
120126 }
@@ -124,9 +130,16 @@ final class AppState {
124130
125131 @MainActor
126132 private func performConnect(to connection: ServerConnection) async -> Bool {
133+ defer {
134+ if connectingConnectionID == connection.id { connectingConnectionID = nil }
135+ }
127136 guard !isConnecting else { return false }
128137
129− if !isNetworkAvailable {
138+ // NWPathMonitor ignores loopback, so with no active network interface it
139+ // reports "unsatisfied" even though a local server (the common docker /
140+ // dev setup) is reachable. Don't block those; a genuinely unreachable
141+ // host still fails below with the same offline message.
142+ if !isNetworkAvailable && !Self.isLoopback(connection.baseURL) {
130143 self.errorMessage = "No internet connection. Check your network and try again."
131144 self.showError = true
132145 return false
@@ -134,7 +147,12 @@ final class AppState {
134147
135148 isConnecting = true
136149 defer { isConnecting = false }
150+ // Reset the flag with the message: a previous failed connect left
151+ // `showError` set, and if its alert couldn't present (e.g. behind the
152+ // connection sheet), it would pop up later — after a successful retry —
153+ // reading "An unknown error occurred".
137154 errorMessage = nil
155+ showError = false
138156
139157 // When switching to a different server, clear stream-specific state
140158 // so stale selections don't reference streams that don't exist.
@@ -164,6 +182,7 @@ final class AppState {
164182
165183 // Test connection — throws on non-200 or network failure
166184 try await newClient.checkHealth()
185+ try await Self.verifyCredentials(with: newClient)
167186
168187 // If the task was cancelled while awaiting (e.g. user clicked
169188 // Disconnect during auto-reconnect), bail before installing the
@@ -200,6 +219,12 @@ final class AppState {
200219 case .success(let list):
201220 self.streams = list
202221 self.streamLoadError = nil
222+ // Like refreshStreams: a selection that doesn't exist on this server
223+ // (e.g. one picked from a stale list while the connect was pending)
224+ // would keep every stream tab querying a missing stream.
225+ if let selected = selectedStream, !list.contains(where: { $0.name == selected }) {
226+ selectedStream = nil
227+ }
203228 case .failure(let error):
204229 self.streams = []
205230 self.streamLoadError = ParseableError.userFriendlyMessage(for: error)
@@ -265,8 +290,13 @@ final class AppState {
265290 let loaded = try await client.listStreams()
266291 // Drop results if the active connection changed while awaiting. Still
267292 // clear isLoadingStreams: this task set the spinner, so leaving it true
268− // wedges the indicator and disables Refresh.
269− guard connID == activeConnection?.id else { isLoadingStreams = false; return }
293+ // wedges the indicator and disables Refresh. Compare the client too:
294+ // editing the active connection's URL/credentials keeps its id but
295+ // installs a new client for a possibly different server.
296+ guard connID == activeConnection?.id, client === self.client else {
297+ isLoadingStreams = false
298+ return
299+ }
270300 streams = loaded
271301 // Drop a selection that no longer exists server-side (e.g. the stream
272302 // was deleted from another client); otherwise the detail tabs keep
@@ -275,7 +305,10 @@ final class AppState {
275305 selectedStream = nil
276306 }
277307 } catch {
278− guard connID == activeConnection?.id else { isLoadingStreams = false; return }
308+ guard connID == activeConnection?.id, client === self.client else {
309+ isLoadingStreams = false
310+ return
311+ }
279312 let message = ParseableError.userFriendlyMessage(for: error)
280313 streamLoadError = message
281314 self.errorMessage = "Failed to load streams: \(message)"
@@ -342,9 +375,49 @@ final class AppState {
342375 ConnectionStore.saveConnections(connections)
343376 if activeConnection?.id == connection.id {
344377 disconnect()
378+ } else if connectingConnectionID == connection.id {
379+ // The removed connection is still being connected to (e.g. Cancel in the
380+ // connection sheet, or deleting it in Settings during the launch
381+ // reconnect). `activeConnection` doesn't point at it yet, so without
382+ // this the connect would carry on and install a client for a
383+ // connection that no longer exists (or tear down the current session
384+ // when it fails) after the user abandoned it.
385+ connectTask?.cancel()
386+ connectTask = nil
387+ connectingConnectionID = nil
388+ // Starting that connect already cleared the current server's stream
389+ // list and filters; reload them if we're still connected to it.
390+ if client != nil {
391+ Task { @MainActor [weak self] in
392+ await self?.refreshStreams()
393+ await self?.refreshFilters()
394+ }
395+ }
396+ }
397+ }
398+
399+ /// `/api/v1/liveness` is unauthenticated on Parseable (it answers 200 to
400+ /// anyone, for load-balancer / k8s probes), so a health check alone accepts
401+ /// any username and password. Probe an authenticated endpoint and fail on
402+ /// 401. Other failures — e.g. a 403 for a role without the about permission —
403+ /// don't show the credentials are wrong, so they're ignored here. The client
404+ /// caches the response, so the follow-up `getAbout()` load reuses it.
405+ static func verifyCredentials(with client: ParseableClient) async throws {
406+ do {
407+ _ = try await client.getAbout()
408+ } catch ParseableError.unauthorized {
409+ throw ParseableError.unauthorized
410+ } catch {
411+ // Not an authentication failure; leave it to the best-effort loads.
345412 }
346413 }
347414
415+ private static func isLoopback(_ url: URL?) -> Bool {
416+ guard let host = url?.host?.lowercased() else { return false }
417+ return host == "localhost" || host.hasSuffix(".localhost")
418+ || host == "::1" || host.hasPrefix("127.")
419+ }
420+
348421 // MARK: - Stream Management
349422
350423 @MainActor
@@ -377,7 +450,10 @@ final class AppState {
377450 let connID = activeConnection?.id
378451 isLoadingFilters = true
379452 let loaded = (try? await client.listFilters()) ?? []
380− guard connID == activeConnection?.id else { isLoadingFilters = false; return }
453+ guard connID == activeConnection?.id, client === self.client else {
454+ isLoadingFilters = false
455+ return
456+ }
381457 filters = loaded
382458 isLoadingFilters = false
383459 }
ParseableViewer/App/ParseableViewerApp.swift+13−1
@@ -4,6 +4,13 @@ import SwiftUI
44struct ParseableViewerApp: App {
55 @State private var appState = AppState()
66
7+ init() {
8+ // All window content shares one AppState (see the File > New group below),
9+ // so don't offer window tabs either: the tab bar's "+" would open a second
10+ // window just like File > New Window.
11+ NSWindow.allowsAutomaticWindowTabbing = false
12+ }
13+
714 var body: some Scene {
815 WindowGroup {
916 ContentView()
@@ -17,7 +24,12 @@ struct ParseableViewerApp: App {
1724 AboutCommand()
1825 }
1926
20− CommandGroup(after: .newItem) {
27+ // Replace (rather than extend) the File > New group to drop "New Window":
28+ // connection, sheet, alert, selection and pending-filter state all live
29+ // in the single shared AppState, so a second window would present every
30+ // sheet and alert twice and race the first window's QueryView for
31+ // saved-filter SQL.
32+ CommandGroup(replacing: .newItem) {
2133 Button("New Connection...") {
2234 appState.editingConnection = nil
2335 appState.showConnectionSheet = true
ParseableViewer/Info.plist+5
@@ -24,6 +24,11 @@
2424 <string>public.app-category.developer-tools</string>
2525 <key>LSMinimumSystemVersion</key>
2626 <string>$(MACOSX_DEPLOYMENT_TARGET)</string>
27+ <key>NSAppTransportSecurity</key>
28+ <dict>
29+ <key>NSAllowsArbitraryLoads</key>
30+ <true/>
31+ </dict>
2732 <key>NSMainNibFile</key>
2833 <string></string>
2934 <key>NSPrincipalClass</key>
ParseableViewer/Models/ServerConnection.swift+19−2
@@ -56,15 +56,32 @@ struct ServerConnection: Identifiable, Codable, Hashable, Sendable {
5656 var baseURL: URL? {
5757 var urlString = url.trimmingCharacters(in: .whitespacesAndNewlines)
5858 if urlString.isEmpty { return nil }
59− if !urlString.hasPrefix("http://") && !urlString.hasPrefix("https://") {
59+ if let schemeRange = Self.urlSchemeRange(in: urlString) {
60+ // Normalize the (case-insensitive) scheme so `HTTP://host` behaves
61+ // exactly like `http://host` everywhere downstream.
62+ urlString.replaceSubrange(schemeRange, with: urlString[schemeRange].lowercased())
63+ } else {
6064 urlString = "https://\(urlString)"
6165 }
6266 while urlString.hasSuffix("/") {
6367 urlString.removeLast()
6468 }
65− guard let parsed = URL(string: urlString), parsed.host != nil else {
69+ guard let parsed = URL(string: urlString), parsed.host != nil,
70+ parsed.scheme == "http" || parsed.scheme == "https" else {
6671 return nil
6772 }
6873 return parsed
6974 }
75+
76+ /// Whether `string` already starts with a URL scheme (`http://`, `HTTPS://`,
77+ /// `ftp://`, …). Schemes are case-insensitive, so a case-sensitive
78+ /// `hasPrefix("http://")` check turned `HTTP://host` into
79+ /// `https://HTTP://host` — a URL whose host is "HTTP".
80+ static func hasURLScheme(_ string: String) -> Bool {
81+ urlSchemeRange(in: string) != nil
82+ }
83+
84+ private static func urlSchemeRange(in string: String) -> Range<String.Index>? {
85+ string.range(of: "^[A-Za-z][A-Za-z0-9+.-]*://", options: .regularExpression)
86+ }
7087}
ParseableViewer/Views/ConnectionSheet.swift+27−7
@@ -18,6 +18,10 @@ struct ConnectionSheet: View {
1818 /// retry (after a failed connect) updates it in place rather than appending a
1919 /// duplicate.
2020 @State private var createdConnection: ServerConnection?
21+ /// Bumped on every field edit and every test run, so an in-flight Test
22+ /// Connection whose fields have since changed doesn't post its (now stale)
23+ /// success/failure under values that were never tested.
24+ @State private var testGeneration = 0
2125
2226 enum TestResult {
2327 case success(String)
@@ -43,7 +47,7 @@ struct ConnectionSheet: View {
4347 TextField("Name:", text: $name)
4448 .textFieldStyle(.roundedBorder)
4549 .accessibilityLabel("Connection name")
46− .onChange(of: name) { _, _ in testResult = nil }
50+ .onChange(of: name) { _, _ in invalidateTestResult() }
4751
4852 TextField("Server URL:", text: $url)
4953 .textFieldStyle(.roundedBorder)
@@ -51,7 +55,7 @@ struct ConnectionSheet: View {
5155 .onChange(of: url) { _, newValue in
5256 urlValidationError = Self.validateURL(newValue)
5357 // A prior test result no longer reflects the edited fields.
54− testResult = nil
58+ invalidateTestResult()
5559 }
5660
5761 if let urlError = urlValidationError, !url.isEmpty {
@@ -63,12 +67,12 @@ struct ConnectionSheet: View {
6367 TextField("Username:", text: $username)
6468 .textFieldStyle(.roundedBorder)
6569 .accessibilityLabel("Username")
66− .onChange(of: username) { _, _ in testResult = nil }
70+ .onChange(of: username) { _, _ in invalidateTestResult() }
6771
6872 SecureField("Password:", text: $password)
6973 .textFieldStyle(.roundedBorder)
7074 .accessibilityLabel("Password")
71− .onChange(of: password) { _, _ in testResult = nil }
75+ .onChange(of: password) { _, _ in invalidateTestResult() }
7276 }
7377 .formStyle(.grouped)
7478 .padding()
@@ -165,9 +169,16 @@ struct ConnectionSheet: View {
165169 }
166170 }
167171
172+ private func invalidateTestResult() {
173+ testGeneration += 1
174+ testResult = nil
175+ }
176+
168177 private func testConnection() {
169178 isTesting = true
170179 testResult = nil
180+ testGeneration += 1
181+ let generation = testGeneration
171182
172183 Task {
173184 do {
@@ -179,14 +190,19 @@ struct ConnectionSheet: View {
179190 )
180191 let client = try ParseableClient(connection: conn)
181192 try await client.checkHealth()
193+ // The health endpoint doesn't check credentials; see
194+ // AppState.verifyCredentials.
195+ try await AppState.verifyCredentials(with: client)
182196 await MainActor.run {
183− testResult = .success("Connection successful")
184197 isTesting = false
198+ guard generation == testGeneration else { return }
199+ testResult = .success("Connection successful")
185200 }
186201 } catch {
187202 await MainActor.run {
188− testResult = .failure(ParseableError.userFriendlyMessage(for: error))
189203 isTesting = false
204+ guard generation == testGeneration else { return }
205+ testResult = .failure(ParseableError.userFriendlyMessage(for: error))
190206 }
191207 }
192208 }
@@ -221,6 +237,10 @@ struct ConnectionSheet: View {
221237 dismiss()
222238 } else {
223239 testResult = .failure(appState.errorMessage ?? "Connection failed")
240+ // The sheet reports the failure inline; drop the app-wide alert
241+ // performConnect also raised, which would otherwise surface
242+ // behind/after the sheet (or twice, from the Settings window).
243+ appState.showError = false
224244 }
225245 }
226246 }
@@ -231,7 +251,7 @@ struct ConnectionSheet: View {
231251 guard !trimmed.isEmpty else { return nil }
232252
233253 var normalized = trimmed
234− if !normalized.hasPrefix("http://") && !normalized.hasPrefix("https://") {
254+ if !ServerConnection.hasURLScheme(normalized) {
235255 normalized = "https://\(normalized)"
236256 }
237257
ParseableViewer/Views/SidebarView.swift+19−1
@@ -6,6 +6,14 @@ struct SidebarView: View {
66 @State private var newStreamName = ""
77 @State private var showDeleteConfirm = false
88 @State private var streamToDelete: String?
9+ /// The connection `streamToDelete` was picked on. Stream names aren't unique
10+ /// across servers, and the delete runs against whatever client is current
11+ /// when the user confirms — so a server switch while the stats lookup was in
12+ /// flight could otherwise delete a same-named stream on the *new* server.
13+ @State private var streamToDeleteConnectionID: UUID?
14+ /// The client the stream was picked with. Editing the active connection's URL
15+ /// keeps its id but installs a new client for a possibly different server.
16+ @State private var streamToDeleteClient: ParseableClient?
917 @State private var deleteStreamDetail: String?
1018
1119 /// Validates a stream name, returning an error message or nil if valid.
@@ -65,7 +73,10 @@ struct SidebarView: View {
6573 // would show the wrong stats on a destructive
6674 // confirmation.
6775 let target = stream.name
76+ let targetConnectionID = appState.activeConnection?.id
6877 streamToDelete = target
78+ streamToDeleteConnectionID = targetConnectionID
79+ streamToDeleteClient = appState.client
6980 deleteStreamDetail = nil
7081 Task {
7182 if let client = appState.client,
@@ -81,7 +92,9 @@ struct SidebarView: View {
8192 deleteStreamDetail = parts.joined(separator: ", ")
8293 }
8394 }
84− if streamToDelete == target {
95+ if streamToDelete == target,
96+ appState.activeConnection?.id == targetConnectionID,
97+ appState.client === streamToDeleteClient {
8598 showDeleteConfirm = true
8699 }
87100 }
@@ -187,6 +200,11 @@ struct SidebarView: View {
187200 .alert("Delete Stream", isPresented: $showDeleteConfirm) {
188201 Button("Delete", role: .destructive) {
189202 if let name = streamToDelete {
203+ guard appState.activeConnection?.id == streamToDeleteConnectionID,
204+ appState.client === streamToDeleteClient else {
205+ appState.showErrorMessage("The server changed since \"\(name)\" was selected, so it was not deleted.")
206+ return
207+ }
190208 Task {
191209 do {
192210 try await appState.deleteStream(name: name)
ParseableViewerTests/ServerConnectionTests.swift+10
@@ -77,4 +77,14 @@ final class ServerConnectionTests: XCTestCase {
7777 let conn = ServerConnection(name: "test", url: "https://", username: "admin", password: "pass")
7878 XCTAssertNil(conn.baseURL)
7979 }
80+
81+ func testBaseURLAcceptsUppercaseScheme() {
82+ let conn = ServerConnection(name: "t", url: "HTTP://10.0.0.5:8000", username: "u", password: "p")
83+ XCTAssertEqual(conn.baseURL?.absoluteString, "http://10.0.0.5:8000")
84+ }
85+
86+ func testBaseURLRejectsNonHTTPScheme() {
87+ let conn = ServerConnection(name: "t", url: "ftp://example.com", username: "u", password: "p")
88+ XCTAssertNil(conn.baseURL)
89+ }
8090}