@@ -2,6 +2,7 @@ import Foundation
2import SwiftUI
2import SwiftUI
5final class QueryViewModel {
6final class QueryViewModel {
6 var sqlQuery = "" {
7 var sqlQuery = "" {
@@ -16,6 +17,8 @@ final class QueryViewModel {
16 // Build search texts asynchronously
17 // Build search texts asynchronously
17 searchTextTask?.cancel()
18 searchTextTask?.cancel()
18 cachedSearchTexts = []
19 cachedSearchTexts = []
20+ searchTextGeneration &+= 1
21+ let generation = searchTextGeneration
19 // Apply the current filter immediately using the inline fallback path
22 // Apply the current filter immediately using the inline fallback path
20 // (the cache was just invalidated). Calling updateFilteredResults()
23 // (the cache was just invalidated). Calling updateFilteredResults()
21 // rather than `filteredResults = results` avoids briefly showing
24 // rather than `filteredResults = results` avoids briefly showing
@@ -24,26 +27,61 @@ final class QueryViewModel {
24 // re-applies the filter.
27 // re-applies the filter.
25 updateFilteredResults()
28 updateFilteredResults()
26 let snapshot = results
29 let snapshot = results
30+ // The class is @MainActor, so this Task inherits main-actor isolation —
31+ // its mutations of cachedSearchTexts/filteredResults are safely serialized
32+ // with SwiftUI reads. Only the pure (and potentially large) displayString
33+ // mapping is pushed off-main via Task.detached so it doesn't block the UI.
27− searchTextTask = Task {
34+ searchTextTask = Task { [weak self] in
35+ let texts = await Task.detached(priority: .userInitiated) {
28− let texts = snapshot.map { record in
36+ snapshot.map { record in
29− record.values.map { $0.displayString }.joined(separator: " ")
37+ record.values.map { $0.displayString }.joined(separator: " ")
31− guard !Task.isCancelled else { return }
40+ guard let self, !Task.isCancelled else { return }
41+ // Reject a stale write: if `results` was reassigned while this task
42+ // was awaiting, a newer didSet bumped the generation. Task.isCancelled
43+ // alone isn't sufficient because two re-queries producing result sets
44+ // of identical count would otherwise let this stale, same-length
45+ // cachedSearchTexts slip past updateFilteredResults's count guard.
46+ guard generation == self.searchTextGeneration else { return }
32− cachedSearchTexts = texts
47+ self.cachedSearchTexts = texts
33− if !filterText.isEmpty {
48+ if !self.filterText.isEmpty {
34− updateFilteredResults()
49+ self.updateFilteredResults()
39 private var cachedSearchTexts: [String] = []
54 private var cachedSearchTexts: [String] = []
40 private var searchTextTask: Task<Void, Never>?
55 private var searchTextTask: Task<Void, Never>?
56+ /// Bumped on every `results` reassignment so the async search-text builder can
57+ /// detect it was superseded and drop a stale write (see results.didSet).
58+ private var searchTextGeneration = 0
41 var columns: [String] = []
59 var columns: [String] = []
42 var columnOrder: [String] = []
60 var columnOrder: [String] = []
43 var hiddenColumns: Set<String> = []
61 var hiddenColumns: Set<String> = []
62+ /// The full persisted set of hidden columns for the current stream, including
63+ /// ones absent from the current result. Hiding a column drops it from the
64+ /// SELECT list, so it's missing from the very next result and `hiddenColumns`
65+ /// (only the columns present) forgets it — the next save would then erase the
66+ /// preference. This keeps the intent, mirroring LiveTailViewModel.
67+ private(set) var savedHiddenColumns: Set<String> = []
68+ /// The persisted column order including columns absent from the current
69+ /// result (the order counterpart of `savedHiddenColumns`), so saving doesn't
70+ /// drop a hidden column's position and it returns to its place when shown.
71+ private var savedColumnOrder: [String] = []
44 var autoHiddenColumns: Set<String> = []
72 var autoHiddenColumns: Set<String> = []
45 /// Column config from a saved query, applied on next query execution.
73 /// Column config from a saved query, applied on next query execution.
46 var pendingColumnConfig: ColumnConfiguration?
74 var pendingColumnConfig: ColumnConfiguration?
76+ /// The connection and stream the editor text and results belong to. The view
77+ /// model outlives QueryView (switching tabs keeps the query), so the view
78+ /// compares this on appear to catch a stream/server change made while another
80+ struct BoundContext: Equatable {
81+ let connectionID: UUID?
84+ var boundContext: BoundContext?
47 private var currentStream: String?
85 private var currentStream: String?
48 var isLoading = false
86 var isLoading = false
49 var errorMessage: String?
87 var errorMessage: String?
@@ -61,10 +99,23 @@ final class QueryViewModel {
61 var schemaFields: [SchemaField] = []
99 var schemaFields: [SchemaField] = []
62 /// The stream of the most recent `loadSchema` call, used to drop a stale
100 /// The stream of the most recent `loadSchema` call, used to drop a stale
63 /// in-flight response when the user rapidly switches streams.
101 /// in-flight response when the user rapidly switches streams.
64− private var latestSchemaStream: String?
102+ private(set) var latestSchemaStream: String?
103+ /// The stream of the most recent `executeQuery` call. Defense-in-depth
104+ /// alongside `queryGeneration`/task cancellation: drops a stale in-flight
105+ /// query response if a newer query for a different stream supersedes it
106+ /// without going through the normal cancel path.
107+ private var latestQueryStream: String?
66 // Query task for cancellation
109 // Query task for cancellation
67 private var queryTask: Task<Void, Never>?
110 private var queryTask: Task<Void, Never>?
111+ /// Bumped at the start of every `executeQuery`. The task captures this value
112+ /// and only clears `isLoading` on exit if it's still the active query — so a
113+ /// superseded query's late cleanup doesn't drop the loading indicator that
114+ /// the newer query set. Without this, `isLoading = false` had to live in
115+ /// every caller of `cancel()` (cancelQuery, clearResults, superseding
116+ /// executeQuery) and a future cancel path that forgot to set it would wedge
117+ /// the spinner indefinitely.
118+ private var queryGeneration = 0
69 // Time range
120 // Time range
70 var timeRangeOption: TimeRangeOption = .last1Hour
121 var timeRangeOption: TimeRangeOption = .last1Hour
@@ -161,9 +212,16 @@ final class QueryViewModel {
161 return columnOrder.filter { !allHidden.contains($0) }
212 return columnOrder.filter { !allHidden.contains($0) }
215+ /// Whether any column is hidden — including saved-hidden columns that aren't
216+ /// in the current result, which "Show All" can bring back.
217+ var hasHiddenColumns: Bool {
218+ !hiddenColumns.isEmpty || !autoHiddenColumns.isEmpty || !savedHiddenColumns.isEmpty
164 func toggleColumnVisibility(_ column: String) {
221 func toggleColumnVisibility(_ column: String) {
165 if hiddenColumns.contains(column) {
222 if hiddenColumns.contains(column) {
166 hiddenColumns.remove(column)
223 hiddenColumns.remove(column)
224+ savedHiddenColumns.remove(column)
167 } else if autoHiddenColumns.contains(column) {
225 } else if autoHiddenColumns.contains(column) {
168 autoHiddenColumns.remove(column)
226 autoHiddenColumns.remove(column)
@@ -172,6 +230,7 @@ final class QueryViewModel {
172 let visibleCount = columnOrder.count - allHidden.count
230 let visibleCount = columnOrder.count - allHidden.count
173 if visibleCount > 1 {
231 if visibleCount > 1 {
174 hiddenColumns.insert(column)
232 hiddenColumns.insert(column)
233+ savedHiddenColumns.insert(column)
177 saveColumnConfig()
236 saveColumnConfig()
@@ -180,6 +239,7 @@ final class QueryViewModel {
181 func showAllColumns() {
240 func showAllColumns() {
182 hiddenColumns.removeAll()
241 hiddenColumns.removeAll()
242+ savedHiddenColumns.removeAll()
183 autoHiddenColumns.removeAll()
243 autoHiddenColumns.removeAll()
184 saveColumnConfig()
244 saveColumnConfig()
185 updateSQLColumns()
245 updateSQLColumns()
@@ -209,32 +269,116 @@ final class QueryViewModel {
210 func resetColumnConfig() {
270 func resetColumnConfig() {
211 columnOrder = columns
271 columnOrder = columns
272+ savedColumnOrder = []
212 hiddenColumns.removeAll()
273 hiddenColumns.removeAll()
274+ savedHiddenColumns.removeAll()
213 autoHiddenColumns.removeAll()
275 autoHiddenColumns.removeAll()
214 saveColumnConfig()
276 saveColumnConfig()
215 updateSQLColumns()
277 updateSQLColumns()
218− /// Rewrites the SELECT clause of `sqlQuery` to reflect the current `visibleColumns`.
280+ /// Rewrites the SELECT clause of `sqlQuery` to reflect the user's column
281+ /// choices (order and hidden columns; auto-hidden columns stay display-only).
219 func updateSQLColumns() {
282 func updateSQLColumns() {
220− guard let range = SQLTokenizer.selectColumnListRange(in: sqlQuery) else { return }
283+ guard let range = SQLTokenizer.selectColumnListRange(in: sqlQuery),
221−
284+ let currentList = Self.parseColumnList(sqlQuery[range]) else { return }
222− let visible = visibleColumns
285+
286+ // Project the user's choices only. `autoHiddenColumns` is a display
287+ // heuristic for the current rows (the field is empty in all of them);
288+ // baking it into the SQL would stop the field from ever being fetched
289+ // again, even for a time range where it has values.
290+ let visible = columnOrder.filter { !hiddenColumns.contains($0) }
223 guard !visible.isEmpty else { return }
291 guard !visible.isEmpty else { return }
293+ // Columns an explicit list names that aren't in the results: Parseable
294+ // omits all-null fields from query JSON, so a sparse listed field can be
295+ // missing from `columns`. Keep it (unless the user hid it) rather than
296+ // silently dropping it from the SELECT on the next rewrite.
297+ var listedButAbsent: [String] = []
298+ var excludesHiddenColumn = false
299+ if case .identifiers(let names) = currentList {
300+ let present = Set(columns)
301+ listedButAbsent = names.filter { !present.contains($0) && !savedHiddenColumns.contains($0) }
302+ // A column the user hid is absent from these results precisely
303+ // because this list was narrowed to exclude it.
304+ excludesHiddenColumn = !savedHiddenColumns.isSubset(of: present)
225 let newColumnList: String
307 let newColumnList: String
226 // Use `*` whenever every column is visible, regardless of display order —
308 // Use `*` whenever every column is visible, regardless of display order —
227 // reordering columns (a set-preserving permutation) must not pin the query
309 // reordering columns (a set-preserving permutation) must not pin the query
228− // to an explicit snapshot that hides newly-appearing fields on re-query.
310+ // to an explicit snapshot that hides newly-appearing fields on re-query —
311+ // unless the list is explicit because it leaves out a hidden column, which
312+ // `*` would fetch again.
229− if visible.count == columns.count && Set(visible) == Set(columns) {
313+ if !excludesHiddenColumn && visible.count == columns.count && Set(visible) == Set(columns) {
230 newColumnList = "*"
314 newColumnList = "*"
232− newColumnList = visible.map { Self.escapeSQLIdentifier($0) }.joined(separator: ", ")
316+ newColumnList = (visible + listedButAbsent).map { Self.escapeSQLIdentifier($0) }.joined(separator: ", ")
235 sqlQuery.replaceSubrange(range, with: newColumnList)
319 sqlQuery.replaceSubrange(range, with: newColumnList)
322+ enum ColumnListShape: Equatable {
324+ /// Plain column references, as the column names they resolve to.
325+ case identifiers([String])
328+ /// Parses a SELECT list the column manager can regenerate without changing
329+ /// what the query computes: `*`, or a comma-separated list of plain column
330+ /// references. Anything else — aggregates, expressions, aliases
331+ /// (`count(*) AS n`), qualified names — returns nil: rewriting it with `*` or
332+ /// bare result keys would break the query, so the column manager then only
333+ /// hides/reorders client-side.
334+ nonisolated static func parseColumnList(_ list: Substring) -> ColumnListShape? {
335+ let tokens = SQLTokenizer.tokenize(String(list)).filter { !$0.kind.isTrivia }
336+ if tokens.count == 1, tokens[0].kind == .star { return .star }
337+ guard tokens.count % 2 == 1 else { return nil }
338+ var names: [String] = []
339+ for (index, token) in tokens.enumerated() {
341+ guard token.kind == .comma else { return nil }
345+ // DataFusion folds unquoted identifiers to lowercase.
346+ case .identifier(let name): names.append(name.lowercased())
347+ case .quotedIdentifier(let name): names.append(name)
351+ return .identifiers(names)
354+ /// Inserts `newColumns` into `order`, placing each one that appears in
355+ /// `reference` (a saved order) right after its nearest saved predecessor
356+ /// that's already placed — or first if none is — and appending the rest.
357+ /// Used to keep the positions of columns that are absent for a while.
358+ nonisolated static func mergedColumnOrder(
359+ _ order: [String], inserting newColumns: [String], reference: [String]
362+ let referenceIndex = Dictionary(reference.enumerated().map { ($1, $0) }, uniquingKeysWith: { first, _ in first })
363+ let pending = newColumns.filter { referenceIndex[$0] == nil }
364+ let positioned = newColumns
365+ .filter { referenceIndex[$0] != nil }
366+ .sorted { referenceIndex[$0]! < referenceIndex[$1]! }
367+ for column in positioned where !result.contains(column) {
368+ let savedIndex = referenceIndex[column]!
369+ let predecessor = reference[..<savedIndex].reversed().first { result.contains($0) }
370+ if let predecessor, let position = result.firstIndex(of: predecessor) {
371+ result.insert(column, at: position + 1)
373+ result.insert(column, at: 0)
376+ for column in pending where !result.contains(column) {
377+ result.append(column)
238 // MARK: - Column Configuration Persistence
382 // MARK: - Column Configuration Persistence
240 struct ColumnConfiguration: Codable {
384 struct ColumnConfiguration: Codable {
@@ -248,7 +392,16 @@ final class QueryViewModel {
249 private func saveColumnConfig() {
393 private func saveColumnConfig() {
250 guard let stream = currentStream else { return }
394 guard let stream = currentStream else { return }
395+ // Persist the full intended hidden set and order, not just the currently
396+ // present columns (see `savedHiddenColumns` / `savedColumnOrder`).
397+ let present = Set(columnOrder)
398+ let order = Self.mergedColumnOrder(
400+ inserting: savedColumnOrder.filter { !present.contains($0) },
401+ reference: savedColumnOrder
403+ savedColumnOrder = order
251− let config = ColumnConfiguration(order: columnOrder, hidden: hiddenColumns)
404+ let config = ColumnConfiguration(order: order, hidden: savedHiddenColumns.union(hiddenColumns))
252 if let data = try? JSONEncoder().encode(config) {
405 if let data = try? JSONEncoder().encode(config) {
253 UserDefaults.standard.set(data, forKey: Self.columnConfigKey(for: stream))
406 UserDefaults.standard.set(data, forKey: Self.columnConfigKey(for: stream))
@@ -277,7 +430,9 @@ final class QueryViewModel {
278 guard let config else {
431 guard let config else {
279 columnOrder = extractedColumns
432 columnOrder = extractedColumns
433+ savedColumnOrder = []
280 hiddenColumns = []
434 hiddenColumns = []
435+ savedHiddenColumns = []
@@ -290,6 +445,8 @@ final class QueryViewModel {
290 merged.append(col)
445 merged.append(col)
292 columnOrder = merged
447 columnOrder = merged
448+ savedColumnOrder = config.order
449+ savedHiddenColumns = config.hidden
293 hiddenColumns = config.hidden.intersection(extractedSet)
450 hiddenColumns = config.hidden.intersection(extractedSet)
295 // The `visibleCount > 1` guard in toggleColumnVisibility only covers
452 // The `visibleCount > 1` guard in toggleColumnVisibility only covers
@@ -383,6 +540,13 @@ final class QueryViewModel {
384 // Cancel any in-flight query
541 // Cancel any in-flight query
385 queryTask?.cancel()
542 queryTask?.cancel()
543+ // Bump the generation so the in-flight task's cleanup can detect that
544+ // it has been superseded and skip its `isLoading = false` (which would
545+ // otherwise race with the `isLoading = true` below and briefly drop
546+ // the loading indicator during this query).
547+ queryGeneration &+= 1
548+ let generation = queryGeneration
549+ latestQueryStream = stream
387 isLoading = true
551 isLoading = true
388 errorMessage = nil
552 errorMessage = nil
@@ -391,6 +555,16 @@ final class QueryViewModel {
391 let startTime = CFAbsoluteTimeGetCurrent()
555 let startTime = CFAbsoluteTimeGetCurrent()
393 let task = Task {
557 let task = Task {
558+ // Always clear the spinner on exit when this is still the active
559+ // query. The defer runs on every path (success, error, and the
560+ // cancellation cases that previously returned before reaching the
561+ // trailing `isLoading = false`), so the spinner can never wedge
562+ // even if a new cancel path is added without resetting it.
564+ if generation == queryGeneration {
395 try Task.checkCancellation()
569 try Task.checkCancellation()
396 let queryResults = try await client.query(sql: sql, startTime: startDate, endTime: endDate)
570 let queryResults = try await client.query(sql: sql, startTime: startDate, endTime: endDate)
@@ -400,14 +574,25 @@ final class QueryViewModel {
400 // cancellation landing just after the check above would otherwise
574 // cancellation landing just after the check above would otherwise
401 // let a stale query clobber the newer one's results/columns.
575 // let a stale query clobber the newer one's results/columns.
402 guard !Task.isCancelled else { return }
576 guard !Task.isCancelled else { return }
577+ // Drop the response if a newer query (possibly for a different
578+ // stream) has since been launched without cancelling this task.
579+ guard latestQueryStream == stream else { return }
404 results = queryResults
581 results = queryResults
582+ // Drop any prior row selection: the new result set reassigns row
583+ // identities, so a retained selectedLogEntry would either dangle or
584+ // value-match an unrelated row, leaving a stale detail inspector.
585+ selectedLogEntry = nil
405 queryDuration = CFAbsoluteTimeGetCurrent() - startTime
586 queryDuration = CFAbsoluteTimeGetCurrent() - startTime
406 resultCount = results.count
587 resultCount = results.count
408− // Detect if results were likely truncated (only meaningful
589+ // Detect if results were likely truncated. We know the cap for
409− // for auto-generated queries where we control the LIMIT)
590+ // auto-generated queries; for user-entered SQL (which includes the
591+ // default query `setDefaultQuery` writes into the editor — the common
592+ // stream-selection path), parse a trailing `LIMIT n` so the indicator
593+ // still fires when the row count lands exactly on the limit.
594+ let effectiveLimit = usedAutoLimit ? limit : Self.trailingLimit(in: sql)
410− resultsTruncated = usedAutoLimit && results.count == limit
595+ resultsTruncated = effectiveLimit.map { results.count == $0 } ?? false
412 // Extract columns in a single pass, with priority fields first,
597 // Extract columns in a single pass, with priority fields first,
413 // then apply any saved column configuration for this stream
598 // then apply any saved column configuration for this stream
@@ -434,12 +619,23 @@ final class QueryViewModel {
435 } catch {
620 } catch {
436 guard !Task.isCancelled else { return }
621 guard !Task.isCancelled else { return }
622+ // Same supersession guard as the success path: a stale failed
623+ // query must not clobber a newer query's state.
624+ guard latestQueryStream == stream else { return }
437 errorMessage = ParseableError.userFriendlyMessage(for: error)
625 errorMessage = ParseableError.userFriendlyMessage(for: error)
438 if let serverError = error as? ParseableError,
626 if let serverError = error as? ParseableError,
439 case .serverError(_, let msg) = serverError,
627 case .serverError(_, let msg) = serverError,
440− let pos = SQLErrorPosition.parse(from: msg) {
628+ let pos = SQLErrorPosition.parse(from: msg),
630+ // The server's line/column is relative to the *submitted* SQL.
631+ // Only map it back into the editor when the editor still holds
632+ // that same text — if the user edited the query while it was in
633+ // flight, the position no longer corresponds to what's displayed
634+ // and would underline an unrelated span. (`sqlQuery`'s didSet
635+ // already cleared errorRange on that edit, so leaving it nil here
636+ // keeps the editor unmarked.)
441 errorRange = SQLTokenizer.errorHighlightRange(
637 errorRange = SQLTokenizer.errorHighlightRange(
442− line: pos.line, column: pos.column, in: sqlQuery
638+ line: pos.line, column: pos.column, in: sql
445 results = []
641 results = []
@@ -449,10 +645,10 @@ final class QueryViewModel {
449 // report stale column names after the failure.
645 // report stale column names after the failure.
450 columnOrder = []
646 columnOrder = []
451 hiddenColumns = []
647 hiddenColumns = []
648+ savedHiddenColumns = []
649+ savedColumnOrder = []
452 autoHiddenColumns = []
650 autoHiddenColumns = []
457 queryTask = task
653 queryTask = task
458 await task.value
654 await task.value
@@ -547,7 +743,7 @@ final class QueryViewModel {
547 /// Projects each record down to the given columns so JSON export, like CSV,
743 /// Projects each record down to the given columns so JSON export, like CSV,
548 /// respects hidden columns instead of leaking every field. Safe to call from
744 /// respects hidden columns instead of leaking every field. Safe to call from
549 /// any thread.
745 /// any thread.
550− static func projectRecords(_ records: [LogRecord], to columns: [String]) -> [LogRecord] {
746+ nonisolated static func projectRecords(_ records: [LogRecord], to columns: [String]) -> [LogRecord] {
551 // No column list means no restriction (columns not computed yet) — export
747 // No column list means no restriction (columns not computed yet) — export
552 // the full records rather than stripping every field to an empty object.
748 // the full records rather than stripping every field to an empty object.
553 guard !columns.isEmpty else { return records }
749 guard !columns.isEmpty else { return records }
@@ -556,7 +752,7 @@ final class QueryViewModel {
558 /// Builds a CSV string from records and columns. Safe to call from any thread.
754 /// Builds a CSV string from records and columns. Safe to call from any thread.
559− static func buildCSV(records: [LogRecord], columns: [String]) -> String {
755+ nonisolated static func buildCSV(records: [LogRecord], columns: [String]) -> String {
560 guard !records.isEmpty, !columns.isEmpty else { return "" }
756 guard !records.isEmpty, !columns.isEmpty else { return "" }
562 var csv = String()
758 var csv = String()
@@ -582,7 +778,7 @@ final class QueryViewModel {
582 return csv
778 return csv
585− private static func escapeCSV(_ value: String) -> String {
781+ nonisolated private static func escapeCSV(_ value: String) -> String {
586 // Check at the Unicode scalar level to correctly detect \r and \n
782 // Check at the Unicode scalar level to correctly detect \r and \n
587 // inside \r\n (CRLF) grapheme clusters, which Swift's String.contains
783 // inside \r\n (CRLF) grapheme clusters, which Swift's String.contains
588 // treats as a single Character that doesn't match "\r" or "\n" alone.
784 // treats as a single Character that doesn't match "\r" or "\n" alone.
@@ -617,6 +813,8 @@ final class QueryViewModel {
617 columns = []
813 columns = []
618 columnOrder = []
814 columnOrder = []
619 hiddenColumns = []
815 hiddenColumns = []
816+ savedHiddenColumns = []
817+ savedColumnOrder = []
620 autoHiddenColumns = []
818 autoHiddenColumns = []
621 currentStream = nil
819 currentStream = nil
622 resultCount = 0
820 resultCount = 0
@@ -626,6 +824,11 @@ final class QueryViewModel {
626 errorRange = nil
824 errorRange = nil
627 resultsTruncated = false
825 resultsTruncated = false
628 schemaFields = []
826 schemaFields = []
827+ // Keep the stream trackers consistent with the cleared schema/results so
828+ // a later reload guard never sees a non-nil stream paired with empty data.
829+ latestSchemaStream = nil
830+ latestQueryStream = nil
631 /// Modifies `sqlQuery` to add a column-value filter condition.
834 /// Modifies `sqlQuery` to add a column-value filter condition.
@@ -635,75 +838,139 @@ final class QueryViewModel {
635 let condition: String
838 let condition: String
636 if let value, value != .null {
839 if let value, value != .null {
637 let literal = value.sqlLiteral
840 let literal = value.sqlLiteral
841+ // Exclude with `IS DISTINCT FROM`, not `<>`: under SQL's three-valued
842+ // logic `NULL <> 'x'` is NULL, so `<>` also dropped every row where the
843+ // column is missing/NULL — common for sparse fields — which "exclude
844+ // this value" doesn't ask for (the live-tail exclude keeps them too).
846+ ? "\(escapedCol) IS DISTINCT FROM \(literal)"
638− condition = exclude ? "\(escapedCol) <> \(literal)" : "\(escapedCol) = \(literal)"
847+ : "\(escapedCol) = \(literal)"
640 condition = exclude ? "\(escapedCol) IS NOT NULL" : "\(escapedCol) IS NULL"
849 condition = exclude ? "\(escapedCol) IS NOT NULL" : "\(escapedCol) IS NULL"
643− var sql = sqlQuery.trimmingCharacters(in: .whitespacesAndNewlines)
852+ let sql = sqlQuery.trimmingCharacters(in: .whitespacesAndNewlines)
644 if sql.isEmpty { return }
853 if sql.isEmpty { return }
646 // Locate the top-level WHERE and the first trailing clause using the
855 // Locate the top-level WHERE and the first trailing clause using the
647 // tokenizer rather than a raw regex, so keywords inside quoted
856 // tokenizer rather than a raw regex, so keywords inside quoted
648 // identifiers, string literals, comments, or subqueries are ignored.
857 // identifiers, string literals, comments, or subqueries are ignored.
649− let tailKeywords: Set<String> = ["ORDER", "GROUP", "HAVING", "LIMIT", "OFFSET"]
858+ let tokens = SQLTokenizer.tokenize(sql)
650 var depth = 0
859 var depth = 0
651− var whereEnd: String.Index?
860+ // WHERE and the trailing clauses only follow the top-level FROM. Keywords
652− var tailStart: String.Index?
861+ // before it belong to the SELECT list — e.g. a field named `offset` or
862+ // `limit` (which the tokenizer reports as keywords) — and must not be
863+ // mistaken for clause starts.
864+ var fromSeen = false
865+ var whereIndex: Int?
653 // Track whether the existing WHERE body has a top-level OR — only then does
867 // Track whether the existing WHERE body has a top-level OR — only then does
654 // AND-ing a new condition need parentheses to preserve precedence.
868 // AND-ing a new condition need parentheses to preserve precedence.
655 var bodyHasTopLevelOr = false
869 var bodyHasTopLevelOr = false
656− for token in SQLTokenizer.tokenize(sql) {
870+ // The last token that is actual SQL — not whitespace, a comment, or a
871+ // statement-terminating `;`. New text is spliced in right after such
872+ // tokens (never at the raw end of the string), so a trailing `;` or a
873+ // trailing `-- comment` stays at the end instead of swallowing the
874+ // appended condition: `... LIMIT 10;` must not become `... LIMIT 10; WHERE`,
875+ // and `... -- note` must not become `... -- note WHERE <commented out>`.
876+ func isSignificant(_ token: SQLTokenizer.Token) -> Bool {
877+ !token.kind.isTrivia && token.kind != .other(";")
879+ func nextSignificantKind(after index: Int) -> SQLTokenizer.TokenKind? {
880+ tokens[(index + 1)...].first(where: { isSignificant($0) })?.kind
882+ // Whether the keyword at `index` actually opens a trailing clause. ORDER and
883+ // GROUP must be followed by BY (so `WITHIN GROUP (…)` or a column named
884+ // `order` doesn't count), and LIMIT/OFFSET by their row count (so a column
885+ // named `offset` in `WHERE offset > 5` doesn't cut the WHERE body short).
886+ func startsTrailingClause(_ keyword: String, at index: Int) -> Bool {
888+ case "ORDER", "GROUP":
889+ return nextSignificantKind(after: index) == .keyword("BY")
890+ case "LIMIT", "OFFSET":
891+ if case .number = nextSignificantKind(after: index) { return true }
899+ var lastSignificant: Int?
900+ for (idx, token) in tokens.enumerated() {
901+ if isSignificant(token) { lastSignificant = idx }
657 switch token.kind {
902 switch token.kind {
658 case .leftParen:
903 case .leftParen:
659 depth += 1
904 depth += 1
660 case .rightParen:
905 case .rightParen:
661 depth = max(0, depth - 1)
906 depth = max(0, depth - 1)
907+ case .keyword("FROM") where depth == 0:
662− case .keyword(let kw) where depth == 0:
909+ case .keyword(let kw) where depth == 0 && fromSeen:
663− if kw == "WHERE", whereEnd == nil {
910+ if kw == "WHERE", whereIndex == nil {
664− whereEnd = token.range.upperBound
911+ whereIndex = idx
665− } else if tailKeywords.contains(kw), tailStart == nil {
912+ // A trailing clause seen *before* the WHERE (e.g. the GROUP BY of
666− tailStart = token.range.lowerBound
913+ // the first SELECT in `... GROUP BY a UNION ALL SELECT ... WHERE`)
914+ // doesn't end this WHERE's body. Keeping it would make the body
915+ // range run backwards (a trapping `Range`), so look for the
916+ // body's end afresh after the WHERE.
918+ } else if tailIndex == nil, startsTrailingClause(kw, at: idx) {
667− } else if kw == "OR", whereEnd != nil, tailStart == nil {
920+ } else if kw == "OR", whereIndex != nil, tailIndex == nil {
668 bodyHasTopLevelOr = true
921 bodyHasTopLevelOr = true
674−
927+ // Nothing but comments/semicolons — there's no statement to filter.
675− if let whereEnd {
928+ guard let lastSignificant else { return }
930+ // Each branch rebuilds the query from slices of the original text, keeping
931+ // the user's line breaks: joining pieces with single spaces would pull the
932+ // text after a `-- comment` onto the comment's line and comment it out.
933+ // Text spliced directly in front of another token (`(a = 1)ORDER BY`) needs
934+ // a space so the two don't fuse (`... IS NULLORDER BY`).
935+ func separated(_ rest: Substring) -> String {
936+ guard let next = rest.first, !next.isWhitespace, next != ";" else { return String(rest) }
940+ // The WHERE body runs up to the first trailing clause, or to the end
941+ // of the statement. Only its significant tokens bound the splice, so a
942+ // comment between the body and ORDER BY stays after the new condition.
943+ let bodyEndIndex = tailIndex ?? (lastSignificant + 1)
944+ let bodyIndices = (whereIndex + 1)..<bodyEndIndex
945+ if let first = bodyIndices.first(where: { isSignificant(tokens[$0]) }),
946+ let last = bodyIndices.last(where: { isSignificant(tokens[$0]) }) {
676− // Parenthesize the existing WHERE body before AND-ing the new
947+ // Parenthesize the existing WHERE body before AND-ing the new
677− // condition only when it has a top-level OR, otherwise the OR
948+ // condition only when it has a top-level OR, otherwise the OR
678− // silently changes meaning: `WHERE a = 1 OR b = 2` would become
949+ // silently changes meaning: `WHERE a = 1 OR b = 2` would become
679− // `WHERE a = 1 OR b = 2 AND c = 3`, which SQL binds as
950+ // `WHERE a = 1 OR b = 2 AND c = 3`, which SQL binds as
680− // `a = 1 OR (b = 2 AND c = 3)` rather than the intended
951+ // `a = 1 OR (b = 2 AND c = 3)` rather than the intended
681− // `(a = 1 OR b = 2) AND c = 3`. A body without a top-level OR is
952+ // `(a = 1 OR b = 2) AND c = 3`. A body without a top-level OR is
682− // left un-parenthesized so simple filters stay readable.
953+ // left un-parenthesized so simple filters stay readable.
683− let bodyEnd = tailStart ?? sql.endIndex
954+ let bodyStart = tokens[first].range.lowerBound
684− let head = sql[..<whereEnd]
955+ let bodyEnd = tokens[last].range.upperBound
685− let body = sql[whereEnd..<bodyEnd].trimmingCharacters(in: .whitespacesAndNewlines)
956+ let body = sql[bodyStart..<bodyEnd]
686− let tail = sql[bodyEnd...].trimmingCharacters(in: .whitespacesAndNewlines)
957+ let wrappedBody = bodyHasTopLevelOr ? "(\(body))" : String(body)
687− // An empty WHERE body (e.g. a half-written `... WHERE` with no
958+ sqlQuery = "\(sql[..<bodyStart])\(wrappedBody) AND \(condition)\(separated(sql[bodyEnd...]))"
688− // condition yet, or `WHERE` immediately followed by ORDER/GROUP/
689− // LIMIT) would otherwise produce `WHERE AND <condition>` — a
690− // dangling AND with no left operand. Drop the AND in that case.
692− sql = "\(head) \(condition)"
694− let wrappedBody = bodyHasTopLevelOr ? "(\(body))" : body
960+ // An empty WHERE body (e.g. a half-written `... WHERE` with no
695− sql = "\(head) \(wrappedBody) AND \(condition)"
961+ // condition yet, or `WHERE` immediately followed by ORDER/GROUP/
696− }
962+ // LIMIT) would otherwise produce `WHERE AND <condition>` — a
697− if !tail.isEmpty {
963+ // dangling AND with no left operand. Drop the AND in that case.
698− sql += " \(tail)"
964+ let whereEnd = tokens[whereIndex].range.upperBound
965+ sqlQuery = "\(sql[..<whereEnd]) \(condition)\(separated(sql[whereEnd...]))"
700− } else if let tailStart {
967+ } else if let tailIndex {
968+ let tailStart = tokens[tailIndex].range.lowerBound
701− sql.insert(contentsOf: "WHERE \(condition) ", at: tailStart)
969+ sqlQuery = "\(sql[..<tailStart])WHERE \(condition) \(sql[tailStart...])"
703− sql += " WHERE \(condition)"
971+ let statementEnd = tokens[lastSignificant].range.upperBound
972+ sqlQuery = "\(sql[..<statementEnd]) WHERE \(condition)\(separated(sql[statementEnd...]))"
709 /// Sets the default query for the given stream, returning `true` if the
976 /// Sets the default query for the given stream, returning `true` if the
@@ -727,13 +994,30 @@ final class QueryViewModel {
729 /// Escapes a SQL identifier by doubling internal double-quotes, then wrapping in double-quotes.
996 /// Escapes a SQL identifier by doubling internal double-quotes, then wrapping in double-quotes.
730− static func escapeSQLIdentifier(_ identifier: String) -> String {
997+ nonisolated static func escapeSQLIdentifier(_ identifier: String) -> String {
731 "\"\(identifier.replacingOccurrences(of: "\"", with: "\"\""))\""
998 "\"\(identifier.replacingOccurrences(of: "\"", with: "\"\""))\""
1001+ /// Extracts the row cap from a trailing `LIMIT n` clause (tolerating a trailing
1002+ /// semicolon/whitespace), used to detect when a result set was truncated.
1003+ /// Returns nil when there's no recognizable trailing `LIMIT` — e.g. when the
1004+ /// query uses `LIMIT n OFFSET m` — so we never report a false truncation.
1005+ nonisolated static func trailingLimit(in sql: String) -> Int? {
1006+ let pattern = #"(?i)\bLIMIT\s+(\d+)\s*;?\s*$"#
1007+ guard let regex = try? NSRegularExpression(pattern: pattern) else { return nil }
1008+ let range = NSRange(sql.startIndex..<sql.endIndex, in: sql)
1009+ guard let match = regex.firstMatch(in: sql, range: range),
1010+ let numberRange = Range(match.range(at: 1), in: sql) else { return nil }
1011+ return Int(sql[numberRange])
734 // MARK: - Query History
1014 // MARK: - Query History
736 private func addToHistory(_ entry: QueryHistoryEntry) {
1016 private func addToHistory(_ entry: QueryHistoryEntry) {
1017+ // Start from what's persisted, not this instance's copy: a model created
1018+ // earlier (e.g. one whose query finished after a reconnect replaced it)
1019+ // would otherwise overwrite newer entries saved by the current one.
1020+ queryHistory = Self.loadHistory()
737 // Deduplicate consecutive identical queries
1021 // Deduplicate consecutive identical queries
738 if queryHistory.first?.sql == entry.sql { return }
1022 if queryHistory.first?.sql == entry.sql { return }
739 queryHistory.insert(entry, at: 0)
1023 queryHistory.insert(entry, at: 0)