git.iko.soy/patch
on develop help sign in
implement PR suggestions
26eea36Daniel Haraj
src/Reflex/Class.hs+1−1
compare with develop
unifiedsplit
@@ -234,7 +234,7 @@ class ( MonadHold t (PushM t)
234 -- 'Behavior's and hold 'Event's, and use the results to produce a occurring
234 -- 'Behavior's and hold 'Event's, and use the results to produce a occurring
235 -- (Just) or non-occurring (Nothing) result
235 -- (Just) or non-occurring (Nothing) result
236 push :: (a -> PushM t (Maybe b)) -> Event t a -> Event t b
236 push :: (a -> PushM t (Maybe b)) -> Event t a -> Event t b
237− -- | Like 'push' but intended for functions that the implementation can consider cheap to compute for performance considerations.
237+ -- | Like 'push' but intended for functions that the implementation can consider cheap to compute for performance considerations. WARNING: The function passed to 'pushCheap' may be run multiple times without any caching.
238 pushCheap :: (a -> PushM t (Maybe b)) -> Event t a -> Event t b
238 pushCheap :: (a -> PushM t (Maybe b)) -> Event t a -> Event t b
239 -- | Create a 'Behavior' by reading from other 'Behavior's; the result will be
239 -- | Create a 'Behavior' by reading from other 'Behavior's; the result will be
240 -- recomputed whenever any of the read 'Behavior's changes
240 -- recomputed whenever any of the read 'Behavior's changes
src/Reflex/Patch.hs+6−2
@@ -11,7 +11,8 @@ module Reflex.Patch
11 , PatchDMap (..)
11 , PatchDMap (..)
12 , ComposeMaybe (..)
12 , ComposeMaybe (..)
13 , PatchMap (..)
13 , PatchMap (..)
14+ , Group (..)
14− , Group (..), Additive
15+ , Additive
15 , AdditivePatch (..)
16 , AdditivePatch (..)
16 ) where
17 ) where
17
18
@@ -87,15 +88,18 @@ instance Ord k => Monoid (PatchMap k v) where
87 mempty = PatchMap mempty
88 mempty = PatchMap mempty
88 mappend = (<>)
89 mappend = (<>)
89
90
90−-- Patches based on commutative groups
91+---- Patches based on commutative groups
91
92
93+-- | A 'Group' is a 'Monoid' where every element has an inverse.
92class (Semigroup q, Monoid q) => Group q where
94class (Semigroup q, Monoid q) => Group q where
93 negateG :: q -> q
95 negateG :: q -> q
94 (~~) :: q -> q -> q
96 (~~) :: q -> q -> q
95 r ~~ s = r <> negateG s
97 r ~~ s = r <> negateG s
96
98
99+-- | An 'Additive' 'Semigroup' is one where the multiplication is commutative
97class Semigroup q => Additive q where
100class Semigroup q => Additive q where
98
101
102+-- | The elements of an 'Additive' 'Semigroup' can be considered as patches of their own type.
99newtype AdditivePatch p = AdditivePatch { unAdditivePatch :: p }
103newtype AdditivePatch p = AdditivePatch { unAdditivePatch :: p }
100
104
101instance Additive p => Patch (AdditivePatch p) where
105instance Additive p => Patch (AdditivePatch p) where
src/Reflex/Pure.hs+1
@@ -66,6 +66,7 @@ instance (Enum t, HasTrie t, Ord t) => Reflex (Pure t) where
66 push :: (a -> PushM (Pure t) (Maybe b)) -> Event (Pure t) a -> Event (Pure t) b
66 push :: (a -> PushM (Pure t) (Maybe b)) -> Event (Pure t) a -> Event (Pure t) b
67 push f e = Event $ memo $ \t -> unEvent e t >>= \o -> f o t
67 push f e = Event $ memo $ \t -> unEvent e t >>= \o -> f o t
68
68
69+ pushCheap :: (a -> PushM (Pure t) (Maybe b)) -> Event (Pure t) a -> Event (Pure t) b
69 pushCheap = push
70 pushCheap = push
70
71
71 pull :: PullM (Pure t) a -> Behavior (Pure t) a
72 pull :: PullM (Pure t) a -> Behavior (Pure t) a
src/Reflex/Spider/Internal.hs+3−3
@@ -1666,12 +1666,12 @@ mergeCheap d = Event $ \sub -> do
1666 , subscriberInvalidateHeight = \_ -> return ()
1666 , subscriberInvalidateHeight = \_ -> return ()
1667 , subscriberRecalculateHeight = \_ -> return ()
1667 , subscriberRecalculateHeight = \_ -> return ()
1668 }
1668 }
1669− (EventSubscription sln changeSubscription, change) <- subscribeAndRead (dynamicUpdated d) s
1669+ (changeSubscription, change) <- subscribeAndRead (dynamicUpdated d) s
1670 forM_ change $ \c -> defer $ SomeMergeUpdate (updateMe c) invalidateMyHeight revalidateMyHeight
1670 forM_ change $ \c -> defer $ SomeMergeUpdate (updateMe c) invalidateMyHeight revalidateMyHeight
1671 -- We explicitly hold on to the unsubscribe function from subscribing to the update event.
1671 -- We explicitly hold on to the unsubscribe function from subscribing to the update event.
1672 -- If we don't do this, there are certain cases where mergeCheap will fail to properly retain
1672 -- If we don't do this, there are certain cases where mergeCheap will fail to properly retain
1673 -- its subscription.
1673 -- its subscription.
1674− liftIO $ writeIORef changeSubdRef (s, sln, changeSubscription)
1674+ liftIO $ writeIORef changeSubdRef (s, changeSubscription)
1675 let unsubscribeAll = do
1675 let unsubscribeAll = do
1676 parents <- readIORef parentsRef
1676 parents <- readIORef parentsRef
1677 forM_ (DMap.toList parents) $ \(_ :=> MergeSubscribedParent s) -> unsubscribe s
1677 forM_ (DMap.toList parents) $ \(_ :=> MergeSubscribedParent s) -> unsubscribe s
@@ -1965,7 +1965,7 @@ instance HasSpiderTimeline x => R.Reflex (SpiderTimeline x) where
1965 {-# INLINABLE current #-}
1965 {-# INLINABLE current #-}
1966 current = SpiderBehavior . dynamicCurrent . unSpiderDynamic
1966 current = SpiderBehavior . dynamicCurrent . unSpiderDynamic
1967 {-# INLINABLE updated #-}
1967 {-# INLINABLE updated #-}
1968− updated = coerceWith Coercion $ SpiderEvent . dynamicUpdated . unSpiderDynamic
1968+ updated = coerce $ SpiderEvent . dynamicUpdated . unSpiderDynamic
1969 {-# INLINABLE unsafeBuildDynamic #-}
1969 {-# INLINABLE unsafeBuildDynamic #-}
1970 unsafeBuildDynamic readV0 v' = SpiderDynamic $ dynamicDynIdentity $ unsafeDyn (coerce readV0) $ coerce $ unSpiderEvent v'
1970 unsafeBuildDynamic readV0 v' = SpiderDynamic $ dynamicDynIdentity $ unsafeDyn (coerce readV0) $ coerce $ unSpiderEvent v'
1971 {-# INLINABLE unsafeBuildIncremental #-}
1971 {-# INLINABLE unsafeBuildIncremental #-}