on develop help sign in
Delete group class, the groups package should be used instead
f6d4c9aJohn Ericson
ChangeLog.md+15
@@ -1,5 +1,20 @@
1# Revision history for patch
1# Revision history for patch
2
2
3+## Unreleased
4+
5+* Remove the `split-these` flag.
6+ We do not need it as we only use the `These` datatype which is provided in all versions.
7+
8+* Stop defining `Group`; `Group` from the `groups` package can be used instead.
9+
10+ Most of the instances are provided by `groups`, except the `Group
11+ MonoidalMap` instance, which is not lawful. `reflex` might provide it as an
12+ orphan for backwards compat, temporarily, but it should eventually be removed
13+ everywhere.
14+
15+* `Applicative` is still defined, because the `Abelian` from `groups` has too
16+ stringent a constraint.
17+
3## 0.0.3.2
18## 0.0.3.2
4
19
5* Update version bounds
20* Update version bounds
patch.cabal+2−14
@@ -1,5 +1,5 @@
1Name: patch
1Name: patch
2−Version: 0.0.3.2
2+Version: 0.1.0.0
3Synopsis: Data structures for describing changes to other data structures.
3Synopsis: Data structures for describing changes to other data structures.
4Description:
4Description:
5 Data structures for describing changes to other data structures.
5 Data structures for describing changes to other data structures.
@@ -25,11 +25,6 @@ tested-with:
25 GHC ==8.0.2 || ==8.2.2 || ==8.4.4 || ==8.6.5 || ==8.8.1
25 GHC ==8.0.2 || ==8.2.2 || ==8.4.4 || ==8.6.5 || ==8.8.1
26 GHCJS ==8.4
26 GHCJS ==8.4
27
27
28−flag split-these
29− description: Use split these/semialign packages
30− manual: False
31− default: True
32−
33library
28library
34 hs-source-dirs: src
29 hs-source-dirs: src
35 default-language: Haskell2010
30 default-language: Haskell2010
@@ -40,6 +35,7 @@ library
40 , dependent-sum >= 0.6 && < 0.8
35 , dependent-sum >= 0.6 && < 0.8
41 , lens >= 4.7 && < 5
36 , lens >= 4.7 && < 5
42 , semigroupoids >= 4.0 && < 6
37 , semigroupoids >= 4.0 && < 6
38+ , these >= 0.4 && < 1.2
43 , transformers >= 0.5.6.0 && < 0.6
39 , transformers >= 0.5.6.0 && < 0.6
44 , witherable >= 0.3 && < 0.4
40 , witherable >= 0.3 && < 0.4
45
41
@@ -56,14 +52,6 @@ library
56
52
57 ghc-options: -Wall -fwarn-redundant-constraints -fwarn-tabs
53 ghc-options: -Wall -fwarn-redundant-constraints -fwarn-tabs
58
54
59− if flag(split-these)
60− build-depends: these >= 1 && <1.2
61− , semialign >=1 && <1.2
62− , monoidal-containers >= 0.6 && < 0.7
63− else
64− build-depends: these >= 0.4 && <0.9
65− , monoidal-containers == 0.4.0.0
66−
67test-suite hlint
55test-suite hlint
68 default-language: Haskell2010
56 default-language: Haskell2010
69 type: exitcode-stdio-1.0
57 type: exitcode-stdio-1.0
src/Data/Patch.hs+1−36
@@ -1,8 +1,6 @@
1{-# LANGUAGE CPP #-}
1{-# LANGUAGE CPP #-}
2−{-# LANGUAGE GeneralizedNewtypeDeriving #-}
3−{-# LANGUAGE StandaloneDeriving #-}
4−{-# LANGUAGE TypeFamilies #-}
5{-# LANGUAGE TypeOperators #-}
2{-# LANGUAGE TypeOperators #-}
3+{-# LANGUAGE TypeFamilies #-}
6-- |
4-- |
7-- Module:
5-- Module:
8-- Data.Patch
6-- Data.Patch
@@ -13,10 +11,8 @@ module Data.Patch
13 , module X
11 , module X
14 ) where
12 ) where
15
13
16−import Control.Applicative
17import Data.Functor.Const (Const (..))
14import Data.Functor.Const (Const (..))
18import Data.Functor.Identity
15import Data.Functor.Identity
19−import Data.Map.Monoidal (MonoidalMap)
20import Data.Proxy
16import Data.Proxy
21#if !MIN_VERSION_base(4,11,0)
17#if !MIN_VERSION_base(4,11,0)
22import Data.Semigroup (Semigroup (..))
18import Data.Semigroup (Semigroup (..))
@@ -39,12 +35,6 @@ import Data.Patch.MapWithMove as X
39 , unsafePatchMapWithMove
35 , unsafePatchMapWithMove
40 )
36 )
41
37
42−-- | A 'Group' is a 'Monoid' where every element has an inverse.
43−class (Semigroup q, Monoid q) => Group q where
44− negateG :: q -> q
45− (~~) :: q -> q -> q
46− r ~~ s = r <> negateG s
47−
48-- | An 'Additive' 'Semigroup' is one where (<>) is commutative
38-- | An 'Additive' 'Semigroup' is one where (<>) is commutative
49class Semigroup q => Additive q where
39class Semigroup q => Additive q where
50
40
@@ -55,52 +45,27 @@ instance Additive p => Patch (AdditivePatch p) where
55 type PatchTarget (AdditivePatch p) = p
45 type PatchTarget (AdditivePatch p) = p
56 apply (AdditivePatch p) q = Just $ p <> q
46 apply (AdditivePatch p) q = Just $ p <> q
57
47
58−instance (Ord k, Group q) => Group (MonoidalMap k q) where
59− negateG = fmap negateG
60−
61−instance (Ord k, Additive q) => Additive (MonoidalMap k q)
62−
63-- | Trivial group.
48-- | Trivial group.
64−instance Group () where
65− negateG _ = ()
66− _ ~~ _ = ()
67instance Additive ()
49instance Additive ()
68
50
69-- | Product group. A Pair of groups gives rise to a group
51-- | Product group. A Pair of groups gives rise to a group
70−instance (Group a, Group b) => Group (a, b) where
71− negateG (a, b) = (negateG a, negateG b)
72− (a, b) ~~ (c, d) = (a ~~ c, b ~~ d)
73instance (Additive a, Additive b) => Additive (a, b)
52instance (Additive a, Additive b) => Additive (a, b)
74
53
75-- See https://gitlab.haskell.org/ghc/ghc/issues/11135#note_111802 for the reason Compose is not also provided.
54-- See https://gitlab.haskell.org/ghc/ghc/issues/11135#note_111802 for the reason Compose is not also provided.
76-- Base does not define Monoid (Compose f g a) so this is the best we can
55-- Base does not define Monoid (Compose f g a) so this is the best we can
77-- really do for functor composition.
56-- really do for functor composition.
78−instance Group (f (g a)) => Group ((f :.: g) a) where
79− negateG (Comp1 xs) = Comp1 (negateG xs)
80− Comp1 xs ~~ Comp1 ys = Comp1 (xs ~~ ys)
81instance Additive (f (g a)) => Additive ((f :.: g) a)
57instance Additive (f (g a)) => Additive ((f :.: g) a)
82
58
83-- | Product of groups, Functor style.
59-- | Product of groups, Functor style.
84−instance (Group (f a), Group (g a)) => Group ((f :*: g) a) where
85− negateG (a :*: b) = negateG a :*: negateG b
86− (a :*: b) ~~ (c :*: d) = (a ~~ c) :*: (b ~~ d)
87instance (Additive (f a), Additive (g a)) => Additive ((f :*: g) a)
60instance (Additive (f a), Additive (g a)) => Additive ((f :*: g) a)
88
61
89-- | Trivial group, Functor style
62-- | Trivial group, Functor style
90−instance Group (Proxy x) where
91− negateG _ = Proxy
92− _ ~~ _ = Proxy
93instance Additive (Proxy x)
63instance Additive (Proxy x)
94
64
95-- | Const lifts groups into a functor.
65-- | Const lifts groups into a functor.
96−deriving instance Group a => Group (Const a x)
97instance Additive a => Additive (Const a x)
66instance Additive a => Additive (Const a x)
98-- | Ideitnty lifts groups pointwise (at only one point)
67-- | Ideitnty lifts groups pointwise (at only one point)
99−deriving instance Group a => Group (Identity a)
100instance Additive a => Additive (Identity a)
68instance Additive a => Additive (Identity a)
101
69
102-- | Functions lift groups pointwise.
70-- | Functions lift groups pointwise.
103−instance Group b => Group (a -> b) where
104− negateG f = negateG . f
105− (~~) = liftA2 (~~)
106instance Additive b => Additive (a -> b)
71instance Additive b => Additive (a -> b)