plausible/analytics
1
1
Fork 0
mirror of https://github.com/plausible/analytics.git synced 2024-12-24 01:54:34 +03:00
Code Issues Packages Projects Releases Wiki Activity

Limit excluded goals to 1000 in goal suggestions (#4319)

Browse Source
This commit is contained in:
Adrian Gruntkowski 2024-07-08 11:20:28 +02:00 committed by GitHub
parent 35596e8692
commit 22b18db94a
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
lib/plausible/stats/goal_suggestions.ex
View File

@ -6,6 +6,14 @@ defmodule Plausible.Stats.GoalSuggestions do
import Plausible.Stats.Base
import Ecto.Query
# As excluded goal names are interpolated as separate
# parameters in the query, there's a risk of running
# against max parameters limit. Given the failure mode
# in this case is suggesting an event that is already
# added as a goal, which will be validated when creating,
# it's safe to trim exclusions list.
@max_excluded 1000
defmacrop visitors(e) do
quote do
selected_as(
@ -23,7 +31,11 @@ defmodule Plausible.Stats.GoalSuggestions do
|> Repo.preload(:goals)
|> Plausible.Imported.load_import_data()
excluded = Keyword.get(opts, :exclude, [])
excluded =
opts
|> Keyword.get(:exclude, [])
|> Enum.take(@max_excluded)
limit = Keyword.get(opts, :limit, 25)
params = %{"with_imported" => "true", "period" => "6mo"}