plausible/analytics
1
1
Fork 0
mirror of https://github.com/plausible/analytics.git synced 2024-12-24 10:02:10 +03:00
Code Issues Packages Projects Releases Wiki Activity

Do not return prop names when they are not used

Browse Source
This commit is contained in:
Uku Taht 2021-09-24 11:03:20 +02:00
parent f42f4da44b
commit 5be38a57fa
3 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/plausible/stats/props.ex
View File

@ -23,10 +23,6 @@ defmodule Plausible.Stats.Props do
end) end)
end end
else else
query =
Plausible.Stats.Query.remove_goal(query)
|> Plausible.Stats.Query.put_filter("event:name", nil)
ClickhouseRepo.all( ClickhouseRepo.all(
from e in base_event_query(site, query), from e in base_event_query(site, query),
inner_lateral_join: meta in fragment("meta as m"), inner_lateral_join: meta in fragment("meta as m"),

7
lib/plausible_web/controllers/api/stats_controller.ex
View File

@ -508,7 +508,12 @@ defmodule PlausibleWeb.Api.StatsController do
%{"visitors" => %{"value" => total_visitors}} = Stats.aggregate(site, total_q, ["visitors"]) %{"visitors" => %{"value" => total_visitors}} = Stats.aggregate(site, total_q, ["visitors"])
prop_names = Stats.props(site, query) prop_names =
if query.filters["event:goal"] do
Stats.props(site, query)
else
%{}
end
conversions = conversions =
Stats.breakdown(site, query, "event:goal", ["visitors", "events"], {100, 1}) Stats.breakdown(site, query, "event:goal", ["visitors", "events"], {100, 1})

2
test/plausible_web/controllers/api/stats_controller/conversions_test.exs
View File

@ -37,7 +37,7 @@ defmodule PlausibleWeb.Api.StatsController.ConversionsTest do
"name" => "Signup", "name" => "Signup",
"count" => 2, "count" => 2,
"total_count" => 3, "total_count" => 3,
"prop_names" => ["variant"], "prop_names" => nil,
"conversion_rate" => 50 "conversion_rate" => 50
}, },
%{ %{