plausible/analytics
1
1
Fork 0
mirror of https://github.com/plausible/analytics.git synced 2024-09-11 18:07:33 +03:00
Code Issues Packages Projects Releases Wiki Activity

Plugins API: mark data_domain as nullable in capabilities schema (#3840)

Browse Source 
* Plugins API: mark data_domain as nullable in capabilities schema

* fixup
This commit is contained in:
hq1 2024-02-28 10:26:01 +01:00 committed by GitHub
parent ea38b45685
commit 5eb9d724e5
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 20 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/plausible_web/plugins/api/schemas/capabilities.ex
View File

@ -17,7 +17,7 @@ defmodule PlausibleWeb.Plugins.API.Schemas.Capabilities do
required: [:authorized, :data_domain, :features],
properties: %{
authorized: %Schema{type: :boolean},
data_domain: %Schema{type: :string},
data_domain: %Schema{type: :string, nullable: true},
features: %Schema{
type: :object,
required: @features,

24
test/plausible_web/plugins/api/controllers/capabilities_test.exs
View File

@ -14,9 +14,12 @@ defmodule PlausibleWeb.Plugins.API.Controllers.CapabilitiesTest do
describe "unauthorized" do
test "no token", %{conn: conn} do
resp = get(conn, Routes.plugins_api_capabilities_url(PlausibleWeb.Endpoint, :index))
resp =
conn
|> get(Routes.plugins_api_capabilities_url(PlausibleWeb.Endpoint, :index))
|> json_response(200)
assert json_response(resp, 200) ==
assert resp ==
%{
"authorized" => false,
"data_domain" => nil,
@ -28,6 +31,8 @@ defmodule PlausibleWeb.Plugins.API.Controllers.CapabilitiesTest do
"StatsAPI" => false
}
}
assert_schema(resp, "Capabilities", spec())
end
test "bad token", %{conn: conn} do
@ -36,8 +41,9 @@ defmodule PlausibleWeb.Plugins.API.Controllers.CapabilitiesTest do
|> put_req_header("content-type", "application/json")
|> authenticate("foo", "bad token")
|> get(Routes.plugins_api_capabilities_url(PlausibleWeb.Endpoint, :index))
|> json_response(200)
assert json_response(resp, 200) ==
assert resp ==
%{
"authorized" => false,
"data_domain" => nil,
@ -49,6 +55,8 @@ defmodule PlausibleWeb.Plugins.API.Controllers.CapabilitiesTest do
"StatsAPI" => false
}
}
assert_schema(resp, "Capabilities", spec())
end
end
@ -59,8 +67,9 @@ defmodule PlausibleWeb.Plugins.API.Controllers.CapabilitiesTest do
|> put_req_header("content-type", "application/json")
|> authenticate(site.domain, token)
|> get(Routes.plugins_api_capabilities_url(PlausibleWeb.Endpoint, :index))
|> json_response(200)
assert json_response(resp, 200) ==
assert resp ==
%{
"authorized" => true,
"data_domain" => site.domain,
@ -72,6 +81,8 @@ defmodule PlausibleWeb.Plugins.API.Controllers.CapabilitiesTest do
"StatsAPI" => true
}
}
assert_schema(resp, "Capabilities", spec())
end
test "growth", %{conn: conn, site: site, token: token} do
@ -83,8 +94,9 @@ defmodule PlausibleWeb.Plugins.API.Controllers.CapabilitiesTest do
|> put_req_header("content-type", "application/json")
|> authenticate(site.domain, token)
|> get(Routes.plugins_api_capabilities_url(PlausibleWeb.Endpoint, :index))
|> json_response(200)
assert json_response(resp, 200) ==
assert resp ==
%{
"authorized" => true,
"data_domain" => site.domain,
@ -96,6 +108,8 @@ defmodule PlausibleWeb.Plugins.API.Controllers.CapabilitiesTest do
"StatsAPI" => false
}
}
assert_schema(resp, "Capabilities", spec())
end
end
end