mirror of
https://github.com/plausible/analytics.git
synced 2024-12-24 01:54:34 +03:00
Remove verification related feature flags (#4345)
- `:verification` flag is no longer needed, however we'll keep the old "awaiting first pageview" flow for Community Edition where verification is not available by default - `:traffic_drop_notifications` have been tested and should be enabled for everyone
This commit is contained in:
parent
a2497f6f8c
commit
d565175c13
@ -23,3 +23,5 @@ S3_REGION=us-east-1
|
||||
S3_ENDPOINT=http://localhost:10000
|
||||
S3_EXPORTS_BUCKET=test-exports
|
||||
S3_IMPORTS_BUCKET=test-imports
|
||||
|
||||
VERIFICATION_ENABLED=true
|
||||
|
@ -4,14 +4,8 @@ defmodule Plausible.Verification do
|
||||
"""
|
||||
use Plausible
|
||||
|
||||
@feature_flag :verification
|
||||
|
||||
def enabled?(user) do
|
||||
enabled_via_config? =
|
||||
def enabled?() do
|
||||
:plausible |> Application.fetch_env!(__MODULE__) |> Keyword.fetch!(:enabled?)
|
||||
|
||||
enabled_for_user? = not is_nil(user) and FunWithFlags.enabled?(@feature_flag, for: user)
|
||||
enabled_via_config? or enabled_for_user?
|
||||
end
|
||||
|
||||
on_ee do
|
||||
|
@ -206,8 +206,7 @@
|
||||
type: :spike
|
||||
) %>
|
||||
|
||||
<%= if FunWithFlags.enabled?(:traffic_drop_notifications, for: @site) do %>
|
||||
<%= render("traffic_change_form",
|
||||
<%= render("traffic_change_form",
|
||||
conn: @conn,
|
||||
notification: @drop_notification,
|
||||
site: @site,
|
||||
@ -216,5 +215,4 @@
|
||||
toggle_text: "Send notifications of traffic drops",
|
||||
threshold_label: "12 hours visitor threshold",
|
||||
type: :drop
|
||||
) %>
|
||||
<% end %>
|
||||
) %>
|
||||
|
@ -109,7 +109,7 @@
|
||||
</a>
|
||||
</div>
|
||||
|
||||
<div :if={Plausible.Verification.enabled?(@current_user)}>
|
||||
<div :if={Plausible.Verification.enabled?()}>
|
||||
<%= live_render(@conn, PlausibleWeb.Live.Verification,
|
||||
session: %{
|
||||
"open_modal?" => !!@conn.params["launch_verification"],
|
||||
|
@ -7,11 +7,11 @@
|
||||
<%= form_for @conn, "/", [class: "max-w-lg w-full mx-auto bg-white dark:bg-gray-800 shadow-md rounded px-8 pt-6 pb-8 mb-4 mt-8"], fn f -> %>
|
||||
<h2 class="text-xl font-bold dark:text-gray-100">Add JavaScript snippet</h2>
|
||||
<div class="mt-4">
|
||||
<p :if={Plausible.Verification.enabled?(@current_user)} class="dark:text-gray-100">
|
||||
<p :if={Plausible.Verification.enabled?()} class="dark:text-gray-100">
|
||||
Include this snippet in the <code><head></code>
|
||||
section of your website.<br />To verify your integration, click the button below to confirm that everything is working correctly.
|
||||
</p>
|
||||
<p :if={not Plausible.Verification.enabled?(@current_user)} class="dark:text-gray-100">
|
||||
<p :if={not Plausible.Verification.enabled?()} class="dark:text-gray-100">
|
||||
Paste this snippet in the <code><head></code> of your website.
|
||||
</p>
|
||||
|
||||
@ -65,7 +65,7 @@
|
||||
</p>
|
||||
</div>
|
||||
<% button_label =
|
||||
if Plausible.Verification.enabled?(@current_user) do
|
||||
if Plausible.Verification.enabled?() do
|
||||
"Verify your integration to start collecting data →"
|
||||
else
|
||||
"Start collecting data →"
|
||||
|
@ -22,7 +22,7 @@
|
||||
</div>
|
||||
<% end %>
|
||||
<div
|
||||
:if={not Plausible.Verification.enabled?(assigns[:current_user])}
|
||||
:if={not Plausible.Verification.enabled?()}
|
||||
class="bg-white dark:bg-gray-800 shadow-md rounded px-8 pt-6 pb-8 mb-4 mt-16 relative text-center"
|
||||
>
|
||||
<h2 class="text-xl font-bold dark:text-gray-100">Waiting for first pageview</h2>
|
||||
@ -61,7 +61,7 @@
|
||||
</div>
|
||||
</div>
|
||||
|
||||
<%= if Plausible.Verification.enabled?(assigns[:current_user]),
|
||||
<%= if Plausible.Verification.enabled?(),
|
||||
do:
|
||||
live_render(@conn, PlausibleWeb.Live.Verification,
|
||||
session: %{
|
||||
|
@ -1,5 +1,3 @@
|
||||
FunWithFlags.enable(:verification)
|
||||
|
||||
if not Enum.empty?(Path.wildcard("lib/**/*_test.exs")) do
|
||||
raise "Oops, test(s) found in `lib/` directory. Move them to `test/`."
|
||||
end
|
||||
|
Loading…
Reference in New Issue
Block a user