plausible/analytics
1
1
Fork 0
mirror of https://github.com/plausible/analytics.git synced 2024-11-22 10:43:38 +03:00
Code Issues Packages Projects Releases Wiki Activity

Restore average/total revenue to top stats (#4716)

Browse Source 
* Restore average/total revenue to top stats

These werent being graphed due to incorrect conditional

* prefer ternary
This commit is contained in:
Karl-Aksel Puulmann 2024-10-22 14:47:29 +03:00 committed by GitHub
parent be83b7829d
commit d727ba5ed5
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 10 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
assets/js/dashboard/stats/graph/top-stats.js
View File

@ -16,30 +16,14 @@ import {
MetricFormatterLong
} from '../reports/metric-formatter'
function Maybe({ condition, children }) {
if (condition) {
return children
} else {
return null
}
}
function topStatNumberShort(metric, value) {
if (typeof value == 'number') {
const formatter = MetricFormatterShort[metric]
return formatter(value)
} else {
return null
}
const formatter = MetricFormatterShort[metric]
return formatter(value)
}
function topStatNumberLong(metric, value) {
if (typeof value == 'number') {
const formatter = MetricFormatterLong[metric]
return formatter(value)
} else {
return null
}
const formatter = MetricFormatterLong[metric]
return formatter(value)
}
export default function TopStats({ data, onMetricUpdate, tooltipBoundary }) {
@ -163,22 +147,22 @@ export default function TopStats({ data, onMetricUpdate, tooltipBoundary }) {
>
{topStatNumberShort(stat.graph_metric, stat.value)}
</p>
<Maybe condition={!query.comparison && stat.change != null}>
{query.comparison && stat.change != null ? (
<ChangeArrow
metric={stat.graph_metric}
change={stat.change}
className="pl-2 text-xs dark:text-gray-100"
/>
</Maybe>
) : null}
</span>
<Maybe condition={query.comparison}>
{query.comparison ? (
<p className="text-xs dark:text-gray-100">
{formatDateRange(site, data.from, data.to)}
</p>
</Maybe>
) : null}
</div>
<Maybe condition={query.comparison}>
{query.comparison ? (
<div>
<p className="font-bold text-xl text-gray-500 dark:text-gray-400">
{topStatNumberShort(stat.graph_metric, stat.comparison_value)}
@ -187,7 +171,7 @@ export default function TopStats({ data, onMetricUpdate, tooltipBoundary }) {
{formatDateRange(site, data.comparing_from, data.comparing_to)}
</p>
</div>
</Maybe>
) : null}
</div>
</Tooltip>
)