plausible/analytics
1
1
Fork 0
mirror of https://github.com/plausible/analytics.git synced 2024-11-23 03:04:43 +03:00
Code Issues Packages Projects Releases Wiki Activity

Goal detail tweaks (#4410)

Browse Source 
* Always show details modal for goal conversions

* Make metrics smaller in breakdown table

So that revenue metrics fit

* So that revenue metrics fit

* Add more space for dimension value in breakdown modal
This commit is contained in:
Uku Taht 2024-07-31 15:19:11 +03:00 committed by GitHub
parent cad7ae7f53
commit d73ed8fe7c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
assets/js/dashboard/stats/behaviours/conversions.js
View File

@ -42,7 +42,6 @@ export default function Conversions({ afterFetchData, onGoalFilterClick }) {
onClick={onGoalFilterClick} onClick={onGoalFilterClick}
metrics={chooseMetrics()} metrics={chooseMetrics()}
detailsLink={url.sitePath('conversions')} detailsLink={url.sitePath('conversions')}
maybeHideDetails={true}
color="bg-red-50" color="bg-red-50"
colMinWidth={90} colMinWidth={90}
/> />

8
assets/js/dashboard/stats/modals/breakdown-modal.js
View File

@ -156,7 +156,7 @@ export default function BreakdownModal({
function renderRow(item) { function renderRow(item) {
return ( return (
<tr className="text-sm dark:text-gray-200" key={item.name}> <tr className="text-sm dark:text-gray-200" key={item.name}>
<td className="w-48 md:w-64 break-all p-2 flex items-center"> <td className="w-48 md:w-80 break-all p-2 flex items-center">
{maybeRenderIcon(item)} {maybeRenderIcon(item)}
<FilterLink <FilterLink
pathname={`/${encodeURIComponent(site.domain)}`} pathname={`/${encodeURIComponent(site.domain)}`}
@ -168,7 +168,7 @@ export default function BreakdownModal({
</td> </td>
{metrics.map((metric) => { {metrics.map((metric) => {
return ( return (
<td key={metric.key} className="p-2 w-32 font-medium" align="right"> <td key={metric.key} className="p-2 w-24 font-medium" align="right">
{metric.renderValue(item[metric.key])} {metric.renderValue(item[metric.key])}
</td> </td>
) )
@ -229,7 +229,7 @@ export default function BreakdownModal({
<thead> <thead>
<tr> <tr>
<th <th
className="p-2 w-48 md:w-64 text-xs tracking-wide font-bold text-gray-500 dark:text-gray-400" className="p-2 w-48 md:w-80 text-xs tracking-wide font-bold text-gray-500 dark:text-gray-400"
align="left" align="left"
> >
{reportInfo.dimensionLabel} {reportInfo.dimensionLabel}
@ -237,7 +237,7 @@ export default function BreakdownModal({
{metrics.map((metric) => { {metrics.map((metric) => {
return ( return (
<th key={metric.key} className="p-2 w-32 text-xs tracking-wide font-bold text-gray-500 dark:text-gray-400" align="right"> <th key={metric.key} className="p-2 w-24 text-xs tracking-wide font-bold text-gray-500 dark:text-gray-400" align="right">
{metric.renderLabel(query)} {metric.renderLabel(query)}
</th> </th>
) )