mirror of
https://github.com/plausible/analytics.git
synced 2024-12-24 01:54:34 +03:00
24a8aa2821
* Reapply "Sentry context in live views (#3672)" This reverts commit 5449fead160064b8a0081c458cc5dcd34399eb0b. * Make sure `:selection_made` is handled in `GoalSettings.Form` That was a bit unepexcted.. normally `handle_info` is injected by the LiveView use macro and it discards any message gracefully. After switching to `use PlausibleWeb, :live_view` we're also using `PlausibleWeb.Live.Flash` that happens to inject its own receive clause for closing the flash. Which then renders the original, overridable, `handle_info` catch-all obsolete. * Update LV SentryContext only on connected sockets (first mount already has the right context coming from Sentry plug) * Make sure Live.ChoosePlan passes `current_user_id` session key
79 lines
2.0 KiB
Elixir
79 lines
2.0 KiB
Elixir
defmodule PlausibleWeb.Live.SentryContextTest do
|
|
use PlausibleWeb.ConnCase, async: true
|
|
import Phoenix.LiveViewTest
|
|
|
|
defmodule SampleLV do
|
|
use PlausibleWeb, :live_view
|
|
|
|
def mount(_params, %{"test" => test_pid}, socket) do
|
|
socket = assign(socket, test_pid: test_pid)
|
|
{:ok, socket}
|
|
end
|
|
|
|
def render(assigns) do
|
|
~H"""
|
|
ok computer
|
|
"""
|
|
end
|
|
|
|
def handle_event("get_sentry_context", _params, socket) do
|
|
context = Sentry.Context.get_all()
|
|
send(socket.assigns.test_pid, {:context, context})
|
|
{:noreply, socket}
|
|
end
|
|
end
|
|
|
|
describe "sentry context" do
|
|
test "basic shape", %{conn: conn} do
|
|
context_hook(conn)
|
|
assert_receive {:context, context}
|
|
|
|
assert %{
|
|
extra: %{},
|
|
request: %{
|
|
env: %{
|
|
"REMOTE_ADDR" => "127.0.0.1",
|
|
"REMOTE_PORT" => port,
|
|
"SEVER_NAME" => "www.example.com"
|
|
},
|
|
host: :not_mounted_at_router
|
|
},
|
|
user: %{},
|
|
tags: %{},
|
|
breadcrumbs: []
|
|
} = context
|
|
|
|
assert is_integer(port)
|
|
end
|
|
|
|
test "user-agent is included", %{conn: conn} do
|
|
conn
|
|
|> put_req_header("user-agent", "Firefox")
|
|
|> context_hook()
|
|
|
|
assert_receive {:context, context}
|
|
assert context.request.headers["User-Agent"] == "Firefox"
|
|
end
|
|
|
|
test "user_id is included", %{conn: conn} do
|
|
context_hook(conn, %{"current_user_id" => 172})
|
|
|
|
assert_receive {:context, context}
|
|
assert context.user.id == 172
|
|
end
|
|
end
|
|
|
|
defp context_hook(conn, extra_session \\ %{}) do
|
|
lv = get_liveview(conn, extra_session)
|
|
assert render(lv) =~ "ok computer"
|
|
render_hook(lv, :get_sentry_context, %{})
|
|
end
|
|
|
|
defp get_liveview(conn, extra_session) do
|
|
{:ok, lv, _html} =
|
|
live_isolated(conn, SampleLV, session: Map.merge(%{"test" => self()}, extra_session))
|
|
|
|
lv
|
|
end
|
|
end
|