From 00b6a848d572a1bf469a8d01ddf20833b69c9e75 Mon Sep 17 00:00:00 2001 From: Shawn Allen Date: Thu, 18 Oct 2018 15:18:19 -0700 Subject: [PATCH] nix release docs in .github/CONTRIBUTING --- .github/CONTRIBUTING.md | 104 +--------------------------------------- 1 file changed, 2 insertions(+), 102 deletions(-) diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md index 340dc69a..85bb5482 100644 --- a/.github/CONTRIBUTING.md +++ b/.github/CONTRIBUTING.md @@ -71,108 +71,8 @@ Here are a few things you can do that will increase the likelihood of your pull - Keep your change as focused as possible. If there are multiple changes you would like to make that are not dependent upon each other, consider submitting them as separate pull requests. - Write a [good commit message](http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html). -## Releasing a new Primer version 🎉 - -This section is targeted at maintainers of primer, to instruct them on the processes for releasing a new version. - -### In `primer/primer`: - -1. Find or create a new pull request with a release branch from `master` and name it `release-`. - - (CI will publish a release candidate version to npm for branches prefixed with `release`. These version numbers have a `rc.` suffix on them) - - For the pull request you can use the following template: - - ```md - # Primer [Major|Minor|Patch] Release - - Tracking Issue for next release: 📦 **0.0.0** - Approximate release date: 📆 DD/MM/YY - - ### Must - - - [ ] - - ### Should - - - [ ] - - ### Could - - - [ ] - - ---- - - ### Ship checklist - - - [ ] Update CHANGELOG - - [ ] Run version bump - - [ ] Update primer.github.io - - [ ] Update github/github - - [ ] Update the style guide - - [ ] Update the release tag note - - [ ] Create a new pull request for the next release - - /cc @primer/ds-core - ``` - -2. Go through the tracking issue and make sure everything that should be merged in is merged in. - -3. Once your builds finish, click on the details links for the continuous-integration/travis-ci/push build. Expand the `Deploying application` output and you should be able to find an outputted change log here. Copy this and update the [CHANGELOG.md](https://github.com/primer/primer/blob/master/CHANGELOG.md) file. - -4. Run the version bump in your terminal: `npm run bump`. - -5. Test your changes with the latest release candidate version in the appropriate places (styleguide, storybook, github/github). - -6. Once the release PR is approved and you've done necessary testing, merge to `master`. This will trigger a publish to npm. - -### In `github/github`: - -1. Create a new branch - -2. Update the primer version in your terminal `bin/npm install primer@`. - -3. If you need to make changes to github/github due to the Primer release, make a separate branch. When ready, merge that branch into your release branch. - -4. Add reviewers. - -5. Check that every deleted vendor file has an accompanying updated vendor file and that the version numbers look correct. - -6. Test on review-lab. - -7. When ready, merge! 🎉 - - -## Other items that need to be done after publishing Primer - -#### Update the Style Guide - -1. In [github/styleguide](https://github.com/github/styleguide), update `primer` to your newly released version in your terminal: - - `npm install primer@latest` - -2. Then run: `script/update-primer-docs`. - -3. Commit changes, make PR, get it approved, merge! 🚀 - -#### Update [primer.github.io](primer.github.io) - -1. Edit [index.html](https://github.com/primer/primer.github.io/blob/master/index.html) to include the latest version. - -#### Update Storybook - -1. Pull the latest from master on primer/primer (after merging in release branch). - -2. Run `npm run publish-storybook`. - -#### Publish release tag - -1. Create a new release tag [here](https://github.com/primer/primer/releases/new). - -2. Copy the changes from the [CHANGELOG](https://github.com/primer/primer/blob/master/CHANGELOG.md) and paste it into the release notes. - -3. Publish 🎉 - +## Releasing a new Primer version +See [RELEASING.md](../RELEASING.md) for our release process. ## Resources