From 71697d8ed369019cb51587d850407453bec845b7 Mon Sep 17 00:00:00 2001 From: simurai Date: Fri, 6 Sep 2019 20:32:11 +0900 Subject: [PATCH 1/2] :fire: Remove .dropdown-menu-content This is not used anymore --- src/dropdown/dropdown.scss | 18 ------------------ 1 file changed, 18 deletions(-) diff --git a/src/dropdown/dropdown.scss b/src/dropdown/dropdown.scss index ac760066..0b9414fb 100644 --- a/src/dropdown/dropdown.scss +++ b/src/dropdown/dropdown.scss @@ -1,12 +1,5 @@ .dropdown { position: relative; - - &.active { - .dropdown-menu-content { - display: block; - pointer-events: all; - } - } } .dropdown-caret { @@ -121,17 +114,6 @@ color: $text-gray; } -.dropdown-menu-content { - display: none; - - // stylelint-disable-next-line primer/no-override - &.anim-scale-in { - position: relative; - z-index: 100; - pointer-events: none; - } -} - .dropdown-item[aria-checked="false"] .octicon-check { display: none; } From f95681fd001c406a4de530b13ec348190ba66f56 Mon Sep 17 00:00:00 2001 From: Shawn Allen Date: Tue, 10 Sep 2019 14:13:13 -0700 Subject: [PATCH 2/2] add deprecations for .dropdown-menu-content --- deprecations.js | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/deprecations.js b/deprecations.js index 143067ab..3c7bd72d 100644 --- a/deprecations.js +++ b/deprecations.js @@ -51,6 +51,14 @@ const versionDeprecations = { { selectors: ['.centered'], message: `You can use the "mx-auto" class to center any element.` + }, + { + selectors: [ + '.dropdown-menu-content', + '.dropdown.active .dropdown-menu-content', + '.dropdown-menu-content.anim-scale-in' + ], + message: `The "dropdown-menu-content" class is unnecessary.` } ] }