From 3e2ea4cca6abc11e5c9594a99573c8bc0d267933 Mon Sep 17 00:00:00 2001 From: Emily Brick Date: Fri, 12 Oct 2018 10:53:17 -0400 Subject: [PATCH] removed old component --- modules/primer-progress-bar/README.md | 41 ++++----- .../primer-progress-bar/lib/progress-bar.scss | 87 ++++++------------- 2 files changed, 47 insertions(+), 81 deletions(-) diff --git a/modules/primer-progress-bar/README.md b/modules/primer-progress-bar/README.md index 5ea180e0..06570378 100644 --- a/modules/primer-progress-bar/README.md +++ b/modules/primer-progress-bar/README.md @@ -41,16 +41,17 @@ status: Experimental --> ```html -
-
-
-
- - + + + + + + + ``` @@ -63,15 +64,17 @@ status: Experimental --> ```html -
-
-
- - + + + + + + + ``` ## Progress Bar With Tooltip @@ -83,18 +86,16 @@ status: Experimental ```html
-
-
-
-
-
- -
- - + +
+
+ + + +
``` ## WIP Reverse Progress diff --git a/modules/primer-progress-bar/lib/progress-bar.scss b/modules/primer-progress-bar/lib/progress-bar.scss index e2afa5d5..23f2ea47 100644 --- a/modules/primer-progress-bar/lib/progress-bar.scss +++ b/modules/primer-progress-bar/lib/progress-bar.scss @@ -1,67 +1,32 @@ -// A green progress bar on a grey background. -.progress-bar { - display: block; - height: 15px; - overflow: hidden; // Crop the progress bar within for rounded corners - background-color: lighten($gray-200, 3%); - border-radius: 3px; - - .progress { - display: block; - height: 100%; - background-color: darken($green-400, 5%); - } -} - -// Reverse progress bar shrinks revealing the bar color which is the container background -.reverse-progress { - &-container { - position: relative; - height: 3px; - background-color: $gray-200; - background-image: linear-gradient( - to right, - $bg-green, - $blue-600, - $purple-800, - $red-600, - $orange-500 - ); - background-size: 100% 3px; - } - - &-bar { - position: absolute; - right: 0; - height: 100%; - background-color: $gray-200; - } -} - -// used new milestones show page for issue reordering -.progress-bar-small { - height: 10px; -} - -// Used with table-list header on new milestones show page -// A more robust fix without nesting requires refactoring issue helper -.progress-bar-inline { - .progress-bar { - width: 100%; - border-color: $gray-200; - border-style: solid; - border-width: 1px; - border-top: 0; - border-radius: 0; - } -} - -// Flexbox Refactoring for Primer CSS Component // +// Progress Bar +// Intended to replace custom styled progress flex-progress-bar-small +// Flex and Functional CSS Refactoring Approach .flex-progress-bar { - height: 15px; + height: 10px; } .flex-progress-bar-small { - height: 10px; + height: 8px; +} + +// BEM/Semantic Approach + +.Progress { + height: 10px; + display: flex; + background-color: $gray-200; + border-radius: $border-radius; + overflow: hidden; +} + +.Progress-value { +} + +.Progress--small { + height: 8px; +} + +.Progress--tiny { + height: 5px; }