From 38c9c8da956902f44af6e037d196f805c7479a97 Mon Sep 17 00:00:00 2001 From: Hector Palacios Date: Tue, 25 May 2021 09:06:10 +0200 Subject: [PATCH 1/2] lists.scss: reset
    without 'type' attr to "decimal" HTML default list-style-type is "decimal" when there is no 'type' attribute. In MarkDown language, you can't specify the style type of a list item, so nested lists *always* represent with decimal numbers at any level. Since this is not user friendly, GitHub CSS styling overrides the HTML standard by setting lower-roman for second-level items and lower-alpha for third-level items. In AsciiDoc language, you can specify the style type of a list item using a tage before the list, for example: Tag Produces [loweralpha]
      [lowerroman]
        [decimal]
          The [decimal] tag doesn't generate any 'type' attribute because the HTML standard when there is no type, *is* decimal. If such a [decimal] tag is used on a second-level or third-level item, GitHub CSS for MarkDown overrides HTML standard and you get instead a lowerroman or loweralpha sign. The added CSS resets the list-style-type of
            without type to decimal, as it should be in the first place, for the construction div > ol, which is only produced by AsciiDoc files, to avoid any effect on existing MarkDown files. Signed-off-by: Hector Palacios --- src/markdown/lists.scss | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/markdown/lists.scss b/src/markdown/lists.scss index e269e534..f61233c0 100644 --- a/src/markdown/lists.scss +++ b/src/markdown/lists.scss @@ -26,6 +26,12 @@ list-style-type: lower-roman; } + // Reset
              style to decimal (HTML default) specifically for AsciiDoc + //
                construction (doesn't affect MarkDown) + div > ol:not([type]) { + list-style-type: decimal; + } + // Did someone complain about list spacing? Encourage them // to create the spacing with their markdown formatting. // List behavior should be controled by the markup, not the css. From 55302dc232cb5cd28c52047a0776549f298a90ce Mon Sep 17 00:00:00 2001 From: Jon Rohan Date: Tue, 25 May 2021 08:47:55 -0700 Subject: [PATCH 2/2] Create quiet-rings-confess.md --- .changeset/quiet-rings-confess.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/quiet-rings-confess.md diff --git a/.changeset/quiet-rings-confess.md b/.changeset/quiet-rings-confess.md new file mode 100644 index 00000000..74506557 --- /dev/null +++ b/.changeset/quiet-rings-confess.md @@ -0,0 +1,5 @@ +--- +"@primer/css": patch +--- + +lists.scss: reset
                  without 'type' attr to "decimal"