From 8cf13e984ca27a286a706fd2b7243980d3de7985 Mon Sep 17 00:00:00 2001
From: simurai <simurai@github.com>
Date: Fri, 2 Dec 2022 10:59:15 +0900
Subject: [PATCH] Move some `form` styles to `base.scss` (#2327)

* Move fieldset + label styles to base.scss

* Create giant-boxes-vanish.md

* Move ::placeholder
---
 .changeset/giant-boxes-vanish.md |  5 +++++
 src/base/base.scss               | 16 ++++++++++++++++
 src/forms/form-control.scss      | 16 ----------------
 3 files changed, 21 insertions(+), 16 deletions(-)
 create mode 100644 .changeset/giant-boxes-vanish.md

diff --git a/.changeset/giant-boxes-vanish.md b/.changeset/giant-boxes-vanish.md
new file mode 100644
index 00000000..1f057131
--- /dev/null
+++ b/.changeset/giant-boxes-vanish.md
@@ -0,0 +1,5 @@
+---
+"@primer/css": patch
+---
+
+Move `fieldset` + `label` styles to `base.scss`
diff --git a/src/base/base.scss b/src/base/base.scss
index f82f8fec..c12269ed 100644
--- a/src/base/base.scss
+++ b/src/base/base.scss
@@ -34,6 +34,22 @@ strong {
   font-weight: $font-weight-bold;
 }
 
+fieldset {
+  padding: 0;
+  margin: 0;
+  border: 0;
+}
+
+label {
+  font-weight: $font-weight-bold;
+}
+
+// Custom styling for HTML5 validation bubbles (WebKit only)
+::placeholder {
+  color: var(--color-fg-subtle);
+  opacity: 1; // override opacity in normalize.css
+}
+
 // Horizontal lines
 //
 // TODO-MDO: Remove `.rule` from everywhere and replace with `<hr>`s
diff --git a/src/forms/form-control.scss b/src/forms/form-control.scss
index c42a1199..dfb09262 100644
--- a/src/forms/form-control.scss
+++ b/src/forms/form-control.scss
@@ -5,16 +5,6 @@
 //
 // Overrides for common inputs for easier styling.
 
-fieldset {
-  padding: 0;
-  margin: 0;
-  border: 0;
-}
-
-label {
-  font-weight: $font-weight-bold;
-}
-
 .form-control,
 .form-select {
   // stylelint-disable-next-line primer/spacing
@@ -96,12 +86,6 @@ textarea.form-control {
   }
 }
 
-// Custom styling for HTML5 validation bubbles (WebKit only)
-::placeholder {
-  color: var(--color-fg-subtle);
-  opacity: 1; // override opacity in normalize.css
-}
-
 // Mini inputs, to match .minibutton
 .input-sm {
   min-height: $size-4;