From 43724fddb9295d7cd5310d2919c76e8b4ca2c808 Mon Sep 17 00:00:00 2001 From: Shawn Allen Date: Mon, 24 Jul 2017 15:48:46 -0700 Subject: [PATCH 1/2] possible fix for #263 --- script/release-candidate | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/script/release-candidate b/script/release-candidate index 9f6447bb..9a740416 100755 --- a/script/release-candidate +++ b/script/release-candidate @@ -8,10 +8,6 @@ package=primer-css npm_tag=rc log=/tmp/rc.log -function bump() { - npm version --no-git $@ -} - # get the version we're publishing as a release candidate local_version=$(jq -r .version modules/$package/package.json) if [[ $local_version =~ "-" ]]; then @@ -25,6 +21,9 @@ fi rc_version=$(npm info $package@$npm_tag version) echo "📦 Published version for $package@$npm_tag: $rc_version" rc_release=${rc_version%-*} +if [[ $local_version != $rc_release ]]; then + rc_version=$local_version +fi # determine the next_version=$( @@ -47,12 +46,14 @@ for module_dir in $module_dirs; do # determine the local version (in git) module_version=$(jq -r .version package.json) + # strip the rc version, just in case + module_version=${module_version%-*} module_next_version="$module_version$pre_version" echo "$module@$module_version => $module_next_version" # "upgrade" to the most recent RC version so that # `npm version prerelease` can increment automatically - bump --quiet "$module_next_version" >> $log + npm version --no-git --quiet "$module_next_version" >> $log popd > /dev/null done From 56a603523c3a98116bb36b853e8771a71a211616 Mon Sep 17 00:00:00 2001 From: Shawn Allen Date: Mon, 24 Jul 2017 23:10:08 -0700 Subject: [PATCH 2/2] pass --bail=false to lerna publish to fix #268? --- script/release-candidate | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/script/release-candidate b/script/release-candidate index 9a740416..f0578fdc 100755 --- a/script/release-candidate +++ b/script/release-candidate @@ -59,4 +59,4 @@ for module_dir in $module_dirs; do done # publish all the things! -lerna exec --bail -- npm publish --tag=$npm_tag +lerna exec --bail=false -- npm publish --tag=$npm_tag