primer/css
1
1
Fork 0
mirror of https://github.com/primer/css.git synced 2024-12-25 07:03:35 +03:00
Code Issues Projects Releases Wiki Activity

Merge pull request #1380 from primer/tobiasahlin/dont-confuse-sizes-with-breakpoints

Browse Source 
Marketing: use size modifiers that don't look like breakpoints modifiers
This commit is contained in:
simurai 2021-05-06 17:35:27 +09:00 committed by GitHub
commit d7209ce182
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
.changeset/thirty-experts-exist.md Normal file
View File

@ -0,0 +1,5 @@
---
"@primer/css": major
---
Marketing: use size modifiers that don't look like breakpoints modifiers

4
deprecations.js
View File

@ -79,10 +79,6 @@ const versionDeprecations = {
selectors: ['.bg-shade-gradient'], selectors: ['.bg-shade-gradient'],
message: `This selector is deprecated, please use "color-bg-secondary" instead of "bg-shade-gradient".` message: `This selector is deprecated, please use "color-bg-secondary" instead of "bg-shade-gradient".`
}, },
{
selectors: ['.btn-large-mktg'],
message: `Please use the ".btn-lg-mktg" class instead of "btn-large-mktg".`
},
{ {
selectors: ['.color-border-overlay'], selectors: ['.color-border-overlay'],
message: `Please use the ".color-border-primary" class instead of ".color-border-overlay".` message: `Please use the ".color-border-primary" class instead of ".color-border-overlay".`

4
src/marketing/buttons/button.scss
View File

@ -95,12 +95,12 @@
// Size modifiers // Size modifiers
.btn-sm-mktg { .btn-small-mktg {
// stylelint-disable-next-line primer/spacing // stylelint-disable-next-line primer/spacing
padding: rem(10px) rem($spacer-3) rem(13px); padding: rem(10px) rem($spacer-3) rem(13px);
} }
.btn-lg-mktg { .btn-large-mktg {
// stylelint-disable-next-line primer/spacing // stylelint-disable-next-line primer/spacing
padding: 20px 30px 23px !important; padding: 20px 30px 23px !important;
} }