Vinicius Depizzol
f544ef8574
Make pane
an optional region for PageLayout component ( #1989 )
...
* Fix PageLayout storybook example imports
* Align PageLayout story spacing props with component
* Fix inherit state of ..DividerWhenNarrow
* Make pane an optional region of PageLayout
* Stylelint auto-fixes
* Create nasty-singers-compare.md
Co-authored-by: Actions Auto Build <actions@github.com>
Co-authored-by: Jon Rohan <yes@jonrohan.codes>
2022-03-14 14:26:46 -07:00
simurai
e3443f1a69
Fix color-fg utilities in links ( #1988 )
...
* Fix color-fg utilities in links
* Create gorgeous-birds-hear.md
2022-03-11 09:01:15 -08:00
Sarah Vessels
c2bd6bc9bf
Add .color-bg-transparent ( #1985 )
...
* Add .color-bg-transparent
* Create ninety-phones-run.md
Co-authored-by: Jon Rohan <rohan@github.com>
2022-03-09 08:52:27 -08:00
GitHub Design Systems Bot
d3792211df
Version Packages ( #1984 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2022-03-09 15:19:09 +09:00
simurai
07bc069ec0
Bump primer/primitives
to ^7.5.1
( #1983 )
...
* yarn add @primer/primitives@^7.5.1
* Create neat-pears-battle.md
2022-03-09 15:12:09 +09:00
GitHub Design Systems Bot
324293bed4
Version Packages ( #1944 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2022-03-04 14:25:52 +09:00
Katie Langerman
a00e6bce01
[Bug fix] Handle pointer-events on ActionList visuals ( #1978 )
...
* pointer-events none on visuals
* Create unlucky-oranges-worry.md
* Stylelint auto-fixes
Co-authored-by: Actions Auto Build <actions@github.com>
2022-03-04 05:19:58 +00:00
simurai
6a83a92b43
Add open
and closed
color roles ( #1948 )
...
* Add `open` and `closed` color role
* Use new open/closed color variables
* yarn add @primer/primitives@0.0.0-202212241414
This is just temporarily to test the docs
* Add `Label--open` and `Label--closed`
* Create clever-bugs-love.md
* yarn add @primer/primitives@0.0.0-202212894219
* yarn add @primer/primitives@7.5.0
2022-03-04 13:54:06 +09:00
Jon Rohan
80bf9d9dea
[Bug Fix] Adding white-space nowrap to Labels ( #1977 )
2022-03-03 15:55:26 -08:00
Jon Rohan
37334bfae3
Update shaggy-coats-relate.md
2022-02-28 17:21:21 -08:00
Reece Atkinson
0450ccbb86
Added line break ( #1942 )
...
* Added line break
To add more space and to make it more spaced out.
* Create neat-rice-study.md
Co-authored-by: Jon Rohan <yes@jonrohan.codes>
Co-authored-by: Jon Rohan <rohan@github.com>
2022-02-28 17:19:52 -08:00
Jon Rohan
a35a8bdcc1
Default .PageLayout to display block ( #1961 )
...
* Default .PageLayout to display block
* Create new-masks-matter.md
2022-02-28 22:39:24 +00:00
Jon Rohan
3906346182
Upgrading @primer/stylelint-config@12.3.3 ( #1956 )
...
* Upgrading @primer/stylelint-config@12.3.2
* @primer/stylelint-config@12.3.3
* Create few-humans-relax.md
2022-02-28 22:35:52 +00:00
Hector Garcia
7c85c50056
Fix sequence of content in Subhead ( #1950 )
...
* Fix sequence of content in Subhead
When a heading, description, and action are rendered in the Subhead
component, the content now follows logical order on screen readers.
* Add changeset
Co-authored-by: Jon Rohan <yes@jonrohan.codes>
2022-02-28 20:55:17 +00:00
Kevin Heis
dab83198c3
In markdown, update summary > heading style ( #1949 )
...
* In markdown, update summary > heading style
* Update headings.scss
* Create tall-experts-hammer.md
* Update headings.scss
* Update headings.scss
* Update headings.scss
* Run stylelint
Co-authored-by: simurai <simulus@gmail.com>
2022-02-28 07:27:55 +00:00
simurai
30f29d3832
Fix input-block
in form-group
( #1954 )
...
* Fix input-block in form-group
* Create famous-masks-end.md
2022-02-28 01:23:19 +00:00
Hector Garcia
3a91a29a82
Use <h2> instead of <div> on Subhead-heading docs ( #1953 )
2022-02-24 17:13:22 +01:00
Vinicius Depizzol
e5c5312ec8
PageLayout API updated props + examples ( #1931 )
...
* Rename inner and outerSpacing props to padding
to match with new conventions discussed in
https://github.com/primer/react/pull/1820
* Fix Layout example stories
* Add header and footer slots to SplitPageLayout
Also add initial skeleton for Pull request detail story
* add TreeView to Pull request detail story
* Add padding: none prop
* Ongoing Pull request detail story
* Create fifty-chefs-help.md
* Resolve storybook conflicts
* Resolve storybook conflicts, second try
Co-authored-by: Jon Rohan <yes@jonrohan.codes>
Co-authored-by: Katie Langerman <langermank@github.com>
2022-02-17 12:31:42 -08:00
GitHub Design Systems Bot
db5e19337e
Version Packages ( #1930 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2022-02-15 10:54:48 -08:00
Katie Langerman
67f08009ef
TreeView single item nesting ( #1937 )
...
* add class for singleton nesting
* Create cold-ducks-deny.md
2022-02-11 11:39:44 -08:00
Kate Higa
c53ecdff54
Deprecate CSS tooltip ( #1936 )
...
* deprecate tooltip css
* update examples
* Create wise-cameras-leave.md
Co-authored-by: Jon Rohan <yes@jonrohan.codes>
2022-02-11 10:27:13 -08:00
Katie Langerman
50221a5486
NavigationList ( #1905 )
...
* here we go!
* nav list
* divider
* collapsible
* here lies breaking changes
* item simplification
* update examples
* move to patterns
* tree view looks broken but its not
* remove notes
* stash
* action list component stories
* fix sub item
* revert treeview to original markup
* tree view readme
* story chaining
* cleanup + readme
* lint
* tree story fix
* Create quiet-walls-walk.md
* address feedback
2022-02-11 09:47:56 -08:00
simurai
0fb6789555
Fix <sup><a>
from getting wrapped with [ ]
( #1928 )
...
* Scope `[ ]` to data-footnote-ref
* Stylelint auto-fixes
* Create ninety-moles-clap.md
Co-authored-by: Actions Auto Build <actions@github.com>
2022-02-03 10:38:50 +09:00
GitHub Design Systems Bot
670149dc8d
Version Packages ( #1891 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2022-02-02 14:10:42 +09:00
Jon Rohan
f02d9a3e4e
Upgrading @primer/stylelint-config@12.3.0 ( #1906 )
...
* Upgrading @primer/stylelint-config@12.3.0
* Fixing issues and removing needless disables
* Create gentle-lizards-switch.md
Co-authored-by: simurai <simurai@github.com>
2022-02-02 03:00:32 +00:00
simurai
84581e96ae
Reduce size of Label--inline
( #1908 )
...
* Reduce size of `Label--inline`
* Create moody-apricots-bake.md
2022-02-01 19:44:22 +00:00
Hector Garcia
21085f5c6c
Add blankslate classes to replace utilities ( #1919 )
...
This is part of the effort to remove all usages of utility classes to
improve consistency and prevent specificity bugs.
2022-02-01 17:13:37 +00:00
Vinicius Depizzol
bcf447ab22
Add mono font stack to <samp> tag ( #1876 )
...
* Add mono font stack to <samp> tag
* Create nice-beers-peel.md
* Add `<samp>` example to docs
* Test
* Another try without the HTML entities
Co-authored-by: simurai <simurai@github.com>
2022-01-26 06:07:32 +00:00
Katie Langerman
55bd498b73
Patch: ActionList divider conflict with inline description ( #1892 )
...
* stash change
* fix divider for inline description
* fix hover state
* Create clever-jars-suffer.md
* Stylelint auto-fixes
* Update clever-jars-suffer.md
* Update src/actionlist/action-list.scss
Co-authored-by: Vinicius Depizzol <vdepizzol@github.com>
Co-authored-by: Actions Auto Build <actions@github.com>
Co-authored-by: Vinicius Depizzol <vdepizzol@github.com>
2022-01-20 08:49:27 -08:00
Andri Alexandrou
74d0438bd4
Add 2 color definitions for Windows High Contrast mode ( #1890 )
...
* Add 2 color definitions for Windows High Contrast mode
* Adds changeset
* stylelint rule
* adds back comment
2022-01-20 02:07:30 +00:00
simurai
d1adf59530
Make pagination
responsive by default ( #1894 )
...
* Make pagination responsive by default
* Lint
* Create swift-actors-drum.md
* Remove duplicate selector
* Remove initial display
This was overridden before with the `.page-responsive .pagination` selector
2022-01-20 02:03:09 +00:00
Ari Seyhun
4a06aba1d3
Fix layout gutter none styles ( #1882 )
...
* Fix layout gutter none styles
Fixes https://github.com/primer/css/issues/1880 .
* Create seven-steaks-wait.md
Co-authored-by: Jon Rohan <rohan@github.com>
2022-01-18 09:42:42 -08:00
GitHub Design Systems Bot
61f7d9b45d
Version Packages ( #1849 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2022-01-14 09:56:33 -08:00
Katie Langerman
cbe3fb56e4
ActionList item outlines for high contrast theme ( #1856 )
...
* fresh branch
* Stylelint auto-fixes
* Create few-mice-scream.md
* Update src/actionlist/action-list-item.scss
Co-authored-by: Vinicius Depizzol <vdepizzol@github.com>
* change to box-shadow
* lint
* compromise
* add reference
* lint
* fix merge, lint
* adjust active state
* lint
* Stylelint auto-fixes
* Update few-mice-scream.md
Co-authored-by: Actions Auto Build <actions@github.com>
Co-authored-by: Vinicius Depizzol <vdepizzol@github.com>
2022-01-13 16:30:26 -08:00
Vinicius Depizzol
815daff9f0
[ActionList] Add hover to aria-current
elements and other micro interactions ( #1870 )
...
* Add hover to aria-current element
Also included a quick transition for subGroup elements
* Add touch-action, remove tap highlight, and more
Also:
- Avoided sticky hover on touch devices with hover:hover media query
- removed pointer: fine specificity to hover media queries
- simplified reduce-motion media query
* Keep parent above subGroup during transition
* Keep out-of-bound indicator line visible
* Please stylelint
* Create six-avocados-promise.md
Co-authored-by: Jon Rohan <yes@jonrohan.codes>
2022-01-12 15:12:10 -08:00
Jeremy Danyow
868f61a199
Remove .avatar's box-shadow when in .AvatarStack-body ( #1869 )
...
* Remove .avatar's box-shadow when in .AvatarStack-body
fixes #1850
* Add changeset
* Update dry-clocks-speak.md
Co-authored-by: Jon Rohan <rohan@github.com>
2022-01-04 17:32:56 +00:00
simurai
8f2e7534ec
Bump primer/primitives to 7.4.0
( #1855 )
...
* yarn add @primer/primitives@^7.4.0
* Create beige-hairs-jam.md
2021-12-22 14:15:41 +09:00
Vinicius Depizzol
6b4089d8b3
PageLayout
component / Layout beta + storybook (#1737 )
...
* storybook for layout alpha
* the beginning of layout beta
* simplify spacing structure and other things
this is a reminder that all the abstraction can happen in the viewComponent;
there's no need to flood the css with constricted behaviors
* add rowGap & dividers, clean spacing props
* content-width support, sticky pane
* cleanup props
* add preset property
* !default
* component name & settings example
* typo, cleaner header & footer template
* fix preset options
* mobile-friendly responsive behavior
* ongoing flowVertical breakpoint behavior
* finish panePosition + responsive pos & dividers
* panePosition fix
* add splitAsPage, finish responsive divider
* Layout beta ongoing updates (#1779 )
- simplify component with better names
- rename it to `PageLayout`
- stylelint cleanup
- finalize responsive variants
- finalize variant-specific region dividers
* add minimum 320px viewport
* fix layout alpha, add layout patterns
* cleanup bg colors, stylint pass
* enable debug bg colors
* colorful regions by default for dubugging
* "Needless disable for primer/no-undefined-vars"
* Stylelint auto-fixes
* line breaks a EOF
* introduce page layout behavior as a sb helper
* children props in specialized components
* cleanup
* typo
* discussions responsive temporary example
* layout alpha descriptions
* pageLayout prop descriptions
* cleanup
* fix conflict
* copy
* responsiveVariant storybook description
* 0 padding on fullscreen storybook layout
* has__divider for boolean props
* cleanup, copy
* cleanup
* cleanup
* cleanup chained selections/descendants
* Stylelint auto-fixes
* inherit values for responsive divider props
* consolidate modifier names for responsive props
Changelog:
### CSS classes
- `PageLayout--variant-stackRegions` → `PageLayout--responsive-stackRegions`
- `PageLayout--variant-separateRegions` → `PageLayout--responsive-separateRegions`
- `PageLayout--variant-stackRegions-panePos-*` →`PageLayout--responsive-panePos-*`
- `PageLayout--variant-separateRegions-primary-*` →`PageLayout--responsive-primary-*`
- `PageLayout-region--hasDivider-*` → `PageLayout-region--dividerNarrow-*`
### Prop names
- `responsivePrimaryRegion` → `primaryRegion`
- `paneResponsivePosition` → `panePositionNarrow`
- `paneResponsiveDivider` → `paneDividerNarrow`
- `headerResponsiveDivider`→ `headerDividerNarrow`
- `footerResponsiveDivider`→ `footerDividerNarrow`
### Args
- `*DividerNarrow` props have new `inherit` value by default
* Create lemon-games-swim.md
* Update lemon-games-swim.md
* cleanup, header+footer dividers as local modifiers
* hasFooterDivider instead of footerDivider
* fix primaryRegion selector
Co-authored-by: Actions Auto Build <actions@github.com>
Co-authored-by: Katie Langerman <langermank@github.com>
2021-12-21 12:51:59 -08:00
GitHub Design Systems Bot
a6da444ed6
Version Packages ( #1829 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2021-12-16 11:54:49 -08:00
Katie Langerman
c46fe9186e
Actionlist tree-view CSS ( #1803 )
...
* collapse state updates
* inset variant
* pseudo, you fine as you are
* tree view pattern draft
* tree view structure
* Stylelint auto-fixes
* trying tree roles
* vertical connector progress
* inline css var for spacing logic
* refactor tree story
* cleanup, lint
* add aria roles
* Create healthy-monkeys-complain.md
* lint
* lil change to trigger cli
* spacing adjustments
* move var
* linty fresh
* stuck in a stylelint loop
* fix var syntax
* one last try for today
* fix var
* test moving stylelint disable
Co-authored-by: Actions Auto Build <actions@github.com>
Co-authored-by: Jon Rohan <yes@jonrohan.codes>
2021-12-16 11:40:54 -08:00
simurai
69e1fc539e
Support fractional viewport sizes for max-width
media queries ( #1827 )
...
* Support fractional viewport sizes
* Create serious-emus-worry.md
* Support fractional viewport sizes for Popover
* Support fractional viewport sizes for Layout
* Create afraid-jars-occur.md
2021-12-15 12:10:43 +00:00
GitHub Design Systems Bot
6a4cf188eb
Version Packages ( #1763 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2021-12-09 11:33:20 +09:00
Vinicius Depizzol
22c29e7a8b
[Layout component] Avoid resizing main
while loading ( #1818 )
...
* avoid resizing `main` while loading
* Update layout.scss
* Create stale-pugs-eat.md
Co-authored-by: Jon Rohan <yes@jonrohan.codes>
2021-12-08 16:04:45 -08:00
Jon Rohan
929ba56f9a
Revert "UnderlineNav :focus
styles ( #1764 )" ( #1820 )
...
* Revert "UnderlineNav `:focus` styles (#1764 )"
This reverts commit cdd9728c7e
.
* Stylelint auto-fixes
Co-authored-by: Actions Auto Build <actions@github.com>
2021-12-08 12:08:49 -08:00
Katie Langerman
cdd9728c7e
UnderlineNav :focus
styles ( #1764 )
...
* add pseudo selectors
* adjustments
* add stories, cleanup
* update mixin
* fix mixin
* lint
* add back overflow styles
* adjust focus for better overflow state, scrollsnap
* post test adjustments, move hacks to primer css
* Stylelint auto-fixes
* hover state desktop only
* document data-content hack
* Create nice-days-jog.md
Co-authored-by: Actions Auto Build <actions@github.com>
Co-authored-by: simurai <simurai@github.com>
2021-12-07 12:13:49 -08:00
simurai
b1c43f1f8d
Use counter-border for LHC ( #1792 )
...
* Use counter-border for LHC
* Create orange-ties-sin.md
* Remove fallback
2021-12-07 14:56:48 +09:00
Emil Nikov
13a4654fa0
Marketing: add link components ( #1807 )
...
* Initial setup for marketing links
* Create short-pugs-press.md
* Rename .mktg-link to .link-mktg
* Update the link underline style
* Update the usage examples
* Clean up the SCSS
* Add animated octicon-chevrow
* Add underline-pale variant
* Improve docs
* Lint ignore the use of currentColor
* Reduce the examples, refactor the chevrow animation
* Refactor the octicon chevrow positioning and sizing
* Less absolute positioning
* Update the docs
* Document link colors
* Define underline offset with ems
* Update marketing-links.md
* Update chevrow position animation
* Rename underline-pale to link-emphasis-mktg
* Fix stylelint errors
* Reduce the :active state chevrow position
* Fix stylelint-disable comments
* Obey the stylelint!
* Rename octicon-chevrow to link-arrow-mktg
* Extract the animated arrow as utility
* Stylelint auto-fixes
* Remove markdown leftover
* Fix positioning in marketing buttons and links
* Stylelint ignore marketing button line-height
* Stylelint auto-fixes
* Expand the arrow-target-mktg selector to cover btn-mktg and link-mktg
Co-authored-by: Tobias Ahlin <hello@tobiasahlin.com>
* Update the btn-mktg line height
* Revert the btn-mktg padding changes
* Remove stylelint ignore rule
* Expand the changelog
* Improve the link-emphasis-mktg docs
* Add prefers-reduced-motion media queries
* Stylelint disable max-nesting-depth
Co-authored-by: Tobias Ahlin <hello@tobiasahlin.com>
Co-authored-by: Actions Auto Build <actions@github.com>
2021-12-06 08:50:14 +00:00
Tobias Ahlin
4abb1af95b
Marketing: Add disabled states for buttons (and tweak hover) ( #1768 )
...
* Add disabled styles
* Make sure links aren't decorated
* Create orange-camels-heal.md
* Stylelint auto-fixes
Co-authored-by: Actions Auto Build <actions@github.com>
2021-12-06 08:37:43 +00:00
Katie Langerman
8e9ba62d30
ActionList followup ( #1780 )
...
* collapse state updates
* inset variant
* pseudo, you fine as you are
* tree view pattern draft
* tree view structure
* move treeview to new pr
* Stylelint auto-fixes
* Create fresh-schools-pull.md
Co-authored-by: Actions Auto Build <actions@github.com>
2021-12-03 08:50:31 -08:00
Manuel Puyol
ee27583f59
Add hover and active states to btn-invisible ( #1808 )
...
Related to https://github.com/github/primer/issues/253 and https://github.com/github/primer/issues/263
Adds hover and active states to `btn-invisible`, as proposed by `@vdepizzol`.
https://user-images.githubusercontent.com/11280312/144511801-2a320990-36ca-4d67-b583-877ce540ed8a.mov
2021-12-03 09:27:03 -06:00