2014-05-27 21:41:24 +04:00
|
|
|
# Contributing to Atom
|
|
|
|
|
|
|
|
:+1::tada: First off, thanks for taking the time to contribute! :tada::+1:
|
2013-08-12 10:18:58 +04:00
|
|
|
|
2014-05-19 06:45:03 +04:00
|
|
|
The following is a set of guidelines for contributing to Atom and its packages,
|
|
|
|
which are hosted in the [Atom Organization](https://github.com/atom) on GitHub.
|
|
|
|
If you're unsure which package is causing your problem or if you're having an
|
2014-05-27 21:43:08 +04:00
|
|
|
issue with Atom core, please open an issue on the [main atom repository](https://github.com/atom/atom/issues).
|
|
|
|
These are just guidelines, not rules, use your best judgement and feel free to
|
|
|
|
propose changes to this document in a pull request.
|
2013-12-04 20:55:19 +04:00
|
|
|
|
2014-05-19 06:45:03 +04:00
|
|
|
## Submitting Issues
|
|
|
|
|
2014-06-15 15:10:04 +04:00
|
|
|
* Check the [debugging guide](https://atom.io/docs/latest/debugging) for tips
|
|
|
|
on debugging. You might be able to find the cause of the problem and fix
|
|
|
|
things yourself.
|
2014-06-04 19:31:11 +04:00
|
|
|
* Include the version of Atom you are using and the OS.
|
2014-05-19 06:45:03 +04:00
|
|
|
* Include screenshots and animated GIFs whenever possible; they are immensely
|
|
|
|
helpful.
|
|
|
|
* Include the behavior you expected and other places you've seen that behavior
|
|
|
|
such as Emacs, vi, Xcode, etc.
|
2014-06-04 19:22:55 +04:00
|
|
|
* Check the dev tools (`alt-cmd-i`) for errors to include. If the dev tools
|
|
|
|
are open _before_ the error is triggered, a full stack trace for the error
|
|
|
|
will be logged. If you can reproduce the error, use this approach to get the
|
|
|
|
full stack trace and include it in the issue.
|
2014-05-19 06:45:03 +04:00
|
|
|
* On Mac, check Console.app for stack traces to include if reporting a crash.
|
|
|
|
* Perform a cursory search to see if a similar issue has already been submitted.
|
2014-03-10 22:13:08 +04:00
|
|
|
|
2013-12-05 20:50:13 +04:00
|
|
|
### Package Repositories
|
|
|
|
|
|
|
|
This is the repository for the core Atom editor only. Atom comes bundled with
|
|
|
|
many packages and themes that are stored in other repos under the
|
2014-05-19 06:45:03 +04:00
|
|
|
[Atom organization](https://github.com/atom) such as
|
|
|
|
[tabs](https://github.com/atom/tabs),
|
2013-12-05 20:50:13 +04:00
|
|
|
[find-and-replace](https://github.com/atom/find-and-replace),
|
2014-05-19 06:45:03 +04:00
|
|
|
[language-javascript](https://github.com/atom/language-javascript), and
|
|
|
|
[atom-light-ui](http://github.com/atom/atom-light-ui).
|
2013-12-05 20:50:13 +04:00
|
|
|
|
2014-05-21 22:35:23 +04:00
|
|
|
For more information on how to work with Atom's official packages, see
|
|
|
|
[Contributing to Atom Packages](https://atom.io/docs/latest/contributing-to-packages.html)
|
2014-05-19 06:45:03 +04:00
|
|
|
|
2013-11-27 23:20:22 +04:00
|
|
|
## Pull Requests
|
2014-05-19 06:45:03 +04:00
|
|
|
|
|
|
|
* Include screenshots and animated GIFs in your pull request whenever possible.
|
|
|
|
* Follow the [CoffeeScript](#coffeescript-styleguide),
|
|
|
|
[JavaScript](https://github.com/styleguide/javascript),
|
|
|
|
and [CSS](https://github.com/styleguide/css) styleguides.
|
|
|
|
* Include thoughtfully-worded, well-structured
|
2014-05-22 19:03:45 +04:00
|
|
|
[Jasmine](http://jasmine.github.io/) specs.
|
2014-05-19 06:45:03 +04:00
|
|
|
* Document new code based on the
|
|
|
|
[Documentation Styleguide](#documentation-styleguide)
|
|
|
|
* End files with a newline.
|
|
|
|
* Place requires in the following order:
|
2013-12-04 20:50:07 +04:00
|
|
|
* Built in Node Modules (such as `path`)
|
|
|
|
* Built in Atom and Atom Shell Modules (such as `atom`, `shell`)
|
|
|
|
* Local Modules (using relative paths)
|
2014-05-19 06:45:03 +04:00
|
|
|
* Place class properties in the following order:
|
|
|
|
* Class methods and properties (methods starting with a `@`)
|
|
|
|
* Instance methods and properties
|
|
|
|
* Avoid platform-dependent code:
|
2013-12-04 20:48:22 +04:00
|
|
|
* Use `require('atom').fs.getHomeDirectory()` to get the home directory.
|
2013-11-27 23:20:22 +04:00
|
|
|
* Use `path.join()` to concatenate filenames.
|
2014-05-19 06:45:03 +04:00
|
|
|
* Use `os.tmpdir()` rather than `/tmp` when you need to reference the
|
|
|
|
temporary directory.
|
2013-12-04 20:53:24 +04:00
|
|
|
|
|
|
|
## Git Commit Messages
|
2014-05-19 06:45:03 +04:00
|
|
|
|
|
|
|
* Use the present tense ("Add feature" not "Added feature")
|
|
|
|
* Use the imperative mood ("Move cursor to..." not "Moves cursor to...")
|
|
|
|
* Limit the first line to 72 characters or less
|
|
|
|
* Reference issues and pull requests liberally
|
|
|
|
* Consider starting the commit message with an applicable emoji:
|
2014-05-06 19:22:01 +04:00
|
|
|
* :lipstick: `:lipstick:` when improving the format/structure of the code
|
|
|
|
* :racehorse: `:racehorse:` when improving performance
|
|
|
|
* :non-potable_water: `:non-potable_water:` when plugging memory leaks
|
|
|
|
* :memo: `:memo:` when writing docs
|
|
|
|
* :penguin: `:penguin:` when fixing something on Linux
|
2014-05-15 21:10:40 +04:00
|
|
|
* :apple: `:apple:` when fixing something on Mac OS
|
2014-05-26 05:28:02 +04:00
|
|
|
* :checkered_flag: `:checkered_flag:` when fixing something on Windows
|
2014-05-19 06:45:03 +04:00
|
|
|
* :bug: `:bug:` when fixing a bug
|
2014-05-15 22:50:06 +04:00
|
|
|
* :fire: `:fire:` when removing code or files
|
2014-05-13 04:05:31 +04:00
|
|
|
* :green_heart: `:green_heart:` when fixing the CI build
|
|
|
|
* :white_check_mark: `:white_check_mark:` when adding tests
|
2014-05-17 02:01:21 +04:00
|
|
|
* :lock: `:lock:` when dealing with security
|
2013-12-12 02:34:51 +04:00
|
|
|
|
|
|
|
## CoffeeScript Styleguide
|
|
|
|
|
|
|
|
* Set parameter defaults without spaces around the equal sign
|
2014-05-19 06:45:03 +04:00
|
|
|
* `clear = (count=1) ->` instead of `clear = (count = 1) ->`
|
|
|
|
* Use parentheses if it improves code clarity.
|
|
|
|
* Prefer alphabetic keywords to symbolic keywords:
|
|
|
|
* `a is b` instead of `a == b`
|
|
|
|
* Avoid spaces inside the curly-braces of hash literals:
|
|
|
|
* `{a: 1, b: 2}` instead of `{ a: 1, b: 2 }`
|
|
|
|
* Include a single line of whitespace between methods.
|
2014-02-07 02:20:08 +04:00
|
|
|
|
|
|
|
## Documentation Styleguide
|
|
|
|
|
2014-02-07 02:38:14 +04:00
|
|
|
* Use [TomDoc](http://tomdoc.org).
|
|
|
|
* Use [Markdown](https://daringfireball.net/projects/markdown).
|
2014-05-19 06:45:03 +04:00
|
|
|
* Reference methods and classes in markdown with the custom `{}` notation:
|
|
|
|
* Reference classes with `{ClassName}`
|
|
|
|
* Reference instance methods with `{ClassName::methodName}`
|
|
|
|
* Reference class methods with `{ClassName.methodName}`
|
|
|
|
* Delegate to comments elsewhere with `{Delegates to: ClassName.methodName}`
|
|
|
|
style notation.
|
2014-02-07 02:28:10 +04:00
|
|
|
|
|
|
|
### Example
|
|
|
|
|
|
|
|
```coffee
|
|
|
|
# Public: Disable the package with the given name.
|
|
|
|
#
|
|
|
|
# This method emits multiple events:
|
|
|
|
#
|
|
|
|
# * `package-will-be-disabled` - before the package is disabled.
|
|
|
|
# * `package-disabled` - after the package is disabled.
|
|
|
|
#
|
|
|
|
# name - The {String} name of the package to disable.
|
2014-02-07 03:55:13 +04:00
|
|
|
# options - The {Object} with disable options (default: {}):
|
|
|
|
# :trackTime - `true` to track the amount of time disabling took.
|
|
|
|
# :ignoreErrors - `true` to catch and ignore errors thrown.
|
2014-02-07 02:28:10 +04:00
|
|
|
# callback - The {Function} to call after the package has been disabled.
|
|
|
|
#
|
|
|
|
# Returns `undefined`.
|
2014-02-07 03:55:13 +04:00
|
|
|
disablePackage: (name, options, callback) ->
|
2014-02-07 02:28:10 +04:00
|
|
|
```
|