pulsar-edit/pulsar
1
1
Fork 0
mirror of https://github.com/pulsar-edit/pulsar.git synced 2024-11-10 10:17:11 +03:00
Code Issues Packages Projects Releases Wiki Activity

Use beforeunload instead of unload

Browse Source 
unload is asynchronous in Chrome 36 and so saving the state while
reloading may not happen before the state is read on the new render
process.
This commit is contained in:
Kevin Sawicki 2014-08-11 11:22:37 -07:00
parent 8dffb45fd7
commit 16d2e41309
3 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
spec/spec-helper.coffee
View File

@ -28,7 +28,7 @@ atom.keymaps.loadBundledKeymaps()
keyBindingsToRestore = atom.keymaps.getKeyBindings() keyBindingsToRestore = atom.keymaps.getKeyBindings()
$(window).on 'core:close', -> window.close() $(window).on 'core:close', -> window.close()
$(window).on 'unload', -> $(window).on 'beforeunload', ->
atom.storeWindowDimensions() atom.storeWindowDimensions()
atom.saveSync() atom.saveSync()
$('html,body').css('overflow', 'auto') $('html,body').css('overflow', 'auto')

4
src/atom.coffee
View File

@ -311,10 +311,10 @@ class Atom extends Model
@requireUserInitScript() @requireUserInitScript()
@menu.update() @menu.update()
$(window).on 'unload', => $(window).on 'beforeunload', =>
$(document.body).css('visibility', 'hidden') $(document.body).css('visibility', 'hidden')
@unloadEditorWindow() @unloadEditorWindow()
false null
@displayWindow() @displayWindow()

6
src/window-event-handler.coffee
View File

@ -37,11 +37,13 @@ class WindowEventHandler
@reloadRequested = false @reloadRequested = false
confirmed confirmed
@subscribe $(window), 'blur unload', -> @subscribe $(window), 'blur beforeunload', ->
atom.storeDefaultWindowDimensions() atom.storeDefaultWindowDimensions()
null
@subscribe $(window), 'unload', -> @subscribe $(window), 'beforeunload', ->
atom.storeWindowDimensions() atom.storeWindowDimensions()
null
@subscribeToCommand $(window), 'window:toggle-full-screen', -> atom.toggleFullScreen() @subscribeToCommand $(window), 'window:toggle-full-screen', -> atom.toggleFullScreen()