pulsar-edit/pulsar
1
1
Fork 0
mirror of https://github.com/pulsar-edit/pulsar.git synced 2024-09-20 07:28:08 +03:00
Code Issues Packages Projects Releases Wiki Activity

Warn rather than failing if we detect leaked pathwatcher subscriptions

Browse Source
This commit is contained in:
Nathan Sobo 2016-03-29 16:46:57 -06:00
parent edcceeed5b
commit 265aa2f6c8
2 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
spec/git-repository-async-spec.js
View File

@ -230,9 +230,7 @@ describe('GitRepositoryAsync', () => {
}) })
}) })
// @joshaber: Disabling for now. There seems to be some race with path describe('.checkoutHeadForEditor(editor)', () => {
// subscriptions leading to intermittent test failures, e.g.: https://travis-ci.org/atom/atom/jobs/102702554
xdescribe('.checkoutHeadForEditor(editor)', () => {
let filePath let filePath
let editor let editor

8
spec/spec-helper.coffee
View File

@ -112,14 +112,14 @@ afterEach ->
document.getElementById('jasmine-content').innerHTML = '' unless window.debugContent document.getElementById('jasmine-content').innerHTML = '' unless window.debugContent
ensureNoPathSubscriptions() warnIfLeakingPathSubscriptions()
waits(0) # yield to ui thread to make screen update more frequently waits(0) # yield to ui thread to make screen update more frequently
ensureNoPathSubscriptions = -> warnIfLeakingPathSubscriptions = ->
watchedPaths = pathwatcher.getWatchedPaths() watchedPaths = pathwatcher.getWatchedPaths()
pathwatcher.closeAllWatchers()
if watchedPaths.length > 0 if watchedPaths.length > 0
throw new Error("Leaking subscriptions for paths: " + watchedPaths.join(", ")) console.error("WARNING: Leaking subscriptions for paths: " + watchedPaths.join(", "))
pathwatcher.closeAllWatchers()
ensureNoDeprecatedFunctionsCalled = -> ensureNoDeprecatedFunctionsCalled = ->
deprecations = Grim.getDeprecations() deprecations = Grim.getDeprecations()